Compare strings instead of objects in SecurityGroupConfig 73/52173/1
authorCédric Ollivier <cedric.ollivier@orange.com>
Wed, 14 Feb 2018 20:59:04 +0000 (21:59 +0100)
committerCédric Ollivier <cedric.ollivier@orange.com>
Wed, 14 Feb 2018 21:00:01 +0000 (22:00 +0100)
It could have worked thanks to interned strings.

Change-Id: If56cc44fe35ca06bc9033af620ddd3c0586877fe
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
snaps/config/security_group.py

index 32a1e95..16e68c7 100644 (file)
@@ -54,7 +54,7 @@ class SecurityGroupConfig(object):
             raise SecurityGroupConfigError('The attribute name is required')
 
         for rule_setting in self.rule_settings:
-            if rule_setting.sec_grp_name is not self.name:
+            if rule_setting.sec_grp_name != self.name:
                 raise SecurityGroupConfigError(
                     'Rule settings must correspond with the name of this '
                     'security group')