Fix duplicate IMAGE_PROPERTIES env variable in functest run 27/63627/2
authorDelia Popescu <delia.popescu@enea.com>
Wed, 17 Oct 2018 07:39:32 +0000 (10:39 +0300)
committerDelia Popescu <delia.popescu@enea.com>
Wed, 17 Oct 2018 14:54:55 +0000 (17:54 +0300)
Update envs only once with IMAGE_PROPERTIES and FLAVOR_EXTRA_SPECS
if installer type is fuel or deploy scenario is ovs or fdio

Change-Id: I7c1e997cf95d30972688e697574458a3a0f1e55c
Signed-off-by: Delia Popescu <delia.popescu@enea.com>
jjb/functest/functest-alpine.sh

index da16735..e8d81ea 100755 (executable)
@@ -136,7 +136,7 @@ if [ "${INSTALLER_TYPE}" == 'fuel' ]; then
     COMPUTE_ARCH=$(ssh -l ubuntu ${INSTALLER_IP} -i ${SSH_KEY} ${ssh_options} \
         "sudo salt 'cmp*' grains.get cpuarch --out yaml | awk '{print \$2; exit}'")
     IMAGE_PROPERTIES="hw_disk_bus:scsi,hw_scsi_model:virtio-scsi"
-    envs="${envs} -e POD_ARCH=${COMPUTE_ARCH} -e IMAGE_PROPERTIES=${IMAGE_PROPERTIES}"
+    envs="${envs} -e POD_ARCH=${COMPUTE_ARCH}"
 fi
 
 if [[ ${INSTALLER_TYPE} == 'fuel' && ${DEPLOY_SCENARIO} == 'os-nosdn-nofeature-noha' ]]; then
@@ -156,12 +156,15 @@ fi
 
 if [[ ${DEPLOY_SCENARIO} == *"ovs"* ]] || [[ ${DEPLOY_SCENARIO} == *"fdio"* ]]; then
     if [[ -n ${IMAGE_PROPERTIES} ]]; then
-        IMAGE_PROPERTIES="${IMAGE_PROPERTIES}, hw_mem_page_size: large"
+        IMAGE_PROPERTIES="${IMAGE_PROPERTIES},hw_mem_page_size:large"
     else
-        IMAGE_PROPERTIES="hw_mem_page_size: large"
+        IMAGE_PROPERTIES="hw_mem_page_size:large"
     fi
-    FLAVOR_EXTRA_SPECS="hw:mem_page_size: large"
-    envs="${envs} -e IMAGE_PROPERTIES=\"${IMAGE_PROPERTIES}\" -e FLAVOR_EXTRA_SPECS=\"${FLAVOR_EXTRA_SPECS}\""
+    FLAVOR_EXTRA_SPECS="hw:mem_page_size:large"
+fi
+
+if [[ -n ${IMAGE_PROPERTIES} ]] || [[ -n ${FLAVOR_EXTRA_SPECS} ]]; then
+    envs="${envs} -e IMAGE_PROPERTIES=${IMAGE_PROPERTIES} -e FLAVOR_EXTRA_SPECS=${FLAVOR_EXTRA_SPECS}"
 fi
 
 volumes="${images_vol} ${results_vol} ${sshkey_vol} ${libvirt_vol} ${userconfig_vol} ${rc_file_vol} ${cacert_file_vol}"