NFVBENCH-198 Error in File logger management (REST API) 35/72135/2
authorfmenguy <francoisregis.menguy@orange.com>
Tue, 2 Mar 2021 14:24:29 +0000 (15:24 +0100)
committerfmenguy <francoisregis.menguy@orange.com>
Wed, 3 Mar 2021 15:26:04 +0000 (16:26 +0100)
Change-Id: I9c798b3bcbf416c0d3f107856aca0872c650a580
Signed-off-by: fmenguy <francoisregis.menguy@orange.com>
nfvbench/nfvbench.py

index 427c94c..6373a59 100644 (file)
@@ -185,13 +185,14 @@ class NFVBench(object):
                         'will be created.', path)
                     os.makedirs(path)
                     LOG.info('%s is created.', path)
-                for h in log.getLogger().handlers:
-                    if isinstance(h, FileHandler) and h.baseFilename != opts['log_file']:
-                        # clean log file handler
-                        log.getLogger().removeHandler(h)
-                # add handler if not existing to avoid duplicates handlers
-                if len(log.getLogger().handlers) == 1:
+                if not any(isinstance(h, FileHandler) for h in log.getLogger().handlers):
                     log.add_file_logger(opts['log_file'])
+                else:
+                    for h in log.getLogger().handlers:
+                        if isinstance(h, FileHandler) and h.baseFilename != opts['log_file']:
+                            # clean log file handler
+                            log.getLogger().removeHandler(h)
+                            log.add_file_logger(opts['log_file'])
 
         self.config.update(opts)
         config = self.config