These changes are the raw update to linux-4.4.6-rt14. Kernel sources
[kvmfornfv.git] / kernel / drivers / pinctrl / sh-pfc / pinctrl.c
1 /*
2  * SuperH Pin Function Controller pinmux support.
3  *
4  * Copyright (C) 2012  Paul Mundt
5  *
6  * This file is subject to the terms and conditions of the GNU General Public
7  * License.  See the file "COPYING" in the main directory of this archive
8  * for more details.
9  */
10
11 #define DRV_NAME "sh-pfc"
12
13 #include <linux/device.h>
14 #include <linux/err.h>
15 #include <linux/init.h>
16 #include <linux/module.h>
17 #include <linux/of.h>
18 #include <linux/pinctrl/consumer.h>
19 #include <linux/pinctrl/machine.h>
20 #include <linux/pinctrl/pinconf.h>
21 #include <linux/pinctrl/pinconf-generic.h>
22 #include <linux/pinctrl/pinctrl.h>
23 #include <linux/pinctrl/pinmux.h>
24 #include <linux/slab.h>
25 #include <linux/spinlock.h>
26
27 #include "core.h"
28 #include "../core.h"
29 #include "../pinconf.h"
30
31 struct sh_pfc_pin_config {
32         u32 type;
33 };
34
35 struct sh_pfc_pinctrl {
36         struct pinctrl_dev *pctl;
37         struct pinctrl_desc pctl_desc;
38
39         struct sh_pfc *pfc;
40
41         struct pinctrl_pin_desc *pins;
42         struct sh_pfc_pin_config *configs;
43
44         const char *func_prop_name;
45         const char *groups_prop_name;
46         const char *pins_prop_name;
47 };
48
49 static int sh_pfc_get_groups_count(struct pinctrl_dev *pctldev)
50 {
51         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
52
53         return pmx->pfc->info->nr_groups;
54 }
55
56 static const char *sh_pfc_get_group_name(struct pinctrl_dev *pctldev,
57                                          unsigned selector)
58 {
59         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
60
61         return pmx->pfc->info->groups[selector].name;
62 }
63
64 static int sh_pfc_get_group_pins(struct pinctrl_dev *pctldev, unsigned selector,
65                                  const unsigned **pins, unsigned *num_pins)
66 {
67         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
68
69         *pins = pmx->pfc->info->groups[selector].pins;
70         *num_pins = pmx->pfc->info->groups[selector].nr_pins;
71
72         return 0;
73 }
74
75 static void sh_pfc_pin_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s,
76                                 unsigned offset)
77 {
78         seq_printf(s, "%s", DRV_NAME);
79 }
80
81 #ifdef CONFIG_OF
82 static int sh_pfc_map_add_config(struct pinctrl_map *map,
83                                  const char *group_or_pin,
84                                  enum pinctrl_map_type type,
85                                  unsigned long *configs,
86                                  unsigned int num_configs)
87 {
88         unsigned long *cfgs;
89
90         cfgs = kmemdup(configs, num_configs * sizeof(*cfgs),
91                        GFP_KERNEL);
92         if (cfgs == NULL)
93                 return -ENOMEM;
94
95         map->type = type;
96         map->data.configs.group_or_pin = group_or_pin;
97         map->data.configs.configs = cfgs;
98         map->data.configs.num_configs = num_configs;
99
100         return 0;
101 }
102
103 static int sh_pfc_dt_subnode_to_map(struct pinctrl_dev *pctldev,
104                                     struct device_node *np,
105                                     struct pinctrl_map **map,
106                                     unsigned int *num_maps, unsigned int *index)
107 {
108         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
109         struct device *dev = pmx->pfc->dev;
110         struct pinctrl_map *maps = *map;
111         unsigned int nmaps = *num_maps;
112         unsigned int idx = *index;
113         unsigned int num_configs;
114         const char *function = NULL;
115         unsigned long *configs;
116         struct property *prop;
117         unsigned int num_groups;
118         unsigned int num_pins;
119         const char *group;
120         const char *pin;
121         int ret;
122
123         /* Support both the old Renesas-specific properties and the new standard
124          * properties. Mixing old and new properties isn't allowed, neither
125          * inside a subnode nor across subnodes.
126          */
127         if (!pmx->func_prop_name) {
128                 if (of_find_property(np, "groups", NULL) ||
129                     of_find_property(np, "pins", NULL)) {
130                         pmx->func_prop_name = "function";
131                         pmx->groups_prop_name = "groups";
132                         pmx->pins_prop_name = "pins";
133                 } else {
134                         pmx->func_prop_name = "renesas,function";
135                         pmx->groups_prop_name = "renesas,groups";
136                         pmx->pins_prop_name = "renesas,pins";
137                 }
138         }
139
140         /* Parse the function and configuration properties. At least a function
141          * or one configuration must be specified.
142          */
143         ret = of_property_read_string(np, pmx->func_prop_name, &function);
144         if (ret < 0 && ret != -EINVAL) {
145                 dev_err(dev, "Invalid function in DT\n");
146                 return ret;
147         }
148
149         ret = pinconf_generic_parse_dt_config(np, NULL, &configs, &num_configs);
150         if (ret < 0)
151                 return ret;
152
153         if (!function && num_configs == 0) {
154                 dev_err(dev,
155                         "DT node must contain at least a function or config\n");
156                 ret = -ENODEV;
157                 goto done;
158         }
159
160         /* Count the number of pins and groups and reallocate mappings. */
161         ret = of_property_count_strings(np, pmx->pins_prop_name);
162         if (ret == -EINVAL) {
163                 num_pins = 0;
164         } else if (ret < 0) {
165                 dev_err(dev, "Invalid pins list in DT\n");
166                 goto done;
167         } else {
168                 num_pins = ret;
169         }
170
171         ret = of_property_count_strings(np, pmx->groups_prop_name);
172         if (ret == -EINVAL) {
173                 num_groups = 0;
174         } else if (ret < 0) {
175                 dev_err(dev, "Invalid pin groups list in DT\n");
176                 goto done;
177         } else {
178                 num_groups = ret;
179         }
180
181         if (!num_pins && !num_groups) {
182                 dev_err(dev, "No pin or group provided in DT node\n");
183                 ret = -ENODEV;
184                 goto done;
185         }
186
187         if (function)
188                 nmaps += num_groups;
189         if (configs)
190                 nmaps += num_pins + num_groups;
191
192         maps = krealloc(maps, sizeof(*maps) * nmaps, GFP_KERNEL);
193         if (maps == NULL) {
194                 ret = -ENOMEM;
195                 goto done;
196         }
197
198         *map = maps;
199         *num_maps = nmaps;
200
201         /* Iterate over pins and groups and create the mappings. */
202         of_property_for_each_string(np, pmx->groups_prop_name, prop, group) {
203                 if (function) {
204                         maps[idx].type = PIN_MAP_TYPE_MUX_GROUP;
205                         maps[idx].data.mux.group = group;
206                         maps[idx].data.mux.function = function;
207                         idx++;
208                 }
209
210                 if (configs) {
211                         ret = sh_pfc_map_add_config(&maps[idx], group,
212                                                     PIN_MAP_TYPE_CONFIGS_GROUP,
213                                                     configs, num_configs);
214                         if (ret < 0)
215                                 goto done;
216
217                         idx++;
218                 }
219         }
220
221         if (!configs) {
222                 ret = 0;
223                 goto done;
224         }
225
226         of_property_for_each_string(np, pmx->pins_prop_name, prop, pin) {
227                 ret = sh_pfc_map_add_config(&maps[idx], pin,
228                                             PIN_MAP_TYPE_CONFIGS_PIN,
229                                             configs, num_configs);
230                 if (ret < 0)
231                         goto done;
232
233                 idx++;
234         }
235
236 done:
237         *index = idx;
238         kfree(configs);
239         return ret;
240 }
241
242 static void sh_pfc_dt_free_map(struct pinctrl_dev *pctldev,
243                                struct pinctrl_map *map, unsigned num_maps)
244 {
245         unsigned int i;
246
247         if (map == NULL)
248                 return;
249
250         for (i = 0; i < num_maps; ++i) {
251                 if (map[i].type == PIN_MAP_TYPE_CONFIGS_GROUP ||
252                     map[i].type == PIN_MAP_TYPE_CONFIGS_PIN)
253                         kfree(map[i].data.configs.configs);
254         }
255
256         kfree(map);
257 }
258
259 static int sh_pfc_dt_node_to_map(struct pinctrl_dev *pctldev,
260                                  struct device_node *np,
261                                  struct pinctrl_map **map, unsigned *num_maps)
262 {
263         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
264         struct device *dev = pmx->pfc->dev;
265         struct device_node *child;
266         unsigned int index;
267         int ret;
268
269         *map = NULL;
270         *num_maps = 0;
271         index = 0;
272
273         for_each_child_of_node(np, child) {
274                 ret = sh_pfc_dt_subnode_to_map(pctldev, child, map, num_maps,
275                                                &index);
276                 if (ret < 0)
277                         goto done;
278         }
279
280         /* If no mapping has been found in child nodes try the config node. */
281         if (*num_maps == 0) {
282                 ret = sh_pfc_dt_subnode_to_map(pctldev, np, map, num_maps,
283                                                &index);
284                 if (ret < 0)
285                         goto done;
286         }
287
288         if (*num_maps)
289                 return 0;
290
291         dev_err(dev, "no mapping found in node %s\n", np->full_name);
292         ret = -EINVAL;
293
294 done:
295         if (ret < 0)
296                 sh_pfc_dt_free_map(pctldev, *map, *num_maps);
297
298         return ret;
299 }
300 #endif /* CONFIG_OF */
301
302 static const struct pinctrl_ops sh_pfc_pinctrl_ops = {
303         .get_groups_count       = sh_pfc_get_groups_count,
304         .get_group_name         = sh_pfc_get_group_name,
305         .get_group_pins         = sh_pfc_get_group_pins,
306         .pin_dbg_show           = sh_pfc_pin_dbg_show,
307 #ifdef CONFIG_OF
308         .dt_node_to_map         = sh_pfc_dt_node_to_map,
309         .dt_free_map            = sh_pfc_dt_free_map,
310 #endif
311 };
312
313 static int sh_pfc_get_functions_count(struct pinctrl_dev *pctldev)
314 {
315         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
316
317         return pmx->pfc->info->nr_functions;
318 }
319
320 static const char *sh_pfc_get_function_name(struct pinctrl_dev *pctldev,
321                                             unsigned selector)
322 {
323         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
324
325         return pmx->pfc->info->functions[selector].name;
326 }
327
328 static int sh_pfc_get_function_groups(struct pinctrl_dev *pctldev,
329                                       unsigned selector,
330                                       const char * const **groups,
331                                       unsigned * const num_groups)
332 {
333         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
334
335         *groups = pmx->pfc->info->functions[selector].groups;
336         *num_groups = pmx->pfc->info->functions[selector].nr_groups;
337
338         return 0;
339 }
340
341 static int sh_pfc_func_set_mux(struct pinctrl_dev *pctldev, unsigned selector,
342                                unsigned group)
343 {
344         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
345         struct sh_pfc *pfc = pmx->pfc;
346         const struct sh_pfc_pin_group *grp = &pfc->info->groups[group];
347         unsigned long flags;
348         unsigned int i;
349         int ret = 0;
350
351         spin_lock_irqsave(&pfc->lock, flags);
352
353         for (i = 0; i < grp->nr_pins; ++i) {
354                 int idx = sh_pfc_get_pin_index(pfc, grp->pins[i]);
355                 struct sh_pfc_pin_config *cfg = &pmx->configs[idx];
356
357                 if (cfg->type != PINMUX_TYPE_NONE) {
358                         ret = -EBUSY;
359                         goto done;
360                 }
361         }
362
363         for (i = 0; i < grp->nr_pins; ++i) {
364                 ret = sh_pfc_config_mux(pfc, grp->mux[i], PINMUX_TYPE_FUNCTION);
365                 if (ret < 0)
366                         break;
367         }
368
369 done:
370         spin_unlock_irqrestore(&pfc->lock, flags);
371         return ret;
372 }
373
374 static int sh_pfc_gpio_request_enable(struct pinctrl_dev *pctldev,
375                                       struct pinctrl_gpio_range *range,
376                                       unsigned offset)
377 {
378         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
379         struct sh_pfc *pfc = pmx->pfc;
380         int idx = sh_pfc_get_pin_index(pfc, offset);
381         struct sh_pfc_pin_config *cfg = &pmx->configs[idx];
382         unsigned long flags;
383         int ret;
384
385         spin_lock_irqsave(&pfc->lock, flags);
386
387         if (cfg->type != PINMUX_TYPE_NONE) {
388                 dev_err(pfc->dev,
389                         "Pin %u is busy, can't configure it as GPIO.\n",
390                         offset);
391                 ret = -EBUSY;
392                 goto done;
393         }
394
395         if (!pfc->gpio) {
396                 /* If GPIOs are handled externally the pin mux type need to be
397                  * set to GPIO here.
398                  */
399                 const struct sh_pfc_pin *pin = &pfc->info->pins[idx];
400
401                 ret = sh_pfc_config_mux(pfc, pin->enum_id, PINMUX_TYPE_GPIO);
402                 if (ret < 0)
403                         goto done;
404         }
405
406         cfg->type = PINMUX_TYPE_GPIO;
407
408         ret = 0;
409
410 done:
411         spin_unlock_irqrestore(&pfc->lock, flags);
412
413         return ret;
414 }
415
416 static void sh_pfc_gpio_disable_free(struct pinctrl_dev *pctldev,
417                                      struct pinctrl_gpio_range *range,
418                                      unsigned offset)
419 {
420         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
421         struct sh_pfc *pfc = pmx->pfc;
422         int idx = sh_pfc_get_pin_index(pfc, offset);
423         struct sh_pfc_pin_config *cfg = &pmx->configs[idx];
424         unsigned long flags;
425
426         spin_lock_irqsave(&pfc->lock, flags);
427         cfg->type = PINMUX_TYPE_NONE;
428         spin_unlock_irqrestore(&pfc->lock, flags);
429 }
430
431 static int sh_pfc_gpio_set_direction(struct pinctrl_dev *pctldev,
432                                      struct pinctrl_gpio_range *range,
433                                      unsigned offset, bool input)
434 {
435         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
436         struct sh_pfc *pfc = pmx->pfc;
437         int new_type = input ? PINMUX_TYPE_INPUT : PINMUX_TYPE_OUTPUT;
438         int idx = sh_pfc_get_pin_index(pfc, offset);
439         const struct sh_pfc_pin *pin = &pfc->info->pins[idx];
440         struct sh_pfc_pin_config *cfg = &pmx->configs[idx];
441         unsigned long flags;
442         unsigned int dir;
443         int ret;
444
445         /* Check if the requested direction is supported by the pin. Not all SoC
446          * provide pin config data, so perform the check conditionally.
447          */
448         if (pin->configs) {
449                 dir = input ? SH_PFC_PIN_CFG_INPUT : SH_PFC_PIN_CFG_OUTPUT;
450                 if (!(pin->configs & dir))
451                         return -EINVAL;
452         }
453
454         spin_lock_irqsave(&pfc->lock, flags);
455
456         ret = sh_pfc_config_mux(pfc, pin->enum_id, new_type);
457         if (ret < 0)
458                 goto done;
459
460         cfg->type = new_type;
461
462 done:
463         spin_unlock_irqrestore(&pfc->lock, flags);
464         return ret;
465 }
466
467 static const struct pinmux_ops sh_pfc_pinmux_ops = {
468         .get_functions_count    = sh_pfc_get_functions_count,
469         .get_function_name      = sh_pfc_get_function_name,
470         .get_function_groups    = sh_pfc_get_function_groups,
471         .set_mux                = sh_pfc_func_set_mux,
472         .gpio_request_enable    = sh_pfc_gpio_request_enable,
473         .gpio_disable_free      = sh_pfc_gpio_disable_free,
474         .gpio_set_direction     = sh_pfc_gpio_set_direction,
475 };
476
477 /* Check whether the requested parameter is supported for a pin. */
478 static bool sh_pfc_pinconf_validate(struct sh_pfc *pfc, unsigned int _pin,
479                                     enum pin_config_param param)
480 {
481         int idx = sh_pfc_get_pin_index(pfc, _pin);
482         const struct sh_pfc_pin *pin = &pfc->info->pins[idx];
483
484         switch (param) {
485         case PIN_CONFIG_BIAS_DISABLE:
486                 return true;
487
488         case PIN_CONFIG_BIAS_PULL_UP:
489                 return pin->configs & SH_PFC_PIN_CFG_PULL_UP;
490
491         case PIN_CONFIG_BIAS_PULL_DOWN:
492                 return pin->configs & SH_PFC_PIN_CFG_PULL_DOWN;
493
494         case PIN_CONFIG_POWER_SOURCE:
495                 return pin->configs & SH_PFC_PIN_CFG_IO_VOLTAGE;
496
497         default:
498                 return false;
499         }
500 }
501
502 static int sh_pfc_pinconf_get(struct pinctrl_dev *pctldev, unsigned _pin,
503                               unsigned long *config)
504 {
505         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
506         struct sh_pfc *pfc = pmx->pfc;
507         enum pin_config_param param = pinconf_to_config_param(*config);
508         unsigned long flags;
509
510         if (!sh_pfc_pinconf_validate(pfc, _pin, param))
511                 return -ENOTSUPP;
512
513         switch (param) {
514         case PIN_CONFIG_BIAS_DISABLE:
515         case PIN_CONFIG_BIAS_PULL_UP:
516         case PIN_CONFIG_BIAS_PULL_DOWN: {
517                 unsigned int bias;
518
519                 if (!pfc->info->ops || !pfc->info->ops->get_bias)
520                         return -ENOTSUPP;
521
522                 spin_lock_irqsave(&pfc->lock, flags);
523                 bias = pfc->info->ops->get_bias(pfc, _pin);
524                 spin_unlock_irqrestore(&pfc->lock, flags);
525
526                 if (bias != param)
527                         return -EINVAL;
528
529                 *config = 0;
530                 break;
531         }
532
533         case PIN_CONFIG_POWER_SOURCE: {
534                 int ret;
535
536                 if (!pfc->info->ops || !pfc->info->ops->get_io_voltage)
537                         return -ENOTSUPP;
538
539                 spin_lock_irqsave(&pfc->lock, flags);
540                 ret = pfc->info->ops->get_io_voltage(pfc, _pin);
541                 spin_unlock_irqrestore(&pfc->lock, flags);
542
543                 if (ret < 0)
544                         return ret;
545
546                 *config = ret;
547                 break;
548         }
549
550         default:
551                 return -ENOTSUPP;
552         }
553
554         return 0;
555 }
556
557 static int sh_pfc_pinconf_set(struct pinctrl_dev *pctldev, unsigned _pin,
558                               unsigned long *configs, unsigned num_configs)
559 {
560         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
561         struct sh_pfc *pfc = pmx->pfc;
562         enum pin_config_param param;
563         unsigned long flags;
564         unsigned int i;
565
566         for (i = 0; i < num_configs; i++) {
567                 param = pinconf_to_config_param(configs[i]);
568
569                 if (!sh_pfc_pinconf_validate(pfc, _pin, param))
570                         return -ENOTSUPP;
571
572                 switch (param) {
573                 case PIN_CONFIG_BIAS_PULL_UP:
574                 case PIN_CONFIG_BIAS_PULL_DOWN:
575                 case PIN_CONFIG_BIAS_DISABLE:
576                         if (!pfc->info->ops || !pfc->info->ops->set_bias)
577                                 return -ENOTSUPP;
578
579                         spin_lock_irqsave(&pfc->lock, flags);
580                         pfc->info->ops->set_bias(pfc, _pin, param);
581                         spin_unlock_irqrestore(&pfc->lock, flags);
582
583                         break;
584
585                 case PIN_CONFIG_POWER_SOURCE: {
586                         unsigned int arg =
587                                 pinconf_to_config_argument(configs[i]);
588                         int ret;
589
590                         if (!pfc->info->ops || !pfc->info->ops->set_io_voltage)
591                                 return -ENOTSUPP;
592
593                         spin_lock_irqsave(&pfc->lock, flags);
594                         ret = pfc->info->ops->set_io_voltage(pfc, _pin, arg);
595                         spin_unlock_irqrestore(&pfc->lock, flags);
596
597                         if (ret)
598                                 return ret;
599
600                         break;
601                 }
602
603                 default:
604                         return -ENOTSUPP;
605                 }
606         } /* for each config */
607
608         return 0;
609 }
610
611 static int sh_pfc_pinconf_group_set(struct pinctrl_dev *pctldev, unsigned group,
612                                     unsigned long *configs,
613                                     unsigned num_configs)
614 {
615         struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
616         const unsigned int *pins;
617         unsigned int num_pins;
618         unsigned int i;
619
620         pins = pmx->pfc->info->groups[group].pins;
621         num_pins = pmx->pfc->info->groups[group].nr_pins;
622
623         for (i = 0; i < num_pins; ++i)
624                 sh_pfc_pinconf_set(pctldev, pins[i], configs, num_configs);
625
626         return 0;
627 }
628
629 static const struct pinconf_ops sh_pfc_pinconf_ops = {
630         .is_generic                     = true,
631         .pin_config_get                 = sh_pfc_pinconf_get,
632         .pin_config_set                 = sh_pfc_pinconf_set,
633         .pin_config_group_set           = sh_pfc_pinconf_group_set,
634         .pin_config_config_dbg_show     = pinconf_generic_dump_config,
635 };
636
637 /* PFC ranges -> pinctrl pin descs */
638 static int sh_pfc_map_pins(struct sh_pfc *pfc, struct sh_pfc_pinctrl *pmx)
639 {
640         unsigned int i;
641
642         /* Allocate and initialize the pins and configs arrays. */
643         pmx->pins = devm_kzalloc(pfc->dev,
644                                  sizeof(*pmx->pins) * pfc->info->nr_pins,
645                                  GFP_KERNEL);
646         if (unlikely(!pmx->pins))
647                 return -ENOMEM;
648
649         pmx->configs = devm_kzalloc(pfc->dev,
650                                     sizeof(*pmx->configs) * pfc->info->nr_pins,
651                                     GFP_KERNEL);
652         if (unlikely(!pmx->configs))
653                 return -ENOMEM;
654
655         for (i = 0; i < pfc->info->nr_pins; ++i) {
656                 const struct sh_pfc_pin *info = &pfc->info->pins[i];
657                 struct sh_pfc_pin_config *cfg = &pmx->configs[i];
658                 struct pinctrl_pin_desc *pin = &pmx->pins[i];
659
660                 /* If the pin number is equal to -1 all pins are considered */
661                 pin->number = info->pin != (u16)-1 ? info->pin : i;
662                 pin->name = info->name;
663                 cfg->type = PINMUX_TYPE_NONE;
664         }
665
666         return 0;
667 }
668
669 int sh_pfc_register_pinctrl(struct sh_pfc *pfc)
670 {
671         struct sh_pfc_pinctrl *pmx;
672         int ret;
673
674         pmx = devm_kzalloc(pfc->dev, sizeof(*pmx), GFP_KERNEL);
675         if (unlikely(!pmx))
676                 return -ENOMEM;
677
678         pmx->pfc = pfc;
679         pfc->pinctrl = pmx;
680
681         ret = sh_pfc_map_pins(pfc, pmx);
682         if (ret < 0)
683                 return ret;
684
685         pmx->pctl_desc.name = DRV_NAME;
686         pmx->pctl_desc.owner = THIS_MODULE;
687         pmx->pctl_desc.pctlops = &sh_pfc_pinctrl_ops;
688         pmx->pctl_desc.pmxops = &sh_pfc_pinmux_ops;
689         pmx->pctl_desc.confops = &sh_pfc_pinconf_ops;
690         pmx->pctl_desc.pins = pmx->pins;
691         pmx->pctl_desc.npins = pfc->info->nr_pins;
692
693         pmx->pctl = pinctrl_register(&pmx->pctl_desc, pfc->dev, pmx);
694         if (IS_ERR(pmx->pctl))
695                 return PTR_ERR(pmx->pctl);
696
697         return 0;
698 }
699
700 int sh_pfc_unregister_pinctrl(struct sh_pfc *pfc)
701 {
702         struct sh_pfc_pinctrl *pmx = pfc->pinctrl;
703
704         pinctrl_unregister(pmx->pctl);
705
706         pfc->pinctrl = NULL;
707         return 0;
708 }