These changes are the raw update to linux-4.4.6-rt14. Kernel sources
[kvmfornfv.git] / kernel / drivers / gpu / drm / rcar-du / rcar_du_crtc.c
1 /*
2  * rcar_du_crtc.c  --  R-Car Display Unit CRTCs
3  *
4  * Copyright (C) 2013-2014 Renesas Electronics Corporation
5  *
6  * Contact: Laurent Pinchart (laurent.pinchart@ideasonboard.com)
7  *
8  * This program is free software; you can redistribute it and/or modify
9  * it under the terms of the GNU General Public License as published by
10  * the Free Software Foundation; either version 2 of the License, or
11  * (at your option) any later version.
12  */
13
14 #include <linux/clk.h>
15 #include <linux/mutex.h>
16
17 #include <drm/drmP.h>
18 #include <drm/drm_atomic.h>
19 #include <drm/drm_atomic_helper.h>
20 #include <drm/drm_crtc.h>
21 #include <drm/drm_crtc_helper.h>
22 #include <drm/drm_fb_cma_helper.h>
23 #include <drm/drm_gem_cma_helper.h>
24 #include <drm/drm_plane_helper.h>
25
26 #include "rcar_du_crtc.h"
27 #include "rcar_du_drv.h"
28 #include "rcar_du_kms.h"
29 #include "rcar_du_plane.h"
30 #include "rcar_du_regs.h"
31
32 static u32 rcar_du_crtc_read(struct rcar_du_crtc *rcrtc, u32 reg)
33 {
34         struct rcar_du_device *rcdu = rcrtc->group->dev;
35
36         return rcar_du_read(rcdu, rcrtc->mmio_offset + reg);
37 }
38
39 static void rcar_du_crtc_write(struct rcar_du_crtc *rcrtc, u32 reg, u32 data)
40 {
41         struct rcar_du_device *rcdu = rcrtc->group->dev;
42
43         rcar_du_write(rcdu, rcrtc->mmio_offset + reg, data);
44 }
45
46 static void rcar_du_crtc_clr(struct rcar_du_crtc *rcrtc, u32 reg, u32 clr)
47 {
48         struct rcar_du_device *rcdu = rcrtc->group->dev;
49
50         rcar_du_write(rcdu, rcrtc->mmio_offset + reg,
51                       rcar_du_read(rcdu, rcrtc->mmio_offset + reg) & ~clr);
52 }
53
54 static void rcar_du_crtc_set(struct rcar_du_crtc *rcrtc, u32 reg, u32 set)
55 {
56         struct rcar_du_device *rcdu = rcrtc->group->dev;
57
58         rcar_du_write(rcdu, rcrtc->mmio_offset + reg,
59                       rcar_du_read(rcdu, rcrtc->mmio_offset + reg) | set);
60 }
61
62 static void rcar_du_crtc_clr_set(struct rcar_du_crtc *rcrtc, u32 reg,
63                                  u32 clr, u32 set)
64 {
65         struct rcar_du_device *rcdu = rcrtc->group->dev;
66         u32 value = rcar_du_read(rcdu, rcrtc->mmio_offset + reg);
67
68         rcar_du_write(rcdu, rcrtc->mmio_offset + reg, (value & ~clr) | set);
69 }
70
71 static int rcar_du_crtc_get(struct rcar_du_crtc *rcrtc)
72 {
73         int ret;
74
75         ret = clk_prepare_enable(rcrtc->clock);
76         if (ret < 0)
77                 return ret;
78
79         ret = clk_prepare_enable(rcrtc->extclock);
80         if (ret < 0)
81                 goto error_clock;
82
83         ret = rcar_du_group_get(rcrtc->group);
84         if (ret < 0)
85                 goto error_group;
86
87         return 0;
88
89 error_group:
90         clk_disable_unprepare(rcrtc->extclock);
91 error_clock:
92         clk_disable_unprepare(rcrtc->clock);
93         return ret;
94 }
95
96 static void rcar_du_crtc_put(struct rcar_du_crtc *rcrtc)
97 {
98         rcar_du_group_put(rcrtc->group);
99
100         clk_disable_unprepare(rcrtc->extclock);
101         clk_disable_unprepare(rcrtc->clock);
102 }
103
104 /* -----------------------------------------------------------------------------
105  * Hardware Setup
106  */
107
108 static void rcar_du_crtc_set_display_timing(struct rcar_du_crtc *rcrtc)
109 {
110         const struct drm_display_mode *mode = &rcrtc->crtc.state->adjusted_mode;
111         unsigned long mode_clock = mode->clock * 1000;
112         unsigned long clk;
113         u32 value;
114         u32 escr;
115         u32 div;
116
117         /* Compute the clock divisor and select the internal or external dot
118          * clock based on the requested frequency.
119          */
120         clk = clk_get_rate(rcrtc->clock);
121         div = DIV_ROUND_CLOSEST(clk, mode_clock);
122         div = clamp(div, 1U, 64U) - 1;
123         escr = div | ESCR_DCLKSEL_CLKS;
124
125         if (rcrtc->extclock) {
126                 unsigned long extclk;
127                 unsigned long extrate;
128                 unsigned long rate;
129                 u32 extdiv;
130
131                 extclk = clk_get_rate(rcrtc->extclock);
132                 extdiv = DIV_ROUND_CLOSEST(extclk, mode_clock);
133                 extdiv = clamp(extdiv, 1U, 64U) - 1;
134
135                 rate = clk / (div + 1);
136                 extrate = extclk / (extdiv + 1);
137
138                 if (abs((long)extrate - (long)mode_clock) <
139                     abs((long)rate - (long)mode_clock)) {
140                         dev_dbg(rcrtc->group->dev->dev,
141                                 "crtc%u: using external clock\n", rcrtc->index);
142                         escr = extdiv | ESCR_DCLKSEL_DCLKIN;
143                 }
144         }
145
146         rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? ESCR2 : ESCR,
147                             escr);
148         rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? OTAR2 : OTAR, 0);
149
150         /* Signal polarities */
151         value = ((mode->flags & DRM_MODE_FLAG_PVSYNC) ? 0 : DSMR_VSL)
152               | ((mode->flags & DRM_MODE_FLAG_PHSYNC) ? 0 : DSMR_HSL)
153               | DSMR_DIPM_DE | DSMR_CSPM;
154         rcar_du_crtc_write(rcrtc, DSMR, value);
155
156         /* Display timings */
157         rcar_du_crtc_write(rcrtc, HDSR, mode->htotal - mode->hsync_start - 19);
158         rcar_du_crtc_write(rcrtc, HDER, mode->htotal - mode->hsync_start +
159                                         mode->hdisplay - 19);
160         rcar_du_crtc_write(rcrtc, HSWR, mode->hsync_end -
161                                         mode->hsync_start - 1);
162         rcar_du_crtc_write(rcrtc, HCR,  mode->htotal - 1);
163
164         rcar_du_crtc_write(rcrtc, VDSR, mode->crtc_vtotal -
165                                         mode->crtc_vsync_end - 2);
166         rcar_du_crtc_write(rcrtc, VDER, mode->crtc_vtotal -
167                                         mode->crtc_vsync_end +
168                                         mode->crtc_vdisplay - 2);
169         rcar_du_crtc_write(rcrtc, VSPR, mode->crtc_vtotal -
170                                         mode->crtc_vsync_end +
171                                         mode->crtc_vsync_start - 1);
172         rcar_du_crtc_write(rcrtc, VCR,  mode->crtc_vtotal - 1);
173
174         rcar_du_crtc_write(rcrtc, DESR,  mode->htotal - mode->hsync_start);
175         rcar_du_crtc_write(rcrtc, DEWR,  mode->hdisplay);
176 }
177
178 void rcar_du_crtc_route_output(struct drm_crtc *crtc,
179                                enum rcar_du_output output)
180 {
181         struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
182         struct rcar_du_device *rcdu = rcrtc->group->dev;
183
184         /* Store the route from the CRTC output to the DU output. The DU will be
185          * configured when starting the CRTC.
186          */
187         rcrtc->outputs |= BIT(output);
188
189         /* Store RGB routing to DPAD0, the hardware will be configured when
190          * starting the CRTC.
191          */
192         if (output == RCAR_DU_OUTPUT_DPAD0)
193                 rcdu->dpad0_source = rcrtc->index;
194 }
195
196 static unsigned int plane_zpos(struct rcar_du_plane *plane)
197 {
198         return to_rcar_plane_state(plane->plane.state)->zpos;
199 }
200
201 static const struct rcar_du_format_info *
202 plane_format(struct rcar_du_plane *plane)
203 {
204         return to_rcar_plane_state(plane->plane.state)->format;
205 }
206
207 static void rcar_du_crtc_update_planes(struct rcar_du_crtc *rcrtc)
208 {
209         struct rcar_du_plane *planes[RCAR_DU_NUM_HW_PLANES];
210         unsigned int num_planes = 0;
211         unsigned int dptsr_planes;
212         unsigned int hwplanes = 0;
213         unsigned int prio = 0;
214         unsigned int i;
215         u32 dspr = 0;
216
217         for (i = 0; i < rcrtc->group->num_planes; ++i) {
218                 struct rcar_du_plane *plane = &rcrtc->group->planes[i];
219                 unsigned int j;
220
221                 if (plane->plane.state->crtc != &rcrtc->crtc)
222                         continue;
223
224                 /* Insert the plane in the sorted planes array. */
225                 for (j = num_planes++; j > 0; --j) {
226                         if (plane_zpos(planes[j-1]) <= plane_zpos(plane))
227                                 break;
228                         planes[j] = planes[j-1];
229                 }
230
231                 planes[j] = plane;
232                 prio += plane_format(plane)->planes * 4;
233         }
234
235         for (i = 0; i < num_planes; ++i) {
236                 struct rcar_du_plane *plane = planes[i];
237                 struct drm_plane_state *state = plane->plane.state;
238                 unsigned int index = to_rcar_plane_state(state)->hwindex;
239
240                 prio -= 4;
241                 dspr |= (index + 1) << prio;
242                 hwplanes |= 1 << index;
243
244                 if (plane_format(plane)->planes == 2) {
245                         index = (index + 1) % 8;
246
247                         prio -= 4;
248                         dspr |= (index + 1) << prio;
249                         hwplanes |= 1 << index;
250                 }
251         }
252
253         /* Update the planes to display timing and dot clock generator
254          * associations.
255          *
256          * Updating the DPTSR register requires restarting the CRTC group,
257          * resulting in visible flicker. To mitigate the issue only update the
258          * association if needed by enabled planes. Planes being disabled will
259          * keep their current association.
260          */
261         mutex_lock(&rcrtc->group->lock);
262
263         dptsr_planes = rcrtc->index % 2 ? rcrtc->group->dptsr_planes | hwplanes
264                      : rcrtc->group->dptsr_planes & ~hwplanes;
265
266         if (dptsr_planes != rcrtc->group->dptsr_planes) {
267                 rcar_du_group_write(rcrtc->group, DPTSR,
268                                     (dptsr_planes << 16) | dptsr_planes);
269                 rcrtc->group->dptsr_planes = dptsr_planes;
270
271                 if (rcrtc->group->used_crtcs)
272                         rcar_du_group_restart(rcrtc->group);
273         }
274
275         mutex_unlock(&rcrtc->group->lock);
276
277         rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? DS2PR : DS1PR,
278                             dspr);
279 }
280
281 /* -----------------------------------------------------------------------------
282  * Page Flip
283  */
284
285 void rcar_du_crtc_cancel_page_flip(struct rcar_du_crtc *rcrtc,
286                                    struct drm_file *file)
287 {
288         struct drm_pending_vblank_event *event;
289         struct drm_device *dev = rcrtc->crtc.dev;
290         unsigned long flags;
291
292         /* Destroy the pending vertical blanking event associated with the
293          * pending page flip, if any, and disable vertical blanking interrupts.
294          */
295         spin_lock_irqsave(&dev->event_lock, flags);
296         event = rcrtc->event;
297         if (event && event->base.file_priv == file) {
298                 rcrtc->event = NULL;
299                 event->base.destroy(&event->base);
300                 drm_crtc_vblank_put(&rcrtc->crtc);
301         }
302         spin_unlock_irqrestore(&dev->event_lock, flags);
303 }
304
305 static void rcar_du_crtc_finish_page_flip(struct rcar_du_crtc *rcrtc)
306 {
307         struct drm_pending_vblank_event *event;
308         struct drm_device *dev = rcrtc->crtc.dev;
309         unsigned long flags;
310
311         spin_lock_irqsave(&dev->event_lock, flags);
312         event = rcrtc->event;
313         rcrtc->event = NULL;
314         spin_unlock_irqrestore(&dev->event_lock, flags);
315
316         if (event == NULL)
317                 return;
318
319         spin_lock_irqsave(&dev->event_lock, flags);
320         drm_send_vblank_event(dev, rcrtc->index, event);
321         wake_up(&rcrtc->flip_wait);
322         spin_unlock_irqrestore(&dev->event_lock, flags);
323
324         drm_crtc_vblank_put(&rcrtc->crtc);
325 }
326
327 static bool rcar_du_crtc_page_flip_pending(struct rcar_du_crtc *rcrtc)
328 {
329         struct drm_device *dev = rcrtc->crtc.dev;
330         unsigned long flags;
331         bool pending;
332
333         spin_lock_irqsave(&dev->event_lock, flags);
334         pending = rcrtc->event != NULL;
335         spin_unlock_irqrestore(&dev->event_lock, flags);
336
337         return pending;
338 }
339
340 static void rcar_du_crtc_wait_page_flip(struct rcar_du_crtc *rcrtc)
341 {
342         struct rcar_du_device *rcdu = rcrtc->group->dev;
343
344         if (wait_event_timeout(rcrtc->flip_wait,
345                                !rcar_du_crtc_page_flip_pending(rcrtc),
346                                msecs_to_jiffies(50)))
347                 return;
348
349         dev_warn(rcdu->dev, "page flip timeout\n");
350
351         rcar_du_crtc_finish_page_flip(rcrtc);
352 }
353
354 /* -----------------------------------------------------------------------------
355  * Start/Stop and Suspend/Resume
356  */
357
358 static void rcar_du_crtc_start(struct rcar_du_crtc *rcrtc)
359 {
360         struct drm_crtc *crtc = &rcrtc->crtc;
361         bool interlaced;
362
363         if (rcrtc->started)
364                 return;
365
366         /* Set display off and background to black */
367         rcar_du_crtc_write(rcrtc, DOOR, DOOR_RGB(0, 0, 0));
368         rcar_du_crtc_write(rcrtc, BPOR, BPOR_RGB(0, 0, 0));
369
370         /* Configure display timings and output routing */
371         rcar_du_crtc_set_display_timing(rcrtc);
372         rcar_du_group_set_routing(rcrtc->group);
373
374         /* Start with all planes disabled. */
375         rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? DS2PR : DS1PR, 0);
376
377         /* Select master sync mode. This enables display operation in master
378          * sync mode (with the HSYNC and VSYNC signals configured as outputs and
379          * actively driven).
380          */
381         interlaced = rcrtc->crtc.mode.flags & DRM_MODE_FLAG_INTERLACE;
382         rcar_du_crtc_clr_set(rcrtc, DSYSR, DSYSR_TVM_MASK | DSYSR_SCM_MASK,
383                              (interlaced ? DSYSR_SCM_INT_VIDEO : 0) |
384                              DSYSR_TVM_MASTER);
385
386         rcar_du_group_start_stop(rcrtc->group, true);
387
388         /* Turn vertical blanking interrupt reporting back on. */
389         drm_crtc_vblank_on(crtc);
390
391         rcrtc->started = true;
392 }
393
394 static void rcar_du_crtc_stop(struct rcar_du_crtc *rcrtc)
395 {
396         struct drm_crtc *crtc = &rcrtc->crtc;
397
398         if (!rcrtc->started)
399                 return;
400
401         /* Disable all planes and wait for the change to take effect. This is
402          * required as the DSnPR registers are updated on vblank, and no vblank
403          * will occur once the CRTC is stopped. Disabling planes when starting
404          * the CRTC thus wouldn't be enough as it would start scanning out
405          * immediately from old frame buffers until the next vblank.
406          *
407          * This increases the CRTC stop delay, especially when multiple CRTCs
408          * are stopped in one operation as we now wait for one vblank per CRTC.
409          * Whether this can be improved needs to be researched.
410          */
411         rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? DS2PR : DS1PR, 0);
412         drm_crtc_wait_one_vblank(crtc);
413
414         /* Disable vertical blanking interrupt reporting. We first need to wait
415          * for page flip completion before stopping the CRTC as userspace
416          * expects page flips to eventually complete.
417          */
418         rcar_du_crtc_wait_page_flip(rcrtc);
419         drm_crtc_vblank_off(crtc);
420
421         /* Select switch sync mode. This stops display operation and configures
422          * the HSYNC and VSYNC signals as inputs.
423          */
424         rcar_du_crtc_clr_set(rcrtc, DSYSR, DSYSR_TVM_MASK, DSYSR_TVM_SWITCH);
425
426         rcar_du_group_start_stop(rcrtc->group, false);
427
428         rcrtc->started = false;
429 }
430
431 void rcar_du_crtc_suspend(struct rcar_du_crtc *rcrtc)
432 {
433         rcar_du_crtc_stop(rcrtc);
434         rcar_du_crtc_put(rcrtc);
435 }
436
437 void rcar_du_crtc_resume(struct rcar_du_crtc *rcrtc)
438 {
439         unsigned int i;
440
441         if (!rcrtc->enabled)
442                 return;
443
444         rcar_du_crtc_get(rcrtc);
445         rcar_du_crtc_start(rcrtc);
446
447         /* Commit the planes state. */
448         for (i = 0; i < rcrtc->group->num_planes; ++i) {
449                 struct rcar_du_plane *plane = &rcrtc->group->planes[i];
450
451                 if (plane->plane.state->crtc != &rcrtc->crtc)
452                         continue;
453
454                 rcar_du_plane_setup(plane);
455         }
456
457         rcar_du_crtc_update_planes(rcrtc);
458 }
459
460 /* -----------------------------------------------------------------------------
461  * CRTC Functions
462  */
463
464 static void rcar_du_crtc_enable(struct drm_crtc *crtc)
465 {
466         struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
467
468         if (rcrtc->enabled)
469                 return;
470
471         rcar_du_crtc_get(rcrtc);
472         rcar_du_crtc_start(rcrtc);
473
474         rcrtc->enabled = true;
475 }
476
477 static void rcar_du_crtc_disable(struct drm_crtc *crtc)
478 {
479         struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
480
481         if (!rcrtc->enabled)
482                 return;
483
484         rcar_du_crtc_stop(rcrtc);
485         rcar_du_crtc_put(rcrtc);
486
487         rcrtc->enabled = false;
488         rcrtc->outputs = 0;
489 }
490
491 static bool rcar_du_crtc_mode_fixup(struct drm_crtc *crtc,
492                                     const struct drm_display_mode *mode,
493                                     struct drm_display_mode *adjusted_mode)
494 {
495         /* TODO Fixup modes */
496         return true;
497 }
498
499 static void rcar_du_crtc_atomic_begin(struct drm_crtc *crtc,
500                                       struct drm_crtc_state *old_crtc_state)
501 {
502         struct drm_pending_vblank_event *event = crtc->state->event;
503         struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
504         struct drm_device *dev = rcrtc->crtc.dev;
505         unsigned long flags;
506
507         if (event) {
508                 WARN_ON(drm_crtc_vblank_get(crtc) != 0);
509
510                 spin_lock_irqsave(&dev->event_lock, flags);
511                 rcrtc->event = event;
512                 spin_unlock_irqrestore(&dev->event_lock, flags);
513         }
514 }
515
516 static void rcar_du_crtc_atomic_flush(struct drm_crtc *crtc,
517                                       struct drm_crtc_state *old_crtc_state)
518 {
519         struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
520
521         rcar_du_crtc_update_planes(rcrtc);
522 }
523
524 static const struct drm_crtc_helper_funcs crtc_helper_funcs = {
525         .mode_fixup = rcar_du_crtc_mode_fixup,
526         .disable = rcar_du_crtc_disable,
527         .enable = rcar_du_crtc_enable,
528         .atomic_begin = rcar_du_crtc_atomic_begin,
529         .atomic_flush = rcar_du_crtc_atomic_flush,
530 };
531
532 static const struct drm_crtc_funcs crtc_funcs = {
533         .reset = drm_atomic_helper_crtc_reset,
534         .destroy = drm_crtc_cleanup,
535         .set_config = drm_atomic_helper_set_config,
536         .page_flip = drm_atomic_helper_page_flip,
537         .atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
538         .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
539 };
540
541 /* -----------------------------------------------------------------------------
542  * Interrupt Handling
543  */
544
545 static irqreturn_t rcar_du_crtc_irq(int irq, void *arg)
546 {
547         struct rcar_du_crtc *rcrtc = arg;
548         irqreturn_t ret = IRQ_NONE;
549         u32 status;
550
551         status = rcar_du_crtc_read(rcrtc, DSSR);
552         rcar_du_crtc_write(rcrtc, DSRCR, status & DSRCR_MASK);
553
554         if (status & DSSR_FRM) {
555                 drm_handle_vblank(rcrtc->crtc.dev, rcrtc->index);
556                 rcar_du_crtc_finish_page_flip(rcrtc);
557                 ret = IRQ_HANDLED;
558         }
559
560         return ret;
561 }
562
563 /* -----------------------------------------------------------------------------
564  * Initialization
565  */
566
567 int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int index)
568 {
569         static const unsigned int mmio_offsets[] = {
570                 DU0_REG_OFFSET, DU1_REG_OFFSET, DU2_REG_OFFSET
571         };
572
573         struct rcar_du_device *rcdu = rgrp->dev;
574         struct platform_device *pdev = to_platform_device(rcdu->dev);
575         struct rcar_du_crtc *rcrtc = &rcdu->crtcs[index];
576         struct drm_crtc *crtc = &rcrtc->crtc;
577         unsigned int irqflags;
578         struct clk *clk;
579         char clk_name[9];
580         char *name;
581         int irq;
582         int ret;
583
584         /* Get the CRTC clock and the optional external clock. */
585         if (rcar_du_has(rcdu, RCAR_DU_FEATURE_CRTC_IRQ_CLOCK)) {
586                 sprintf(clk_name, "du.%u", index);
587                 name = clk_name;
588         } else {
589                 name = NULL;
590         }
591
592         rcrtc->clock = devm_clk_get(rcdu->dev, name);
593         if (IS_ERR(rcrtc->clock)) {
594                 dev_err(rcdu->dev, "no clock for CRTC %u\n", index);
595                 return PTR_ERR(rcrtc->clock);
596         }
597
598         sprintf(clk_name, "dclkin.%u", index);
599         clk = devm_clk_get(rcdu->dev, clk_name);
600         if (!IS_ERR(clk)) {
601                 rcrtc->extclock = clk;
602         } else if (PTR_ERR(rcrtc->clock) == -EPROBE_DEFER) {
603                 dev_info(rcdu->dev, "can't get external clock %u\n", index);
604                 return -EPROBE_DEFER;
605         }
606
607         init_waitqueue_head(&rcrtc->flip_wait);
608
609         rcrtc->group = rgrp;
610         rcrtc->mmio_offset = mmio_offsets[index];
611         rcrtc->index = index;
612         rcrtc->enabled = false;
613
614         ret = drm_crtc_init_with_planes(rcdu->ddev, crtc,
615                                         &rgrp->planes[index % 2].plane,
616                                         NULL, &crtc_funcs);
617         if (ret < 0)
618                 return ret;
619
620         drm_crtc_helper_add(crtc, &crtc_helper_funcs);
621
622         /* Start with vertical blanking interrupt reporting disabled. */
623         drm_crtc_vblank_off(crtc);
624
625         /* Register the interrupt handler. */
626         if (rcar_du_has(rcdu, RCAR_DU_FEATURE_CRTC_IRQ_CLOCK)) {
627                 irq = platform_get_irq(pdev, index);
628                 irqflags = 0;
629         } else {
630                 irq = platform_get_irq(pdev, 0);
631                 irqflags = IRQF_SHARED;
632         }
633
634         if (irq < 0) {
635                 dev_err(rcdu->dev, "no IRQ for CRTC %u\n", index);
636                 return irq;
637         }
638
639         ret = devm_request_irq(rcdu->dev, irq, rcar_du_crtc_irq, irqflags,
640                                dev_name(rcdu->dev), rcrtc);
641         if (ret < 0) {
642                 dev_err(rcdu->dev,
643                         "failed to register IRQ for CRTC %u\n", index);
644                 return ret;
645         }
646
647         return 0;
648 }
649
650 void rcar_du_crtc_enable_vblank(struct rcar_du_crtc *rcrtc, bool enable)
651 {
652         if (enable) {
653                 rcar_du_crtc_write(rcrtc, DSRCR, DSRCR_VBCL);
654                 rcar_du_crtc_set(rcrtc, DIER, DIER_VBE);
655         } else {
656                 rcar_du_crtc_clr(rcrtc, DIER, DIER_VBE);
657         }
658 }