2 * Copyright (C) 2013 Red Hat
3 * Author: Rob Clark <robdclark@gmail.com>
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 as published by
7 * the Free Software Foundation.
9 * This program is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
14 * You should have received a copy of the GNU General Public License along with
15 * this program. If not, see <http://www.gnu.org/licenses/>.
20 #include <drm/drm_mode.h>
22 #include "drm_crtc_helper.h"
23 #include "drm_flip_work.h"
33 /* which mixer/encoder we route output to: */
39 uint32_t width, height;
42 /* next cursor to scan-out: */
44 struct drm_gem_object *next_bo;
46 /* current cursor being scanned out: */
47 struct drm_gem_object *scanout_bo;
51 /* if there is a pending flip, these will be non-null: */
52 struct drm_pending_vblank_event *event;
54 #define PENDING_CURSOR 0x1
55 #define PENDING_FLIP 0x2
58 /* for unref'ing cursor bo's after scanout completes: */
59 struct drm_flip_work unref_cursor_work;
61 struct mdp_irq vblank;
64 #define to_mdp4_crtc(x) container_of(x, struct mdp4_crtc, base)
66 static struct mdp4_kms *get_kms(struct drm_crtc *crtc)
68 struct msm_drm_private *priv = crtc->dev->dev_private;
69 return to_mdp4_kms(to_mdp_kms(priv->kms));
72 static void request_pending(struct drm_crtc *crtc, uint32_t pending)
74 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
76 atomic_or(pending, &mdp4_crtc->pending);
77 mdp_irq_register(&get_kms(crtc)->base, &mdp4_crtc->vblank);
80 static void crtc_flush(struct drm_crtc *crtc)
82 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
83 struct mdp4_kms *mdp4_kms = get_kms(crtc);
84 struct drm_plane *plane;
87 drm_atomic_crtc_for_each_plane(plane, crtc) {
88 enum mdp4_pipe pipe_id = mdp4_plane_pipe(plane);
89 flush |= pipe2flush(pipe_id);
92 flush |= ovlp2flush(mdp4_crtc->ovlp);
94 DBG("%s: flush=%08x", mdp4_crtc->name, flush);
96 mdp4_write(mdp4_kms, REG_MDP4_OVERLAY_FLUSH, flush);
99 /* if file!=NULL, this is preclose potential cancel-flip path */
100 static void complete_flip(struct drm_crtc *crtc, struct drm_file *file)
102 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
103 struct drm_device *dev = crtc->dev;
104 struct drm_pending_vblank_event *event;
107 spin_lock_irqsave(&dev->event_lock, flags);
108 event = mdp4_crtc->event;
110 /* if regular vblank case (!file) or if cancel-flip from
111 * preclose on file that requested flip, then send the
114 if (!file || (event->base.file_priv == file)) {
115 mdp4_crtc->event = NULL;
116 DBG("%s: send event: %p", mdp4_crtc->name, event);
117 drm_send_vblank_event(dev, mdp4_crtc->id, event);
120 spin_unlock_irqrestore(&dev->event_lock, flags);
123 static void unref_cursor_worker(struct drm_flip_work *work, void *val)
125 struct mdp4_crtc *mdp4_crtc =
126 container_of(work, struct mdp4_crtc, unref_cursor_work);
127 struct mdp4_kms *mdp4_kms = get_kms(&mdp4_crtc->base);
129 msm_gem_put_iova(val, mdp4_kms->id);
130 drm_gem_object_unreference_unlocked(val);
133 static void mdp4_crtc_destroy(struct drm_crtc *crtc)
135 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
137 drm_crtc_cleanup(crtc);
138 drm_flip_work_cleanup(&mdp4_crtc->unref_cursor_work);
143 static bool mdp4_crtc_mode_fixup(struct drm_crtc *crtc,
144 const struct drm_display_mode *mode,
145 struct drm_display_mode *adjusted_mode)
150 /* statically (for now) map planes to mixer stage (z-order): */
151 static const int idxs[] = {
162 /* setup mixer config, for which we need to consider all crtc's and
163 * the planes attached to them
165 * TODO may possibly need some extra locking here
167 static void setup_mixer(struct mdp4_kms *mdp4_kms)
169 struct drm_mode_config *config = &mdp4_kms->dev->mode_config;
170 struct drm_crtc *crtc;
171 uint32_t mixer_cfg = 0;
172 static const enum mdp_mixer_stage_id stages[] = {
173 STAGE_BASE, STAGE0, STAGE1, STAGE2, STAGE3,
176 list_for_each_entry(crtc, &config->crtc_list, head) {
177 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
178 struct drm_plane *plane;
180 drm_atomic_crtc_for_each_plane(plane, crtc) {
181 enum mdp4_pipe pipe_id = mdp4_plane_pipe(plane);
182 int idx = idxs[pipe_id];
183 mixer_cfg = mixercfg(mixer_cfg, mdp4_crtc->mixer,
184 pipe_id, stages[idx]);
188 mdp4_write(mdp4_kms, REG_MDP4_LAYERMIXER_IN_CFG, mixer_cfg);
191 static void blend_setup(struct drm_crtc *crtc)
193 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
194 struct mdp4_kms *mdp4_kms = get_kms(crtc);
195 struct drm_plane *plane;
196 int i, ovlp = mdp4_crtc->ovlp;
197 bool alpha[4]= { false, false, false, false };
199 mdp4_write(mdp4_kms, REG_MDP4_OVLP_TRANSP_LOW0(ovlp), 0);
200 mdp4_write(mdp4_kms, REG_MDP4_OVLP_TRANSP_LOW1(ovlp), 0);
201 mdp4_write(mdp4_kms, REG_MDP4_OVLP_TRANSP_HIGH0(ovlp), 0);
202 mdp4_write(mdp4_kms, REG_MDP4_OVLP_TRANSP_HIGH1(ovlp), 0);
204 drm_atomic_crtc_for_each_plane(plane, crtc) {
205 enum mdp4_pipe pipe_id = mdp4_plane_pipe(plane);
206 int idx = idxs[pipe_id];
208 const struct mdp_format *format =
209 to_mdp_format(msm_framebuffer_format(plane->fb));
210 alpha[idx-1] = format->alpha_enable;
214 for (i = 0; i < 4; i++) {
218 op = MDP4_OVLP_STAGE_OP_FG_ALPHA(FG_PIXEL) |
219 MDP4_OVLP_STAGE_OP_BG_ALPHA(FG_PIXEL) |
220 MDP4_OVLP_STAGE_OP_BG_INV_ALPHA;
222 op = MDP4_OVLP_STAGE_OP_FG_ALPHA(FG_CONST) |
223 MDP4_OVLP_STAGE_OP_BG_ALPHA(BG_CONST);
226 mdp4_write(mdp4_kms, REG_MDP4_OVLP_STAGE_FG_ALPHA(ovlp, i), 0xff);
227 mdp4_write(mdp4_kms, REG_MDP4_OVLP_STAGE_BG_ALPHA(ovlp, i), 0x00);
228 mdp4_write(mdp4_kms, REG_MDP4_OVLP_STAGE_OP(ovlp, i), op);
229 mdp4_write(mdp4_kms, REG_MDP4_OVLP_STAGE_CO3(ovlp, i), 1);
230 mdp4_write(mdp4_kms, REG_MDP4_OVLP_STAGE_TRANSP_LOW0(ovlp, i), 0);
231 mdp4_write(mdp4_kms, REG_MDP4_OVLP_STAGE_TRANSP_LOW1(ovlp, i), 0);
232 mdp4_write(mdp4_kms, REG_MDP4_OVLP_STAGE_TRANSP_HIGH0(ovlp, i), 0);
233 mdp4_write(mdp4_kms, REG_MDP4_OVLP_STAGE_TRANSP_HIGH1(ovlp, i), 0);
236 setup_mixer(mdp4_kms);
239 static void mdp4_crtc_mode_set_nofb(struct drm_crtc *crtc)
241 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
242 struct mdp4_kms *mdp4_kms = get_kms(crtc);
243 enum mdp4_dma dma = mdp4_crtc->dma;
244 int ovlp = mdp4_crtc->ovlp;
245 struct drm_display_mode *mode;
247 if (WARN_ON(!crtc->state))
250 mode = &crtc->state->adjusted_mode;
252 DBG("%s: set mode: %d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
253 mdp4_crtc->name, mode->base.id, mode->name,
254 mode->vrefresh, mode->clock,
255 mode->hdisplay, mode->hsync_start,
256 mode->hsync_end, mode->htotal,
257 mode->vdisplay, mode->vsync_start,
258 mode->vsync_end, mode->vtotal,
259 mode->type, mode->flags);
261 mdp4_write(mdp4_kms, REG_MDP4_DMA_SRC_SIZE(dma),
262 MDP4_DMA_SRC_SIZE_WIDTH(mode->hdisplay) |
263 MDP4_DMA_SRC_SIZE_HEIGHT(mode->vdisplay));
265 /* take data from pipe: */
266 mdp4_write(mdp4_kms, REG_MDP4_DMA_SRC_BASE(dma), 0);
267 mdp4_write(mdp4_kms, REG_MDP4_DMA_SRC_STRIDE(dma), 0);
268 mdp4_write(mdp4_kms, REG_MDP4_DMA_DST_SIZE(dma),
269 MDP4_DMA_DST_SIZE_WIDTH(0) |
270 MDP4_DMA_DST_SIZE_HEIGHT(0));
272 mdp4_write(mdp4_kms, REG_MDP4_OVLP_BASE(ovlp), 0);
273 mdp4_write(mdp4_kms, REG_MDP4_OVLP_SIZE(ovlp),
274 MDP4_OVLP_SIZE_WIDTH(mode->hdisplay) |
275 MDP4_OVLP_SIZE_HEIGHT(mode->vdisplay));
276 mdp4_write(mdp4_kms, REG_MDP4_OVLP_STRIDE(ovlp), 0);
278 mdp4_write(mdp4_kms, REG_MDP4_OVLP_CFG(ovlp), 1);
281 mdp4_write(mdp4_kms, REG_MDP4_DMA_E_QUANT(0), 0x00ff0000);
282 mdp4_write(mdp4_kms, REG_MDP4_DMA_E_QUANT(1), 0x00ff0000);
283 mdp4_write(mdp4_kms, REG_MDP4_DMA_E_QUANT(2), 0x00ff0000);
287 static void mdp4_crtc_disable(struct drm_crtc *crtc)
289 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
290 struct mdp4_kms *mdp4_kms = get_kms(crtc);
292 DBG("%s", mdp4_crtc->name);
294 if (WARN_ON(!mdp4_crtc->enabled))
297 mdp_irq_unregister(&mdp4_kms->base, &mdp4_crtc->err);
298 mdp4_disable(mdp4_kms);
300 mdp4_crtc->enabled = false;
303 static void mdp4_crtc_enable(struct drm_crtc *crtc)
305 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
306 struct mdp4_kms *mdp4_kms = get_kms(crtc);
308 DBG("%s", mdp4_crtc->name);
310 if (WARN_ON(mdp4_crtc->enabled))
313 mdp4_enable(mdp4_kms);
314 mdp_irq_register(&mdp4_kms->base, &mdp4_crtc->err);
318 mdp4_crtc->enabled = true;
321 static int mdp4_crtc_atomic_check(struct drm_crtc *crtc,
322 struct drm_crtc_state *state)
324 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
325 DBG("%s: check", mdp4_crtc->name);
326 // TODO anything else to check?
330 static void mdp4_crtc_atomic_begin(struct drm_crtc *crtc)
332 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
333 DBG("%s: begin", mdp4_crtc->name);
336 static void mdp4_crtc_atomic_flush(struct drm_crtc *crtc)
338 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
339 struct drm_device *dev = crtc->dev;
342 DBG("%s: event: %p", mdp4_crtc->name, crtc->state->event);
344 WARN_ON(mdp4_crtc->event);
346 spin_lock_irqsave(&dev->event_lock, flags);
347 mdp4_crtc->event = crtc->state->event;
348 spin_unlock_irqrestore(&dev->event_lock, flags);
352 request_pending(crtc, PENDING_FLIP);
355 static int mdp4_crtc_set_property(struct drm_crtc *crtc,
356 struct drm_property *property, uint64_t val)
362 #define CURSOR_WIDTH 64
363 #define CURSOR_HEIGHT 64
365 /* called from IRQ to update cursor related registers (if needed). The
366 * cursor registers, other than x/y position, appear not to be double
367 * buffered, and changing them other than from vblank seems to trigger
370 static void update_cursor(struct drm_crtc *crtc)
372 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
373 struct mdp4_kms *mdp4_kms = get_kms(crtc);
374 enum mdp4_dma dma = mdp4_crtc->dma;
377 spin_lock_irqsave(&mdp4_crtc->cursor.lock, flags);
378 if (mdp4_crtc->cursor.stale) {
379 struct drm_gem_object *next_bo = mdp4_crtc->cursor.next_bo;
380 struct drm_gem_object *prev_bo = mdp4_crtc->cursor.scanout_bo;
381 uint32_t iova = mdp4_crtc->cursor.next_iova;
384 /* take a obj ref + iova ref when we start scanning out: */
385 drm_gem_object_reference(next_bo);
386 msm_gem_get_iova_locked(next_bo, mdp4_kms->id, &iova);
389 mdp4_write(mdp4_kms, REG_MDP4_DMA_CURSOR_SIZE(dma),
390 MDP4_DMA_CURSOR_SIZE_WIDTH(mdp4_crtc->cursor.width) |
391 MDP4_DMA_CURSOR_SIZE_HEIGHT(mdp4_crtc->cursor.height));
392 mdp4_write(mdp4_kms, REG_MDP4_DMA_CURSOR_BASE(dma), iova);
393 mdp4_write(mdp4_kms, REG_MDP4_DMA_CURSOR_BLEND_CONFIG(dma),
394 MDP4_DMA_CURSOR_BLEND_CONFIG_FORMAT(CURSOR_ARGB) |
395 MDP4_DMA_CURSOR_BLEND_CONFIG_CURSOR_EN);
397 /* disable cursor: */
398 mdp4_write(mdp4_kms, REG_MDP4_DMA_CURSOR_BASE(dma),
399 mdp4_kms->blank_cursor_iova);
402 /* and drop the iova ref + obj rev when done scanning out: */
404 drm_flip_work_queue(&mdp4_crtc->unref_cursor_work, prev_bo);
406 mdp4_crtc->cursor.scanout_bo = next_bo;
407 mdp4_crtc->cursor.stale = false;
410 mdp4_write(mdp4_kms, REG_MDP4_DMA_CURSOR_POS(dma),
411 MDP4_DMA_CURSOR_POS_X(mdp4_crtc->cursor.x) |
412 MDP4_DMA_CURSOR_POS_Y(mdp4_crtc->cursor.y));
414 spin_unlock_irqrestore(&mdp4_crtc->cursor.lock, flags);
417 static int mdp4_crtc_cursor_set(struct drm_crtc *crtc,
418 struct drm_file *file_priv, uint32_t handle,
419 uint32_t width, uint32_t height)
421 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
422 struct mdp4_kms *mdp4_kms = get_kms(crtc);
423 struct drm_device *dev = crtc->dev;
424 struct drm_gem_object *cursor_bo, *old_bo;
429 if ((width > CURSOR_WIDTH) || (height > CURSOR_HEIGHT)) {
430 dev_err(dev->dev, "bad cursor size: %dx%d\n", width, height);
435 cursor_bo = drm_gem_object_lookup(dev, file_priv, handle);
443 ret = msm_gem_get_iova(cursor_bo, mdp4_kms->id, &iova);
450 spin_lock_irqsave(&mdp4_crtc->cursor.lock, flags);
451 old_bo = mdp4_crtc->cursor.next_bo;
452 mdp4_crtc->cursor.next_bo = cursor_bo;
453 mdp4_crtc->cursor.next_iova = iova;
454 mdp4_crtc->cursor.width = width;
455 mdp4_crtc->cursor.height = height;
456 mdp4_crtc->cursor.stale = true;
457 spin_unlock_irqrestore(&mdp4_crtc->cursor.lock, flags);
460 /* drop our previous reference: */
461 drm_flip_work_queue(&mdp4_crtc->unref_cursor_work, old_bo);
464 request_pending(crtc, PENDING_CURSOR);
469 drm_gem_object_unreference_unlocked(cursor_bo);
473 static int mdp4_crtc_cursor_move(struct drm_crtc *crtc, int x, int y)
475 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
478 spin_lock_irqsave(&mdp4_crtc->cursor.lock, flags);
479 mdp4_crtc->cursor.x = x;
480 mdp4_crtc->cursor.y = y;
481 spin_unlock_irqrestore(&mdp4_crtc->cursor.lock, flags);
484 request_pending(crtc, PENDING_CURSOR);
489 static const struct drm_crtc_funcs mdp4_crtc_funcs = {
490 .set_config = drm_atomic_helper_set_config,
491 .destroy = mdp4_crtc_destroy,
492 .page_flip = drm_atomic_helper_page_flip,
493 .set_property = mdp4_crtc_set_property,
494 .cursor_set = mdp4_crtc_cursor_set,
495 .cursor_move = mdp4_crtc_cursor_move,
496 .reset = drm_atomic_helper_crtc_reset,
497 .atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
498 .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
501 static const struct drm_crtc_helper_funcs mdp4_crtc_helper_funcs = {
502 .mode_fixup = mdp4_crtc_mode_fixup,
503 .mode_set_nofb = mdp4_crtc_mode_set_nofb,
504 .disable = mdp4_crtc_disable,
505 .enable = mdp4_crtc_enable,
506 .atomic_check = mdp4_crtc_atomic_check,
507 .atomic_begin = mdp4_crtc_atomic_begin,
508 .atomic_flush = mdp4_crtc_atomic_flush,
511 static void mdp4_crtc_vblank_irq(struct mdp_irq *irq, uint32_t irqstatus)
513 struct mdp4_crtc *mdp4_crtc = container_of(irq, struct mdp4_crtc, vblank);
514 struct drm_crtc *crtc = &mdp4_crtc->base;
515 struct msm_drm_private *priv = crtc->dev->dev_private;
518 mdp_irq_unregister(&get_kms(crtc)->base, &mdp4_crtc->vblank);
520 pending = atomic_xchg(&mdp4_crtc->pending, 0);
522 if (pending & PENDING_FLIP) {
523 complete_flip(crtc, NULL);
526 if (pending & PENDING_CURSOR) {
528 drm_flip_work_commit(&mdp4_crtc->unref_cursor_work, priv->wq);
532 static void mdp4_crtc_err_irq(struct mdp_irq *irq, uint32_t irqstatus)
534 struct mdp4_crtc *mdp4_crtc = container_of(irq, struct mdp4_crtc, err);
535 struct drm_crtc *crtc = &mdp4_crtc->base;
536 DBG("%s: error: %08x", mdp4_crtc->name, irqstatus);
540 uint32_t mdp4_crtc_vblank(struct drm_crtc *crtc)
542 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
543 return mdp4_crtc->vblank.irqmask;
546 void mdp4_crtc_cancel_pending_flip(struct drm_crtc *crtc, struct drm_file *file)
548 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
549 DBG("%s: cancel: %p", mdp4_crtc->name, file);
550 complete_flip(crtc, file);
553 /* set dma config, ie. the format the encoder wants. */
554 void mdp4_crtc_set_config(struct drm_crtc *crtc, uint32_t config)
556 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
557 struct mdp4_kms *mdp4_kms = get_kms(crtc);
559 mdp4_write(mdp4_kms, REG_MDP4_DMA_CONFIG(mdp4_crtc->dma), config);
562 /* set interface for routing crtc->encoder: */
563 void mdp4_crtc_set_intf(struct drm_crtc *crtc, enum mdp4_intf intf, int mixer)
565 struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc);
566 struct mdp4_kms *mdp4_kms = get_kms(crtc);
569 intf_sel = mdp4_read(mdp4_kms, REG_MDP4_DISP_INTF_SEL);
571 switch (mdp4_crtc->dma) {
573 intf_sel &= ~MDP4_DISP_INTF_SEL_PRIM__MASK;
574 intf_sel |= MDP4_DISP_INTF_SEL_PRIM(intf);
577 intf_sel &= ~MDP4_DISP_INTF_SEL_SEC__MASK;
578 intf_sel |= MDP4_DISP_INTF_SEL_SEC(intf);
581 intf_sel &= ~MDP4_DISP_INTF_SEL_EXT__MASK;
582 intf_sel |= MDP4_DISP_INTF_SEL_EXT(intf);
586 if (intf == INTF_DSI_VIDEO) {
587 intf_sel &= ~MDP4_DISP_INTF_SEL_DSI_CMD;
588 intf_sel |= MDP4_DISP_INTF_SEL_DSI_VIDEO;
589 } else if (intf == INTF_DSI_CMD) {
590 intf_sel &= ~MDP4_DISP_INTF_SEL_DSI_VIDEO;
591 intf_sel |= MDP4_DISP_INTF_SEL_DSI_CMD;
594 mdp4_crtc->mixer = mixer;
598 DBG("%s: intf_sel=%08x", mdp4_crtc->name, intf_sel);
600 mdp4_write(mdp4_kms, REG_MDP4_DISP_INTF_SEL, intf_sel);
603 static const char *dma_names[] = {
604 "DMA_P", "DMA_S", "DMA_E",
607 /* initialize crtc */
608 struct drm_crtc *mdp4_crtc_init(struct drm_device *dev,
609 struct drm_plane *plane, int id, int ovlp_id,
610 enum mdp4_dma dma_id)
612 struct drm_crtc *crtc = NULL;
613 struct mdp4_crtc *mdp4_crtc;
615 mdp4_crtc = kzalloc(sizeof(*mdp4_crtc), GFP_KERNEL);
617 return ERR_PTR(-ENOMEM);
619 crtc = &mdp4_crtc->base;
623 mdp4_crtc->ovlp = ovlp_id;
624 mdp4_crtc->dma = dma_id;
626 mdp4_crtc->vblank.irqmask = dma2irq(mdp4_crtc->dma);
627 mdp4_crtc->vblank.irq = mdp4_crtc_vblank_irq;
629 mdp4_crtc->err.irqmask = dma2err(mdp4_crtc->dma);
630 mdp4_crtc->err.irq = mdp4_crtc_err_irq;
632 snprintf(mdp4_crtc->name, sizeof(mdp4_crtc->name), "%s:%d",
633 dma_names[dma_id], ovlp_id);
635 spin_lock_init(&mdp4_crtc->cursor.lock);
637 drm_flip_work_init(&mdp4_crtc->unref_cursor_work,
638 "unref cursor", unref_cursor_worker);
640 drm_crtc_init_with_planes(dev, crtc, plane, NULL, &mdp4_crtc_funcs);
641 drm_crtc_helper_add(crtc, &mdp4_crtc_helper_funcs);
644 mdp4_plane_install_properties(plane, &crtc->base);