Convert service_name to underscore syntax
authorSteven Hardy <shardy@redhat.com>
Thu, 28 Jul 2016 09:30:10 +0000 (10:30 +0100)
committerSteven Hardy <shardy@redhat.com>
Thu, 28 Jul 2016 15:31:36 +0000 (16:31 +0100)
Currently we use hyphens, e.g cinder-api, but in overcloud.yaml
we have a lot of references to services (e.g for AllNodesConfig)
by underscore, e.g cinder_api.  To enable dynamic generation of
this data, we need the service name in underscore format.

Change-Id: Ief13dfe5d8d7691dfe2534ad5c39d7eacbcb6f70

95 files changed:
puppet/services/ceilometer-agent-central.yaml
puppet/services/ceilometer-agent-compute.yaml
puppet/services/ceilometer-agent-notification.yaml
puppet/services/ceilometer-api.yaml
puppet/services/ceilometer-base.yaml
puppet/services/ceilometer-collector.yaml
puppet/services/ceilometer-expirer.yaml
puppet/services/ceph-base.yaml
puppet/services/ceph-client.yaml
puppet/services/ceph-external.yaml
puppet/services/ceph-mon.yaml
puppet/services/ceph-osd.yaml
puppet/services/cinder-api.yaml
puppet/services/cinder-base.yaml
puppet/services/cinder-scheduler.yaml
puppet/services/cinder-volume.yaml
puppet/services/database/mongodb-base.yaml
puppet/services/database/redis-base.yaml
puppet/services/glance-api.yaml
puppet/services/glance-registry.yaml
puppet/services/gnocchi-api.yaml
puppet/services/gnocchi-base.yaml
puppet/services/gnocchi-metricd.yaml
puppet/services/gnocchi-statsd.yaml
puppet/services/heat-api-cfn.yaml
puppet/services/heat-api-cloudwatch.yaml
puppet/services/heat-api.yaml
puppet/services/heat-base.yaml
puppet/services/heat-engine.yaml
puppet/services/ironic-api.yaml
puppet/services/ironic-base.yaml
puppet/services/ironic-conductor.yaml
puppet/services/neutron-base.yaml
puppet/services/neutron-compute-plugin-midonet.yaml
puppet/services/neutron-compute-plugin-nuage.yaml
puppet/services/neutron-compute-plugin-opencontrail.yaml
puppet/services/neutron-compute-plugin-plumgrid.yaml
puppet/services/neutron-dhcp.yaml
puppet/services/neutron-l3.yaml
puppet/services/neutron-metadata.yaml
puppet/services/neutron-midonet.yaml
puppet/services/neutron-ovs-agent.yaml
puppet/services/neutron-plugin-ml2.yaml
puppet/services/neutron-plugin-nuage.yaml
puppet/services/neutron-plugin-opencontrail.yaml
puppet/services/neutron-plugin-plumgrid.yaml
puppet/services/neutron-server.yaml
puppet/services/nova-api.yaml
puppet/services/nova-base.yaml
puppet/services/nova-compute.yaml
puppet/services/nova-conductor.yaml
puppet/services/nova-consoleauth.yaml
puppet/services/nova-libvirt.yaml
puppet/services/nova-scheduler.yaml
puppet/services/nova-vncproxy.yaml
puppet/services/pacemaker/ceilometer-agent-central.yaml
puppet/services/pacemaker/ceilometer-agent-notification.yaml
puppet/services/pacemaker/ceilometer-api.yaml
puppet/services/pacemaker/ceilometer-collector.yaml
puppet/services/pacemaker/cinder-api.yaml
puppet/services/pacemaker/cinder-scheduler.yaml
puppet/services/pacemaker/cinder-volume.yaml
puppet/services/pacemaker/glance-api.yaml
puppet/services/pacemaker/glance-registry.yaml
puppet/services/pacemaker/gnocchi-api.yaml
puppet/services/pacemaker/gnocchi-metricd.yaml
puppet/services/pacemaker/gnocchi-statsd.yaml
puppet/services/pacemaker/heat-api-cfn.yaml
puppet/services/pacemaker/heat-api-cloudwatch.yaml
puppet/services/pacemaker/heat-api.yaml
puppet/services/pacemaker/heat-engine.yaml
puppet/services/pacemaker/neutron-dhcp.yaml
puppet/services/pacemaker/neutron-l3.yaml
puppet/services/pacemaker/neutron-metadata.yaml
puppet/services/pacemaker/neutron-midonet.yaml
puppet/services/pacemaker/neutron-ovs-agent.yaml
puppet/services/pacemaker/neutron-plugin-ml2.yaml
puppet/services/pacemaker/neutron-plugin-nuage.yaml
puppet/services/pacemaker/neutron-plugin-opencontrail.yaml
puppet/services/pacemaker/neutron-plugin-plumgrid.yaml
puppet/services/pacemaker/neutron-server.yaml
puppet/services/pacemaker/nova-api.yaml
puppet/services/pacemaker/nova-conductor.yaml
puppet/services/pacemaker/nova-consoleauth.yaml
puppet/services/pacemaker/nova-scheduler.yaml
puppet/services/pacemaker/nova-vncproxy.yaml
puppet/services/pacemaker/sahara-api.yaml
puppet/services/pacemaker/sahara-engine.yaml
puppet/services/sahara-api.yaml
puppet/services/sahara-base.yaml
puppet/services/sahara-engine.yaml
puppet/services/swift-proxy.yaml
puppet/services/swift-ringbuilder.yaml
puppet/services/swift-storage.yaml
tools/yaml-validate.py

index 34735f7..80f656d 100644 (file)
@@ -28,7 +28,7 @@ outputs:
   role_data:
     description: Role data for the Ceilometer Central Agent role.
     value:
-      service_name: ceilometer-agent-central
+      service_name: ceilometer_agent_central
       config_settings:
         map_merge:
           - get_attr: [CeilometerServiceBase, role_data, config_settings]
index 9e4d057..181c64d 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Ceilometer Compute Agent role.
     value:
-      service_name: ceilometer-agent-compute
+      service_name: ceilometer_agent_compute
       config_settings:
         get_attr: [CeilometerServiceBase, role_data, config_settings]
       step_config: |
index b65e189..58e28a3 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Ceilometer Notification Agent role.
     value:
-      service_name: ceilometer-agent-notification
+      service_name: ceilometer_agent_notification
       config_settings:
         get_attr: [CeilometerServiceBase, role_data, config_settings]
       step_config: |
index d0f3767..b4db4fe 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Ceilometer API role.
     value:
-      service_name: ceilometer-api
+      service_name: ceilometer_api
       config_settings:
         map_merge:
           - get_attr: [CeilometerServiceBase, role_data, config_settings]
index 40060a1..aa0c76c 100644 (file)
@@ -62,7 +62,7 @@ outputs:
   role_data:
     description: Role data for the Ceilometer role.
     value:
-      service_name: ceilometer-base
+      service_name: ceilometer_base
       config_settings:
         ceilometer::db::database_connection:
           list_join:
index 540a465..7a7bc19 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Ceilometer Collector role.
     value:
-      service_name: ceilometer-collector
+      service_name: ceilometer_collector
       config_settings:
         get_attr: [CeilometerServiceBase, role_data, config_settings]
       step_config: |
index 7816a85..c960e6d 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Ceilometer Expirer role.
     value:
-      service_name: ceilometer-expirer
+      service_name: ceilometer_expirer
       config_settings:
         get_attr: [CeilometerServiceBase, role_data, config_settings]
       step_config: |
index 76f649b..563feeb 100644 (file)
@@ -57,7 +57,7 @@ outputs:
   role_data:
     description: Role data for the Ceph base service.
     value:
-      service_name: ceph-base
+      service_name: ceph_base
       config_settings:
         tripleo::profile::base::ceph::ceph_ipv6: {get_param: CephIPv6}
         tripleo::profile::base::ceph::enable_ceph_storage: {get_param: ControllerEnableCephStorage}
index fc23f71..33bbbe5 100644 (file)
@@ -18,7 +18,7 @@ outputs:
   role_data:
     description: Role data for the Cinder OSD service.
     value:
-      service_name: ceph-client
+      service_name: ceph_client
       config_settings:
         get_attr: [CephBase, role_data, config_settings]
       step_config: |
index b656e24..7c1cfba 100644 (file)
@@ -40,7 +40,7 @@ outputs:
   role_data:
     description: Role data for the Ceph External service.
     value:
-      service_name: ceph-external
+      service_name: ceph_external
       config_settings:
         tripleo::profile::base::ceph::ceph_mon_host: {get_param: CephExternalMonHost}
         ceph::profile::params::fsid: {get_param: CephClusterFSID}
index 8df7683..25da71f 100644 (file)
@@ -41,7 +41,7 @@ outputs:
   role_data:
     description: Role data for the Ceph Monitor service.
     value:
-      service_name: ceph-mon
+      service_name: ceph_mon
       config_settings:
         map_merge:
           - get_attr: [CephBase, role_data, config_settings]
index b6f464b..21cefb3 100644 (file)
@@ -18,7 +18,7 @@ outputs:
   role_data:
     description: Role data for the Cinder OSD service.
     value:
-      service_name: ceph-osd
+      service_name: ceph_osd
       config_settings:
         map_merge:
           - get_attr: [CephBase, role_data, config_settings]
index 0cefb38..ba2131c 100644 (file)
@@ -30,7 +30,7 @@ outputs:
   role_data:
     description: Role data for the Cinder API role.
     value:
-      service_name: cinder-api
+      service_name: cinder_api
       config_settings:
         map_merge:
           - get_attr: [CinderBase, role_data, config_settings]
index adacc73..e365854 100644 (file)
@@ -40,7 +40,7 @@ outputs:
   role_data:
     description: Role data for the Cinder base service.
     value:
-      service_name: cinder-base
+      service_name: cinder_base
       config_settings:
         cinder::database_connection:
           list_join:
index 2e1e852..28dc694 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Cinder Scheduler role.
     value:
-      service_name: cinder-scheduler
+      service_name: cinder_scheduler
       config_settings:
         get_attr: [CinderBase, role_data, config_settings]
       step_config: |
index 8f63ff6..9f49bc0 100644 (file)
@@ -59,7 +59,7 @@ outputs:
   role_data:
     description: Role data for the Cinder Volume role.
     value:
-      service_name: cinder-volume
+      service_name: cinder_volume
       config_settings:
         map_merge:
           - get_attr: [CinderBase, role_data, config_settings]
index ed0b92a..88d4570 100644 (file)
@@ -24,7 +24,7 @@ outputs:
   role_data:
     description: Role data for the MongoDB base service.
     value:
-      service_name: mongodb-base
+      service_name: mongodb_base
       config_settings:
         mongodb::server::nojournal: {get_param: MongoDbNoJournal}
         mongodb::server::ipv6: {get_param: MongoDbIPv6}
index c7b083f..2fa624f 100644 (file)
@@ -13,7 +13,7 @@ outputs:
   role_data:
     description: Role data for the redis role.
     value:
-      service_name: redis-base
+      service_name: redis_base
       config_settings:
        redis::requirepass: {get_param: RedisPassword}
        redis::masterauth: {get_param: RedisPassword}
index ee4c17c..5df1220 100644 (file)
@@ -65,7 +65,7 @@ outputs:
   role_data:
     description: Role data for the Glance API role.
     value:
-      service_name: glance-api
+      service_name: glance_api
       config_settings:
         glance::api::database_connection:
           list_join:
index f9d9dd6..d2a6f4f 100644 (file)
@@ -26,7 +26,7 @@ outputs:
   role_data:
     description: Role data for the Glance Registry role.
     value:
-      service_name: glance-registry
+      service_name: glance_registry
       config_settings:
         glance::registry::database_connection:
           list_join:
index bf23cda..891a60e 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Gnocchi role.
     value:
-      service_name: gnocchi-api
+      service_name: gnocchi_api
       config_settings:
         map_merge:
           - get_attr: [GnocchiServiceBase, role_data, config_settings]
index fa00f73..cb1aad8 100644 (file)
@@ -39,7 +39,7 @@ outputs:
   role_data:
     description: Shared role data for the Heat services.
     value:
-      service_name: gnocchi-base
+      service_name: gnocchi_base
       config_settings:
         #Gnocchi engine
         gnocchi::debug: {get_input: debug}
index 2021538..8041c6f 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Gnocchi role.
     value:
-      service_name: gnocchi-metricd
+      service_name: gnocchi_metricd
       config_settings:
         map_merge:
           - get_attr: [GnocchiServiceBase, role_data, config_settings]
index 4fef7af..9c8e689 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Gnocchi role.
     value:
-      service_name: gnocchi-statsd
+      service_name: gnocchi_statsd
       config_settings:
         map_merge:
           - get_attr: [GnocchiServiceBase, role_data, config_settings]
index 67c89bb..f8832dd 100644 (file)
@@ -30,7 +30,7 @@ outputs:
   role_data:
     description: Role data for the Heat CloudFormation API role.
     value:
-      service_name: heat-api-cfn
+      service_name: heat_api_cfn
       config_settings:
         map_merge:
           - get_attr: [HeatBase, role_data, config_settings]
index 32a0a58..b4669ac 100644 (file)
@@ -22,7 +22,7 @@ outputs:
   role_data:
     description: Role data for the Heat Cloudwatch API role.
     value:
-      service_name: heat-api-cloudwatch
+      service_name: heat_api_cloudwatch
       config_settings:
         map_merge:
           - get_attr: [HeatBase, role_data, config_settings]
index 0bb208d..c0e7a69 100644 (file)
@@ -30,7 +30,7 @@ outputs:
   role_data:
     description: Role data for the Heat API role.
     value:
-      service_name: heat-api
+      service_name: heat_api
       config_settings:
         map_merge:
           - get_attr: [HeatBase, role_data, config_settings]
index 2a7aeab..11818cb 100644 (file)
@@ -31,7 +31,7 @@ outputs:
   role_data:
     description: Shared role data for the Heat services.
     value:
-      service_name: heat-base
+      service_name: heat_base
       config_settings:
         heat::rabbit_userid: {get_param: RabbitUserName}
         heat::rabbit_password: {get_param: RabbitPassword}
index 2fd0188..dea1eea 100644 (file)
@@ -35,7 +35,7 @@ outputs:
   role_data:
     description: Role data for the Heat Engine role.
     value:
-      service_name: heat-engine
+      service_name: heat_engine
       config_settings:
         map_merge:
           - get_attr: [HeatBase, role_data, config_settings]
index 6f369f7..949cdf3 100644 (file)
@@ -24,7 +24,7 @@ outputs:
   role_data:
     description: Role data for the Ironic API role.
     value:
-      service_name: ironic-api
+      service_name: ironic_api
       config_settings:
         map_merge:
           - get_attr: [IronicBase, role_data, config_settings]
index fb9d4dd..41d2234 100644 (file)
@@ -40,7 +40,7 @@ outputs:
   role_data:
     description: Role data for the Ironic role.
     value:
-      service_name: ironic-base
+      service_name: ironic_base
       config_settings:
         ironic::database_connection:
           list_join:
index 574e5ae..a3bce30 100644 (file)
@@ -24,7 +24,7 @@ outputs:
   role_data:
     description: Role data for the Ironic conductor role.
     value:
-      service_name: ironic-conductor
+      service_name: ironic_conductor
       config_settings:
         map_merge:
           - get_attr: [IronicBase, role_data, config_settings]
index 301759c..81da08f 100644 (file)
@@ -47,7 +47,7 @@ outputs:
   role_data:
     description: Role data for the Neutron base service.
     value:
-      service_name: neutron-base
+      service_name: neutron_base
       config_settings:
         neutron::rabbit_password: {get_param: RabbitPassword}
         neutron::rabbit_user: {get_param: RabbitUserName}
index f08afd1..200aaa1 100644 (file)
@@ -14,7 +14,7 @@ outputs:
   role_data:
     description: Role data for the Neutron Compute Plumgrid plugin
     value:
-      service_name: neutron-compute-plugin-midonet
+      service_name: neutron_compute_plugin_midonet
       config_settings:
       step_config: |
         include ::tripleo::profile::base::neutron::agents::midonet
index f6e2f3a..44aac57 100644 (file)
@@ -18,7 +18,7 @@ outputs:
   role_data:
     description: Role data for the Neutron Compute Nuage plugin
     value:
-      service_name: neutron-compute-plugin-nuage
+      service_name: neutron_compute_plugin_nuage
       config_settings:
         tripleo::profile::base::neutron::agents::nuage::nova_os_tenant_name: 'service'
         tripleo::profile::base::neutron::agents::nuage::nova_os_password: {get_param: NovaPassword}
index b95a655..fb6d640 100644 (file)
@@ -14,7 +14,7 @@ outputs:
   role_data:
     description: Role data for the Neutron Compute OpenContrail plugin
     value:
-      service_name: neutron-compute-plugin-opencontrail
+      service_name: neutron_compute_plugin_opencontrail
       config_settings:
       step_config: |
         include ::tripleo::profile::base::neutron::opencontrail::vrouter
index 064ac9e..ad1e346 100644 (file)
@@ -14,7 +14,7 @@ outputs:
   role_data:
     description: Role data for the Neutron Compute Plumgrid plugin
     value:
-      service_name: neutron-compute-plugin-plumgrid
+      service_name: neutron_compute_plugin_plumgrid
       config_settings:
       step_config: |
         include tripleo::profile::base::neutron::plumgrid
index 1c57aa4..322e018 100644 (file)
@@ -23,7 +23,7 @@ outputs:
   role_data:
     description: Role data for the Neutron DHCP agent service.
     value:
-      service_name: neutron-dhcp
+      service_name: neutron_dhcp
       config_settings:
         map_merge:
           - get_attr: [NeutronBase, role_data, config_settings]
index 0e56861..f62d202 100644 (file)
@@ -26,7 +26,7 @@ outputs:
   role_data:
     description: Role data for the Neutron L3 agent service.
     value:
-      service_name: neutron-l3
+      service_name: neutron_l3
       config_settings:
         map_merge:
           - get_attr: [NeutronBase, role_data, config_settings]
index 04c80e0..68ccea6 100644 (file)
@@ -31,7 +31,7 @@ outputs:
   role_data:
     description: Role data for the Neutron Metadata agent service.
     value:
-      service_name: neutron-metadata
+      service_name: neutron_metadata
       config_settings:
         map_merge:
           - get_attr: [NeutronBase, role_data, config_settings]
index d48d97f..ccc0b0d 100644 (file)
@@ -36,7 +36,7 @@ outputs:
   role_data:
     description: Role data for the Neutron Midonet plugin and services
     value:
-      service_name: neutron-midonet
+      service_name: neutron_midonet
       config_settings:
         tripleo::profile::base::neutron::midonet::admin_password: {get_param: AdminPassword}
         tripleo::profile::base::neutron::midonet::keystone_admin_token: {get_param: AdminToken}
index 30caeec..d8679f2 100644 (file)
@@ -47,7 +47,7 @@ outputs:
   role_data:
     description: Role data for the Neutron OVS agent service.
     value:
-      service_name: neutron-ovs-agent
+      service_name: neutron_ovs_agent
       config_settings:
         map_merge:
           - get_attr: [NeutronBase, role_data, config_settings]
index 3511b2f..158122e 100644 (file)
@@ -61,7 +61,7 @@ outputs:
   role_data:
     description: Role data for the Neutron ML2 plugin.
     value:
-      service_name: neutron-plugin-ml2
+      service_name: neutron_plugin_ml2
       config_settings:
         map_merge:
           - get_attr: [NeutronBase, role_data, config_settings]
index 3889f84..5f228f9 100644 (file)
@@ -59,7 +59,7 @@ outputs:
   role_data:
     description: Role data for the Neutron Nuage plugin
     value:
-      service_name: neutron-plugin-nuage
+      service_name: neutron_plugin_nuage
       config_settings:
         map_merge:
           - get_attr: [NeutronBase, role_data, config_settings]
index 1d23c49..ed6a2c0 100644 (file)
@@ -42,7 +42,7 @@ outputs:
   role_data:
     description: Role data for the Neutron Opencontrail plugin
     value:
-      service_name: neutron-plugin-opencontrail
+      service_name: neutron_plugin_opencontrail
       config_settings:
         map_merge:
           - get_attr: [NeutronBase, role_data, config_settings]
index 484d163..5ae699d 100644 (file)
@@ -80,7 +80,7 @@ outputs:
   role_data:
     description: Role data for the Neutron Plumgrid plugin
     value:
-      service_name: neutron-plugin-plumgrid
+      service_name: neutron_plugin_plumgrid
       config_settings:
         neutron::plugins::plumgrid::connection:
           list_join:
index 253a6bf..8c6a253 100644 (file)
@@ -39,7 +39,7 @@ outputs:
   role_data:
     description: Role data for the Neutron Server agent service.
     value:
-      service_name: neutron-server
+      service_name: neutron_server
       config_settings:
         map_merge:
           - get_attr: [NeutronBase, role_data, config_settings]
index 0dd8fd5..402c39e 100644 (file)
@@ -24,7 +24,7 @@ outputs:
   role_data:
     description: Role data for the Nova API service.
     value:
-      service_name: nova-api
+      service_name: nova_api
       config_settings:
         map_merge:
           - get_attr: [NovaBase, role_data, config_settings]
index c94e024..1686261 100644 (file)
@@ -40,7 +40,7 @@ outputs:
   role_data:
     description: Role data for the Nova base service.
     value:
-      service_name: nova-base
+      service_name: nova_base
       config_settings:
         nova::rabbit_password: {get_param: RabbitPassword}
         nova::rabbit_user: {get_param: RabbitUserName}
index a7226bd..0bf27d1 100644 (file)
@@ -26,7 +26,7 @@ outputs:
   role_data:
     description: Role data for the Nova Compute service.
     value:
-      service_name: nova-compute
+      service_name: nova_compute
       config_settings:
         map_merge:
           - get_attr: [NovaBase, role_data, config_settings]
index c334de4..5964f88 100644 (file)
@@ -24,7 +24,7 @@ outputs:
   role_data:
     description: Role data for the Nova Conductor service.
     value:
-      service_name: nova-conductor
+      service_name: nova_conductor
       config_settings:
         map_merge:
           - get_attr: [NovaBase, role_data, config_settings]
index 0e7bf3b..5fbce1b 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Nova Consoleauth service.
     value:
-      service_name: nova-consoleauth
+      service_name: nova_consoleauth
       config_settings:
         get_attr: [NovaBase, role_data, config_settings]
       step_config: |
index 087ad27..939b6a0 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Libvirt service.
     value:
-      service_name: nova-libvirt
+      service_name: nova_libvirt
       config_settings:
         map_merge:
           - get_attr: [NovaBase, role_data, config_settings]
index 4187b72..bd6e511 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Nova Scheduler service.
     value:
-      service_name: nova-scheduler
+      service_name: nova_scheduler
       config_settings:
         map_merge:
           - get_attr: [NovaBase, role_data, config_settings]
index d8e04cc..f681210 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Nova Vncproxy service.
     value:
-      service_name: nova-vncproxy
+      service_name: nova_vncproxy
       config_settings:
         get_attr: [NovaBase, role_data, config_settings]
       step_config: |
index 3ba78fc..471b9f7 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Ceilometer Central Agent pacemaker role.
     value:
-      service_name: ceilometer-agent-central
+      service_name: ceilometer_agent_central
       config_settings:
         map_merge:
           - get_attr: [CeilometerServiceBase, role_data, config_settings]
index 0fb008c..2530848 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Ceilometer Notification Agent pacemaker role.
     value:
-      service_name: ceilometer-agent-notification
+      service_name: ceilometer_agent_notification
       config_settings:
         map_merge:
           - get_attr: [CeilometerServiceBase, role_data, config_settings]
index 5cd8bb8..f188537 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Ceilometer API pacemaker role.
     value:
-      service_name: ceilometer-api
+      service_name: ceilometer_api
       config_settings:
         map_merge:
           - get_attr: [CeilometerServiceBase, role_data, config_settings]
index 9e3671e..8d31e1a 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Ceilometer Collector pacemaker role.
     value:
-      service_name: ceilometer-collector
+      service_name: ceilometer_collector
       config_settings:
         map_merge:
           - get_attr: [CeilometerServiceBase, role_data, config_settings]
index d1313b2..706a189 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Cinder API role.
     value:
-      service_name: cinder-api
+      service_name: cinder_api
       config_settings:
         map_merge:
           - get_attr: [CinderApiBase, role_data, config_settings]
index c4e0a34..350d712 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Cinder Scheduler role.
     value:
-      service_name: cinder-scheduler
+      service_name: cinder_scheduler
       config_settings:
         map_merge:
           - get_attr: [CinderSchedulerBase, role_data, config_settings]
index 3e28039..7b6e9a7 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Cinder Volume role.
     value:
-      service_name: cinder-volume
+      service_name: cinder_volume
       config_settings:
         map_merge:
           - get_attr: [CinderVolumeBase, role_data, config_settings]
index bc611b0..4e27fd5 100644 (file)
@@ -45,7 +45,7 @@ outputs:
   role_data:
     description: Role data for the Glance role.
     value:
-      service_name: glance-api
+      service_name: glance_api
       config_settings:
         map_merge:
           - get_attr: [GlanceApiBase, role_data, config_settings]
index 72ca939..ae7aa30 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Glance role.
     value:
-      service_name: glance-registry
+      service_name: glance_registry
       config_settings:
         map_merge:
           - get_attr: [GlanceRegistryBase, role_data, config_settings]
index 6c01bc5..bcd73e6 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Gnocchi role.
     value:
-      service_name: gnocchi-api
+      service_name: gnocchi_api
       config_settings:
         map_merge:
           - get_attr: [GnocchiServiceBase, role_data, config_settings]
index 4895bac..ec487e8 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Gnocchi role.
     value:
-      service_name: gnocchi-metricd
+      service_name: gnocchi_metricd
       config_settings:
         map_merge:
           - get_attr: [GnocchiServiceBase, role_data, config_settings]
index 2760df3..d110652 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Gnocchi role.
     value:
-      service_name: gnocchi-statsd
+      service_name: gnocchi_statsd
       config_settings:
         map_merge:
           - get_attr: [GnocchiServiceBase, role_data, config_settings]
index bf01ced..8f2c561 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Heat CloudFormation API role.
     value:
-      service_name: heat-api-cfn
+      service_name: heat_api_cfn
       config_settings:
         map_merge:
           - get_attr: [HeatApiCfnBase, role_data, config_settings]
index 6ee844d..a08e026 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Heat Cloudwatch API role.
     value:
-      service_name: heat-api-cloudwatch
+      service_name: heat_api_cloudwatch
       config_settings:
         map_merge:
            - get_attr: [HeatApiCloudwatchBase, role_data, config_settings]
index 1460442..5cf2551 100644 (file)
@@ -20,7 +20,7 @@ outputs:
   role_data:
     description: Role data for the Heat API role.
     value:
-      service_name: heat-api
+      service_name: heat_api
       config_settings:
         map_merge:
           - get_attr: [HeatApiBase, role_data, config_settings]
index 450917f..4d41cbe 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Heat engine role.
     value:
-      service_name: heat-engine
+      service_name: heat_engine
       config_settings:
         map_merge:
           - get_attr: [HeatEngineBase, role_data, config_settings]
index 312e275..3a5ada4 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Neutron DHCP role.
     value:
-      service_name: neutron-dhcp
+      service_name: neutron_dhcp
       config_settings:
         map_merge:
           - get_attr: [NeutronDhcpBase, role_data, config_settings]
index 8607614..a4f2c0e 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Neutron L3 role.
     value:
-      service_name: neutron-l3
+      service_name: neutron_l3
       config_settings:
         map_merge:
           - get_attr: [NeutronL3Base, role_data, config_settings]
index 96f3fb4..9b322f2 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Neutron Metadata role.
     value:
-      service_name: neutron-metadata
+      service_name: neutron_metadata
       config_settings:
         map_merge:
           - get_attr: [NeutronMetadataBase, role_data, config_settings]
index 3c185da..e93ed66 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Neutron Midonet plugin.
     value:
-      service_name: neutron-midonet
+      service_name: neutron_midonet
       config_settings:
         map_merge:
           - get_attr: [NeutronMidonetBase, role_data, config_settings]
index 214dc1c..b2260de 100644 (file)
@@ -19,7 +19,7 @@ outputs:
   role_data:
     description: Role data for the Neutron OVS agent service.
     value:
-      service_name: neutron-ovs-agent
+      service_name: neutron_ovs_agent
       config_settings:
         get_attr: [NeutronOvsBase, role_data, config_settings]
       step_config: |
index a4c4a5e..dc10d09 100644 (file)
@@ -19,7 +19,7 @@ outputs:
   role_data:
     description: Role data for the Neutron ML2 plugin.
     value:
-      service_name: neutron-plugin-ml2
+      service_name: neutron_plugin_ml2
       config_settings:
         map_merge:
           - get_attr: [NeutronMl2Base, role_data, config_settings]
index 64ad0f4..414c046 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Neutron Nuage plugin.
     value:
-      service_name: neutron-plugin-nuage
+      service_name: neutron_plugin_nuage
       config_settings:
         map_merge:
           - get_attr: [NeutronPluginNuageBase, role_data, config_settings]
index f2fd5b9..1d385d8 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Neutron OpenContrail plugin.
     value:
-      service_name: neutron-plugin-opencontrail
+      service_name: neutron_plugin_opencontrail
       config_settings:
         map_merge:
           - get_attr: [NeutronPluginOpenContrail, role_data, config_settings]
index 9ceaf00..69f5fd2 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Neutron PLUMgrid plugin.
     value:
-      service_name: neutron-plugin-plumgrid
+      service_name: neutron_plugin_plumgrid
       config_settings:
         map_merge:
           - get_attr: [NeutronPluginPlumgridBase, role_data, config_settings]
index 74234a8..b0f739d 100644 (file)
@@ -25,7 +25,7 @@ outputs:
   role_data:
     description: Role data for the Neutron Server.
     value:
-      service_name: neutron-server
+      service_name: neutron_server
       config_settings:
         map_merge:
           - get_attr: [NeutronServerBase, role_data, config_settings]
index 467955f..2d497ab 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Nova API role.
     value:
-      service_name: nova-api
+      service_name: nova_api
       config_settings:
         map_merge:
           - get_attr: [NovaApiBase, role_data, config_settings]
index fe0b00f..1f57cf0 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Nova Conductor role.
     value:
-      service_name: nova-conductor
+      service_name: nova_conductor
       config_settings:
         map_merge:
           - get_attr: [NovaConductorBase, role_data, config_settings]
index cc683eb..bbab8be 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Nova Consoleauth role.
     value:
-      service_name: nova-consoleauth
+      service_name: nova_consoleauth
       config_settings:
         map_merge:
           - get_attr: [NovaConsoleauthBase, role_data, config_settings]
index dbb643c..bf2c62b 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Nova Scheduler role.
     value:
-      service_name: nova-scheduler
+      service_name: nova_scheduler
       config_settings:
         map_merge:
           - get_attr: [NovaSchedulerBase, role_data, config_settings]
index 8fb07d5..0353d92 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Nova Vncproxy role.
     value:
-      service_name: nova-vncproxy
+      service_name: nova_vncproxy
       config_settings:
         map_merge:
           - get_attr: [NovaVncproxyBase, role_data, config_settings]
index a4dfa13..ac05a01 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Sahara API role.
     value:
-      service_name: sahara-api
+      service_name: sahara_api
       config_settings:
         map_merge:
           - get_attr: [SaharaApiBase, role_data, config_settings]
index 31d9bea..f6bd8f6 100644 (file)
@@ -21,7 +21,7 @@ outputs:
   role_data:
     description: Role data for the Sahara Engine role.
     value:
-      service_name: sahara-engine
+      service_name: sahara_engine
       config_settings:
         map_merge:
           - get_attr: [SaharaEngineBase, role_data, config_settings]
index c911201..7ca9bbd 100644 (file)
@@ -34,7 +34,7 @@ outputs:
   role_data:
     description: Role data for the Sahara API role.
     value:
-      service_name: sahara-api
+      service_name: sahara_api
       config_settings:
         map_merge:
           - get_attr: [SaharaBase, role_data, config_settings]
index 72fc33a..981b7c0 100644 (file)
@@ -31,7 +31,7 @@ outputs:
   role_data:
     description: Role data for the Sahara base service.
     value:
-      service_name: sahara-base
+      service_name: sahara_base
       config_settings:
         sahara::rabbit_password: {get_param: RabbitPassword}
         sahara::rabbit_user: {get_param: RabbitUserName}
index b799e27..548d961 100644 (file)
@@ -23,7 +23,7 @@ outputs:
   role_data:
     description: Role data for the Sahara Engine role.
     value:
-      service_name: sahara-engine
+      service_name: sahara_engine
       config_settings:
         map_merge:
           - get_attr: [SaharaBase, role_data, config_settings]
index 12165cc..dcd2c2a 100644 (file)
@@ -35,7 +35,7 @@ outputs:
   role_data:
     description: Role data for the Swift proxy service.
     value:
-      service_name: swift-proxy
+      service_name: swift_proxy
       config_settings:
         # Swift
         swift::proxy::authtoken::auth_uri: {get_param: [EndpointMap, KeystoneInternal, uri]}
index b341b0f..0b17c73 100644 (file)
@@ -30,7 +30,7 @@ outputs:
   role_data:
     description: Role data for Swift Ringbuilder configuration.
     value:
-      service_name: swift-ringbuilder
+      service_name: swift_ringbuilder
       config_settings:
         tripleo::profile::base::swift::ringbuilder::build_ring: {get_param: SwiftRingBuild}
         tripleo::profile::base::swift::ringbuilder::replicas: {get_param: SwiftReplicas}
index d63dc87..effdaf6 100644 (file)
@@ -36,7 +36,7 @@ outputs:
   role_data:
     description: Role data for the Swift Proxy role.
     value:
-      service_name: swift-storage
+      service_name: swift_storage
       config_settings:
         # Swift
         swift::storage::all::mount_check: {get_param: SwiftMountCheck}
index 34219ef..c93c84b 100755 (executable)
@@ -33,8 +33,9 @@ def validate_service(filename, tpl):
             print('ERROR: service_name is required in role_data for %s.'
                   % filename)
             return 1
+        # service_name must match the filename, but with an underscore
         if (role_data['service_name'] !=
-                os.path.basename(filename).split('.')[0]):
+                os.path.basename(filename).split('.')[0].replace("-", "_")):
             print('ERROR: service_name should match file name for service: %s.'
                   % filename)
             return 1