samplevnf.git
5 years agoGambia 7.1 release notes update 99/65799/1 opnfv-7.0.1 opnfv-7.1.0
Deepak S [Thu, 13 Dec 2018 20:32:14 +0000 (02:02 +0530)]
Gambia 7.1 release notes update

Change-Id: I145c87b0c18565da479ecaa08e5ffce91232a7ce
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
5 years agoAdd index.rst 51/65151/1
Aric Gardner [Sat, 10 Nov 2018 21:15:16 +0000 (16:15 -0500)]
Add index.rst

We need an index file so that

https://opnfv-samplevnf.readthedocs.io/en/latest/

can build

Change-Id: I81a98f5264f8ffef0e157610c75f7a172278bcc7
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
(cherry picked from commit 9640f37b8a110f5e9fa1e71cd2de48b95373ed12)

5 years agoUpdating release notes for Gambia... 15/64415/1 opnfv-7.0.0
Deepak S [Fri, 2 Nov 2018 09:36:25 +0000 (15:06 +0530)]
Updating release notes for Gambia...

Change-Id: Ide712ee94254b506a0ad88c95a7e01b789f00e48
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
5 years agoAdd Gambia release notes 43/64343/1
Deepak S [Wed, 31 Oct 2018 23:46:33 +0000 (05:16 +0530)]
Add Gambia release notes

Change-Id: Ide712ee94254b506a0ad88c95a7e01b789f99d49
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
5 years agoSupport for DPDK 18.05 and DPDK 18.08 39/64339/1
Xavier Simonart [Sat, 27 Oct 2018 14:26:26 +0000 (16:26 +0200)]
Support for DPDK 18.05 and DPDK 18.08

Improve DPDK 18.05 support introduced by 3e532aca.
Support for DPDK 18.08.

Change-Id: Ide712ee94254b506a0ad88c95a7e01b789f99d48
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
5 years agoFix potential crash when shuffling mbufs 37/64337/1
Xavier Simonart [Sun, 28 Oct 2018 14:54:28 +0000 (15:54 +0100)]
Fix potential crash when shuffling mbufs

Change-Id: I70de6345afc6a696906f006c1b0f44540ae4ecec
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
5 years agoAdd support for counting non dataplane related packets 35/64335/1
Xavier Simonart [Mon, 22 Oct 2018 13:46:23 +0000 (15:46 +0200)]
Add support for counting non dataplane related packets

When performing some zero packet loss performance testing on dataplane, it
is important (not) to count non dataplane packets. For instance, one might
receive uexpected packets from a switch, or ARP packets. Or one might need
to transmit ARP packets. Such packets should not be counted as dataplane
packets as for thse packets there is no 1:1 mapping between transmitted
packets and received packets.
To support this, the counters reporting numbers of transmitted and received
packets remain unchanged but two new counters have been added to PROX,
counting respectively number of received and number of transmitted
non-dataplane packets.
On RX side, packets are counsidered as non-dataplane if being ARP or if
they do not countain the proper signature
On TX side, ARP packets are not considered as dataplane packets.
This feature requires configuration of signature.
"dp core stats" command has been added

Change-Id: I98e113cd02f36d540383d343a433592867ad86a9
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
5 years agoTest improvements and fixes for image creation 31/64331/1
Luc Provoost [Thu, 11 Oct 2018 16:23:20 +0000 (18:23 +0200)]
Test improvements and fixes for image creation

Updated and corrected the creation of an image containing the PROX
tool with packer.
Test will now only be declared successful when average and maximum
latency are below a certain threshold.
The start speed is now also a parameter of the *.test files.

Change-Id: I1112555c87e7a857e1c699921ae08f61281642e1
Signed-off-by: Luc Provoost <luc.provoost@intel.com>
5 years agoLocal Documentation Builds 99/62499/1
Aric Gardner [Tue, 18 Sep 2018 15:05:14 +0000 (11:05 -0400)]
Local Documentation Builds

    This adds configuration for performing local documentation builds
    with the following simple command:

    tox -e docs

Change-Id: I84d69542d8c603e72d4af460834134d9711ac537
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
5 years agoImprove l3fwd performance 19/61819/2
Xavier Simonart [Tue, 4 Sep 2018 09:58:36 +0000 (11:58 +0200)]
Improve l3fwd performance

JIRA: SAMPLEVNF-128

Improve performance of l3fwd use-case.
L3fwd did not disable TX offload flags, which resulted in
non-vector mode to be used in pmd in some cases like bare-metal.
Note that in some cases such as virtio, vector mode was already
used as OVS reports that it does not support TX-offload, hence
TX-offload was already disabled on virtio.
Using vector mode usually brings higher performance.

Change-Id: I102b846d604a9cf28c6b7dae8bedbe918ccfcf6c
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
5 years agoWorkaround DPDK net/virtio queue setup issue 73/61773/2
Patrice Buriez [Mon, 3 Sep 2018 16:55:24 +0000 (18:55 +0200)]
Workaround DPDK net/virtio queue setup issue

JIRA: SAMPLEVNF-127

PROX was crashing in the VM with vector mode enabled and multiple OVS
queues. This was not really a PROX bug, but a DPDK issue, which has been
fixed by DPDK commit https://git.dpdk.org/dpdk/commit/?id=efc83a1e7fc3
This "net/virtio: fix queue setup consistency" is included in DPDK 17.11
and subsequent versions, and has been backported into:
- DPDK 16.11.4:
  https://git.dpdk.org/dpdk-stable/commit/?h=16.11&id=516447a5056c
- DPDK 17.08.1:
  https://git.dpdk.org/dpdk-stable/commit/?h=17.08&id=907fe4fc263e

This means the fix is not included into any DPDK 17.02.x used by NSB.
Fortunately, a simple workaround consists of calling
rte_eth_tx_queue_setup() before rte_eth_rx_queue_setup().

This change implements this simple workaround, in order to make PROX
work, even with unfixed DPDK versions.

Change-Id: I818e9bb812babe023c6b7225c8b9769a359d9bec
Signed-off-by: Patrice Buriez <patrice.buriez@intel.com>
5 years agoupdate from src port in the pvt/pub handler 75/60775/1
Deepak S [Thu, 9 Aug 2018 05:00:51 +0000 (10:30 +0530)]
update from src port in the pvt/pub handler

Change-Id: Iccd72f6ab3db68bc093c42d60d225fe86f8fbda7
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
5 years agoEnable the local cache mac address 95/60695/1
Deepak S [Tue, 7 Aug 2018 03:20:01 +0000 (08:50 +0530)]
Enable the local cache mac address

Change-Id: If7d72f6ab3db68bc093c42d60d125fe86f8fbda7
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
5 years agoMerge "Initial support for DPDK 18.05"
Deepak S [Fri, 27 Jul 2018 16:13:49 +0000 (16:13 +0000)]
Merge "Initial support for DPDK 18.05"

5 years agoInitial support for DPDK 18.05 45/59545/3
Xavier Simonart [Wed, 4 Jul 2018 09:46:25 +0000 (11:46 +0200)]
Initial support for DPDK 18.05

This patch makes PROX compile with DPDK 18.05.
However some features are disabled or will not work as expected
such as:
"mem info" command
"police" mode
Those will need to be fixed later (see DPDK1805 within code).

Change-Id: Ie7d72f6ab3db68bc093c42d60d125fe86f8fbda7
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
Signed-off-by: Patrice Buriez <patrice.buriez@intel.com>
5 years agoFix potential crash with latency accuracy 93/59593/1
Patrice Buriez [Sat, 7 Jul 2018 12:03:32 +0000 (14:03 +0200)]
Fix potential crash with latency accuracy

Detect, remember and skip bad/unexpected packets:
- too short to hold the latency-related values
- with bad signature
- with invalid generator_id
using a uint64_t-based bitmap.

Also moved variable declarations closer to usage,
added some likely/unlikely hints,
reworked some return statements, and
fixed 32-bit overflow (every ~4s) of rx_time_err computation.

Change-Id: Ib2aadc1af6b7a68601cc080ba66b10d41ff9a64e
Signed-off-by: Patrice Buriez <patrice.buriez@intel.com>
5 years agoUpdating release notes for OPNFV Fraser 6.2 05/59305/1
Deepak S [Fri, 29 Jun 2018 12:24:06 +0000 (17:54 +0530)]
Updating release notes for OPNFV Fraser 6.2

Change-Id: I9a9da79cb4ccb245ddb38b50b561da51a40a359d
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
5 years agoMerge "TempFix: vCGNAPT/vACL ipv4 perf issue"
Deepak S [Fri, 29 Jun 2018 06:53:05 +0000 (06:53 +0000)]
Merge "TempFix: vCGNAPT/vACL ipv4 perf issue"

5 years agoMerge "Temp Fix for vFW perf issue"
Deepak S [Fri, 29 Jun 2018 06:53:01 +0000 (06:53 +0000)]
Merge "Temp Fix for vFW perf issue"

5 years agoAdding centos.json to be used with packer to generate a VM with PROX 13/58613/2
Luc Provoost [Fri, 15 Jun 2018 20:39:28 +0000 (22:39 +0200)]
Adding centos.json to be used with packer to generate a VM with PROX

Based on a CentOS cloud image downloadable from the web, you can now use
packer to create an image that has DPDK and PROX installed in the
proper directories. The VM is also tuned for guest VNFs.
A service is also created to deal with the proper isolated_cpu settings
for tuned. The service will also make sure uio and igb_uio are loaded.
The prox_user_data.sh is not needed any more and hence deleted.
ctrl-c of runrapid.py will now also stop prox in all the VMs so a new
test can be started.

Change-Id: I16cc59878e2d4912757f42e05f98d51dff5feb89
Signed-off-by: Luc Provoost <luc.provoost@intel.com>
5 years agoAdding support for Ubuntu 17.10... 47/58447/1
Deepak S [Tue, 12 Jun 2018 15:37:59 +0000 (21:07 +0530)]
Adding support for Ubuntu 17.10...

Change-Id: I9a9da79cb4ccb245ccb38b50b561da51a40a359d
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
5 years agoGet multiple port stats simultaneously 45/58345/1
Patrice Buriez [Thu, 7 Jun 2018 17:04:48 +0000 (19:04 +0200)]
Get multiple port stats simultaneously

JIRA: YARDSTICK-1220

Implemented new "multi port stats <port list>" command, which returns a
semi-colon-separated list of comma-separated values:
- port id
- total (at last_tsc) for rx_pkts, tx_pkts, no_mbufs, ierrors + imissed
- last_tsc

Change-Id: I8a8da79cb4ccb245ccb38b50b561da51a40a359d
Signed-off-by: Patrice Buriez <patrice.buriez@intel.com>
5 years agoTempFix: vCGNAPT/vACL ipv4 perf issue 25/58225/1
Deepak S [Tue, 5 Jun 2018 14:14:01 +0000 (19:44 +0530)]
TempFix: vCGNAPT/vACL ipv4 perf issue

Change-Id: I924fcac7a65c0d221d5d422f419deb9c0f864172
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
5 years agoTemp Fix for vFW perf issue 63/58163/1
Deepak S [Sat, 2 Jun 2018 22:06:25 +0000 (03:36 +0530)]
Temp Fix for vFW perf issue

Change-Id: I324fcac7a65c0d221d5d422f419deb9c0f864172
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
5 years agoUpdating release notes for OPNFV Farser 6.1 65/57865/1
Deepak S [Fri, 25 May 2018 09:14:36 +0000 (14:44 +0530)]
Updating release notes for OPNFV Farser 6.1

Change-Id: I333fcac7a65c0d221d5d422f419deb9c0f864172
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
5 years agoIncrease default mbuf size and code simplification/cleanup 09/56709/3
Xavier Simonart [Wed, 25 Apr 2018 23:03:05 +0000 (01:03 +0200)]
Increase default mbuf size and code simplification/cleanup

mbuf size was setup to achieve the best performance i.e.
using the smallest mbuf and not segmenting packets.
However this resulted in complex code, much dependent of the way
the pmd are working e.g. a change(fix) in recent dpdk i40e
implementation caused a 1782 (=1518+8+256) bytes mbuf to be too
small to hold a 1518 bytes packets.
Hence this change simplifies the mbuf size selection at the price
of a potential decreases in performance - as more memory is now used.
Except if jumbo frames are used, the mbuf size will now be the same
for all modes. The packets will not be segmented except if jumbo
frames are enabled.
If jumbo frames are enabled, packets are by default segmented, except
if the mbuf size is configured big enough in the config file.

Change-Id: I222fcac7a65c0d221d5d422f419deb9c0f864172
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
6 years agofix code standard in VNFs/DPPD-PROX/handle_esp.c 07/57407/1
Igor Shaula [Tue, 15 May 2018 15:47:45 +0000 (17:47 +0200)]
fix code standard in VNFs/DPPD-PROX/handle_esp.c

Change-Id: I6c1a8f6d8e3bc84f7eb8e5780cde98dd9c03c805
Signed-off-by: Igor Shaula <igor.shaula@intel.com>
6 years agoMerge "Update Fraser document..."
Deepak S [Thu, 26 Apr 2018 06:07:13 +0000 (06:07 +0000)]
Merge "Update Fraser document..."

6 years agoUpdate Fraser document... 99/56599/1
Deepak S [Thu, 26 Apr 2018 11:25:59 +0000 (16:55 +0530)]
Update Fraser document...

Change-Id: I4ed02be7ca899db4f8f97355c180a92d69d38d8f
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
6 years agoMerge "Fix crc offloads."
Deepak S [Thu, 26 Apr 2018 05:22:45 +0000 (05:22 +0000)]
Merge "Fix crc offloads."

6 years agoMerge "Add support for multiple variables in core definition"
Deepak S [Thu, 26 Apr 2018 03:51:47 +0000 (03:51 +0000)]
Merge "Add support for multiple variables in core definition"

6 years agoMerge "Fix memory leak introduced by 4a65cd84"
Deepak S [Thu, 26 Apr 2018 03:51:38 +0000 (03:51 +0000)]
Merge "Fix memory leak introduced by 4a65cd84"

6 years agoMerge "Support for dpdk-stable-17.11.1 crypto"
Deepak S [Thu, 26 Apr 2018 03:51:28 +0000 (03:51 +0000)]
Merge "Support for dpdk-stable-17.11.1 crypto"

6 years agoMerge "Add support for generation of jumbo frames"
Deepak S [Thu, 26 Apr 2018 03:51:17 +0000 (03:51 +0000)]
Merge "Add support for generation of jumbo frames"

6 years agoFix crc offloads. 53/56553/1
Xavier Simonart [Sun, 15 Apr 2018 13:35:07 +0000 (15:35 +0200)]
Fix crc offloads.

When configuring a port, prox configures queue flags.
For historitical reasons, offloads had to be disabled on
some pmds.
There is now an API to query the ports and gets their
capabilities. This fix sets now the flags based on the capabilities,
and not the driver name.

Change-Id: Ic72d15001992f26910f653c70d31e4381fff8089
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoSupport reading inline jumbo frame and dump them 51/56551/1
Xavier Simonart [Sun, 15 Apr 2018 13:14:01 +0000 (15:14 +0200)]
Support reading inline jumbo frame and dump them

Add support for pkt_inline of jumbo frames.
Dump the whole packet, and not a truncated packet. This might
have a small impact on performance as the memory footprint
is increased (by ~640K * number of tasks), resulting in potential
higher DTLB misses.

Change-Id: I4ed02be7ca899db4f8f97355c180a92d69d39d8f
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoAdd support for generation of jumbo frames 49/56549/1
Xavier Simonart [Sat, 14 Apr 2018 20:42:53 +0000 (22:42 +0200)]
Add support for generation of jumbo frames

Change-Id: I63af4e5c5c01a4412d517e33fc7111481fd0524a
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoSupport for dpdk-stable-17.11.1 crypto 53/56353/1
Igor Shaula [Tue, 24 Apr 2018 11:14:54 +0000 (13:14 +0200)]
Support for dpdk-stable-17.11.1 crypto

Change-Id: I1a4aee3d550d007046be9d1677dd0ad980cb9817
Signed-off-by: Igor Shaula <igor.shaula@intel.com>
6 years agoFix memory leak introduced by 4a65cd84 65/56265/2
Xavier Simonart [Mon, 23 Apr 2018 12:19:58 +0000 (14:19 +0200)]
Fix memory leak introduced by 4a65cd84

Change-Id: I937bb38baa51d1902793fa8720a3ea740a583473
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoAdd support for multiple variables in core definition 47/56247/1
Xavier Simonart [Mon, 23 Apr 2018 08:19:24 +0000 (10:19 +0200)]
Add support for multiple variables in core definition

In the [core] definition we were able to use one variable
such as $core1 in [core $core1] but not [core ${core1}].
The second syntax is used when we want multiple
variables such as in [core ${first_core}-${last_core}].
This second syntax is now supported.

Change-Id: Ic94b84cb8cf827acb6697789cd180f41c3bdb028
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoMerge "Add support for reception of jumbo frames"
Deepak S [Fri, 20 Apr 2018 05:28:26 +0000 (05:28 +0000)]
Merge "Add support for reception of jumbo frames"

6 years agoMerge "Support async operation in handle_esp"
Deepak S [Fri, 20 Apr 2018 05:28:11 +0000 (05:28 +0000)]
Merge "Support async operation in handle_esp"

6 years agoFix link speed when link is down at startup. 21/55421/4
Xavier Simonart [Wed, 11 Apr 2018 14:15:55 +0000 (16:15 +0200)]
Fix link speed when link is down at startup.

When link is down at startup, the link_speed returned by DPDK
is 0. This results in un-optimized latency estimates in gen and lat.
With this fix, lat and gen do nothing until link_speed is
properly initialized, and use the right link speed in the fast path.

Change-Id: Id2d14b6966ccfac7cc78db3c5a74e704b42edae7
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoSupport async operation in handle_esp 85/55785/2
Xavier Simonart [Mon, 16 Apr 2018 02:00:44 +0000 (04:00 +0200)]
Support async operation in handle_esp

Change-Id: Ibee77e31c0eb7a0e14e7aa0df092a278dfe75d6b
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoAdd support for reception of jumbo frames 87/55787/1
Xavier Simonart [Sat, 14 Apr 2018 15:19:41 +0000 (17:19 +0200)]
Add support for reception of jumbo frames

Jumbo frames are now supported through the addition of a "mtu"
parameter of the port in the config file.
Setting the mtu to a value higher than 1500 bytes will enable
the reception of jumbo frames.
In addition, the rte_eth_dev_set_mtu is now set for all pmds.
Finally, setting mbuf_size does not set MEMPOOL_F_NO_SPREAD
anymore. This option was only used for pure debugging.

Big packets can be received using two ways
- Using multiple "small" mbufs, i.e. around 2K. This is the default.
- Using one big mbuf holding the whole packet. This can be enabled
  by setting a parameter mbuf_size in the receiving core configuration

Change-Id: Idd60ad31f41c89f9522dff4d894af2696b7a2ea1
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoMerge "Added missing file: rapidVMs.vms"
Deepak S [Fri, 6 Apr 2018 04:59:40 +0000 (04:59 +0000)]
Merge "Added missing file: rapidVMs.vms"

6 years agoMerge "Add support for multiple GEN tasks running on the same core"
Deepak S [Fri, 6 Apr 2018 04:59:22 +0000 (04:59 +0000)]
Merge "Add support for multiple GEN tasks running on the same core"

6 years agoMerge "Add support for crypto on multiple cores"
Deepak S [Fri, 6 Apr 2018 04:58:54 +0000 (04:58 +0000)]
Merge "Add support for crypto on multiple cores"

6 years agoAdded missing file: rapidVMs.vms 95/54795/1
Luc Provoost [Tue, 3 Apr 2018 11:59:35 +0000 (13:59 +0200)]
Added missing file: rapidVMs.vms

This file describes flavors, flavor meta data and boot info.
All this info can be defined in the [Default] section and will then be
used by to create all VMs. This data can also be specified in individual
VM sections to overule the deault values per VM.

Change-Id: I9d59208360eacec2790e5c467d7afcbeba301251
Signed-off-by: Luc Provoost <luc.provoost@intel.com>
6 years agoSupport additional MAC format in config file 49/54649/1
Igor Shaula [Fri, 30 Mar 2018 12:25:08 +0000 (14:25 +0200)]
Support additional MAC format in config file

Add support for space-divided bytes in MAC string.
Support the same format as in "pkt inline".

Change-Id: I7f2136c4424c45ce4abad4082470c9c9b1b3ab05
Signed-off-by: Igor Shaula <igor.shaula@intel.com>
6 years agoAdd support for multiple GEN tasks running on the same core 47/54647/1
Igor Shaula [Fri, 30 Mar 2018 12:05:50 +0000 (14:05 +0200)]
Add support for multiple GEN tasks running on the same core

resolve memory allocation issue

Change-Id: I90bbf711a6a7a4869e5024c061470d9779839a60
Signed-off-by: Igor Shaula <igor.shaula@intel.com>
6 years agoAdd support for crypto on multiple cores 45/54645/1
Igor Shaula [Fri, 30 Mar 2018 11:45:00 +0000 (13:45 +0200)]
Add support for crypto on multiple cores

* Experimental, for dpdk-stable-17.05.2
* New improved ESP decapsulation function

Change-Id: If4862dacb3fcf53e21eb5932a195664f80c7c192
Signed-off-by: Igor Shaula <igor.shaula@intel.com>
6 years agoReplaced heat stack yaml files by individual server creation 11/54511/1
Luc Provoost [Tue, 27 Mar 2018 12:40:18 +0000 (14:40 +0200)]
Replaced heat stack yaml files by individual server creation

There is now a new file (rapidVMs.vms) describing how many VMs need
to be created. You can specify the same flavor values in the [DEFAULT]
section or specify specific flavors per VM.
The heat stack yaml files are removed.

Change-Id: Ic5ec485e8344a35e9ac9f6e8347adbc70520d10a
Signed-off-by: Luc Provoost <luc.provoost@intel.com>
6 years agoTrivial: fix trailing white-spaces 07/54407/1
Patrice Buriez [Fri, 23 Mar 2018 17:20:00 +0000 (18:20 +0100)]
Trivial: fix trailing white-spaces

Makefile checks for some coding style rules.
Previous commit introduced trailing white-spaces, which broke
compilation.

Change-Id: Ia57fc9b1428b4a9f8537dce4875e62ac55265fe3
Signed-off-by: Patrice Buriez <patrice.buriez@intel.com>
6 years agoMerge "Fix potential crash if link speed is null"
Deepak S [Fri, 16 Mar 2018 04:19:03 +0000 (04:19 +0000)]
Merge "Fix potential crash if link speed is null"

6 years agoMerge "Fix minimum latency"
Deepak S [Fri, 16 Mar 2018 04:18:54 +0000 (04:18 +0000)]
Merge "Fix minimum latency"

6 years agoAdding Farser preliminary documentation 29/53929/1
Deepak S [Fri, 16 Mar 2018 09:35:37 +0000 (15:05 +0530)]
Adding Farser  preliminary documentation

Change-Id: I3bbd7897deb6e452068c07ef68d395affa4a4b50
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
6 years agoFix minimum latency 85/52785/2
Xavier Simonart [Tue, 27 Feb 2018 22:59:52 +0000 (23:59 +0100)]
Fix minimum latency

Revert back part of commit 9fa316261d7d9
The function abs_diff was erroneously changed to diff_or_zero.
This function was supposed to measure the difference between rx and
tx time; when rx time overflowed and tx time not yet (i.e.
rx time ~= 0 and tx_time ~=UINT32_MAX, this function added UINT32_MAX
to rx_time. The name of the function was confusing and caused the
previous commit. Net effect of previous commit was that every four seconds
the minimum latency was 0
This commit reverse back to the original behavior, with a function name
diff_time.

Change-Id: Ia1b80e48a756cf5df411dcf58ca1cbc835214d13
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoFix potential crash if link speed is null 81/52781/1
Xavier Simonart [Tue, 27 Feb 2018 22:44:51 +0000 (23:44 +0100)]
Fix potential crash if link speed is null

Link_speed could be null when prox started with the ports down.
This was potentially causing a crash.
Another task will need to update link speed when the port come
up. Failing to do this results in less accurate latencies
(no extrapolation)

Change-Id: I597b68e30117e6edb9ccb4732c2acedd5eb8ac80
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoMerge "Fixed the calculation of dropped packets and other changes"
Deepak S [Thu, 22 Feb 2018 14:48:39 +0000 (14:48 +0000)]
Merge "Fixed the calculation of dropped packets and other changes"

6 years agoMerge "Add support for comments in configuration variables"
Deepak S [Thu, 22 Feb 2018 14:48:27 +0000 (14:48 +0000)]
Merge "Add support for comments in configuration variables"

6 years agoMerge "Fix latency accuracy and dumping latencies to file"
Deepak S [Thu, 22 Feb 2018 14:48:19 +0000 (14:48 +0000)]
Merge "Fix latency accuracy and dumping latencies to file"

6 years agoFixed the calculation of dropped packets and other changes 23/52423/1
Luc Provoost [Wed, 21 Feb 2018 20:03:38 +0000 (21:03 +0100)]
Fixed the calculation of dropped packets and other changes

* Calculation of aboslute and relative dropped packets was wrong and is
now fixed.
* ./createrapid.py has now an extra option to select custom availability
zones for the different VMs.
* Fixed a typo to create the flavor: hw:cpu_thread_policy
* The generator config files have now the packet id & signature fields.
See PROX for more details on this.
* ./runrapid has now a new option --configonly. Default is False. If set
to True, all configuration files will be copied to the VMS, but the
tests are not started. This allows you to go to the VMs and manually
start PROX.
* In addition to the average latency, maximum latency is now also
displayed.

Change-Id: I3bbd7897deb6e452068c07ef68d3959ffa4a4b50
Signed-off-by: Luc Provoost <luc.provoost@intel.com>
6 years agoFix latency accuracy and dumping latencies to file 31/51131/3
Xavier Simonart [Sat, 13 Jan 2018 20:28:14 +0000 (21:28 +0100)]
Fix latency accuracy and dumping latencies to file

- Also changed lat_info.tx_packet_index to uint64_t,
  so also did it for task_lat.prev_tx_packet_index and n_loss.
- Adjusted format strings accordingly, and fixed some other formats.
- Adjusted overflow increment to 2^32 (i.e. UINT32_MAX + 1).
- Replaced hard-coded 64 with ACCURACY_BUFFER_SIZE (still hard-coded
  in handle_gen.c).

Change-Id: Ia59f36e17c0797a2a958dbe3b2ac420263473524
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
Signed-off-by: Patrice Buriez <patrice.buriez@intel.com>
6 years agoAdd support for comments in configuration variables 95/52195/1
Xavier Simonart [Thu, 15 Feb 2018 14:45:04 +0000 (15:45 +0100)]
Add support for comments in configuration variables

This feature will enable the possibility to have many cores
configured in a prox config file, and enable/disable them
through variables.
For instance, a [core $var1] section in a config file will
result in [core 1] if $var1 = 1; the whole section and section
content will be ignored if $var1=#
Before this implementation, [#core 1] or [core #] was already
treated as a commented out section (the whole section was
commented). But there was no way to define a variable $var = #
to comment a section through a variable.

Note that in today's implementation any non numerical
(except s, h, t, -) characteter in the [core] section header
(and not only #) will cause the section to be ignored.
It would probably be better to consider # (as maybe N/A and none)
as comments, and everything else as error. This is however not
supported by the change request.

Change-Id: Id4e2b27a1f9b6d595e0b442dcd971ad44a502031
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoMerge "Auto Generated INFO.yaml file"
Deepak S [Thu, 15 Feb 2018 10:03:19 +0000 (10:03 +0000)]
Merge "Auto Generated INFO.yaml file"

6 years agoMerge "Fix potential crash in rx and tx distribution"
Deepak S [Thu, 15 Feb 2018 10:00:55 +0000 (10:00 +0000)]
Merge "Fix potential crash in rx and tx distribution"

6 years agoFix potential crash in rx and tx distribution 25/51125/2
Xavier Simonart [Sat, 13 Jan 2018 20:44:49 +0000 (21:44 +0100)]
Fix potential crash in rx and tx distribution

In some (rare) modes, more than 64 packets can be received through
one rx function. This is for instance the case of the lat mode.

Change-Id: Ie733c927a8e116c679c464f2551768185ef85366
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoZero packet loss testing has been added. 37/52037/1
Luc Provoost [Mon, 12 Feb 2018 10:32:35 +0000 (11:32 +0100)]
Zero packet loss testing has been added.

Using l2 testing, where no ARP messages are being used, you can now run
a zero packet loss test. The binary search will continue to find the
speed where absolutely no packets have been lost during the test.
On top of that, the output has been reformatted to also show the
absolute and relative packet loss.
The *.test files have now 2 new parameters: drop_rate_treshold and accuracy.
When drop_rate_treshold is set to 0, this test will conclude successfull
when no packet has been lost whatsoever. If this is set to any other
number, the test will be successfull when the relative packet loss is
lower than drop_rate_treshold.
The new accuray parameter defines when the binary search will stop:
when the relative difference between the min and max of the search
window is lower than accuracy.
The irq testing is slightly modified to print the total number of
interrupts in a certain time bucket, not only as the number per second,
but when there is no interrupt whatsowever, we print '0' in stead of
'0.0'

Change-Id: I8fafded0a225cbe1ba7ac61cd28e94d72099e4a0
Signed-off-by: Luc Provoost <luc.provoost@intel.com>
6 years agoAuto Generated INFO.yaml file 03/51703/1
agardner [Mon, 5 Feb 2018 19:25:04 +0000 (14:25 -0500)]
Auto Generated INFO.yaml file

INFO.yaml meant to be machine readable.
This file was auto generated from an ldap lookup
and your projects INFO file.

Meeting times are not currently filled out.
please ammend this patchset to complete

Going forward comitter promotions should be done
against this file.

PTLs:
Must be merged for you to gain delete access on
testresults.opnfv.org

If project_lead: is missing (my script could not parse)
please amend with same from commiters section eg:

project_lead: &opnfv_$project_ptl
    name: 'Lead Name'
    email: 'lead email'
    id: 'lead lfid'
    company: 'lead company'

Change-Id: Ib034d62db7138a9f7c66c4d3377d6681764c41b4
Signed-off-by: agardner <agardner@linuxfoundation.org>
6 years agoFixed issues with the pkt_size command 23/51623/2
Luc Provoost [Sat, 3 Feb 2018 21:47:55 +0000 (22:47 +0100)]
Fixed issues with the pkt_size command

Fixed issues with pkt_size. For a 64 byte packet, we need to issue
pkt_size <core> <task> 60
4 extra bytes will be calculated and added automatically by PROX
Also added the missing irq.test and irq.cfg files
Added support for OpenStack systems not using floating IP addresses

Change-Id: I05d775eb858a58dd349ea370a0e34ac6448590c9
Signed-off-by: Luc Provoost <luc.provoost@intel.com>
6 years agoRework of the test cases in the *.test files 03/51303/2
Provoost [Mon, 29 Jan 2018 12:01:07 +0000 (13:01 +0100)]
Rework of the test cases in the *.test files
Cores can now be specified in the test files. An irq test has been
added to verify if the VMs are not suffering from long interrupts.

Change-Id: I647fda3ebf76c7c2b36a8df9a63d9fb83563c249
Signed-off-by: Provoost <luc.provoost@intel.com>
6 years agoMerge "Fix dumping receive packets"
Deepak S [Thu, 25 Jan 2018 14:50:52 +0000 (14:50 +0000)]
Merge "Fix dumping receive packets"

6 years agoMerge "Integrate irq mode into PROX (support display and command line)"
Deepak S [Thu, 25 Jan 2018 14:50:45 +0000 (14:50 +0000)]
Merge "Integrate irq mode into PROX (support display and command line)"

6 years agoFix extrapolation used in latency measurements 05/50705/2
Xavier Simonart [Mon, 8 Jan 2018 10:21:44 +0000 (11:21 +0100)]
Fix extrapolation used in latency measurements

When doing latency measurements PROX takes into account the
generation or reception of a bulk of packets. For instance, if
PROX receives at time T 4 packets, it knows that the first
packet was received by te NIC before T (the time to receive the other
3 packets, as they were received at maximum link speed).
So the latency data is decreased by the minimum time to receive those
3 packets.
For this PROX was using a default link speed of 10Gbps. This is wrong
for 1Gbps and 40Gbps networks, and was causing for instance issues
on 40 Gbps networks as extrapolating too much, resulting in either
too low latencies or negative numbers (visible as very high latencies).

Change-Id: I4e0f02e8383dd8d168ac50ecae37a05510ad08bc
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoIntegrate irq mode into PROX (support display and command line) 09/50709/1
Xavier Simonart [Sun, 14 Jan 2018 17:13:09 +0000 (18:13 +0100)]
Integrate irq mode into PROX (support display and command line)

irq mode can be used to show how a core is interrupted by other tasks.
This mode does not handle packets. It only loops reading tsc.
When the difference between two consecutive calls to rdtsc() is high
then it means the core was interrupted.
This task implementes the display, so that we can see a histogram of
interrupts as well as the maximum, per core.
Command line is also supported, through "show irq buckets" (too show
the intervals of each buckets, in micrcoseconds), and the stats
command line (showing the number of items in each buckets and the max)..

Change-Id: I153cc3deaa7b86ae2776ea44e46ef9ecfd116992
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoFix dumping receive packets 07/50707/1
Xavier Simonart [Mon, 8 Jan 2018 11:32:23 +0000 (12:32 +0100)]
Fix dumping receive packets

There were two issues identified in dump receive packets
- when the receive packets was going to be dropped (and not transmitted),
  it was also printed as TX[255].
- a potential crash when using the dump function with modes like
  lat which can receive more than MAX_RING_BURST.
Those issues have been fixed.

Change-Id: Ia2297539d64961a211389d68e3c9c6280472243c
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoMerge "Add support for DPDK 17.11"
Deepak S [Tue, 16 Jan 2018 12:51:27 +0000 (12:51 +0000)]
Merge "Add support for DPDK 17.11"

6 years agoMerge "Add config option to use port mac as src mac in l2fwd and swap"
Deepak S [Tue, 16 Jan 2018 12:51:25 +0000 (12:51 +0000)]
Merge "Add config option to use port mac as src mac in l2fwd and swap"

6 years agoMerge "Fix using signature in latency measurements"
Deepak S [Tue, 16 Jan 2018 12:51:22 +0000 (12:51 +0000)]
Merge "Fix using signature in latency measurements"

6 years agoMerge "Fix stacking of rx receive functions"
Deepak S [Tue, 16 Jan 2018 12:51:20 +0000 (12:51 +0000)]
Merge "Fix stacking of rx receive functions"

6 years agoMerge "Fix potential crash when issuing "tx distr stop" command."
Deepak S [Tue, 16 Jan 2018 12:51:17 +0000 (12:51 +0000)]
Merge "Fix potential crash when issuing "tx distr stop" command."

6 years agoFix using signature in latency measurements 27/50227/1
Xavier Simonart [Mon, 8 Jan 2018 11:10:41 +0000 (12:10 +0100)]
Fix using signature in latency measurements

When doing latency measurements the generator can add a
32 bits signature in the packet at a specific location,
so that the receiver only uses the packets generated by the
generator and ignores packets generated for instance by a switch
The is particuly important for latency measurements as we use
data in the packets as timestamps, and packets generated elsewhere
would result in random latency for those packets.

Change-Id: I8352b35aff76ec8d1344a1e492b9dcc20a53f1ce
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoFix stacking of rx receive functions 17/50217/1
Xavier Simonart [Mon, 8 Jan 2018 09:58:14 +0000 (10:58 +0100)]
Fix stacking of rx receive functions

PROX can stack different RX functions, so that they are executed
after each other.
This feature is for instance used to dump packets or to print
distribution of receive packets, without influencing the performance
of the rx functions when no dump or print is needed.
The previous implementation was wrong and causing some of the stacked
functions not to be executed. This was causing for instance issues
in latency measurement after enabling dumping packets.

Change-Id: I766b8ee8e8852fa17cdaf60ee6e1fec0dc98c719
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoMerge "Initialize fields of outer IP header"
Deepak S [Fri, 5 Jan 2018 04:48:07 +0000 (04:48 +0000)]
Merge "Initialize fields of outer IP header"

6 years agoFix potential crash when issuing "tx distr stop" command. 47/50047/1
Xavier Simonart [Thu, 4 Jan 2018 15:29:04 +0000 (16:29 +0100)]
Fix potential crash when issuing "tx distr stop" command.

Change-Id: I9ef89020d203674f6c3301653ab2ff9d623665b6
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoAdd config option to use port mac as src mac in l2fwd and swap 41/48641/2
Xavier Simonart [Mon, 11 Dec 2017 12:15:58 +0000 (13:15 +0100)]
Add config option to use port mac as src mac in l2fwd and swap

L2fwd and swap has many options to set src mac. swap was supposed
to support the ability to use port mac, but config file parsing was
wrong. L2fwd was using port mac if a port was available and if
src mac=packet or if there was no src mac in the config.

Now l2fwd supports the following options
- "src mac=xx:xx:xx:xx:xx:xx" => this mac address is used as src mac.
- "src mac=packet" => the src mac is taken from the dst mac of the
received packet.
- "src mac=hw" => the src mac is taken from the mac address of the port,
if there is a physical port. Error otherwise.
- "src mac=no" => src mac kept untouched
- No "src mac" => same as "src mac=hw" if there is a physical port
              and same as "src mac=packet" otherwise.

Default is (no "src mac") hence the mac is taken from the tx port if there
              is one tx port and from the packet otherwise.

swap support is similar, except that it does not support "src mac=no".

Change-Id: I70fe49a61c2e85772288b769ede14a7a6205d122
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoAdd support for DPDK 17.11 41/50041/1
Xavier Simonart [Thu, 4 Jan 2018 13:35:57 +0000 (14:35 +0100)]
Add support for DPDK 17.11

Change-Id: I5611ead4b61b23d6c1c983852e8c75619e08ecf9
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoInitialize fields of outer IP header 47/49147/2
Xavier Simonart [Sun, 17 Dec 2017 16:19:07 +0000 (17:19 +0100)]
Initialize fields of outer IP header

As it was non being initialized, fragment offset was sometimes non null.
prox_ip_cksum_sw (as well as prox_ip_cksum_hw) require the hdr_checksum
field to be initialized to 0.

Change-Id: I3824682023782edb555982e558e5ae68062c3c9b
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoMerge "Adding Security gateway testing"
Deepak S [Tue, 19 Dec 2017 05:34:56 +0000 (05:34 +0000)]
Merge "Adding Security gateway testing"

6 years agoMerge "Add l3 support for tasks without physical tx ports"
Deepak S [Tue, 19 Dec 2017 05:34:54 +0000 (05:34 +0000)]
Merge "Add l3 support for tasks without physical tx ports"

6 years agoAdd support for multiple tasks generating to same ip in l3 mode. 49/49149/2
Xavier Simonart [Sun, 17 Dec 2017 17:43:56 +0000 (18:43 +0100)]
Add support for multiple tasks generating to same ip in l3 mode.

When multiple tasks generate to the same ip in l3 mode (i.e. with arp
support), all those tasks generate arp requests. we need to make sure
that they all receive a arp-reply i.e. that the master broadcast
the reply to all those cores.

Change-Id: I7e89196497a1016a94dde167f212b1f6ed03bcfe
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoAdd l3 support for tasks without physical tx ports 45/49145/2
Xavier Simonart [Sun, 17 Dec 2017 15:46:52 +0000 (16:46 +0100)]
Add l3 support for tasks without physical tx ports

This adds support for tasks in l3 submode receiving from ports but
transmitting to rings.

ARP related information is exchanged between tasks through master core.
Tasks transmitting to physical ports are responsible to transmit arp
related packets. Tasks not transmitting to physical ports (and using
rings) should not try to transmit arp packets. Transmitting arp
packets through ring would be more complex, as we would need extra information
(within the mbuf) to distinguish for instance an arp reply comoing from the
network and an arp reply coming from a core (as a reply to an arp request).

Change-Id: Ib55dc8c39d5e55703a933faa16bcc008f1274929
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoAdding Security gateway testing 89/49089/2
Provoost [Fri, 15 Dec 2017 17:33:59 +0000 (18:33 +0100)]
Adding Security gateway testing

Using now .test files describing the test to be executed.
Also desribed in the README file how to deal with SRIOV ports.

Change-Id: I3eb1551d7f205fef3fa1914bc6959c2126d63425
Signed-off-by: Provoost <luc.provoost@intel.com>
6 years agoUpdating release notes for OPNFV Euphrates 5.1 31/49031/1 opnfv-5.1.0 opnfv-5.1.RC1
Deepak S [Thu, 14 Dec 2017 20:52:18 +0000 (12:52 -0800)]
Updating release notes for OPNFV Euphrates 5.1

Change-Id: I01a619de621a3dfbfe11cabef257f9dec311e318
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
6 years agoMerge "Fix command parser"
Deepak S [Fri, 8 Dec 2017 03:39:59 +0000 (03:39 +0000)]
Merge "Fix command parser"

6 years agoMerge "Fix checks done when changing generator pkt_size"
Deepak S [Fri, 8 Dec 2017 03:39:49 +0000 (03:39 +0000)]
Merge "Fix checks done when changing generator pkt_size"

6 years agoFix qos statistics 77/48477/1
Xavier Simonart [Wed, 6 Dec 2017 17:09:19 +0000 (18:09 +0100)]
Fix qos statistics

Packets dropped by QoS (because queues were full) were erroneously
shown as idle cycles. There aee now shown as discarded packets.

Change-Id: I01a619de621a3dfbfe11cabef257f9dec311e208
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoFix checks done when changing generator pkt_size 71/48471/1
Xavier Simonart [Wed, 6 Dec 2017 15:54:05 +0000 (16:54 +0100)]
Fix checks done when changing generator pkt_size

Different checks were done when setting the generator pkt_size.
In case of wrong pkt_size (e.g. too big) an error was printed but
the pkt_size was still set causing a potential corruption.
In addition, in case of a packet size incompatible with some
of the packet fields (e.g. latency data) PROX was panicing
while this should not happen runtime for such an error.

Change-Id: Ifa11475bf295aaac7b0255c1bf9b5feed8ef90c4
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
6 years agoFix command parser 59/48459/1
Xavier Simonart [Wed, 6 Dec 2017 15:18:05 +0000 (16:18 +0100)]
Fix command parser

Command parser could have been crashing if a wrong core/task was
used in pkt_size command. For some other commands both an error
and a warning were printed in case of errors.

Change-Id: I6648bfca1b5bcde3c6393d49687ed84900326d49
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>