From 738df5b97312bb61617669250ce67073108de070 Mon Sep 17 00:00:00 2001 From: Liang Li Date: Thu, 24 Sep 2015 08:56:12 +0800 Subject: [PATCH] migration: do cleanup operation after completion Because of the patch 3ea3b7fa9af067982f34b of kvm, now the migration_end() is a time consuming operation, which takes about dozens of milliseconds, and will prolong VM downtime. Such an operation should be done after migration completion. For a VM with 8G RAM, this patch can reduce the VM downtime about 32 ms during live migration. Change-Id: Iddd10bd5a2b1bf52cce36253f303fc458da343cd Signed-off-by: Liang Li --- qemu/migration/block.c | 1 - qemu/migration/migration.c | 14 +++++++------- qemu/migration/ram.c | 1 - 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/qemu/migration/block.c b/qemu/migration/block.c index ed865ed23..85496fd80 100644 --- a/qemu/migration/block.c +++ b/qemu/migration/block.c @@ -750,7 +750,6 @@ static int block_save_complete(QEMUFile *f, void *opaque) qemu_put_be64(f, BLK_MIG_FLAG_EOS); - blk_mig_cleanup(); return 0; } diff --git a/qemu/migration/migration.c b/qemu/migration/migration.c index 662e77e4e..4ddb9adce 100644 --- a/qemu/migration/migration.c +++ b/qemu/migration/migration.c @@ -560,12 +560,9 @@ static void migrate_fd_cleanup(void *opaque) assert(s->state != MIGRATION_STATUS_ACTIVE); - if (s->state != MIGRATION_STATUS_COMPLETED) { - qemu_savevm_state_cancel(); - if (s->state == MIGRATION_STATUS_CANCELLING) { - migrate_set_state(s, MIGRATION_STATUS_CANCELLING, - MIGRATION_STATUS_CANCELLED); - } + if (s->state == MIGRATION_STATUS_CANCELLING) { + migrate_set_state(s, MIGRATION_STATUS_CANCELLING, + MIGRATION_STATUS_CANCELLED); } notifier_list_notify(&migration_state_notifiers, s); @@ -923,6 +920,7 @@ static void *migration_thread(void *opaque) int64_t initial_bytes = 0; int64_t max_size = 0; int64_t start_time = initial_time; + int64_t end_time; bool old_vm_running = false; rcu_register_thread(); @@ -1007,9 +1005,11 @@ static void *migration_thread(void *opaque) } } + end_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); + qemu_mutex_lock_iothread(); + qemu_savevm_state_cancel(); if (s->state == MIGRATION_STATUS_COMPLETED) { - int64_t end_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); uint64_t transferred_bytes = qemu_ftell(s->file); s->total_time = end_time - s->total_time; s->downtime = end_time - start_time; diff --git a/qemu/migration/ram.c b/qemu/migration/ram.c index 7f007e643..6249f6e60 100644 --- a/qemu/migration/ram.c +++ b/qemu/migration/ram.c @@ -1269,7 +1269,6 @@ static int ram_save_complete(QEMUFile *f, void *opaque) rcu_read_unlock(); - migration_end(); qemu_put_be64(f, RAM_SAVE_FLAG_EOS); return 0; -- 2.16.6