These changes are the raw update to linux-4.4.6-rt14. Kernel sources
[kvmfornfv.git] / kernel / net / batman-adv / bat_iv_ogm.c
index 00e00e0..912d9c3 100644 (file)
@@ -1,4 +1,4 @@
-/* Copyright (C) 2007-2014 B.A.T.M.A.N. contributors:
+/* Copyright (C) 2007-2015 B.A.T.M.A.N. contributors:
  *
  * Marek Lindner, Simon Wunderlich
  *
  * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
+#include "bat_algo.h"
 #include "main.h"
-#include "translation-table.h"
+
+#include <linux/atomic.h>
+#include <linux/bitmap.h>
+#include <linux/bitops.h>
+#include <linux/bug.h>
+#include <linux/byteorder/generic.h>
+#include <linux/cache.h>
+#include <linux/errno.h>
+#include <linux/etherdevice.h>
+#include <linux/fs.h>
+#include <linux/if_ether.h>
+#include <linux/init.h>
+#include <linux/jiffies.h>
+#include <linux/list.h>
+#include <linux/netdevice.h>
+#include <linux/pkt_sched.h>
+#include <linux/printk.h>
+#include <linux/random.h>
+#include <linux/rculist.h>
+#include <linux/rcupdate.h>
+#include <linux/seq_file.h>
+#include <linux/skbuff.h>
+#include <linux/slab.h>
+#include <linux/spinlock.h>
+#include <linux/stddef.h>
+#include <linux/string.h>
+#include <linux/types.h>
+#include <linux/workqueue.h>
+
+#include "bitarray.h"
+#include "hard-interface.h"
+#include "hash.h"
+#include "network-coding.h"
 #include "originator.h"
+#include "packet.h"
 #include "routing.h"
-#include "gateway_common.h"
-#include "gateway_client.h"
-#include "hard-interface.h"
 #include "send.h"
-#include "bat_algo.h"
-#include "network-coding.h"
+#include "translation-table.h"
 
 /**
  * enum batadv_dup_status - duplicate status
- * @BATADV_NO_DUP: the packet is a duplicate
+ * @BATADV_NO_DUP: the packet is no duplicate
  * @BATADV_ORIG_DUP: OGM is a duplicate in the originator (but not for the
  *  neighbor)
  * @BATADV_NEIGH_DUP: OGM is a duplicate for the neighbor
@@ -47,24 +77,25 @@ enum batadv_dup_status {
  * @lq_index: index to store the value at
  * @value: value to store in the ring buffer
  */
-static void batadv_ring_buffer_set(uint8_t lq_recv[], uint8_t *lq_index,
-                                  uint8_t value)
+static void batadv_ring_buffer_set(u8 lq_recv[], u8 *lq_index, u8 value)
 {
        lq_recv[*lq_index] = value;
        *lq_index = (*lq_index + 1) % BATADV_TQ_GLOBAL_WINDOW_SIZE;
 }
 
 /**
- * batadv_ring_buffer_set - compute the average of all non-zero values stored
+ * batadv_ring_buffer_avg - compute the average of all non-zero values stored
  * in the given ring buffer
  * @lq_recv: pointer to the ring buffer
  *
  * Returns computed average value.
  */
-static uint8_t batadv_ring_buffer_avg(const uint8_t lq_recv[])
+static u8 batadv_ring_buffer_avg(const u8 lq_recv[])
 {
-       const uint8_t *ptr;
-       uint16_t count = 0, i = 0, sum = 0;
+       const u8 *ptr;
+       u16 count = 0;
+       u16 i = 0;
+       u16 sum = 0;
 
        ptr = lq_recv;
 
@@ -81,7 +112,7 @@ static uint8_t batadv_ring_buffer_avg(const uint8_t lq_recv[])
        if (count == 0)
                return 0;
 
-       return (uint8_t)(sum / count);
+       return (u8)(sum / count);
 }
 
 /**
@@ -123,14 +154,14 @@ static int batadv_iv_ogm_orig_add_if(struct batadv_orig_node *orig_node,
        kfree(orig_node->bat_iv.bcast_own);
        orig_node->bat_iv.bcast_own = data_ptr;
 
-       data_ptr = kmalloc_array(max_if_num, sizeof(uint8_t), GFP_ATOMIC);
+       data_ptr = kmalloc_array(max_if_num, sizeof(u8), GFP_ATOMIC);
        if (!data_ptr) {
                kfree(orig_node->bat_iv.bcast_own);
                goto unlock;
        }
 
        memcpy(data_ptr, orig_node->bat_iv.bcast_own_sum,
-              (max_if_num - 1) * sizeof(uint8_t));
+              (max_if_num - 1) * sizeof(u8));
        kfree(orig_node->bat_iv.bcast_own_sum);
        orig_node->bat_iv.bcast_own_sum = data_ptr;
 
@@ -183,19 +214,19 @@ free_bcast_own:
        if (max_if_num == 0)
                goto free_own_sum;
 
-       data_ptr = kmalloc_array(max_if_num, sizeof(uint8_t), GFP_ATOMIC);
+       data_ptr = kmalloc_array(max_if_num, sizeof(u8), GFP_ATOMIC);
        if (!data_ptr) {
                kfree(orig_node->bat_iv.bcast_own);
                goto unlock;
        }
 
        memcpy(data_ptr, orig_node->bat_iv.bcast_own_sum,
-              del_if_num * sizeof(uint8_t));
+              del_if_num * sizeof(u8));
 
-       if_offset = (del_if_num + 1) * sizeof(uint8_t);
-       memcpy((char *)data_ptr + del_if_num * sizeof(uint8_t),
+       if_offset = (del_if_num + 1) * sizeof(u8);
+       memcpy((char *)data_ptr + del_if_num * sizeof(u8),
               orig_node->bat_iv.bcast_own_sum + if_offset,
-              (max_if_num - del_if_num) * sizeof(uint8_t));
+              (max_if_num - del_if_num) * sizeof(u8));
 
 free_own_sum:
        kfree(orig_node->bat_iv.bcast_own_sum);
@@ -218,7 +249,7 @@ unlock:
  * If the object does not exists it is created an initialised.
  */
 static struct batadv_orig_node *
-batadv_iv_ogm_orig_get(struct batadv_priv *bat_priv, const uint8_t *addr)
+batadv_iv_ogm_orig_get(struct batadv_priv *bat_priv, const u8 *addr)
 {
        struct batadv_orig_node *orig_node;
        int size, hash_added;
@@ -238,7 +269,7 @@ batadv_iv_ogm_orig_get(struct batadv_priv *bat_priv, const uint8_t *addr)
        if (!orig_node->bat_iv.bcast_own)
                goto free_orig_node;
 
-       size = bat_priv->num_ifaces * sizeof(uint8_t);
+       size = bat_priv->num_ifaces * sizeof(u8);
        orig_node->bat_iv.bcast_own_sum = kzalloc(size, GFP_ATOMIC);
        if (!orig_node->bat_iv.bcast_own_sum)
                goto free_orig_node;
@@ -261,43 +292,17 @@ free_orig_node:
 
 static struct batadv_neigh_node *
 batadv_iv_ogm_neigh_new(struct batadv_hard_iface *hard_iface,
-                       const uint8_t *neigh_addr,
+                       const u8 *neigh_addr,
                        struct batadv_orig_node *orig_node,
                        struct batadv_orig_node *orig_neigh)
 {
-       struct batadv_priv *bat_priv = netdev_priv(hard_iface->soft_iface);
-       struct batadv_neigh_node *neigh_node, *tmp_neigh_node;
+       struct batadv_neigh_node *neigh_node;
 
-       neigh_node = batadv_neigh_node_new(hard_iface, neigh_addr, orig_node);
+       neigh_node = batadv_neigh_node_new(orig_node, hard_iface, neigh_addr);
        if (!neigh_node)
                goto out;
 
-       if (!atomic_inc_not_zero(&hard_iface->refcount)) {
-               kfree(neigh_node);
-               neigh_node = NULL;
-               goto out;
-       }
-
        neigh_node->orig_node = orig_neigh;
-       neigh_node->if_incoming = hard_iface;
-
-       spin_lock_bh(&orig_node->neigh_list_lock);
-       tmp_neigh_node = batadv_neigh_node_get(orig_node, hard_iface,
-                                              neigh_addr);
-       if (!tmp_neigh_node) {
-               hlist_add_head_rcu(&neigh_node->list, &orig_node->neigh_list);
-       } else {
-               kfree(neigh_node);
-               batadv_hardif_free_ref(hard_iface);
-               neigh_node = tmp_neigh_node;
-       }
-       spin_unlock_bh(&orig_node->neigh_list_lock);
-
-       if (!tmp_neigh_node)
-               batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
-                          "Creating new neighbor %pM for orig_node %pM on interface %s\n",
-                          neigh_addr, orig_node->orig,
-                          hard_iface->net_dev->name);
 
 out:
        return neigh_node;
@@ -307,8 +312,7 @@ static int batadv_iv_ogm_iface_enable(struct batadv_hard_iface *hard_iface)
 {
        struct batadv_ogm_packet *batadv_ogm_packet;
        unsigned char *ogm_buff;
-       uint32_t random_seqno;
-       int res = -ENOMEM;
+       u32 random_seqno;
 
        /* randomize initial seqno to avoid collision */
        get_random_bytes(&random_seqno, sizeof(random_seqno));
@@ -317,7 +321,7 @@ static int batadv_iv_ogm_iface_enable(struct batadv_hard_iface *hard_iface)
        hard_iface->bat_iv.ogm_buff_len = BATADV_OGM_HLEN;
        ogm_buff = kmalloc(hard_iface->bat_iv.ogm_buff_len, GFP_ATOMIC);
        if (!ogm_buff)
-               goto out;
+               return -ENOMEM;
 
        hard_iface->bat_iv.ogm_buff = ogm_buff;
 
@@ -329,10 +333,7 @@ static int batadv_iv_ogm_iface_enable(struct batadv_hard_iface *hard_iface)
        batadv_ogm_packet->reserved = 0;
        batadv_ogm_packet->tq = BATADV_TQ_MAX_VALUE;
 
-       res = 0;
-
-out:
-       return res;
+       return 0;
 }
 
 static void batadv_iv_ogm_iface_disable(struct batadv_hard_iface *hard_iface)
@@ -383,8 +384,7 @@ static unsigned long batadv_iv_ogm_fwd_send_time(void)
 }
 
 /* apply hop penalty for a normal link */
-static uint8_t batadv_hop_penalty(uint8_t tq,
-                                 const struct batadv_priv *bat_priv)
+static u8 batadv_hop_penalty(u8 tq, const struct batadv_priv *bat_priv)
 {
        int hop_penalty = atomic_read(&bat_priv->hop_penalty);
        int new_tq;
@@ -396,8 +396,8 @@ static uint8_t batadv_hop_penalty(uint8_t tq,
 }
 
 /* is there another aggregated packet here? */
-static int batadv_iv_ogm_aggr_packet(int buff_pos, int packet_len,
-                                    __be16 tvlv_len)
+static bool batadv_iv_ogm_aggr_packet(int buff_pos, int packet_len,
+                                     __be16 tvlv_len)
 {
        int next_buff_pos = 0;
 
@@ -413,12 +413,12 @@ static void batadv_iv_ogm_send_to_if(struct batadv_forw_packet *forw_packet,
                                     struct batadv_hard_iface *hard_iface)
 {
        struct batadv_priv *bat_priv = netdev_priv(hard_iface->soft_iface);
-       char *fwd_str;
-       uint8_t packet_num;
-       int16_t buff_pos;
+       const char *fwd_str;
+       u8 packet_num;
+       s16 buff_pos;
        struct batadv_ogm_packet *batadv_ogm_packet;
        struct sk_buff *skb;
-       uint8_t *packet_pos;
+       u8 *packet_pos;
 
        if (hard_iface->if_status != BATADV_IF_ACTIVE)
                return;
@@ -451,7 +451,7 @@ static void batadv_iv_ogm_send_to_if(struct batadv_forw_packet *forw_packet,
                           batadv_ogm_packet->orig,
                           ntohl(batadv_ogm_packet->seqno),
                           batadv_ogm_packet->tq, batadv_ogm_packet->ttl,
-                          (batadv_ogm_packet->flags & BATADV_DIRECTLINK ?
+                          ((batadv_ogm_packet->flags & BATADV_DIRECTLINK) ?
                            "on" : "off"),
                           hard_iface->net_dev->name,
                           hard_iface->net_dev->dev_addr);
@@ -548,58 +548,62 @@ batadv_iv_ogm_can_aggregate(const struct batadv_ogm_packet *new_bat_ogm_packet,
         * - the send time is within our MAX_AGGREGATION_MS time
         * - the resulting packet wont be bigger than
         *   MAX_AGGREGATION_BYTES
+        * otherwise aggregation is not possible
         */
-       if (time_before(send_time, forw_packet->send_time) &&
-           time_after_eq(aggregation_end_time, forw_packet->send_time) &&
-           (aggregated_bytes <= BATADV_MAX_AGGREGATION_BYTES)) {
-               /* check aggregation compatibility
-                * -> direct link packets are broadcasted on
-                *    their interface only
-                * -> aggregate packet if the current packet is
-                *    a "global" packet as well as the base
-                *    packet
-                */
-               primary_if = batadv_primary_if_get_selected(bat_priv);
-               if (!primary_if)
-                       goto out;
-
-               /* packet is not leaving on the same interface. */
-               if (forw_packet->if_outgoing != if_outgoing)
-                       goto out;
+       if (!time_before(send_time, forw_packet->send_time) ||
+           !time_after_eq(aggregation_end_time, forw_packet->send_time))
+               return false;
+
+       if (aggregated_bytes > BATADV_MAX_AGGREGATION_BYTES)
+               return false;
+
+       /* packet is not leaving on the same interface. */
+       if (forw_packet->if_outgoing != if_outgoing)
+               return false;
+
+       /* check aggregation compatibility
+        * -> direct link packets are broadcasted on
+        *    their interface only
+        * -> aggregate packet if the current packet is
+        *    a "global" packet as well as the base
+        *    packet
+        */
+       primary_if = batadv_primary_if_get_selected(bat_priv);
+       if (!primary_if)
+               return false;
 
-               /* packets without direct link flag and high TTL
-                * are flooded through the net
-                */
-               if ((!directlink) &&
-                   (!(batadv_ogm_packet->flags & BATADV_DIRECTLINK)) &&
-                   (batadv_ogm_packet->ttl != 1) &&
-
-                   /* own packets originating non-primary
-                    * interfaces leave only that interface
-                    */
-                   ((!forw_packet->own) ||
-                    (forw_packet->if_incoming == primary_if))) {
-                       res = true;
-                       goto out;
-               }
+       /* packets without direct link flag and high TTL
+        * are flooded through the net
+        */
+       if (!directlink &&
+           !(batadv_ogm_packet->flags & BATADV_DIRECTLINK) &&
+           batadv_ogm_packet->ttl != 1 &&
+
+           /* own packets originating non-primary
+            * interfaces leave only that interface
+            */
+           (!forw_packet->own ||
+            forw_packet->if_incoming == primary_if)) {
+               res = true;
+               goto out;
+       }
 
-               /* if the incoming packet is sent via this one
-                * interface only - we still can aggregate
-                */
-               if ((directlink) &&
-                   (new_bat_ogm_packet->ttl == 1) &&
-                   (forw_packet->if_incoming == if_incoming) &&
-
-                   /* packets from direct neighbors or
-                    * own secondary interface packets
-                    * (= secondary interface packets in general)
-                    */
-                   (batadv_ogm_packet->flags & BATADV_DIRECTLINK ||
-                    (forw_packet->own &&
-                     forw_packet->if_incoming != primary_if))) {
-                       res = true;
-                       goto out;
-               }
+       /* if the incoming packet is sent via this one
+        * interface only - we still can aggregate
+        */
+       if (directlink &&
+           new_bat_ogm_packet->ttl == 1 &&
+           forw_packet->if_incoming == if_incoming &&
+
+           /* packets from direct neighbors or
+            * own secondary interface packets
+            * (= secondary interface packets in general)
+            */
+           (batadv_ogm_packet->flags & BATADV_DIRECTLINK ||
+            (forw_packet->own &&
+             forw_packet->if_incoming != primary_if))) {
+               res = true;
+               goto out;
        }
 
 out:
@@ -642,19 +646,16 @@ static void batadv_iv_ogm_aggregate_new(const unsigned char *packet_buff,
                if (!batadv_atomic_dec_not_zero(&bat_priv->batman_queue_left)) {
                        batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
                                   "batman packet queue full\n");
-                       goto out;
+                       goto out_free_outgoing;
                }
        }
 
        forw_packet_aggr = kmalloc(sizeof(*forw_packet_aggr), GFP_ATOMIC);
-       if (!forw_packet_aggr) {
-               if (!own_packet)
-                       atomic_inc(&bat_priv->batman_queue_left);
-               goto out;
-       }
+       if (!forw_packet_aggr)
+               goto out_nomem;
 
-       if ((atomic_read(&bat_priv->aggregated_ogms)) &&
-           (packet_len < BATADV_MAX_AGGREGATION_BYTES))
+       if (atomic_read(&bat_priv->aggregated_ogms) &&
+           packet_len < BATADV_MAX_AGGREGATION_BYTES)
                skb_size = BATADV_MAX_AGGREGATION_BYTES;
        else
                skb_size = packet_len;
@@ -662,12 +663,8 @@ static void batadv_iv_ogm_aggregate_new(const unsigned char *packet_buff,
        skb_size += ETH_HLEN;
 
        forw_packet_aggr->skb = netdev_alloc_skb_ip_align(NULL, skb_size);
-       if (!forw_packet_aggr->skb) {
-               if (!own_packet)
-                       atomic_inc(&bat_priv->batman_queue_left);
-               kfree(forw_packet_aggr);
-               goto out;
-       }
+       if (!forw_packet_aggr->skb)
+               goto out_free_forw_packet;
        forw_packet_aggr->skb->priority = TC_PRIO_CONTROL;
        skb_reserve(forw_packet_aggr->skb, ETH_HLEN);
 
@@ -699,7 +696,12 @@ static void batadv_iv_ogm_aggregate_new(const unsigned char *packet_buff,
                           send_time - jiffies);
 
        return;
-out:
+out_free_forw_packet:
+       kfree(forw_packet_aggr);
+out_nomem:
+       if (!own_packet)
+               atomic_inc(&bat_priv->batman_queue_left);
+out_free_outgoing:
        batadv_hardif_free_ref(if_outgoing);
 out_free_incoming:
        batadv_hardif_free_ref(if_incoming);
@@ -752,13 +754,13 @@ static void batadv_iv_ogm_queue_add(struct batadv_priv *bat_priv,
        unsigned long max_aggregation_jiffies;
 
        batadv_ogm_packet = (struct batadv_ogm_packet *)packet_buff;
-       direct_link = batadv_ogm_packet->flags & BATADV_DIRECTLINK ? 1 : 0;
+       direct_link = !!(batadv_ogm_packet->flags & BATADV_DIRECTLINK);
        max_aggregation_jiffies = msecs_to_jiffies(BATADV_MAX_AGGREGATION_MS);
 
        /* find position for the packet in the forward queue */
        spin_lock_bh(&bat_priv->forw_bat_list_lock);
        /* own packets are not to be aggregated */
-       if ((atomic_read(&bat_priv->aggregated_ogms)) && (!own_packet)) {
+       if (atomic_read(&bat_priv->aggregated_ogms) && !own_packet) {
                hlist_for_each_entry(forw_packet_pos,
                                     &bat_priv->forw_bat_list, list) {
                        if (batadv_iv_ogm_can_aggregate(batadv_ogm_packet,
@@ -807,7 +809,7 @@ static void batadv_iv_ogm_forward(struct batadv_orig_node *orig_node,
                                  struct batadv_hard_iface *if_outgoing)
 {
        struct batadv_priv *bat_priv = netdev_priv(if_incoming->soft_iface);
-       uint16_t tvlv_len;
+       u16 tvlv_len;
 
        if (batadv_ogm_packet->ttl <= 1) {
                batadv_dbg(BATADV_DBG_BATMAN, bat_priv, "ttl exceeded\n");
@@ -866,9 +868,9 @@ batadv_iv_ogm_slide_own_bcast_window(struct batadv_hard_iface *hard_iface)
        struct hlist_head *head;
        struct batadv_orig_node *orig_node;
        unsigned long *word;
-       uint32_t i;
+       u32 i;
        size_t word_index;
-       uint8_t *w;
+       u8 *w;
        int if_num;
 
        for (i = 0; i < hash->size; i++) {
@@ -897,8 +899,8 @@ static void batadv_iv_ogm_schedule(struct batadv_hard_iface *hard_iface)
        struct batadv_ogm_packet *batadv_ogm_packet;
        struct batadv_hard_iface *primary_if, *tmp_hard_iface;
        int *ogm_buff_len = &hard_iface->bat_iv.ogm_buff_len;
-       uint32_t seqno;
-       uint16_t tvlv_len = 0;
+       u32 seqno;
+       u16 tvlv_len = 0;
        unsigned long send_time;
 
        primary_if = batadv_primary_if_get_selected(bat_priv);
@@ -917,7 +919,7 @@ static void batadv_iv_ogm_schedule(struct batadv_hard_iface *hard_iface)
        batadv_ogm_packet->tvlv_len = htons(tvlv_len);
 
        /* change sequence number to network order */
-       seqno = (uint32_t)atomic_read(&hard_iface->bat_iv.ogm_seqno);
+       seqno = (u32)atomic_read(&hard_iface->bat_iv.ogm_seqno);
        batadv_ogm_packet->seqno = htonl(seqno);
        atomic_inc(&hard_iface->bat_iv.ogm_seqno);
 
@@ -940,7 +942,7 @@ static void batadv_iv_ogm_schedule(struct batadv_hard_iface *hard_iface)
        rcu_read_lock();
        list_for_each_entry_rcu(tmp_hard_iface, &batadv_hardif_list, list) {
                if (tmp_hard_iface->soft_iface != hard_iface->soft_iface)
-                               continue;
+                       continue;
                batadv_iv_ogm_queue_add(bat_priv, *ogm_buff,
                                        *ogm_buff_len, hard_iface,
                                        tmp_hard_iface, 1, send_time);
@@ -976,13 +978,14 @@ batadv_iv_ogm_orig_update(struct batadv_priv *bat_priv,
 {
        struct batadv_neigh_ifinfo *neigh_ifinfo = NULL;
        struct batadv_neigh_ifinfo *router_ifinfo = NULL;
-       struct batadv_neigh_node *neigh_node = NULL, *tmp_neigh_node = NULL;
+       struct batadv_neigh_node *neigh_node = NULL;
+       struct batadv_neigh_node *tmp_neigh_node = NULL;
        struct batadv_neigh_node *router = NULL;
        struct batadv_orig_node *orig_node_tmp;
        int if_num;
-       uint8_t sum_orig, sum_neigh;
-       uint8_t *neigh_addr;
-       uint8_t tq_avg;
+       u8 sum_orig, sum_neigh;
+       u8 *neigh_addr;
+       u8 tq_avg;
 
        batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
                   "update_originator(): Searching and updating originator entry of received packet\n");
@@ -1034,9 +1037,10 @@ batadv_iv_ogm_orig_update(struct batadv_priv *bat_priv,
                batadv_orig_node_free_ref(orig_tmp);
                if (!neigh_node)
                        goto unlock;
-       } else
+       } else {
                batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
                           "Updating existing last-hop neighbor of originator\n");
+       }
 
        rcu_read_unlock();
        neigh_ifinfo = batadv_neigh_ifinfo_new(neigh_node, if_outgoing);
@@ -1081,7 +1085,7 @@ batadv_iv_ogm_orig_update(struct batadv_priv *bat_priv,
         * won't consider it either
         */
        if (router_ifinfo &&
-           (neigh_ifinfo->bat_iv.tq_avg == router_ifinfo->bat_iv.tq_avg)) {
+           neigh_ifinfo->bat_iv.tq_avg == router_ifinfo->bat_iv.tq_avg) {
                orig_node_tmp = router->orig_node;
                spin_lock_bh(&orig_node_tmp->bat_iv.ogm_cnt_lock);
                if_num = router->if_incoming->if_num;
@@ -1133,8 +1137,8 @@ static int batadv_iv_ogm_calc_tq(struct batadv_orig_node *orig_node,
        struct batadv_priv *bat_priv = netdev_priv(if_incoming->soft_iface);
        struct batadv_neigh_node *neigh_node = NULL, *tmp_neigh_node;
        struct batadv_neigh_ifinfo *neigh_ifinfo;
-       uint8_t total_count;
-       uint8_t orig_eq_count, neigh_rq_count, neigh_rq_inv, tq_own;
+       u8 total_count;
+       u8 orig_eq_count, neigh_rq_count, neigh_rq_inv, tq_own;
        unsigned int neigh_rq_inv_cube, neigh_rq_max_cube;
        int tq_asym_penalty, inv_asym_penalty, if_num, ret = 0;
        unsigned int combined_tq;
@@ -1280,13 +1284,13 @@ batadv_iv_ogm_update_seqnos(const struct ethhdr *ethhdr,
        struct batadv_neigh_node *neigh_node;
        struct batadv_neigh_ifinfo *neigh_ifinfo;
        int is_dup;
-       int32_t seq_diff;
+       s32 seq_diff;
        int need_update = 0;
        int set_mark;
        enum batadv_dup_status ret = BATADV_NO_DUP;
-       uint32_t seqno = ntohl(batadv_ogm_packet->seqno);
-       uint8_t *neigh_addr;
-       uint8_t packet_count;
+       u32 seqno = ntohl(batadv_ogm_packet->seqno);
+       u8 *neigh_addr;
+       u8 packet_count;
        unsigned long *bitmap;
 
        orig_node = batadv_iv_ogm_orig_get(bat_priv, batadv_ogm_packet->orig);
@@ -1356,8 +1360,7 @@ batadv_iv_ogm_update_seqnos(const struct ethhdr *ethhdr,
 out:
        spin_unlock_bh(&orig_node->bat_iv.ogm_cnt_lock);
        batadv_orig_node_free_ref(orig_node);
-       if (orig_ifinfo)
-               batadv_orig_ifinfo_free_ref(orig_ifinfo);
+       batadv_orig_ifinfo_free_ref(orig_ifinfo);
        return ret;
 }
 
@@ -1376,7 +1379,8 @@ batadv_iv_ogm_process_per_outif(const struct sk_buff *skb, int ogm_offset,
                                struct batadv_hard_iface *if_outgoing)
 {
        struct batadv_priv *bat_priv = netdev_priv(if_incoming->soft_iface);
-       struct batadv_neigh_node *router = NULL, *router_router = NULL;
+       struct batadv_neigh_node *router = NULL;
+       struct batadv_neigh_node *router_router = NULL;
        struct batadv_orig_node *orig_neigh_node;
        struct batadv_orig_ifinfo *orig_ifinfo;
        struct batadv_neigh_node *orig_neigh_router = NULL;
@@ -1388,7 +1392,7 @@ batadv_iv_ogm_process_per_outif(const struct sk_buff *skb, int ogm_offset,
        bool sameseq, similar_ttl;
        struct sk_buff *skb_priv;
        struct ethhdr *ethhdr;
-       uint8_t *prev_sender;
+       u8 *prev_sender;
        int is_bidirect;
 
        /* create a private copy of the skb, as some functions change tq value
@@ -1570,7 +1574,7 @@ static void batadv_iv_ogm_process(const struct sk_buff *skb, int ogm_offset,
        struct batadv_orig_node *orig_neigh_node, *orig_node;
        struct batadv_hard_iface *hard_iface;
        struct batadv_ogm_packet *ogm_packet;
-       uint32_t if_incoming_seqno;
+       u32 if_incoming_seqno;
        bool has_directlink_flag;
        struct ethhdr *ethhdr;
        bool is_my_oldorig = false;
@@ -1643,9 +1647,9 @@ static void batadv_iv_ogm_process(const struct sk_buff *skb, int ogm_offset,
        if (is_my_orig) {
                unsigned long *word;
                int offset;
-               int32_t bit_pos;
-               int16_t if_num;
-               uint8_t *weight;
+               s32 bit_pos;
+               s16 if_num;
+               u8 *weight;
 
                orig_neigh_node = batadv_iv_ogm_orig_get(bat_priv,
                                                         ethhdr->h_source);
@@ -1721,7 +1725,7 @@ static int batadv_iv_ogm_receive(struct sk_buff *skb,
 {
        struct batadv_priv *bat_priv = netdev_priv(if_incoming->soft_iface);
        struct batadv_ogm_packet *ogm_packet;
-       uint8_t *packet_pos;
+       u8 *packet_pos;
        int ogm_offset;
        bool ret;
 
@@ -1805,7 +1809,7 @@ static void batadv_iv_ogm_orig_print(struct batadv_priv *bat_priv,
        unsigned long last_seen_jiffies;
        struct hlist_head *head;
        int batman_count = 0;
-       uint32_t i;
+       u32 i;
 
        seq_printf(seq, "  %-15s %s (%s/%i) %17s [%10s]: %20s ...\n",
                   "Originator", "last-seen", "#", BATADV_TQ_MAX_VALUE,
@@ -1873,7 +1877,7 @@ static int batadv_iv_ogm_neigh_cmp(struct batadv_neigh_node *neigh1,
                                   struct batadv_hard_iface *if_outgoing2)
 {
        struct batadv_neigh_ifinfo *neigh1_ifinfo, *neigh2_ifinfo;
-       uint8_t tq1, tq2;
+       u8 tq1, tq2;
        int diff;
 
        neigh1_ifinfo = batadv_neigh_ifinfo_get(neigh1, if_outgoing1);
@@ -1915,7 +1919,7 @@ batadv_iv_ogm_neigh_is_eob(struct batadv_neigh_node *neigh1,
                           struct batadv_hard_iface *if_outgoing2)
 {
        struct batadv_neigh_ifinfo *neigh1_ifinfo, *neigh2_ifinfo;
-       uint8_t tq1, tq2;
+       u8 tq1, tq2;
        bool ret;
 
        neigh1_ifinfo = batadv_neigh_ifinfo_get(neigh1, if_outgoing1);