These changes are the raw update to linux-4.4.6-rt14. Kernel sources
[kvmfornfv.git] / kernel / drivers / net / wireless / mwifiex / pcie.c
index bcc7751..21192b6 100644 (file)
@@ -57,7 +57,7 @@ mwifiex_map_pci_memory(struct mwifiex_adapter *adapter, struct sk_buff *skb,
 
        mapping.addr = pci_map_single(card->dev, skb->data, size, flags);
        if (pci_dma_mapping_error(card->dev, mapping.addr)) {
-               dev_err(adapter->dev, "failed to map pci memory!\n");
+               mwifiex_dbg(adapter, ERROR, "failed to map pci memory!\n");
                return -1;
        }
        mapping.len = size;
@@ -89,8 +89,9 @@ static bool mwifiex_pcie_ok_to_access_hw(struct mwifiex_adapter *adapter)
 
        if (card->sleep_cookie_vbase) {
                cookie_addr = (u32 *)card->sleep_cookie_vbase;
-               dev_dbg(adapter->dev, "info: ACCESS_HW: sleep cookie=0x%x\n",
-                       *cookie_addr);
+               mwifiex_dbg(adapter, INFO,
+                           "info: ACCESS_HW: sleep cookie=0x%x\n",
+                           *cookie_addr);
                if (*cookie_addr == FW_AWAKE_COOKIE)
                        return true;
        }
@@ -164,7 +165,8 @@ static int mwifiex_pcie_resume(struct device *dev)
        adapter = card->adapter;
 
        if (!adapter->is_suspended) {
-               dev_warn(adapter->dev, "Device already resumed\n");
+               mwifiex_dbg(adapter, WARN,
+                           "Device already resumed\n");
                return 0;
        }
 
@@ -264,12 +266,17 @@ static const struct pci_device_id mwifiex_ids[] = {
        {
                PCIE_VENDOR_ID_MARVELL, PCIE_DEVICE_ID_MARVELL_88W8766P,
                PCI_ANY_ID, PCI_ANY_ID, 0, 0,
-               .driver_data = (unsigned long) &mwifiex_pcie8766,
+               .driver_data = (unsigned long)&mwifiex_pcie8766,
        },
        {
                PCIE_VENDOR_ID_MARVELL, PCIE_DEVICE_ID_MARVELL_88W8897,
                PCI_ANY_ID, PCI_ANY_ID, 0, 0,
-               .driver_data = (unsigned long) &mwifiex_pcie8897,
+               .driver_data = (unsigned long)&mwifiex_pcie8897,
+       },
+       {
+               PCIE_VENDOR_ID_MARVELL, PCIE_DEVICE_ID_MARVELL_88W8997,
+               PCI_ANY_ID, PCI_ANY_ID, 0, 0,
+               .driver_data = (unsigned long)&mwifiex_pcie8997,
        },
        {},
 };
@@ -361,16 +368,16 @@ static void mwifiex_delay_for_sleep_cookie(struct mwifiex_adapter *adapter,
                sleep_cookie = *(u32 *)buffer;
 
                if (sleep_cookie == MWIFIEX_DEF_SLEEP_COOKIE) {
-                       dev_dbg(adapter->dev,
-                               "sleep cookie found at count %d\n", count);
+                       mwifiex_dbg(adapter, INFO,
+                                   "sleep cookie found at count %d\n", count);
                        break;
                }
                usleep_range(20, 30);
        }
 
        if (count >= max_delay_loop_cnt)
-               dev_dbg(adapter->dev,
-                       "max count reached while accessing sleep cookie\n");
+               mwifiex_dbg(adapter, INFO,
+                           "max count reached while accessing sleep cookie\n");
 }
 
 /* This function wakes up the card by reading fw_status register. */
@@ -380,20 +387,23 @@ static int mwifiex_pm_wakeup_card(struct mwifiex_adapter *adapter)
        struct pcie_service_card *card = adapter->card;
        const struct mwifiex_pcie_card_reg *reg = card->pcie.reg;
 
-       dev_dbg(adapter->dev, "event: Wakeup device...\n");
+       mwifiex_dbg(adapter, EVENT,
+                   "event: Wakeup device...\n");
 
        if (reg->sleep_cookie)
                mwifiex_pcie_dev_wakeup_delay(adapter);
 
        /* Reading fw_status register will wakeup device */
        if (mwifiex_read_reg(adapter, reg->fw_status, &fw_status)) {
-               dev_warn(adapter->dev, "Reading fw_status register failed\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "Reading fw_status register failed\n");
                return -1;
        }
 
        if (reg->sleep_cookie) {
                mwifiex_pcie_dev_wakeup_delay(adapter);
-               dev_dbg(adapter->dev, "PCIE wakeup: Setting PS_STATE_AWAKE\n");
+               mwifiex_dbg(adapter, INFO,
+                           "PCIE wakeup: Setting PS_STATE_AWAKE\n");
                adapter->ps_state = PS_STATE_AWAKE;
        }
 
@@ -407,7 +417,8 @@ static int mwifiex_pm_wakeup_card(struct mwifiex_adapter *adapter)
  */
 static int mwifiex_pm_wakeup_card_complete(struct mwifiex_adapter *adapter)
 {
-       dev_dbg(adapter->dev, "cmd: Wakeup device completed\n");
+       mwifiex_dbg(adapter, CMD,
+                   "cmd: Wakeup device completed\n");
 
        return 0;
 }
@@ -423,7 +434,8 @@ static int mwifiex_pcie_disable_host_int(struct mwifiex_adapter *adapter)
        if (mwifiex_pcie_ok_to_access_hw(adapter)) {
                if (mwifiex_write_reg(adapter, PCIE_HOST_INT_MASK,
                                      0x00000000)) {
-                       dev_warn(adapter->dev, "Disable host interrupt failed\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "Disable host interrupt failed\n");
                        return -1;
                }
        }
@@ -443,7 +455,8 @@ static int mwifiex_pcie_enable_host_int(struct mwifiex_adapter *adapter)
                /* Simply write the mask to the register */
                if (mwifiex_write_reg(adapter, PCIE_HOST_INT_MASK,
                                      HOST_INTR_MASK)) {
-                       dev_warn(adapter->dev, "Enable host interrupt failed\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "Enable host interrupt failed\n");
                        return -1;
                }
        }
@@ -499,8 +512,8 @@ static int mwifiex_init_rxq_ring(struct mwifiex_adapter *adapter)
                skb = mwifiex_alloc_dma_align_buf(MWIFIEX_RX_DATA_BUF_SIZE,
                                                  GFP_KERNEL | GFP_DMA);
                if (!skb) {
-                       dev_err(adapter->dev,
-                               "Unable to allocate skb for RX ring.\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "Unable to allocate skb for RX ring.\n");
                        kfree(card->rxbd_ring_vbase);
                        return -ENOMEM;
                }
@@ -512,10 +525,10 @@ static int mwifiex_init_rxq_ring(struct mwifiex_adapter *adapter)
 
                buf_pa = MWIFIEX_SKB_DMA_ADDR(skb);
 
-               dev_dbg(adapter->dev,
-                       "info: RX ring: skb=%p len=%d data=%p buf_pa=%#x:%x\n",
-                       skb, skb->len, skb->data, (u32)buf_pa,
-                       (u32)((u64)buf_pa >> 32));
+               mwifiex_dbg(adapter, INFO,
+                           "info: RX ring: skb=%p len=%d data=%p buf_pa=%#x:%x\n",
+                           skb, skb->len, skb->data, (u32)buf_pa,
+                           (u32)((u64)buf_pa >> 32));
 
                card->rx_buf_list[i] = skb;
                if (reg->pfu_enabled) {
@@ -556,8 +569,8 @@ static int mwifiex_pcie_init_evt_ring(struct mwifiex_adapter *adapter)
                /* Allocate skb here so that firmware can DMA data from it */
                skb = dev_alloc_skb(MAX_EVENT_SIZE);
                if (!skb) {
-                       dev_err(adapter->dev,
-                               "Unable to allocate skb for EVENT buf.\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "Unable to allocate skb for EVENT buf.\n");
                        kfree(card->evtbd_ring_vbase);
                        return -ENOMEM;
                }
@@ -569,10 +582,10 @@ static int mwifiex_pcie_init_evt_ring(struct mwifiex_adapter *adapter)
 
                buf_pa = MWIFIEX_SKB_DMA_ADDR(skb);
 
-               dev_dbg(adapter->dev,
-                       "info: EVT ring: skb=%p len=%d data=%p buf_pa=%#x:%x\n",
-                       skb, skb->len, skb->data, (u32)buf_pa,
-                       (u32)((u64)buf_pa >> 32));
+               mwifiex_dbg(adapter, EVENT,
+                           "info: EVT ring: skb=%p len=%d data=%p buf_pa=%#x:%x\n",
+                           skb, skb->len, skb->data, (u32)buf_pa,
+                           (u32)((u64)buf_pa >> 32));
 
                card->evt_buf_list[i] = skb;
                card->evtbd_ring[i] = (void *)(card->evtbd_ring_vbase +
@@ -715,21 +728,23 @@ static int mwifiex_pcie_create_txbd_ring(struct mwifiex_adapter *adapter)
                card->txbd_ring_size = sizeof(struct mwifiex_pcie_buf_desc) *
                                       MWIFIEX_MAX_TXRX_BD;
 
-       dev_dbg(adapter->dev, "info: txbd_ring: Allocating %d bytes\n",
-               card->txbd_ring_size);
+       mwifiex_dbg(adapter, INFO,
+                   "info: txbd_ring: Allocating %d bytes\n",
+                   card->txbd_ring_size);
        card->txbd_ring_vbase = pci_alloc_consistent(card->dev,
                                                     card->txbd_ring_size,
                                                     &card->txbd_ring_pbase);
        if (!card->txbd_ring_vbase) {
-               dev_err(adapter->dev,
-                       "allocate consistent memory (%d bytes) failed!\n",
-                       card->txbd_ring_size);
+               mwifiex_dbg(adapter, ERROR,
+                           "allocate consistent memory (%d bytes) failed!\n",
+                           card->txbd_ring_size);
                return -ENOMEM;
        }
-       dev_dbg(adapter->dev,
-               "info: txbd_ring - base: %p, pbase: %#x:%x, len: %x\n",
-               card->txbd_ring_vbase, (unsigned int)card->txbd_ring_pbase,
-               (u32)((u64)card->txbd_ring_pbase >> 32), card->txbd_ring_size);
+       mwifiex_dbg(adapter, DATA,
+                   "info: txbd_ring - base: %p, pbase: %#x:%x, len: %x\n",
+                   card->txbd_ring_vbase, (unsigned int)card->txbd_ring_pbase,
+                   (u32)((u64)card->txbd_ring_pbase >> 32),
+                   card->txbd_ring_size);
 
        return mwifiex_init_txq_ring(adapter);
 }
@@ -777,23 +792,24 @@ static int mwifiex_pcie_create_rxbd_ring(struct mwifiex_adapter *adapter)
                card->rxbd_ring_size = sizeof(struct mwifiex_pcie_buf_desc) *
                                       MWIFIEX_MAX_TXRX_BD;
 
-       dev_dbg(adapter->dev, "info: rxbd_ring: Allocating %d bytes\n",
-               card->rxbd_ring_size);
+       mwifiex_dbg(adapter, INFO,
+                   "info: rxbd_ring: Allocating %d bytes\n",
+                   card->rxbd_ring_size);
        card->rxbd_ring_vbase = pci_alloc_consistent(card->dev,
                                                     card->rxbd_ring_size,
                                                     &card->rxbd_ring_pbase);
        if (!card->rxbd_ring_vbase) {
-               dev_err(adapter->dev,
-                       "allocate consistent memory (%d bytes) failed!\n",
-                       card->rxbd_ring_size);
+               mwifiex_dbg(adapter, ERROR,
+                           "allocate consistent memory (%d bytes) failed!\n",
+                           card->rxbd_ring_size);
                return -ENOMEM;
        }
 
-       dev_dbg(adapter->dev,
-               "info: rxbd_ring - base: %p, pbase: %#x:%x, len: %#x\n",
-               card->rxbd_ring_vbase, (u32)card->rxbd_ring_pbase,
-               (u32)((u64)card->rxbd_ring_pbase >> 32),
-               card->rxbd_ring_size);
+       mwifiex_dbg(adapter, DATA,
+                   "info: rxbd_ring - base: %p, pbase: %#x:%x, len: %#x\n",
+                   card->rxbd_ring_vbase, (u32)card->rxbd_ring_pbase,
+                   (u32)((u64)card->rxbd_ring_pbase >> 32),
+                   card->rxbd_ring_size);
 
        return mwifiex_init_rxq_ring(adapter);
 }
@@ -840,23 +856,24 @@ static int mwifiex_pcie_create_evtbd_ring(struct mwifiex_adapter *adapter)
        card->evtbd_ring_size = sizeof(struct mwifiex_evt_buf_desc) *
                                MWIFIEX_MAX_EVT_BD;
 
-       dev_dbg(adapter->dev, "info: evtbd_ring: Allocating %d bytes\n",
+       mwifiex_dbg(adapter, INFO,
+                   "info: evtbd_ring: Allocating %d bytes\n",
                card->evtbd_ring_size);
        card->evtbd_ring_vbase = pci_alloc_consistent(card->dev,
                                                      card->evtbd_ring_size,
                                                      &card->evtbd_ring_pbase);
        if (!card->evtbd_ring_vbase) {
-               dev_err(adapter->dev,
-                       "allocate consistent memory (%d bytes) failed!\n",
-                       card->evtbd_ring_size);
+               mwifiex_dbg(adapter, ERROR,
+                           "allocate consistent memory (%d bytes) failed!\n",
+                           card->evtbd_ring_size);
                return -ENOMEM;
        }
 
-       dev_dbg(adapter->dev,
-               "info: CMDRSP/EVT bd_ring - base: %p pbase: %#x:%x len: %#x\n",
-               card->evtbd_ring_vbase, (u32)card->evtbd_ring_pbase,
-               (u32)((u64)card->evtbd_ring_pbase >> 32),
-               card->evtbd_ring_size);
+       mwifiex_dbg(adapter, EVENT,
+                   "info: CMDRSP/EVT bd_ring - base: %p pbase: %#x:%x len: %#x\n",
+                   card->evtbd_ring_vbase, (u32)card->evtbd_ring_pbase,
+                   (u32)((u64)card->evtbd_ring_pbase >> 32),
+                   card->evtbd_ring_size);
 
        return mwifiex_pcie_init_evt_ring(adapter);
 }
@@ -895,8 +912,8 @@ static int mwifiex_pcie_alloc_cmdrsp_buf(struct mwifiex_adapter *adapter)
        /* Allocate memory for receiving command response data */
        skb = dev_alloc_skb(MWIFIEX_UPLD_SIZE);
        if (!skb) {
-               dev_err(adapter->dev,
-                       "Unable to allocate skb for command response data.\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "Unable to allocate skb for command response data.\n");
                return -ENOMEM;
        }
        skb_put(skb, MWIFIEX_UPLD_SIZE);
@@ -944,14 +961,16 @@ static int mwifiex_pcie_alloc_sleep_cookie_buf(struct mwifiex_adapter *adapter)
        card->sleep_cookie_vbase = pci_alloc_consistent(card->dev, sizeof(u32),
                                                     &card->sleep_cookie_pbase);
        if (!card->sleep_cookie_vbase) {
-               dev_err(adapter->dev, "pci_alloc_consistent failed!\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "pci_alloc_consistent failed!\n");
                return -ENOMEM;
        }
        /* Init val of Sleep Cookie */
        *(u32 *)card->sleep_cookie_vbase = FW_AWAKE_COOKIE;
 
-       dev_dbg(adapter->dev, "alloc_scook: sleep cookie=0x%x\n",
-               *((u32 *)card->sleep_cookie_vbase));
+       mwifiex_dbg(adapter, INFO,
+                   "alloc_scook: sleep cookie=0x%x\n",
+                   *((u32 *)card->sleep_cookie_vbase));
 
        return 0;
 }
@@ -993,8 +1012,8 @@ static int mwifiex_clean_pcie_ring_buf(struct mwifiex_adapter *adapter)
                 */
                if (mwifiex_write_reg(adapter, PCIE_CPU_INT_EVENT,
                                      CPU_INTR_DNLD_RDY)) {
-                       dev_err(adapter->dev,
-                               "failed to assert dnld-rdy interrupt.\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "failed to assert dnld-rdy interrupt.\n");
                        return -1;
                }
        }
@@ -1018,13 +1037,14 @@ static int mwifiex_pcie_send_data_complete(struct mwifiex_adapter *adapter)
 
        /* Read the TX ring read pointer set by firmware */
        if (mwifiex_read_reg(adapter, reg->tx_rdptr, &rdptr)) {
-               dev_err(adapter->dev,
-                       "SEND COMP: failed to read reg->tx_rdptr\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "SEND COMP: failed to read reg->tx_rdptr\n");
                return -1;
        }
 
-       dev_dbg(adapter->dev, "SEND COMP: rdptr_prev=0x%x, rdptr=0x%x\n",
-               card->txbd_rdptr, rdptr);
+       mwifiex_dbg(adapter, DATA,
+                   "SEND COMP: rdptr_prev=0x%x, rdptr=0x%x\n",
+                   card->txbd_rdptr, rdptr);
 
        num_tx_buffs = MWIFIEX_MAX_TXRX_BD << reg->tx_start_ptr;
        /* free from previous txbd_rdptr to current txbd_rdptr */
@@ -1038,9 +1058,9 @@ static int mwifiex_pcie_send_data_complete(struct mwifiex_adapter *adapter)
                skb = card->tx_buf_list[wrdoneidx];
 
                if (skb) {
-                       dev_dbg(adapter->dev,
-                               "SEND COMP: Detach skb %p at txbd_rdidx=%d\n",
-                               skb, wrdoneidx);
+                       mwifiex_dbg(adapter, DATA,
+                                   "SEND COMP: Detach skb %p at txbd_rdidx=%d\n",
+                                   skb, wrdoneidx);
                        mwifiex_unmap_pci_memory(adapter, skb,
                                                 PCI_DMA_TODEVICE);
 
@@ -1067,6 +1087,7 @@ static int mwifiex_pcie_send_data_complete(struct mwifiex_adapter *adapter)
                        card->txbd_rdptr++;
                        break;
                case PCIE_DEVICE_ID_MARVELL_88W8897:
+               case PCIE_DEVICE_ID_MARVELL_88W8997:
                        card->txbd_rdptr += reg->ring_tx_start_ptr;
                        break;
                }
@@ -1112,8 +1133,9 @@ mwifiex_pcie_send_data(struct mwifiex_adapter *adapter, struct sk_buff *skb,
        __le16 *tmp;
 
        if (!(skb->data && skb->len)) {
-               dev_err(adapter->dev, "%s(): invalid parameter <%p, %#x>\n",
-                       __func__, skb->data, skb->len);
+               mwifiex_dbg(adapter, ERROR,
+                           "%s(): invalid parameter <%p, %#x>\n",
+                           __func__, skb->data, skb->len);
                return -1;
        }
 
@@ -1121,7 +1143,8 @@ mwifiex_pcie_send_data(struct mwifiex_adapter *adapter, struct sk_buff *skb,
                mwifiex_pm_wakeup_card(adapter);
 
        num_tx_buffs = MWIFIEX_MAX_TXRX_BD << reg->tx_start_ptr;
-       dev_dbg(adapter->dev, "info: SEND DATA: <Rd: %#x, Wr: %#x>\n",
+       mwifiex_dbg(adapter, DATA,
+                   "info: SEND DATA: <Rd: %#x, Wr: %#x>\n",
                card->txbd_rdptr, card->txbd_wrptr);
        if (mwifiex_pcie_txbd_not_full(card)) {
                u8 *payload;
@@ -1162,6 +1185,7 @@ mwifiex_pcie_send_data(struct mwifiex_adapter *adapter, struct sk_buff *skb,
                        card->txbd_wrptr++;
                        break;
                case PCIE_DEVICE_ID_MARVELL_88W8897:
+               case PCIE_DEVICE_ID_MARVELL_88W8997:
                        card->txbd_wrptr += reg->ring_tx_start_ptr;
                        break;
                }
@@ -1175,39 +1199,40 @@ mwifiex_pcie_send_data(struct mwifiex_adapter *adapter, struct sk_buff *skb,
                /* Write the TX ring write pointer in to reg->tx_wrptr */
                if (mwifiex_write_reg(adapter, reg->tx_wrptr,
                                      card->txbd_wrptr | rx_val)) {
-                       dev_err(adapter->dev,
-                               "SEND DATA: failed to write reg->tx_wrptr\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "SEND DATA: failed to write reg->tx_wrptr\n");
                        ret = -1;
                        goto done_unmap;
                }
                if ((mwifiex_pcie_txbd_not_full(card)) &&
                    tx_param->next_pkt_len) {
                        /* have more packets and TxBD still can hold more */
-                       dev_dbg(adapter->dev,
-                               "SEND DATA: delay dnld-rdy interrupt.\n");
+                       mwifiex_dbg(adapter, DATA,
+                                   "SEND DATA: delay dnld-rdy interrupt.\n");
                        adapter->data_sent = false;
                } else {
                        /* Send the TX ready interrupt */
                        if (mwifiex_write_reg(adapter, PCIE_CPU_INT_EVENT,
                                              CPU_INTR_DNLD_RDY)) {
-                               dev_err(adapter->dev,
-                                       "SEND DATA: failed to assert dnld-rdy interrupt.\n");
+                               mwifiex_dbg(adapter, ERROR,
+                                           "SEND DATA: failed to assert dnld-rdy interrupt.\n");
                                ret = -1;
                                goto done_unmap;
                        }
                }
-               dev_dbg(adapter->dev, "info: SEND DATA: Updated <Rd: %#x, Wr: "
-                       "%#x> and sent packet to firmware successfully\n",
-                       card->txbd_rdptr, card->txbd_wrptr);
+               mwifiex_dbg(adapter, DATA,
+                           "info: SEND DATA: Updated <Rd: %#x, Wr:\t"
+                           "%#x> and sent packet to firmware successfully\n",
+                           card->txbd_rdptr, card->txbd_wrptr);
        } else {
-               dev_dbg(adapter->dev,
-                       "info: TX Ring full, can't send packets to fw\n");
+               mwifiex_dbg(adapter, DATA,
+                           "info: TX Ring full, can't send packets to fw\n");
                adapter->data_sent = true;
                /* Send the TX ready interrupt */
                if (mwifiex_write_reg(adapter, PCIE_CPU_INT_EVENT,
                                      CPU_INTR_DNLD_RDY))
-                       dev_err(adapter->dev,
-                               "SEND DATA: failed to assert door-bell intr\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "SEND DATA: failed to assert door-bell intr\n");
                return -EBUSY;
        }
 
@@ -1243,8 +1268,8 @@ static int mwifiex_pcie_process_recv_data(struct mwifiex_adapter *adapter)
 
        /* Read the RX ring Write pointer set by firmware */
        if (mwifiex_read_reg(adapter, reg->rx_wrptr, &wrptr)) {
-               dev_err(adapter->dev,
-                       "RECV DATA: failed to read reg->rx_wrptr\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "RECV DATA: failed to read reg->rx_wrptr\n");
                ret = -1;
                goto done;
        }
@@ -1277,15 +1302,15 @@ static int mwifiex_pcie_process_recv_data(struct mwifiex_adapter *adapter)
                rx_len = le16_to_cpu(pkt_len);
                if (WARN_ON(rx_len <= INTF_HEADER_LEN ||
                            rx_len > MWIFIEX_RX_DATA_BUF_SIZE)) {
-                       dev_err(adapter->dev,
-                               "Invalid RX len %d, Rd=%#x, Wr=%#x\n",
-                               rx_len, card->rxbd_rdptr, wrptr);
+                       mwifiex_dbg(adapter, ERROR,
+                                   "Invalid RX len %d, Rd=%#x, Wr=%#x\n",
+                                   rx_len, card->rxbd_rdptr, wrptr);
                        dev_kfree_skb_any(skb_data);
                } else {
                        skb_put(skb_data, rx_len);
-                       dev_dbg(adapter->dev,
-                               "info: RECV DATA: Rd=%#x, Wr=%#x, Len=%d\n",
-                               card->rxbd_rdptr, wrptr, rx_len);
+                       mwifiex_dbg(adapter, DATA,
+                                   "info: RECV DATA: Rd=%#x, Wr=%#x, Len=%d\n",
+                                   card->rxbd_rdptr, wrptr, rx_len);
                        skb_pull(skb_data, INTF_HEADER_LEN);
                        if (adapter->rx_work_enabled) {
                                skb_queue_tail(&adapter->rx_data_q, skb_data);
@@ -1299,8 +1324,8 @@ static int mwifiex_pcie_process_recv_data(struct mwifiex_adapter *adapter)
                skb_tmp = mwifiex_alloc_dma_align_buf(MWIFIEX_RX_DATA_BUF_SIZE,
                                                      GFP_KERNEL | GFP_DMA);
                if (!skb_tmp) {
-                       dev_err(adapter->dev,
-                               "Unable to allocate skb.\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "Unable to allocate skb.\n");
                        return -ENOMEM;
                }
 
@@ -1311,9 +1336,9 @@ static int mwifiex_pcie_process_recv_data(struct mwifiex_adapter *adapter)
 
                buf_pa = MWIFIEX_SKB_DMA_ADDR(skb_tmp);
 
-               dev_dbg(adapter->dev,
-                       "RECV DATA: Attach new sk_buff %p at rxbd_rdidx=%d\n",
-                       skb_tmp, rd_index);
+               mwifiex_dbg(adapter, INFO,
+                           "RECV DATA: Attach new sk_buff %p at rxbd_rdidx=%d\n",
+                           skb_tmp, rd_index);
                card->rx_buf_list[rd_index] = skb_tmp;
 
                if (reg->pfu_enabled) {
@@ -1336,28 +1361,29 @@ static int mwifiex_pcie_process_recv_data(struct mwifiex_adapter *adapter)
                                             reg->rx_rollover_ind) ^
                                             reg->rx_rollover_ind);
                }
-               dev_dbg(adapter->dev, "info: RECV DATA: <Rd: %#x, Wr: %#x>\n",
-                       card->rxbd_rdptr, wrptr);
+               mwifiex_dbg(adapter, DATA,
+                           "info: RECV DATA: <Rd: %#x, Wr: %#x>\n",
+                           card->rxbd_rdptr, wrptr);
 
                tx_val = card->txbd_wrptr & reg->tx_wrap_mask;
                /* Write the RX ring read pointer in to reg->rx_rdptr */
                if (mwifiex_write_reg(adapter, reg->rx_rdptr,
                                      card->rxbd_rdptr | tx_val)) {
-                       dev_err(adapter->dev,
-                               "RECV DATA: failed to write reg->rx_rdptr\n");
+                       mwifiex_dbg(adapter, DATA,
+                                   "RECV DATA: failed to write reg->rx_rdptr\n");
                        ret = -1;
                        goto done;
                }
 
                /* Read the RX ring Write pointer set by firmware */
                if (mwifiex_read_reg(adapter, reg->rx_wrptr, &wrptr)) {
-                       dev_err(adapter->dev,
-                               "RECV DATA: failed to read reg->rx_wrptr\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "RECV DATA: failed to read reg->rx_wrptr\n");
                        ret = -1;
                        goto done;
                }
-               dev_dbg(adapter->dev,
-                       "info: RECV DATA: Rcvd packet from fw successfully\n");
+               mwifiex_dbg(adapter, DATA,
+                           "info: RECV DATA: Rcvd packet from fw successfully\n");
                card->rxbd_wrptr = wrptr;
        }
 
@@ -1376,9 +1402,9 @@ mwifiex_pcie_send_boot_cmd(struct mwifiex_adapter *adapter, struct sk_buff *skb)
        const struct mwifiex_pcie_card_reg *reg = card->pcie.reg;
 
        if (!(skb->data && skb->len)) {
-               dev_err(adapter->dev,
-                       "Invalid parameter in %s <%p. len %d>\n",
-                       __func__, skb->data, skb->len);
+               mwifiex_dbg(adapter, ERROR,
+                           "Invalid parameter in %s <%p. len %d>\n",
+                           __func__, skb->data, skb->len);
                return -1;
        }
 
@@ -1391,9 +1417,9 @@ mwifiex_pcie_send_boot_cmd(struct mwifiex_adapter *adapter, struct sk_buff *skb)
         * address scratch register
         */
        if (mwifiex_write_reg(adapter, reg->cmd_addr_lo, (u32)buf_pa)) {
-               dev_err(adapter->dev,
-                       "%s: failed to write download command to boot code.\n",
-                       __func__);
+               mwifiex_dbg(adapter, ERROR,
+                           "%s: failed to write download command to boot code.\n",
+                           __func__);
                mwifiex_unmap_pci_memory(adapter, skb, PCI_DMA_TODEVICE);
                return -1;
        }
@@ -1403,18 +1429,18 @@ mwifiex_pcie_send_boot_cmd(struct mwifiex_adapter *adapter, struct sk_buff *skb)
         */
        if (mwifiex_write_reg(adapter, reg->cmd_addr_hi,
                              (u32)((u64)buf_pa >> 32))) {
-               dev_err(adapter->dev,
-                       "%s: failed to write download command to boot code.\n",
-                       __func__);
+               mwifiex_dbg(adapter, ERROR,
+                           "%s: failed to write download command to boot code.\n",
+                           __func__);
                mwifiex_unmap_pci_memory(adapter, skb, PCI_DMA_TODEVICE);
                return -1;
        }
 
        /* Write the command length to cmd_size scratch register */
        if (mwifiex_write_reg(adapter, reg->cmd_size, skb->len)) {
-               dev_err(adapter->dev,
-                       "%s: failed to write command len to cmd_size scratch reg\n",
-                       __func__);
+               mwifiex_dbg(adapter, ERROR,
+                           "%s: failed to write command len to cmd_size scratch reg\n",
+                           __func__);
                mwifiex_unmap_pci_memory(adapter, skb, PCI_DMA_TODEVICE);
                return -1;
        }
@@ -1422,8 +1448,8 @@ mwifiex_pcie_send_boot_cmd(struct mwifiex_adapter *adapter, struct sk_buff *skb)
        /* Ring the door bell */
        if (mwifiex_write_reg(adapter, PCIE_CPU_INT_EVENT,
                              CPU_INTR_DOOR_BELL)) {
-               dev_err(adapter->dev,
-                       "%s: failed to assert door-bell intr\n", __func__);
+               mwifiex_dbg(adapter, ERROR,
+                           "%s: failed to assert door-bell intr\n", __func__);
                mwifiex_unmap_pci_memory(adapter, skb, PCI_DMA_TODEVICE);
                return -1;
        }
@@ -1443,8 +1469,8 @@ static int mwifiex_pcie_init_fw_port(struct mwifiex_adapter *adapter)
        /* Write the RX ring read pointer in to reg->rx_rdptr */
        if (mwifiex_write_reg(adapter, reg->rx_rdptr, card->rxbd_rdptr |
                              tx_wrap)) {
-               dev_err(adapter->dev,
-                       "RECV DATA: failed to write reg->rx_rdptr\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "RECV DATA: failed to write reg->rx_rdptr\n");
                return -1;
        }
        return 0;
@@ -1462,15 +1488,16 @@ mwifiex_pcie_send_cmd(struct mwifiex_adapter *adapter, struct sk_buff *skb)
        u8 *payload = (u8 *)skb->data;
 
        if (!(skb->data && skb->len)) {
-               dev_err(adapter->dev, "Invalid parameter in %s <%p, %#x>\n",
-                       __func__, skb->data, skb->len);
+               mwifiex_dbg(adapter, ERROR,
+                           "Invalid parameter in %s <%p, %#x>\n",
+                           __func__, skb->data, skb->len);
                return -1;
        }
 
        /* Make sure a command response buffer is available */
        if (!card->cmdrsp_buf) {
-               dev_err(adapter->dev,
-                       "No response buffer available, send command failed\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "No response buffer available, send command failed\n");
                return -EBUSY;
        }
 
@@ -1503,8 +1530,8 @@ mwifiex_pcie_send_cmd(struct mwifiex_adapter *adapter, struct sk_buff *skb)
                   address */
                if (mwifiex_write_reg(adapter, reg->cmdrsp_addr_lo,
                                      (u32)cmdrsp_buf_pa)) {
-                       dev_err(adapter->dev,
-                               "Failed to write download cmd to boot code.\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "Failed to write download cmd to boot code.\n");
                        ret = -1;
                        goto done;
                }
@@ -1512,8 +1539,8 @@ mwifiex_pcie_send_cmd(struct mwifiex_adapter *adapter, struct sk_buff *skb)
                   address */
                if (mwifiex_write_reg(adapter, reg->cmdrsp_addr_hi,
                                      (u32)((u64)cmdrsp_buf_pa >> 32))) {
-                       dev_err(adapter->dev,
-                               "Failed to write download cmd to boot code.\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "Failed to write download cmd to boot code.\n");
                        ret = -1;
                        goto done;
                }
@@ -1523,16 +1550,16 @@ mwifiex_pcie_send_cmd(struct mwifiex_adapter *adapter, struct sk_buff *skb)
        /* Write the lower 32bits of the physical address to reg->cmd_addr_lo */
        if (mwifiex_write_reg(adapter, reg->cmd_addr_lo,
                              (u32)cmd_buf_pa)) {
-               dev_err(adapter->dev,
-                       "Failed to write download cmd to boot code.\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "Failed to write download cmd to boot code.\n");
                ret = -1;
                goto done;
        }
        /* Write the upper 32bits of the physical address to reg->cmd_addr_hi */
        if (mwifiex_write_reg(adapter, reg->cmd_addr_hi,
                              (u32)((u64)cmd_buf_pa >> 32))) {
-               dev_err(adapter->dev,
-                       "Failed to write download cmd to boot code.\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "Failed to write download cmd to boot code.\n");
                ret = -1;
                goto done;
        }
@@ -1540,8 +1567,8 @@ mwifiex_pcie_send_cmd(struct mwifiex_adapter *adapter, struct sk_buff *skb)
        /* Write the command length to reg->cmd_size */
        if (mwifiex_write_reg(adapter, reg->cmd_size,
                              card->cmd_buf->len)) {
-               dev_err(adapter->dev,
-                       "Failed to write cmd len to reg->cmd_size\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "Failed to write cmd len to reg->cmd_size\n");
                ret = -1;
                goto done;
        }
@@ -1549,8 +1576,8 @@ mwifiex_pcie_send_cmd(struct mwifiex_adapter *adapter, struct sk_buff *skb)
        /* Ring the door bell */
        if (mwifiex_write_reg(adapter, PCIE_CPU_INT_EVENT,
                              CPU_INTR_DOOR_BELL)) {
-               dev_err(adapter->dev,
-                       "Failed to assert door-bell intr\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "Failed to assert door-bell intr\n");
                ret = -1;
                goto done;
        }
@@ -1574,7 +1601,8 @@ static int mwifiex_pcie_process_cmd_complete(struct mwifiex_adapter *adapter)
        u16 rx_len;
        __le16 pkt_len;
 
-       dev_dbg(adapter->dev, "info: Rx CMD Response\n");
+       mwifiex_dbg(adapter, CMD,
+                   "info: Rx CMD Response\n");
 
        mwifiex_unmap_pci_memory(adapter, skb, PCI_DMA_FROMDEVICE);
 
@@ -1598,8 +1626,8 @@ static int mwifiex_pcie_process_cmd_complete(struct mwifiex_adapter *adapter)
                        if (mwifiex_write_reg(adapter,
                                              PCIE_CPU_INT_EVENT,
                                              CPU_INTR_SLEEP_CFM_DONE)) {
-                               dev_warn(adapter->dev,
-                                        "Write register failed\n");
+                               mwifiex_dbg(adapter, ERROR,
+                                           "Write register failed\n");
                                return -1;
                        }
                        mwifiex_delay_for_sleep_cookie(adapter,
@@ -1608,8 +1636,8 @@ static int mwifiex_pcie_process_cmd_complete(struct mwifiex_adapter *adapter)
                               mwifiex_pcie_ok_to_access_hw(adapter))
                                usleep_range(50, 60);
                } else {
-                       dev_err(adapter->dev,
-                               "There is no command but got cmdrsp\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "There is no command but got cmdrsp\n");
                }
                memcpy(adapter->upld_buf, skb->data,
                       min_t(u32, MWIFIEX_SIZE_OF_CMD_BUFFER, skb->len));
@@ -1628,15 +1656,15 @@ static int mwifiex_pcie_process_cmd_complete(struct mwifiex_adapter *adapter)
                   will prevent firmware from writing to the same response
                   buffer again. */
                if (mwifiex_write_reg(adapter, reg->cmdrsp_addr_lo, 0)) {
-                       dev_err(adapter->dev,
-                               "cmd_done: failed to clear cmd_rsp_addr_lo\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "cmd_done: failed to clear cmd_rsp_addr_lo\n");
                        return -1;
                }
                /* Write the upper 32bits of the cmdrsp buffer physical
                   address */
                if (mwifiex_write_reg(adapter, reg->cmdrsp_addr_hi, 0)) {
-                       dev_err(adapter->dev,
-                               "cmd_done: failed to clear cmd_rsp_addr_hi\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "cmd_done: failed to clear cmd_rsp_addr_hi\n");
                        return -1;
                }
        }
@@ -1678,25 +1706,28 @@ static int mwifiex_pcie_process_event_ready(struct mwifiex_adapter *adapter)
                mwifiex_pm_wakeup_card(adapter);
 
        if (adapter->event_received) {
-               dev_dbg(adapter->dev, "info: Event being processed, "
-                       "do not process this interrupt just yet\n");
+               mwifiex_dbg(adapter, EVENT,
+                           "info: Event being processed,\t"
+                           "do not process this interrupt just yet\n");
                return 0;
        }
 
        if (rdptr >= MWIFIEX_MAX_EVT_BD) {
-               dev_dbg(adapter->dev, "info: Invalid read pointer...\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "info: Invalid read pointer...\n");
                return -1;
        }
 
        /* Read the event ring write pointer set by firmware */
        if (mwifiex_read_reg(adapter, reg->evt_wrptr, &wrptr)) {
-               dev_err(adapter->dev,
-                       "EventReady: failed to read reg->evt_wrptr\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "EventReady: failed to read reg->evt_wrptr\n");
                return -1;
        }
 
-       dev_dbg(adapter->dev, "info: EventReady: Initial <Rd: 0x%x, Wr: 0x%x>",
-               card->evtbd_rdptr, wrptr);
+       mwifiex_dbg(adapter, EVENT,
+                   "info: EventReady: Initial <Rd: 0x%x, Wr: 0x%x>",
+                   card->evtbd_rdptr, wrptr);
        if (((wrptr & MWIFIEX_EVTBD_MASK) != (card->evtbd_rdptr
                                              & MWIFIEX_EVTBD_MASK)) ||
            ((wrptr & reg->evt_rollover_ind) ==
@@ -1705,7 +1736,8 @@ static int mwifiex_pcie_process_event_ready(struct mwifiex_adapter *adapter)
                __le16 data_len = 0;
                u16 evt_len;
 
-               dev_dbg(adapter->dev, "info: Read Index: %d\n", rdptr);
+               mwifiex_dbg(adapter, INFO,
+                           "info: Read Index: %d\n", rdptr);
                skb_cmd = card->evt_buf_list[rdptr];
                mwifiex_unmap_pci_memory(adapter, skb_cmd, PCI_DMA_FROMDEVICE);
 
@@ -1721,9 +1753,10 @@ static int mwifiex_pcie_process_event_ready(struct mwifiex_adapter *adapter)
                   len is 2 bytes followed by type which is 2 bytes */
                memcpy(&data_len, skb_cmd->data, sizeof(__le16));
                evt_len = le16_to_cpu(data_len);
-
+               skb_trim(skb_cmd, evt_len);
                skb_pull(skb_cmd, INTF_HEADER_LEN);
-               dev_dbg(adapter->dev, "info: Event length: %d\n", evt_len);
+               mwifiex_dbg(adapter, EVENT,
+                           "info: Event length: %d\n", evt_len);
 
                if ((evt_len > 0) && (evt_len  < MAX_EVENT_SIZE))
                        memcpy(adapter->event_body, skb_cmd->data +
@@ -1740,8 +1773,8 @@ static int mwifiex_pcie_process_event_ready(struct mwifiex_adapter *adapter)
        } else {
                if (mwifiex_write_reg(adapter, PCIE_CPU_INT_EVENT,
                                      CPU_INTR_EVENT_DONE)) {
-                       dev_warn(adapter->dev,
-                                "Write register failed\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "Write register failed\n");
                        return -1;
                }
        }
@@ -1766,20 +1799,22 @@ static int mwifiex_pcie_event_complete(struct mwifiex_adapter *adapter,
                return 0;
 
        if (rdptr >= MWIFIEX_MAX_EVT_BD) {
-               dev_err(adapter->dev, "event_complete: Invalid rdptr 0x%x\n",
-                       rdptr);
+               mwifiex_dbg(adapter, ERROR,
+                           "event_complete: Invalid rdptr 0x%x\n",
+                           rdptr);
                return -EINVAL;
        }
 
        /* Read the event ring write pointer set by firmware */
        if (mwifiex_read_reg(adapter, reg->evt_wrptr, &wrptr)) {
-               dev_err(adapter->dev,
-                       "event_complete: failed to read reg->evt_wrptr\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "event_complete: failed to read reg->evt_wrptr\n");
                return -1;
        }
 
        if (!card->evt_buf_list[rdptr]) {
                skb_push(skb, INTF_HEADER_LEN);
+               skb_put(skb, MAX_EVENT_SIZE - skb->len);
                if (mwifiex_map_pci_memory(adapter, skb,
                                           MAX_EVENT_SIZE,
                                           PCI_DMA_FROMDEVICE))
@@ -1791,9 +1826,9 @@ static int mwifiex_pcie_event_complete(struct mwifiex_adapter *adapter,
                desc->flags = 0;
                skb = NULL;
        } else {
-               dev_dbg(adapter->dev,
-                       "info: ERROR: buf still valid at index %d, <%p, %p>\n",
-                       rdptr, card->evt_buf_list[rdptr], skb);
+               mwifiex_dbg(adapter, ERROR,
+                           "info: ERROR: buf still valid at index %d, <%p, %p>\n",
+                           rdptr, card->evt_buf_list[rdptr], skb);
        }
 
        if ((++card->evtbd_rdptr & MWIFIEX_EVTBD_MASK) == MWIFIEX_MAX_EVT_BD) {
@@ -1802,18 +1837,20 @@ static int mwifiex_pcie_event_complete(struct mwifiex_adapter *adapter,
                                        reg->evt_rollover_ind);
        }
 
-       dev_dbg(adapter->dev, "info: Updated <Rd: 0x%x, Wr: 0x%x>",
-               card->evtbd_rdptr, wrptr);
+       mwifiex_dbg(adapter, EVENT,
+                   "info: Updated <Rd: 0x%x, Wr: 0x%x>",
+                   card->evtbd_rdptr, wrptr);
 
        /* Write the event ring read pointer in to reg->evt_rdptr */
        if (mwifiex_write_reg(adapter, reg->evt_rdptr,
                              card->evtbd_rdptr)) {
-               dev_err(adapter->dev,
-                       "event_complete: failed to read reg->evt_rdptr\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "event_complete: failed to read reg->evt_rdptr\n");
                return -1;
        }
 
-       dev_dbg(adapter->dev, "info: Check Events Again\n");
+       mwifiex_dbg(adapter, EVENT,
+                   "info: Check Events Again\n");
        ret = mwifiex_pcie_process_event_ready(adapter);
 
        return ret;
@@ -1840,17 +1877,18 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
        const struct mwifiex_pcie_card_reg *reg = card->pcie.reg;
 
        if (!firmware || !firmware_len) {
-               dev_err(adapter->dev,
-                       "No firmware image found! Terminating download\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "No firmware image found! Terminating download\n");
                return -1;
        }
 
-       dev_dbg(adapter->dev, "info: Downloading FW image (%d bytes)\n",
-               firmware_len);
+       mwifiex_dbg(adapter, INFO,
+                   "info: Downloading FW image (%d bytes)\n",
+                   firmware_len);
 
        if (mwifiex_pcie_disable_host_int(adapter)) {
-               dev_err(adapter->dev,
-                       "%s: Disabling interrupts failed.\n", __func__);
+               mwifiex_dbg(adapter, ERROR,
+                           "%s: Disabling interrupts failed.\n", __func__);
                return -1;
        }
 
@@ -1872,8 +1910,8 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
                        ret = mwifiex_read_reg(adapter, reg->cmd_size,
                                               &len);
                        if (ret) {
-                               dev_warn(adapter->dev,
-                                        "Failed reading len from boot code\n");
+                               mwifiex_dbg(adapter, FATAL,
+                                           "Failed reading len from boot code\n");
                                goto done;
                        }
                        if (len)
@@ -1884,8 +1922,9 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
                if (!len) {
                        break;
                } else if (len > MWIFIEX_UPLD_SIZE) {
-                       pr_err("FW download failure @ %d, invalid length %d\n",
-                              offset, len);
+                       mwifiex_dbg(adapter, ERROR,
+                                   "FW download failure @ %d, invalid length %d\n",
+                                   offset, len);
                        ret = -1;
                        goto done;
                }
@@ -1895,14 +1934,16 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
                if (len & BIT(0)) {
                        block_retry_cnt++;
                        if (block_retry_cnt > MAX_WRITE_IOMEM_RETRY) {
-                               pr_err("FW download failure @ %d, over max "
-                                      "retry count\n", offset);
+                               mwifiex_dbg(adapter, ERROR,
+                                           "FW download failure @ %d, over max\t"
+                                           "retry count\n", offset);
                                ret = -1;
                                goto done;
                        }
-                       dev_err(adapter->dev, "FW CRC error indicated by the "
-                               "helper: len = 0x%04X, txlen = %d\n",
-                               len, txlen);
+                       mwifiex_dbg(adapter, ERROR,
+                                   "FW CRC error indicated by the\t"
+                                   "helper: len = 0x%04X, txlen = %d\n",
+                                   len, txlen);
                        len &= ~BIT(0);
                        /* Setting this to 0 to resend from same offset */
                        txlen = 0;
@@ -1913,7 +1954,7 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
                        if (firmware_len - offset < txlen)
                                txlen = firmware_len - offset;
 
-                       dev_dbg(adapter->dev, ".");
+                       mwifiex_dbg(adapter, INFO, ".");
 
                        tx_blocks = (txlen + card->pcie.blksz_fw_dl - 1) /
                                    card->pcie.blksz_fw_dl;
@@ -1927,8 +1968,8 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
 
                /* Send the boot command to device */
                if (mwifiex_pcie_send_boot_cmd(adapter, skb)) {
-                       dev_err(adapter->dev,
-                               "Failed to send firmware download command\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "Failed to send firmware download command\n");
                        ret = -1;
                        goto done;
                }
@@ -1937,9 +1978,10 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
                do {
                        if (mwifiex_read_reg(adapter, PCIE_CPU_INT_STATUS,
                                             &ireg_intr)) {
-                               dev_err(adapter->dev, "%s: Failed to read "
-                                       "interrupt status during fw dnld.\n",
-                                       __func__);
+                               mwifiex_dbg(adapter, ERROR,
+                                           "%s: Failed to read\t"
+                                           "interrupt status during fw dnld.\n",
+                                           __func__);
                                mwifiex_unmap_pci_memory(adapter, skb,
                                                         PCI_DMA_TODEVICE);
                                ret = -1;
@@ -1953,8 +1995,8 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
                offset += txlen;
        } while (true);
 
-       dev_notice(adapter->dev,
-                  "info: FW download over, size %d bytes\n", offset);
+       mwifiex_dbg(adapter, MSG,
+                   "info: FW download over, size %d bytes\n", offset);
 
        ret = 0;
 
@@ -1980,15 +2022,17 @@ mwifiex_check_fw_status(struct mwifiex_adapter *adapter, u32 poll_num)
        /* Mask spurios interrupts */
        if (mwifiex_write_reg(adapter, PCIE_HOST_INT_STATUS_MASK,
                              HOST_INTR_MASK)) {
-               dev_warn(adapter->dev, "Write register failed\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "Write register failed\n");
                return -1;
        }
 
-       dev_dbg(adapter->dev, "Setting driver ready signature\n");
+       mwifiex_dbg(adapter, INFO,
+                   "Setting driver ready signature\n");
        if (mwifiex_write_reg(adapter, reg->drv_rdy,
                              FIRMWARE_READY_PCIE)) {
-               dev_err(adapter->dev,
-                       "Failed to write driver ready signature\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "Failed to write driver ready signature\n");
                return -1;
        }
 
@@ -2015,12 +2059,13 @@ mwifiex_check_fw_status(struct mwifiex_adapter *adapter, u32 poll_num)
                                     &winner_status))
                        ret = -1;
                else if (!winner_status) {
-                       dev_err(adapter->dev, "PCI-E is the winner\n");
+                       mwifiex_dbg(adapter, INFO,
+                                   "PCI-E is the winner\n");
                        adapter->winner = 1;
                } else {
-                       dev_err(adapter->dev,
-                               "PCI-E is not the winner <%#x,%d>, exit dnld\n",
-                               ret, adapter->winner);
+                       mwifiex_dbg(adapter, ERROR,
+                                   "PCI-E is not the winner <%#x,%d>, exit dnld\n",
+                                   ret, adapter->winner);
                }
        }
 
@@ -2039,7 +2084,7 @@ static void mwifiex_interrupt_status(struct mwifiex_adapter *adapter)
                return;
 
        if (mwifiex_read_reg(adapter, PCIE_HOST_INT_STATUS, &pcie_ireg)) {
-               dev_warn(adapter->dev, "Read register failed\n");
+               mwifiex_dbg(adapter, ERROR, "Read register failed\n");
                return;
        }
 
@@ -2050,7 +2095,8 @@ static void mwifiex_interrupt_status(struct mwifiex_adapter *adapter)
                /* Clear the pending interrupts */
                if (mwifiex_write_reg(adapter, PCIE_HOST_INT_STATUS,
                                      ~pcie_ireg)) {
-                       dev_warn(adapter->dev, "Write register failed\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "Write register failed\n");
                        return;
                }
                spin_lock_irqsave(&adapter->int_lock, flags);
@@ -2133,21 +2179,24 @@ static int mwifiex_process_int_status(struct mwifiex_adapter *adapter)
        while (pcie_ireg & HOST_INTR_MASK) {
                if (pcie_ireg & HOST_INTR_DNLD_DONE) {
                        pcie_ireg &= ~HOST_INTR_DNLD_DONE;
-                       dev_dbg(adapter->dev, "info: TX DNLD Done\n");
+                       mwifiex_dbg(adapter, INTR,
+                                   "info: TX DNLD Done\n");
                        ret = mwifiex_pcie_send_data_complete(adapter);
                        if (ret)
                                return ret;
                }
                if (pcie_ireg & HOST_INTR_UPLD_RDY) {
                        pcie_ireg &= ~HOST_INTR_UPLD_RDY;
-                       dev_dbg(adapter->dev, "info: Rx DATA\n");
+                       mwifiex_dbg(adapter, INTR,
+                                   "info: Rx DATA\n");
                        ret = mwifiex_pcie_process_recv_data(adapter);
                        if (ret)
                                return ret;
                }
                if (pcie_ireg & HOST_INTR_EVENT_RDY) {
                        pcie_ireg &= ~HOST_INTR_EVENT_RDY;
-                       dev_dbg(adapter->dev, "info: Rx EVENT\n");
+                       mwifiex_dbg(adapter, INTR,
+                                   "info: Rx EVENT\n");
                        ret = mwifiex_pcie_process_event_ready(adapter);
                        if (ret)
                                return ret;
@@ -2156,8 +2205,8 @@ static int mwifiex_process_int_status(struct mwifiex_adapter *adapter)
                if (pcie_ireg & HOST_INTR_CMD_DONE) {
                        pcie_ireg &= ~HOST_INTR_CMD_DONE;
                        if (adapter->cmd_sent) {
-                               dev_dbg(adapter->dev,
-                                       "info: CMD sent Interrupt\n");
+                               mwifiex_dbg(adapter, INTR,
+                                           "info: CMD sent Interrupt\n");
                                adapter->cmd_sent = false;
                        }
                        /* Handle command response */
@@ -2169,8 +2218,8 @@ static int mwifiex_process_int_status(struct mwifiex_adapter *adapter)
                if (mwifiex_pcie_ok_to_access_hw(adapter)) {
                        if (mwifiex_read_reg(adapter, PCIE_HOST_INT_STATUS,
                                             &pcie_ireg)) {
-                               dev_warn(adapter->dev,
-                                        "Read register failed\n");
+                               mwifiex_dbg(adapter, ERROR,
+                                           "Read register failed\n");
                                return -1;
                        }
 
@@ -2178,16 +2227,17 @@ static int mwifiex_process_int_status(struct mwifiex_adapter *adapter)
                                if (mwifiex_write_reg(adapter,
                                                      PCIE_HOST_INT_STATUS,
                                                      ~pcie_ireg)) {
-                                       dev_warn(adapter->dev,
-                                                "Write register failed\n");
+                                       mwifiex_dbg(adapter, ERROR,
+                                                   "Write register failed\n");
                                        return -1;
                                }
                        }
 
                }
        }
-       dev_dbg(adapter->dev, "info: cmd_sent=%d data_sent=%d\n",
-               adapter->cmd_sent, adapter->data_sent);
+       mwifiex_dbg(adapter, INTR,
+                   "info: cmd_sent=%d data_sent=%d\n",
+                   adapter->cmd_sent, adapter->data_sent);
        if (adapter->ps_state != PS_STATE_SLEEP)
                mwifiex_pcie_enable_host_int(adapter);
 
@@ -2209,7 +2259,8 @@ static int mwifiex_pcie_host_to_card(struct mwifiex_adapter *adapter, u8 type,
                                     struct mwifiex_tx_param *tx_param)
 {
        if (!skb) {
-               dev_err(adapter->dev, "Passed NULL skb to %s\n", __func__);
+               mwifiex_dbg(adapter, ERROR,
+                           "Passed NULL skb to %s\n", __func__);
                return -1;
        }
 
@@ -2232,7 +2283,8 @@ mwifiex_pcie_rdwr_firmware(struct mwifiex_adapter *adapter, u8 doneflag)
 
        ret = mwifiex_write_reg(adapter, reg->fw_dump_ctrl, FW_DUMP_HOST_READY);
        if (ret) {
-               dev_err(adapter->dev, "PCIE write err\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "PCIE write err\n");
                return RDWR_STATUS_FAILURE;
        }
 
@@ -2243,24 +2295,25 @@ mwifiex_pcie_rdwr_firmware(struct mwifiex_adapter *adapter, u8 doneflag)
                if (doneflag && ctrl_data == doneflag)
                        return RDWR_STATUS_DONE;
                if (ctrl_data != FW_DUMP_HOST_READY) {
-                       dev_info(adapter->dev,
-                                "The ctrl reg was changed, re-try again!\n");
+                       mwifiex_dbg(adapter, WARN,
+                                   "The ctrl reg was changed, re-try again!\n");
                        ret = mwifiex_write_reg(adapter, reg->fw_dump_ctrl,
                                                FW_DUMP_HOST_READY);
                        if (ret) {
-                               dev_err(adapter->dev, "PCIE write err\n");
+                               mwifiex_dbg(adapter, ERROR,
+                                           "PCIE write err\n");
                                return RDWR_STATUS_FAILURE;
                        }
                }
                usleep_range(100, 200);
        }
 
-       dev_err(adapter->dev, "Fail to pull ctrl_data\n");
+       mwifiex_dbg(adapter, ERROR, "Fail to pull ctrl_data\n");
        return RDWR_STATUS_FAILURE;
 }
 
 /* This function dump firmware memory to file */
-static void mwifiex_pcie_fw_dump_work(struct mwifiex_adapter *adapter)
+static void mwifiex_pcie_fw_dump(struct mwifiex_adapter *adapter)
 {
        struct pcie_service_card *card = adapter->card;
        const struct mwifiex_pcie_card_reg *creg = card->pcie.reg;
@@ -2269,7 +2322,6 @@ static void mwifiex_pcie_fw_dump_work(struct mwifiex_adapter *adapter)
        enum rdwr_status stat;
        u32 memory_size;
        int ret;
-       static char *env[] = { "DRIVER=mwifiex_pcie", "EVENT=fw_dump", NULL };
 
        if (!card->pcie.can_dump_fw)
                return;
@@ -2284,12 +2336,12 @@ static void mwifiex_pcie_fw_dump_work(struct mwifiex_adapter *adapter)
                entry->mem_size = 0;
        }
 
-       dev_info(adapter->dev, "== mwifiex firmware dump start ==\n");
+       mwifiex_dbg(adapter, DUMP, "== mwifiex firmware dump start ==\n");
 
        /* Read the number of the memories which will dump */
        stat = mwifiex_pcie_rdwr_firmware(adapter, doneflag);
        if (stat == RDWR_STATUS_FAILURE)
-               goto done;
+               return;
 
        reg = creg->fw_dump_start;
        mwifiex_read_reg_byte(adapter, reg, &dump_num);
@@ -2300,7 +2352,7 @@ static void mwifiex_pcie_fw_dump_work(struct mwifiex_adapter *adapter)
 
                stat = mwifiex_pcie_rdwr_firmware(adapter, doneflag);
                if (stat == RDWR_STATUS_FAILURE)
-                       goto done;
+                       return;
 
                memory_size = 0;
                reg = creg->fw_dump_start;
@@ -2311,36 +2363,36 @@ static void mwifiex_pcie_fw_dump_work(struct mwifiex_adapter *adapter)
                }
 
                if (memory_size == 0) {
-                       dev_info(adapter->dev, "Firmware dump Finished!\n");
+                       mwifiex_dbg(adapter, MSG, "Firmware dump Finished!\n");
                        ret = mwifiex_write_reg(adapter, creg->fw_dump_ctrl,
                                                FW_DUMP_READ_DONE);
                        if (ret) {
-                               dev_err(adapter->dev, "PCIE write err\n");
-                               goto done;
+                               mwifiex_dbg(adapter, ERROR, "PCIE write err\n");
+                               return;
                        }
                        break;
                }
 
-               dev_info(adapter->dev,
-                        "%s_SIZE=0x%x\n", entry->mem_name, memory_size);
+               mwifiex_dbg(adapter, DUMP,
+                           "%s_SIZE=0x%x\n", entry->mem_name, memory_size);
                entry->mem_ptr = vmalloc(memory_size + 1);
                entry->mem_size = memory_size;
                if (!entry->mem_ptr) {
-                       dev_err(adapter->dev,
-                               "Vmalloc %s failed\n", entry->mem_name);
-                       goto done;
+                       mwifiex_dbg(adapter, ERROR,
+                                   "Vmalloc %s failed\n", entry->mem_name);
+                       return;
                }
                dbg_ptr = entry->mem_ptr;
                end_ptr = dbg_ptr + memory_size;
 
                doneflag = entry->done_flag;
-               dev_info(adapter->dev, "Start %s output, please wait...\n",
-                        entry->mem_name);
+               mwifiex_dbg(adapter, DUMP, "Start %s output, please wait...\n",
+                           entry->mem_name);
 
                do {
                        stat = mwifiex_pcie_rdwr_firmware(adapter, doneflag);
                        if (RDWR_STATUS_FAILURE == stat)
-                               goto done;
+                               return;
 
                        reg_start = creg->fw_dump_start;
                        reg_end = creg->fw_dump_end;
@@ -2349,46 +2401,49 @@ static void mwifiex_pcie_fw_dump_work(struct mwifiex_adapter *adapter)
                                if (dbg_ptr < end_ptr) {
                                        dbg_ptr++;
                                } else {
-                                       dev_err(adapter->dev,
-                                               "Allocated buf not enough\n");
-                                       goto done;
+                                       mwifiex_dbg(adapter, ERROR,
+                                                   "Allocated buf not enough\n");
+                                       return;
                                }
                        }
 
                        if (stat != RDWR_STATUS_DONE)
                                continue;
 
-                       dev_info(adapter->dev, "%s done: size=0x%tx\n",
-                                entry->mem_name, dbg_ptr - entry->mem_ptr);
+                       mwifiex_dbg(adapter, DUMP,
+                                   "%s done: size=0x%tx\n",
+                                   entry->mem_name, dbg_ptr - entry->mem_ptr);
                        break;
                } while (true);
        }
-       dev_info(adapter->dev, "== mwifiex firmware dump end ==\n");
-
-       kobject_uevent_env(&adapter->wiphy->dev.kobj, KOBJ_CHANGE, env);
+       mwifiex_dbg(adapter, DUMP, "== mwifiex firmware dump end ==\n");
+}
 
-done:
-       adapter->curr_mem_idx = 0;
+static void mwifiex_pcie_device_dump_work(struct mwifiex_adapter *adapter)
+{
+       mwifiex_drv_info_dump(adapter);
+       mwifiex_pcie_fw_dump(adapter);
+       mwifiex_upload_device_dump(adapter);
 }
 
 static unsigned long iface_work_flags;
 static struct mwifiex_adapter *save_adapter;
 static void mwifiex_pcie_work(struct work_struct *work)
 {
-       if (test_and_clear_bit(MWIFIEX_IFACE_WORK_FW_DUMP,
+       if (test_and_clear_bit(MWIFIEX_IFACE_WORK_DEVICE_DUMP,
                               &iface_work_flags))
-               mwifiex_pcie_fw_dump_work(save_adapter);
+               mwifiex_pcie_device_dump_work(save_adapter);
 }
 
 static DECLARE_WORK(pcie_work, mwifiex_pcie_work);
 /* This function dumps FW information */
-static void mwifiex_pcie_fw_dump(struct mwifiex_adapter *adapter)
+static void mwifiex_pcie_device_dump(struct mwifiex_adapter *adapter)
 {
        save_adapter = adapter;
-       if (test_bit(MWIFIEX_IFACE_WORK_FW_DUMP, &iface_work_flags))
+       if (test_bit(MWIFIEX_IFACE_WORK_DEVICE_DUMP, &iface_work_flags))
                return;
 
-       set_bit(MWIFIEX_IFACE_WORK_FW_DUMP, &iface_work_flags);
+       set_bit(MWIFIEX_IFACE_WORK_DEVICE_DUMP, &iface_work_flags);
 
        schedule_work(&pcie_work);
 }
@@ -2418,45 +2473,50 @@ static int mwifiex_pcie_init(struct mwifiex_adapter *adapter)
 
        pci_set_master(pdev);
 
-       dev_dbg(adapter->dev, "try set_consistent_dma_mask(32)\n");
+       mwifiex_dbg(adapter, INFO,
+                   "try set_consistent_dma_mask(32)\n");
        ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
        if (ret) {
-               dev_err(adapter->dev, "set_dma_mask(32) failed\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "set_dma_mask(32) failed\n");
                goto err_set_dma_mask;
        }
 
        ret = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
        if (ret) {
-               dev_err(adapter->dev, "set_consistent_dma_mask(64) failed\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "set_consistent_dma_mask(64) failed\n");
                goto err_set_dma_mask;
        }
 
        ret = pci_request_region(pdev, 0, DRV_NAME);
        if (ret) {
-               dev_err(adapter->dev, "req_reg(0) error\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "req_reg(0) error\n");
                goto err_req_region0;
        }
        card->pci_mmap = pci_iomap(pdev, 0, 0);
        if (!card->pci_mmap) {
-               dev_err(adapter->dev, "iomap(0) error\n");
+               mwifiex_dbg(adapter, ERROR, "iomap(0) error\n");
                ret = -EIO;
                goto err_iomap0;
        }
        ret = pci_request_region(pdev, 2, DRV_NAME);
        if (ret) {
-               dev_err(adapter->dev, "req_reg(2) error\n");
+               mwifiex_dbg(adapter, ERROR, "req_reg(2) error\n");
                goto err_req_region2;
        }
        card->pci_mmap1 = pci_iomap(pdev, 2, 0);
        if (!card->pci_mmap1) {
-               dev_err(adapter->dev, "iomap(2) error\n");
+               mwifiex_dbg(adapter, ERROR,
+                           "iomap(2) error\n");
                ret = -EIO;
                goto err_iomap2;
        }
 
-       dev_dbg(adapter->dev,
-               "PCI memory map Virt0: %p PCI memory map Virt2: %p\n",
-               card->pci_mmap, card->pci_mmap1);
+       mwifiex_dbg(adapter, INFO,
+                   "PCI memory map Virt0: %p PCI memory map Virt2: %p\n",
+                   card->pci_mmap, card->pci_mmap1);
 
        card->cmdrsp_buf = NULL;
        ret = mwifiex_pcie_create_txbd_ring(adapter);
@@ -2521,10 +2581,11 @@ static void mwifiex_pcie_cleanup(struct mwifiex_adapter *adapter)
        const struct mwifiex_pcie_card_reg *reg = card->pcie.reg;
 
        if (user_rmmod) {
-               dev_dbg(adapter->dev, "Clearing driver ready signature\n");
+               mwifiex_dbg(adapter, INFO,
+                           "Clearing driver ready signature\n");
                if (mwifiex_write_reg(adapter, reg->drv_rdy, 0x00000000))
-                       dev_err(adapter->dev,
-                               "Failed to write driver not-ready signature\n");
+                       mwifiex_dbg(adapter, ERROR,
+                                   "Failed to write driver not-ready signature\n");
        }
 
        if (pdev) {
@@ -2555,7 +2616,8 @@ static int mwifiex_register_dev(struct mwifiex_adapter *adapter)
        ret = request_irq(pdev->irq, mwifiex_pcie_interrupt, IRQF_SHARED,
                          "MRVL_PCIE", pdev);
        if (ret) {
-               pr_err("request_irq failed: ret=%d\n", ret);
+               mwifiex_dbg(adapter, ERROR,
+                           "request_irq failed: ret=%d\n", ret);
                adapter->card = NULL;
                return -1;
        }
@@ -2582,7 +2644,8 @@ static void mwifiex_unregister_dev(struct mwifiex_adapter *adapter)
        const struct mwifiex_pcie_card_reg *reg;
 
        if (card) {
-               dev_dbg(adapter->dev, "%s(): calling free_irq()\n", __func__);
+               mwifiex_dbg(adapter, INFO,
+                           "%s(): calling free_irq()\n", __func__);
                free_irq(card->dev->irq, card->dev);
 
                reg = card->pcie.reg;
@@ -2617,7 +2680,7 @@ static struct mwifiex_if_ops pcie_ops = {
        .cleanup_mpa_buf =              NULL,
        .init_fw_port =                 mwifiex_pcie_init_fw_port,
        .clean_pcie_ring =              mwifiex_clean_pcie_ring_buf,
-       .fw_dump =                      mwifiex_pcie_fw_dump,
+       .device_dump =                  mwifiex_pcie_device_dump,
 };
 
 /*
@@ -2676,3 +2739,4 @@ MODULE_VERSION(PCIE_VERSION);
 MODULE_LICENSE("GPL v2");
 MODULE_FIRMWARE(PCIE8766_DEFAULT_FW_NAME);
 MODULE_FIRMWARE(PCIE8897_DEFAULT_FW_NAME);
+MODULE_FIRMWARE(PCIE8997_DEFAULT_FW_NAME);