These changes are the raw update to linux-4.4.6-rt14. Kernel sources
[kvmfornfv.git] / kernel / drivers / mfd / arizona-core.c
index 6523903..d474732 100644 (file)
 #include <linux/regulator/consumer.h>
 #include <linux/regulator/machine.h>
 #include <linux/slab.h>
+#include <linux/platform_device.h>
 
 #include <linux/mfd/arizona/core.h>
 #include <linux/mfd/arizona/registers.h>
 
 #include "arizona.h"
 
-static const char *wm5102_core_supplies[] = {
+static const char * const wm5102_core_supplies[] = {
        "AVDD",
        "DBVDD1",
 };
@@ -69,8 +70,6 @@ EXPORT_SYMBOL_GPL(arizona_clk32k_enable);
 
 int arizona_clk32k_disable(struct arizona *arizona)
 {
-       int ret = 0;
-
        mutex_lock(&arizona->clk_lock);
 
        BUG_ON(arizona->clk32k_ref <= 0);
@@ -90,7 +89,7 @@ int arizona_clk32k_disable(struct arizona *arizona)
 
        mutex_unlock(&arizona->clk_lock);
 
-       return ret;
+       return 0;
 }
 EXPORT_SYMBOL_GPL(arizona_clk32k_disable);
 
@@ -146,17 +145,31 @@ static irqreturn_t arizona_underclocked(int irq, void *data)
 static irqreturn_t arizona_overclocked(int irq, void *data)
 {
        struct arizona *arizona = data;
-       unsigned int val[2];
+       unsigned int val[3];
        int ret;
-       
+
        ret = regmap_bulk_read(arizona->regmap, ARIZONA_INTERRUPT_RAW_STATUS_6,
-                              &val[0], 2);
+                              &val[0], 3);
        if (ret != 0) {
                dev_err(arizona->dev, "Failed to read overclock status: %d\n",
                        ret);
                return IRQ_NONE;
        }
 
+       switch (arizona->type) {
+       case WM8998:
+       case WM1814:
+               /* Some bits are shifted on WM8998,
+                * rearrange to match the standard bit layout
+                */
+               val[0] = ((val[0] & 0x60e0) >> 1) |
+                        ((val[0] & 0x1e00) >> 2) |
+                        (val[0] & 0x000f);
+               break;
+       default:
+               break;
+       }
+
        if (val[0] & ARIZONA_PWM_OVERCLOCKED_STS)
                dev_err(arizona->dev, "PWM overclocked\n");
        if (val[0] & ARIZONA_FX_CORE_OVERCLOCKED_STS)
@@ -201,6 +214,9 @@ static irqreturn_t arizona_overclocked(int irq, void *data)
        if (val[1] & ARIZONA_ISRC1_OVERCLOCKED_STS)
                dev_err(arizona->dev, "ISRC1 overclocked\n");
 
+       if (val[2] & ARIZONA_SPDIF_OVERCLOCKED_STS)
+               dev_err(arizona->dev, "SPDIF overclocked\n");
+
        return IRQ_HANDLED;
 }
 
@@ -250,20 +266,50 @@ static int arizona_wait_for_boot(struct arizona *arizona)
        return ret;
 }
 
-static int arizona_apply_hardware_patch(struct arizona* arizona)
+static inline void arizona_enable_reset(struct arizona *arizona)
+{
+       if (arizona->pdata.reset)
+               gpio_set_value_cansleep(arizona->pdata.reset, 0);
+}
+
+static void arizona_disable_reset(struct arizona *arizona)
+{
+       if (arizona->pdata.reset) {
+               switch (arizona->type) {
+               case WM5110:
+               case WM8280:
+                       /* Meet requirements for minimum reset duration */
+                       msleep(5);
+                       break;
+               default:
+                       break;
+               }
+
+               gpio_set_value_cansleep(arizona->pdata.reset, 1);
+               msleep(1);
+       }
+}
+
+struct arizona_sysclk_state {
+       unsigned int fll;
+       unsigned int sysclk;
+};
+
+static int arizona_enable_freerun_sysclk(struct arizona *arizona,
+                                        struct arizona_sysclk_state *state)
 {
-       unsigned int fll, sysclk;
        int ret, err;
 
        /* Cache existing FLL and SYSCLK settings */
-       ret = regmap_read(arizona->regmap, ARIZONA_FLL1_CONTROL_1, &fll);
-       if (ret != 0) {
+       ret = regmap_read(arizona->regmap, ARIZONA_FLL1_CONTROL_1, &state->fll);
+       if (ret) {
                dev_err(arizona->dev, "Failed to cache FLL settings: %d\n",
                        ret);
                return ret;
        }
-       ret = regmap_read(arizona->regmap, ARIZONA_SYSTEM_CLOCK_1, &sysclk);
-       if (ret != 0) {
+       ret = regmap_read(arizona->regmap, ARIZONA_SYSTEM_CLOCK_1,
+                         &state->sysclk);
+       if (ret) {
                dev_err(arizona->dev, "Failed to cache SYSCLK settings: %d\n",
                        ret);
                return ret;
@@ -272,7 +318,7 @@ static int arizona_apply_hardware_patch(struct arizona* arizona)
        /* Start up SYSCLK using the FLL in free running mode */
        ret = regmap_write(arizona->regmap, ARIZONA_FLL1_CONTROL_1,
                        ARIZONA_FLL1_ENA | ARIZONA_FLL1_FREERUN);
-       if (ret != 0) {
+       if (ret) {
                dev_err(arizona->dev,
                        "Failed to start FLL in freerunning mode: %d\n",
                        ret);
@@ -281,56 +327,184 @@ static int arizona_apply_hardware_patch(struct arizona* arizona)
        ret = arizona_poll_reg(arizona, 25, ARIZONA_INTERRUPT_RAW_STATUS_5,
                               ARIZONA_FLL1_CLOCK_OK_STS,
                               ARIZONA_FLL1_CLOCK_OK_STS);
-       if (ret != 0) {
+       if (ret) {
                ret = -ETIMEDOUT;
                goto err_fll;
        }
 
        ret = regmap_write(arizona->regmap, ARIZONA_SYSTEM_CLOCK_1, 0x0144);
-       if (ret != 0) {
+       if (ret) {
                dev_err(arizona->dev, "Failed to start SYSCLK: %d\n", ret);
                goto err_fll;
        }
 
+       return 0;
+
+err_fll:
+       err = regmap_write(arizona->regmap, ARIZONA_FLL1_CONTROL_1, state->fll);
+       if (err)
+               dev_err(arizona->dev,
+                       "Failed to re-apply old FLL settings: %d\n", err);
+
+       return ret;
+}
+
+static int arizona_disable_freerun_sysclk(struct arizona *arizona,
+                                         struct arizona_sysclk_state *state)
+{
+       int ret;
+
+       ret = regmap_write(arizona->regmap, ARIZONA_SYSTEM_CLOCK_1,
+                          state->sysclk);
+       if (ret) {
+               dev_err(arizona->dev,
+                       "Failed to re-apply old SYSCLK settings: %d\n", ret);
+               return ret;
+       }
+
+       ret = regmap_write(arizona->regmap, ARIZONA_FLL1_CONTROL_1, state->fll);
+       if (ret) {
+               dev_err(arizona->dev,
+                       "Failed to re-apply old FLL settings: %d\n", ret);
+               return ret;
+       }
+
+       return 0;
+}
+
+static int wm5102_apply_hardware_patch(struct arizona *arizona)
+{
+       struct arizona_sysclk_state state;
+       int err, ret;
+
+       ret = arizona_enable_freerun_sysclk(arizona, &state);
+       if (ret)
+               return ret;
+
        /* Start the write sequencer and wait for it to finish */
        ret = regmap_write(arizona->regmap, ARIZONA_WRITE_SEQUENCER_CTRL_0,
-                       ARIZONA_WSEQ_ENA | ARIZONA_WSEQ_START | 160);
-       if (ret != 0) {
+                          ARIZONA_WSEQ_ENA | ARIZONA_WSEQ_START | 160);
+       if (ret) {
                dev_err(arizona->dev, "Failed to start write sequencer: %d\n",
                        ret);
-               goto err_sysclk;
+               goto err;
        }
+
        ret = arizona_poll_reg(arizona, 5, ARIZONA_WRITE_SEQUENCER_CTRL_1,
                               ARIZONA_WSEQ_BUSY, 0);
-       if (ret != 0) {
+       if (ret) {
                regmap_write(arizona->regmap, ARIZONA_WRITE_SEQUENCER_CTRL_0,
-                               ARIZONA_WSEQ_ABORT);
+                            ARIZONA_WSEQ_ABORT);
                ret = -ETIMEDOUT;
        }
 
-err_sysclk:
-       err = regmap_write(arizona->regmap, ARIZONA_SYSTEM_CLOCK_1, sysclk);
-       if (err != 0) {
+err:
+       err = arizona_disable_freerun_sysclk(arizona, &state);
+
+       return ret ?: err;
+}
+
+/*
+ * Register patch to some of the CODECs internal write sequences
+ * to ensure a clean exit from the low power sleep state.
+ */
+static const struct reg_sequence wm5110_sleep_patch[] = {
+       { 0x337A, 0xC100 },
+       { 0x337B, 0x0041 },
+       { 0x3300, 0xA210 },
+       { 0x3301, 0x050C },
+};
+
+static int wm5110_apply_sleep_patch(struct arizona *arizona)
+{
+       struct arizona_sysclk_state state;
+       int err, ret;
+
+       ret = arizona_enable_freerun_sysclk(arizona, &state);
+       if (ret)
+               return ret;
+
+       ret = regmap_multi_reg_write_bypassed(arizona->regmap,
+                                             wm5110_sleep_patch,
+                                             ARRAY_SIZE(wm5110_sleep_patch));
+
+       err = arizona_disable_freerun_sysclk(arizona, &state);
+
+       return ret ?: err;
+}
+
+static int wm5102_clear_write_sequencer(struct arizona *arizona)
+{
+       int ret;
+
+       ret = regmap_write(arizona->regmap, ARIZONA_WRITE_SEQUENCER_CTRL_3,
+                          0x0);
+       if (ret) {
                dev_err(arizona->dev,
-                       "Failed to re-apply old SYSCLK settings: %d\n",
-                       err);
+                       "Failed to clear write sequencer state: %d\n", ret);
+               return ret;
        }
 
-err_fll:
-       err = regmap_write(arizona->regmap, ARIZONA_FLL1_CONTROL_1, fll);
-       if (err != 0) {
-               dev_err(arizona->dev,
-                       "Failed to re-apply old FLL settings: %d\n",
-                       err);
+       arizona_enable_reset(arizona);
+       regulator_disable(arizona->dcvdd);
+
+       msleep(20);
+
+       ret = regulator_enable(arizona->dcvdd);
+       if (ret) {
+               dev_err(arizona->dev, "Failed to re-enable DCVDD: %d\n", ret);
+               return ret;
        }
+       arizona_disable_reset(arizona);
+
+       return 0;
+}
+
+#ifdef CONFIG_PM
+static int arizona_isolate_dcvdd(struct arizona *arizona)
+{
+       int ret;
+
+       ret = regmap_update_bits(arizona->regmap,
+                                ARIZONA_ISOLATION_CONTROL,
+                                ARIZONA_ISOLATE_DCVDD1,
+                                ARIZONA_ISOLATE_DCVDD1);
+       if (ret != 0)
+               dev_err(arizona->dev, "Failed to isolate DCVDD: %d\n", ret);
+
+       return ret;
+}
 
+static int arizona_connect_dcvdd(struct arizona *arizona)
+{
+       int ret;
+
+       ret = regmap_update_bits(arizona->regmap,
+                                ARIZONA_ISOLATION_CONTROL,
+                                ARIZONA_ISOLATE_DCVDD1, 0);
        if (ret != 0)
+               dev_err(arizona->dev, "Failed to connect DCVDD: %d\n", ret);
+
+       return ret;
+}
+
+static int arizona_is_jack_det_active(struct arizona *arizona)
+{
+       unsigned int val;
+       int ret;
+
+       ret = regmap_read(arizona->regmap, ARIZONA_JACK_DETECT_ANALOGUE, &val);
+       if (ret) {
+               dev_err(arizona->dev,
+                       "Failed to check jack det status: %d\n", ret);
                return ret;
-       else
-               return err;
+       } else if (val & ARIZONA_JD1_ENA) {
+               return 1;
+       } else {
+               return 0;
+       }
 }
 
-#ifdef CONFIG_PM
 static int arizona_runtime_resume(struct device *dev)
 {
        struct arizona *arizona = dev_get_drvdata(dev);
@@ -338,25 +512,41 @@ static int arizona_runtime_resume(struct device *dev)
 
        dev_dbg(arizona->dev, "Leaving AoD mode\n");
 
+       if (arizona->has_fully_powered_off) {
+               dev_dbg(arizona->dev, "Re-enabling core supplies\n");
+
+               ret = regulator_bulk_enable(arizona->num_core_supplies,
+                                           arizona->core_supplies);
+               if (ret) {
+                       dev_err(dev, "Failed to enable core supplies: %d\n",
+                               ret);
+                       return ret;
+               }
+       }
+
        ret = regulator_enable(arizona->dcvdd);
        if (ret != 0) {
                dev_err(arizona->dev, "Failed to enable DCVDD: %d\n", ret);
+               if (arizona->has_fully_powered_off)
+                       regulator_bulk_disable(arizona->num_core_supplies,
+                                              arizona->core_supplies);
                return ret;
        }
 
+       if (arizona->has_fully_powered_off) {
+               arizona_disable_reset(arizona);
+               enable_irq(arizona->irq);
+               arizona->has_fully_powered_off = false;
+       }
+
        regcache_cache_only(arizona->regmap, false);
 
        switch (arizona->type) {
        case WM5102:
                if (arizona->external_dcvdd) {
-                       ret = regmap_update_bits(arizona->regmap,
-                                                ARIZONA_ISOLATION_CONTROL,
-                                                ARIZONA_ISOLATE_DCVDD1, 0);
-                       if (ret != 0) {
-                               dev_err(arizona->dev,
-                                       "Failed to connect DCVDD: %d\n", ret);
+                       ret = arizona_connect_dcvdd(arizona);
+                       if (ret != 0)
                                goto err;
-                       }
                }
 
                ret = wm5102_patch(arizona);
@@ -366,30 +556,58 @@ static int arizona_runtime_resume(struct device *dev)
                        goto err;
                }
 
-               ret = arizona_apply_hardware_patch(arizona);
-               if (ret != 0) {
+               ret = wm5102_apply_hardware_patch(arizona);
+               if (ret) {
                        dev_err(arizona->dev,
                                "Failed to apply hardware patch: %d\n",
                                ret);
                        goto err;
                }
                break;
-       default:
+       case WM5110:
+       case WM8280:
                ret = arizona_wait_for_boot(arizona);
-               if (ret != 0) {
+               if (ret)
                        goto err;
-               }
 
                if (arizona->external_dcvdd) {
-                       ret = regmap_update_bits(arizona->regmap,
-                                                ARIZONA_ISOLATION_CONTROL,
-                                                ARIZONA_ISOLATE_DCVDD1, 0);
-                       if (ret != 0) {
+                       ret = arizona_connect_dcvdd(arizona);
+                       if (ret != 0)
+                               goto err;
+               } else {
+                       /*
+                        * As this is only called for the internal regulator
+                        * (where we know voltage ranges available) it is ok
+                        * to request an exact range.
+                        */
+                       ret = regulator_set_voltage(arizona->dcvdd,
+                                                   1200000, 1200000);
+                       if (ret < 0) {
                                dev_err(arizona->dev,
-                                       "Failed to connect DCVDD: %d\n", ret);
+                                       "Failed to set resume voltage: %d\n",
+                                       ret);
                                goto err;
                        }
                }
+
+               ret = wm5110_apply_sleep_patch(arizona);
+               if (ret) {
+                       dev_err(arizona->dev,
+                               "Failed to re-apply sleep patch: %d\n",
+                               ret);
+                       goto err;
+               }
+               break;
+       default:
+               ret = arizona_wait_for_boot(arizona);
+               if (ret != 0)
+                       goto err;
+
+               if (arizona->external_dcvdd) {
+                       ret = arizona_connect_dcvdd(arizona);
+                       if (ret != 0)
+                               goto err;
+               }
                break;
        }
 
@@ -410,26 +628,89 @@ err:
 static int arizona_runtime_suspend(struct device *dev)
 {
        struct arizona *arizona = dev_get_drvdata(dev);
+       int jd_active = 0;
        int ret;
 
        dev_dbg(arizona->dev, "Entering AoD mode\n");
 
-       if (arizona->external_dcvdd) {
-               ret = regmap_update_bits(arizona->regmap,
-                                        ARIZONA_ISOLATION_CONTROL,
-                                        ARIZONA_ISOLATE_DCVDD1,
-                                        ARIZONA_ISOLATE_DCVDD1);
-               if (ret != 0) {
-                       dev_err(arizona->dev, "Failed to isolate DCVDD: %d\n",
-                               ret);
-                       return ret;
+       switch (arizona->type) {
+       case WM5110:
+       case WM8280:
+               jd_active = arizona_is_jack_det_active(arizona);
+               if (jd_active < 0)
+                       return jd_active;
+
+               if (arizona->external_dcvdd) {
+                       ret = arizona_isolate_dcvdd(arizona);
+                       if (ret != 0)
+                               return ret;
+               } else {
+                       /*
+                        * As this is only called for the internal regulator
+                        * (where we know voltage ranges available) it is ok
+                        * to request an exact range.
+                        */
+                       ret = regulator_set_voltage(arizona->dcvdd,
+                                                   1175000, 1175000);
+                       if (ret < 0) {
+                               dev_err(arizona->dev,
+                                       "Failed to set suspend voltage: %d\n",
+                                       ret);
+                               return ret;
+                       }
+               }
+               break;
+       case WM5102:
+               jd_active = arizona_is_jack_det_active(arizona);
+               if (jd_active < 0)
+                       return jd_active;
+
+               if (arizona->external_dcvdd) {
+                       ret = arizona_isolate_dcvdd(arizona);
+                       if (ret != 0)
+                               return ret;
+               }
+
+               if (!jd_active) {
+                       ret = regmap_write(arizona->regmap,
+                                          ARIZONA_WRITE_SEQUENCER_CTRL_3, 0x0);
+                       if (ret) {
+                               dev_err(arizona->dev,
+                                       "Failed to clear write sequencer: %d\n",
+                                       ret);
+                               return ret;
+                       }
+               }
+               break;
+       default:
+               jd_active = arizona_is_jack_det_active(arizona);
+               if (jd_active < 0)
+                       return jd_active;
+
+               if (arizona->external_dcvdd) {
+                       ret = arizona_isolate_dcvdd(arizona);
+                       if (ret != 0)
+                               return ret;
                }
+               break;
        }
 
        regcache_cache_only(arizona->regmap, true);
        regcache_mark_dirty(arizona->regmap);
        regulator_disable(arizona->dcvdd);
 
+       /* Allow us to completely power down if no jack detection */
+       if (!jd_active) {
+               dev_dbg(arizona->dev, "Fully powering off\n");
+
+               arizona->has_fully_powered_off = true;
+
+               disable_irq_nosync(arizona->irq);
+               arizona_enable_reset(arizona);
+               regulator_bulk_disable(arizona->num_core_supplies,
+                                      arizona->core_supplies);
+       }
+
        return 0;
 }
 #endif
@@ -532,8 +813,8 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
 
        ret = of_property_read_u32_array(arizona->dev->of_node,
                                         "wlf,gpio-defaults",
-                                        arizona->pdata.gpio_defaults,
-                                        ARRAY_SIZE(arizona->pdata.gpio_defaults));
+                                        pdata->gpio_defaults,
+                                        ARRAY_SIZE(pdata->gpio_defaults));
        if (ret >= 0) {
                /*
                 * All values are literal except out of range values
@@ -541,11 +822,11 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
                 * data which uses 0 as chip default and out of range
                 * as zero.
                 */
-               for (i = 0; i < ARRAY_SIZE(arizona->pdata.gpio_defaults); i++) {
-                       if (arizona->pdata.gpio_defaults[i] > 0xffff)
-                               arizona->pdata.gpio_defaults[i] = 0;
-                       else if (arizona->pdata.gpio_defaults[i] == 0)
-                               arizona->pdata.gpio_defaults[i] = 0x10000;
+               for (i = 0; i < ARRAY_SIZE(pdata->gpio_defaults); i++) {
+                       if (pdata->gpio_defaults[i] > 0xffff)
+                               pdata->gpio_defaults[i] = 0;
+                       else if (pdata->gpio_defaults[i] == 0)
+                               pdata->gpio_defaults[i] = 0x10000;
                }
        } else {
                dev_err(arizona->dev, "Failed to parse GPIO defaults: %d\n",
@@ -554,20 +835,20 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
 
        of_property_for_each_u32(arizona->dev->of_node, "wlf,inmode", prop,
                                 cur, val) {
-               if (count == ARRAY_SIZE(arizona->pdata.inmode))
+               if (count == ARRAY_SIZE(pdata->inmode))
                        break;
 
-               arizona->pdata.inmode[count] = val;
+               pdata->inmode[count] = val;
                count++;
        }
 
        count = 0;
        of_property_for_each_u32(arizona->dev->of_node, "wlf,dmic-ref", prop,
                                 cur, val) {
-               if (count == ARRAY_SIZE(arizona->pdata.dmic_ref))
+               if (count == ARRAY_SIZE(pdata->dmic_ref))
                        break;
 
-               arizona->pdata.dmic_ref[count] = val;
+               pdata->dmic_ref[count] = val;
                count++;
        }
 
@@ -579,6 +860,8 @@ const struct of_device_id arizona_of_match[] = {
        { .compatible = "wlf,wm5110", .data = (void *)WM5110 },
        { .compatible = "wlf,wm8280", .data = (void *)WM8280 },
        { .compatible = "wlf,wm8997", .data = (void *)WM8997 },
+       { .compatible = "wlf,wm8998", .data = (void *)WM8998 },
+       { .compatible = "wlf,wm1814", .data = (void *)WM1814 },
        {},
 };
 EXPORT_SYMBOL_GPL(arizona_of_match);
@@ -593,7 +876,7 @@ static const struct mfd_cell early_devs[] = {
        { .name = "arizona-ldo1" },
 };
 
-static const char *wm5102_supplies[] = {
+static const char * const wm5102_supplies[] = {
        "MICVDD",
        "DBVDD2",
        "DBVDD3",
@@ -636,7 +919,7 @@ static const struct mfd_cell wm5110_devs[] = {
        },
 };
 
-static const char *wm8997_supplies[] = {
+static const char * const wm8997_supplies[] = {
        "MICVDD",
        "DBVDD2",
        "CPVDD",
@@ -660,13 +943,31 @@ static const struct mfd_cell wm8997_devs[] = {
        },
 };
 
+static const struct mfd_cell wm8998_devs[] = {
+       {
+               .name = "arizona-extcon",
+               .parent_supplies = wm5102_supplies,
+               .num_parent_supplies = 1, /* We only need MICVDD */
+       },
+       { .name = "arizona-gpio" },
+       { .name = "arizona-haptics" },
+       { .name = "arizona-pwm" },
+       {
+               .name = "wm8998-codec",
+               .parent_supplies = wm5102_supplies,
+               .num_parent_supplies = ARRAY_SIZE(wm5102_supplies),
+       },
+       { .name = "arizona-micsupp" },
+};
+
 int arizona_dev_init(struct arizona *arizona)
 {
        struct device *dev = arizona->dev;
        const char *type_name;
-       unsigned int reg, val;
+       unsigned int reg, val, mask;
        int (*apply_patch)(struct arizona *) = NULL;
-       int ret, i;
+       const struct mfd_cell *subdevs = NULL;
+       int n_subdevs, ret, i;
 
        dev_set_drvdata(arizona->dev, arizona);
        mutex_init(&arizona->clk_lock);
@@ -684,6 +985,8 @@ int arizona_dev_init(struct arizona *arizona)
        case WM5110:
        case WM8280:
        case WM8997:
+       case WM8998:
+       case WM1814:
                for (i = 0; i < ARRAY_SIZE(wm5102_core_supplies); i++)
                        arizona->core_supplies[i].supply
                                = wm5102_core_supplies[i];
@@ -728,9 +1031,9 @@ int arizona_dev_init(struct arizona *arizona)
 
        if (arizona->pdata.reset) {
                /* Start out with /RESET low to put the chip into reset */
-               ret = gpio_request_one(arizona->pdata.reset,
-                                      GPIOF_DIR_OUT | GPIOF_INIT_LOW,
-                                      "arizona /RESET");
+               ret = devm_gpio_request_one(arizona->dev, arizona->pdata.reset,
+                                           GPIOF_DIR_OUT | GPIOF_INIT_LOW,
+                                           "arizona /RESET");
                if (ret != 0) {
                        dev_err(dev, "Failed to request /RESET: %d\n", ret);
                        goto err_dcvdd;
@@ -751,10 +1054,7 @@ int arizona_dev_init(struct arizona *arizona)
                goto err_enable;
        }
 
-       if (arizona->pdata.reset) {
-               gpio_set_value_cansleep(arizona->pdata.reset, 1);
-               msleep(1);
-       }
+       arizona_disable_reset(arizona);
 
        regcache_cache_only(arizona->regmap, false);
 
@@ -768,6 +1068,7 @@ int arizona_dev_init(struct arizona *arizona)
        switch (reg) {
        case 0x5102:
        case 0x5110:
+       case 0x6349:
        case 0x8997:
                break;
        default:
@@ -777,8 +1078,6 @@ int arizona_dev_init(struct arizona *arizona)
 
        /* If we have a /RESET GPIO we'll already be reset */
        if (!arizona->pdata.reset) {
-               regcache_mark_dirty(arizona->regmap);
-
                ret = regmap_write(arizona->regmap, ARIZONA_SOFTWARE_RESET, 0);
                if (ret != 0) {
                        dev_err(dev, "Failed to reset device: %d\n", ret);
@@ -786,12 +1085,6 @@ int arizona_dev_init(struct arizona *arizona)
                }
 
                msleep(1);
-
-               ret = regcache_sync(arizona->regmap);
-               if (ret != 0) {
-                       dev_err(dev, "Failed to sync device: %d\n", ret);
-                       goto err_reset;
-               }
        }
 
        /* Ensure device startup is complete */
@@ -799,21 +1092,24 @@ int arizona_dev_init(struct arizona *arizona)
        case WM5102:
                ret = regmap_read(arizona->regmap,
                                  ARIZONA_WRITE_SEQUENCER_CTRL_3, &val);
-               if (ret != 0)
+               if (ret) {
                        dev_err(dev,
                                "Failed to check write sequencer state: %d\n",
                                ret);
-               else if (val & 0x01)
-                       break;
-               /* Fall through */
-       default:
-               ret = arizona_wait_for_boot(arizona);
-               if (ret != 0) {
-                       dev_err(arizona->dev,
-                               "Device failed initial boot: %d\n", ret);
-                       goto err_reset;
+               } else if (val & 0x01) {
+                       ret = wm5102_clear_write_sequencer(arizona);
+                       if (ret)
+                               return ret;
                }
                break;
+       default:
+               break;
+       }
+
+       ret = arizona_wait_for_boot(arizona);
+       if (ret) {
+               dev_err(arizona->dev, "Device failed initial boot: %d\n", ret);
+               goto err_reset;
        }
 
        /* Read the device ID information & do device specific stuff */
@@ -832,53 +1128,95 @@ int arizona_dev_init(struct arizona *arizona)
        arizona->rev &= ARIZONA_DEVICE_REVISION_MASK;
 
        switch (reg) {
-#ifdef CONFIG_MFD_WM5102
        case 0x5102:
-               type_name = "WM5102";
-               if (arizona->type != WM5102) {
-                       dev_err(arizona->dev, "WM5102 registered as %d\n",
-                               arizona->type);
-                       arizona->type = WM5102;
+               if (IS_ENABLED(CONFIG_MFD_WM5102)) {
+                       type_name = "WM5102";
+                       if (arizona->type != WM5102) {
+                               dev_warn(arizona->dev,
+                                        "WM5102 registered as %d\n",
+                                        arizona->type);
+                               arizona->type = WM5102;
+                       }
+
+                       apply_patch = wm5102_patch;
+                       arizona->rev &= 0x7;
+                       subdevs = wm5102_devs;
+                       n_subdevs = ARRAY_SIZE(wm5102_devs);
                }
-               apply_patch = wm5102_patch;
-               arizona->rev &= 0x7;
                break;
-#endif
-#ifdef CONFIG_MFD_WM5110
        case 0x5110:
-               switch (arizona->type) {
-               case WM5110:
-                       type_name = "WM5110";
-                       break;
-               case WM8280:
-                       type_name = "WM8280";
-                       break;
-               default:
-                       type_name = "WM5110";
-                       dev_err(arizona->dev, "WM5110 registered as %d\n",
-                               arizona->type);
-                       arizona->type = WM5110;
-                       break;
+               if (IS_ENABLED(CONFIG_MFD_WM5110)) {
+                       switch (arizona->type) {
+                       case WM5110:
+                               type_name = "WM5110";
+                               break;
+                       case WM8280:
+                               type_name = "WM8280";
+                               break;
+                       default:
+                               type_name = "WM5110";
+                               dev_warn(arizona->dev,
+                                        "WM5110 registered as %d\n",
+                                        arizona->type);
+                               arizona->type = WM5110;
+                               break;
+                       }
+
+                       apply_patch = wm5110_patch;
+                       subdevs = wm5110_devs;
+                       n_subdevs = ARRAY_SIZE(wm5110_devs);
                }
-               apply_patch = wm5110_patch;
                break;
-#endif
-#ifdef CONFIG_MFD_WM8997
        case 0x8997:
-               type_name = "WM8997";
-               if (arizona->type != WM8997) {
-                       dev_err(arizona->dev, "WM8997 registered as %d\n",
-                               arizona->type);
-                       arizona->type = WM8997;
+               if (IS_ENABLED(CONFIG_MFD_WM8997)) {
+                       type_name = "WM8997";
+                       if (arizona->type != WM8997) {
+                               dev_warn(arizona->dev,
+                                        "WM8997 registered as %d\n",
+                                        arizona->type);
+                               arizona->type = WM8997;
+                       }
+
+                       apply_patch = wm8997_patch;
+                       subdevs = wm8997_devs;
+                       n_subdevs = ARRAY_SIZE(wm8997_devs);
+               }
+               break;
+       case 0x6349:
+               if (IS_ENABLED(CONFIG_MFD_WM8998)) {
+                       switch (arizona->type) {
+                       case WM8998:
+                               type_name = "WM8998";
+                               break;
+
+                       case WM1814:
+                               type_name = "WM1814";
+                               break;
+
+                       default:
+                               type_name = "WM8998";
+                               dev_warn(arizona->dev,
+                                        "WM8998 registered as %d\n",
+                                        arizona->type);
+                               arizona->type = WM8998;
+                       }
+
+                       apply_patch = wm8998_patch;
+                       subdevs = wm8998_devs;
+                       n_subdevs = ARRAY_SIZE(wm8998_devs);
                }
-               apply_patch = wm8997_patch;
                break;
-#endif
        default:
                dev_err(arizona->dev, "Unknown device ID %x\n", reg);
                goto err_reset;
        }
 
+       if (!subdevs) {
+               dev_err(arizona->dev,
+                       "No kernel support for device ID %x\n", reg);
+               goto err_reset;
+       }
+
        dev_info(dev, "%s revision %c\n", type_name, arizona->rev + 'A');
 
        if (apply_patch) {
@@ -891,14 +1229,24 @@ int arizona_dev_init(struct arizona *arizona)
 
                switch (arizona->type) {
                case WM5102:
-                       ret = arizona_apply_hardware_patch(arizona);
-                       if (ret != 0) {
+                       ret = wm5102_apply_hardware_patch(arizona);
+                       if (ret) {
                                dev_err(arizona->dev,
                                        "Failed to apply hardware patch: %d\n",
                                        ret);
                                goto err_reset;
                        }
                        break;
+               case WM5110:
+               case WM8280:
+                       ret = wm5110_apply_sleep_patch(arizona);
+                       if (ret) {
+                               dev_err(arizona->dev,
+                                       "Failed to apply sleep patch: %d\n",
+                                       ret);
+                               goto err_reset;
+                       }
+                       break;
                default:
                        break;
                }
@@ -973,12 +1321,40 @@ int arizona_dev_init(struct arizona *arizona)
                /* Default for both is 0 so noop with defaults */
                val = arizona->pdata.dmic_ref[i]
                        << ARIZONA_IN1_DMIC_SUP_SHIFT;
-               val |= arizona->pdata.inmode[i] << ARIZONA_IN1_MODE_SHIFT;
+               if (arizona->pdata.inmode[i] & ARIZONA_INMODE_DMIC)
+                       val |= 1 << ARIZONA_IN1_MODE_SHIFT;
+
+               switch (arizona->type) {
+               case WM8998:
+               case WM1814:
+                       regmap_update_bits(arizona->regmap,
+                               ARIZONA_ADC_DIGITAL_VOLUME_1L + (i * 8),
+                               ARIZONA_IN1L_SRC_SE_MASK,
+                               (arizona->pdata.inmode[i] & ARIZONA_INMODE_SE)
+                                       << ARIZONA_IN1L_SRC_SE_SHIFT);
+
+                       regmap_update_bits(arizona->regmap,
+                               ARIZONA_ADC_DIGITAL_VOLUME_1R + (i * 8),
+                               ARIZONA_IN1R_SRC_SE_MASK,
+                               (arizona->pdata.inmode[i] & ARIZONA_INMODE_SE)
+                                       << ARIZONA_IN1R_SRC_SE_SHIFT);
+
+                       mask = ARIZONA_IN1_DMIC_SUP_MASK |
+                               ARIZONA_IN1_MODE_MASK;
+                       break;
+               default:
+                       if (arizona->pdata.inmode[i] & ARIZONA_INMODE_SE)
+                               val |= 1 << ARIZONA_IN1_SINGLE_ENDED_SHIFT;
+
+                       mask = ARIZONA_IN1_DMIC_SUP_MASK |
+                               ARIZONA_IN1_MODE_MASK |
+                               ARIZONA_IN1_SINGLE_ENDED_MASK;
+                       break;
+               }
 
                regmap_update_bits(arizona->regmap,
                                   ARIZONA_IN1L_CONTROL + (i * 8),
-                                  ARIZONA_IN1_DMIC_SUP_MASK |
-                                  ARIZONA_IN1_MODE_MASK, val);
+                                  mask, val);
        }
 
        for (i = 0; i < ARIZONA_MAX_OUTPUT; i++) {
@@ -1026,23 +1402,10 @@ int arizona_dev_init(struct arizona *arizona)
        arizona_request_irq(arizona, ARIZONA_IRQ_UNDERCLOCKED, "Underclocked",
                            arizona_underclocked, arizona);
 
-       switch (arizona->type) {
-       case WM5102:
-               ret = mfd_add_devices(arizona->dev, -1, wm5102_devs,
-                                     ARRAY_SIZE(wm5102_devs), NULL, 0, NULL);
-               break;
-       case WM5110:
-       case WM8280:
-               ret = mfd_add_devices(arizona->dev, -1, wm5110_devs,
-                                     ARRAY_SIZE(wm5110_devs), NULL, 0, NULL);
-               break;
-       case WM8997:
-               ret = mfd_add_devices(arizona->dev, -1, wm8997_devs,
-                                     ARRAY_SIZE(wm8997_devs), NULL, 0, NULL);
-               break;
-       }
+       ret = mfd_add_devices(arizona->dev, PLATFORM_DEVID_NONE,
+                             subdevs, n_subdevs, NULL, 0, NULL);
 
-       if (ret != 0) {
+       if (ret) {
                dev_err(arizona->dev, "Failed to add subdevices: %d\n", ret);
                goto err_irq;
        }
@@ -1052,10 +1415,7 @@ int arizona_dev_init(struct arizona *arizona)
 err_irq:
        arizona_irq_exit(arizona);
 err_reset:
-       if (arizona->pdata.reset) {
-               gpio_set_value_cansleep(arizona->pdata.reset, 0);
-               gpio_free(arizona->pdata.reset);
-       }
+       arizona_enable_reset(arizona);
        regulator_disable(arizona->dcvdd);
 err_enable:
        regulator_bulk_disable(arizona->num_core_supplies,
@@ -1080,8 +1440,7 @@ int arizona_dev_exit(struct arizona *arizona)
        arizona_free_irq(arizona, ARIZONA_IRQ_OVERCLOCKED, arizona);
        arizona_free_irq(arizona, ARIZONA_IRQ_CLKGEN_ERR, arizona);
        arizona_irq_exit(arizona);
-       if (arizona->pdata.reset)
-               gpio_set_value_cansleep(arizona->pdata.reset, 0);
+       arizona_enable_reset(arizona);
 
        regulator_bulk_disable(arizona->num_core_supplies,
                               arizona->core_supplies);