From 29f7bab413201b24fa09c70eb08a569c78d56f9f Mon Sep 17 00:00:00 2001 From: Alexandru Avadanii Date: Wed, 15 Jan 2020 18:05:55 +0100 Subject: [PATCH] odl: Make odl_hostconfig patching idempotent Although rarely, ODL hostconfig patching for py3 compatibility silently fails, leading to fatal errors in later deploy stages. Skip said patch if already applied, respectively fail if the patch can't be applied. Change-Id: I1addf17f61fa01055c0db83056870a7e7b8d3a42 Signed-off-by: Alexandru Avadanii --- mcp/config/states/opendaylight | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mcp/config/states/opendaylight b/mcp/config/states/opendaylight index eb6cc6524..ae8b4cc92 100755 --- a/mcp/config/states/opendaylight +++ b/mcp/config/states/opendaylight @@ -21,5 +21,7 @@ wait_for 5.0 "salt -I 'opendaylight:server' state.sls opendaylight" wait_for 20 "salt --out yaml -C 'I@neutron:server and *01*' network.connect $(odl bind_ip) $(odl rest_port) | fgrep -q 'result: true'" # https://bugs.launchpad.net/networking-odl/+bug/1822559 +FILE=/usr/lib/python3/dist-packages/networking_odl/cmd/set_ovs_hostconfigs.py +PFILE=/var/tmp/odl_hostconfig.patch salt -I 'linux:network:bridge:openvswitch' pkg.install python3-networking-odl -salt -I 'linux:network:bridge:openvswitch' file.patch /usr/lib/python3/dist-packages/networking_odl/cmd/set_ovs_hostconfigs.py /var/tmp/odl_hostconfig.patch || true +salt -I 'linux:network:bridge:openvswitch' cmd.run "patch -R -s --dry-run $FILE < $PFILE || patch $FILE < $PFILE" -- 2.16.6