From 506187a2e2a7e9232954192d1cf45aab76a0c6a6 Mon Sep 17 00:00:00 2001
From: Stamatis Katsaounis <mokats@intracom-telecom.com>
Date: Mon, 10 Sep 2018 11:34:17 +0300
Subject: [PATCH] Replace % operator with format method

JIRA: SDNVPN-223

Running the testcase 3 with the % operator was causing an error
on formating the string. This patch replace % operator with
format method.

Change-Id: I33d3a4539bd7e1914f8c52ea8e91ae15083ce0b1
Signed-off-by: Stamatis Katsaounis <mokats@intracom-telecom.com>
---
 sdnvpn/artifacts/quagga_setup.sh | 20 ++++++++++----------
 sdnvpn/lib/quagga.py             |  8 ++++----
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/sdnvpn/artifacts/quagga_setup.sh b/sdnvpn/artifacts/quagga_setup.sh
index fbd229f..b3bf786 100644
--- a/sdnvpn/artifacts/quagga_setup.sh
+++ b/sdnvpn/artifacts/quagga_setup.sh
@@ -9,22 +9,22 @@ echo 'ubuntu:opnfv' | chpasswd
 sleep 100
 
 # Variables to be filled in with python
-NEIGHBOR_IP=$1
-OWN_IP=$2
+NEIGHBOR_IP={0}
+OWN_IP={1}
 # directly access the instance from the external net without NAT
-EXT_NET_MASK=$3
-IP_PREFIX=$4
-RD=$5
-IRT=$6
-ERT=$7
+EXT_NET_MASK={2}
+IP_PREFIX={3}
+RD={4}
+IRT={5}
+ERT={6}
 
-if [[ $(getent hosts | awk '{print $2}') != *"$(cat /etc/hostname | awk '{print $1}')"* ]]
+if [[ $(getent hosts | awk '{{print $2}}') != *"$(cat /etc/hostname | awk '{{print $1}}')"* ]]
 then
-echo "127.0.1.1 $(cat /etc/hostname | awk '{print $1}')" | tee -a /etc/hosts
+echo "127.0.1.1 $(cat /etc/hostname | awk '{{print $1}}')" | tee -a /etc/hosts
 fi
 
 quagga_int=''
-for net_int in $(netstat -ia | awk 'NR>2{print $1}');
+for net_int in $(netstat -ia | awk 'NR>2{{print $1}}');
 do
 if [ -z "$(ifconfig | grep $net_int)" ]
 then
diff --git a/sdnvpn/lib/quagga.py b/sdnvpn/lib/quagga.py
index 0ea206e..f11e188 100644
--- a/sdnvpn/lib/quagga.py
+++ b/sdnvpn/lib/quagga.py
@@ -48,10 +48,10 @@ def gen_quagga_setup_script(controller_ip,
                             ip_prefix, rd, irt, ert):
     with open(COMMON_CONFIG.quagga_setup_script_path) as f:
         template = f.read()
-    script = template % (controller_ip,
-                         fake_floating_ip,
-                         ext_net_mask,
-                         ip_prefix, rd, irt, ert)
+    script = template.format(controller_ip,
+                             fake_floating_ip,
+                             ext_net_mask,
+                             ip_prefix, rd, irt, ert)
     return script
 
 
-- 
2.16.6