From e7440f39c66121cf915f156897c0a7d0e2af2951 Mon Sep 17 00:00:00 2001 From: =?utf8?q?C=C3=A9dric=20Ollivier?= Date: Sun, 26 Mar 2017 12:08:32 +0200 Subject: [PATCH] Fix pylint warnings in test_testcase_base MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit It takes into account the following warnings: - wrong-import-order - no-value-for-parameter The 'no-value-for-parameter' warnings are false positive. The added default values are useless but avoid them. Change-Id: I50d0af178d9da668a3c72e75f5af467d36ca0e6a Signed-off-by: Cédric Ollivier --- functest/tests/unit/core/test_testcase_base.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/functest/tests/unit/core/test_testcase_base.py b/functest/tests/unit/core/test_testcase_base.py index b7c81d87c..182da6ea3 100644 --- a/functest/tests/unit/core/test_testcase_base.py +++ b/functest/tests/unit/core/test_testcase_base.py @@ -8,9 +8,10 @@ # http://www.apache.org/licenses/LICENSE-2.0 import logging -import mock import unittest +import mock + from functest.core import testcase_base @@ -33,7 +34,7 @@ class TestcaseBaseTesting(unittest.TestCase): @mock.patch('functest.utils.functest_utils.push_results_to_db', return_value=False) - def _test_missing_attribute(self, mock_function): + def _test_missing_attribute(self, mock_function=None): self.assertEqual(self.test.push_to_db(), testcase_base.TestcaseBase.EX_PUSH_TO_DB_ERROR) mock_function.assert_not_called() @@ -56,7 +57,7 @@ class TestcaseBaseTesting(unittest.TestCase): @mock.patch('functest.utils.functest_utils.push_results_to_db', return_value=True) - def test_missing_details(self, mock_function): + def test_missing_details(self, mock_function=None): self.test.details = None self.assertEqual(self.test.push_to_db(), testcase_base.TestcaseBase.EX_OK) @@ -66,7 +67,7 @@ class TestcaseBaseTesting(unittest.TestCase): @mock.patch('functest.utils.functest_utils.push_results_to_db', return_value=False) - def test_push_to_db_failed(self, mock_function): + def test_push_to_db_failed(self, mock_function=None): self.assertEqual(self.test.push_to_db(), testcase_base.TestcaseBase.EX_PUSH_TO_DB_ERROR) mock_function.assert_called_once_with( @@ -75,7 +76,7 @@ class TestcaseBaseTesting(unittest.TestCase): @mock.patch('functest.utils.functest_utils.push_results_to_db', return_value=True) - def test_push_to_db(self, mock_function): + def test_push_to_db(self, mock_function=None): self.assertEqual(self.test.push_to_db(), testcase_base.TestcaseBase.EX_OK) mock_function.assert_called_once_with( -- 2.16.6