From e4d7506a5a21550a89f897dfaea3f0dcae352e5b Mon Sep 17 00:00:00 2001 From: =?utf8?q?C=C3=A9dric=20Ollivier?= Date: Sun, 26 Mar 2017 11:55:10 +0200 Subject: [PATCH] Fix pylint warnings in testcase_base MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit It takes into account the following warnings: - bare-except - unused-argument - broad-except Change-Id: I3a50bf6d07823edc80a7f0f78f46681ace7f4a39 Signed-off-by: Cédric Ollivier --- functest/core/testcase_base.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/functest/core/testcase_base.py b/functest/core/testcase_base.py index 838b63983..2848073f7 100644 --- a/functest/core/testcase_base.py +++ b/functest/core/testcase_base.py @@ -35,11 +35,12 @@ class TestcaseBase(object): assert self.criteria if self.criteria == 'PASS': return TestcaseBase.EX_OK - except: + except AssertionError: self.logger.error("Please run test before checking the results") return TestcaseBase.EX_TESTCASE_FAILED def run(self, **kwargs): + # pylint: disable=unused-argument self.logger.error("Run must be implemented") return TestcaseBase.EX_RUN_ERROR @@ -58,6 +59,6 @@ class TestcaseBase(object): else: self.logger.error("The results cannot be pushed to DB") return TestcaseBase.EX_PUSH_TO_DB_ERROR - except Exception: + except Exception: # pylint: disable=broad-except self.logger.exception("The results cannot be pushed to DB") return TestcaseBase.EX_PUSH_TO_DB_ERROR -- 2.16.6