From 857de0535fcac0b353cc7f3c555060aa5807cfc7 Mon Sep 17 00:00:00 2001 From: Victor Morales Date: Thu, 27 Aug 2020 11:41:33 -0400 Subject: [PATCH] Enable external sources for kuberef shellcheck Shellcheck is failing on the execution given that it's missing the -x argument. This change fixes that problem adding the argument. Signed-off-by: Victor Morales Change-Id: Idc1795b604f4b88e5e4468b8fd26b961c08455bf --- jjb/kuberef/kuberef-run-linting.sh | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/jjb/kuberef/kuberef-run-linting.sh b/jjb/kuberef/kuberef-run-linting.sh index 4f681ac53..810f93321 100755 --- a/jjb/kuberef/kuberef-run-linting.sh +++ b/jjb/kuberef/kuberef-run-linting.sh @@ -12,6 +12,7 @@ set -o nounset set -o pipefail set -o xtrace +echo "Requirements validation" # shellcheck disable=SC1091 source /etc/os-release || source /usr/lib/os-release @@ -32,6 +33,7 @@ if ! command -v pip; then fi if [ -n "$pkgs" ]; then + echo "Requirements installation" case ${ID,,} in *suse*) sudo zypper install --gpg-auto-import-keys refresh @@ -52,5 +54,11 @@ if [ -n "$pkgs" ]; then esac fi +echo "Server tools information:" +python -V +tox --version +shellcheck -V + +echo "Linting process execution" tox -e lint -bash -c 'shopt -s globstar; shellcheck **/*.sh' +bash -c 'shopt -s globstar; shellcheck -x **/*.sh' -- 2.16.6