functest.git
4 years agoReduce Tempest multi threads 90/69890/1
Cédric Ollivier [Sat, 4 Apr 2020 19:56:45 +0000 (21:56 +0200)]
Reduce Tempest multi threads

It decreases the threads from 4 to 3 to allow running the testcases in
parallel. Else a few tests sometimes fail.

Change-Id: I268eff5a72d5de5b26d7549ac74ee0e2a05cb61e
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoSkip test_container_synchronization 85/69885/2
Cédric Ollivier [Sat, 4 Apr 2020 15:17:30 +0000 (17:17 +0200)]
Skip test_container_synchronization

It's not supported by radosgw which is now used in Functest SUTs [1][2].
It's removed from CNTT which seems leveraging on ceph (at least RI) [3]

[1] https://access.redhat.com/documentation/en-us/red_hat_ceph_storage/3.2/html/release_notes/bug-fixes
[2] http://artifacts.opnfv.org/functest/E46RCZLBRYCC/functest-opnfv-functest-smoke-hunter-tempest_slow-run-127/tempest_slow/tempest-report.html
[3] http://artifacts.opnfv.org/cntt/WKFRPQODPW34/cntt-opnfv-functest-smoke-latest-tempest_slow-run-37/tempest_slow/tempest-report.html

Change-Id: I8127df786c41af0d0285ef0e5cd1b28901685f65
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoRevert "Keep the modified tempest" 79/69879/1
Cédric Ollivier [Thu, 2 Apr 2020 20:20:10 +0000 (22:20 +0200)]
Revert "Keep the modified tempest"

It's simply useless and may raise side effects later.

Change-Id: Idaeab672480597ed39a5e29719580fee38aeb4ad
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoKeep the modified tempest 74/69874/3
Cédric Ollivier [Thu, 2 Apr 2020 16:54:58 +0000 (18:54 +0200)]
Keep the modified tempest

http://artifacts.opnfv.org/functest/CRY58ZS3031L/functest-ovn-opnfv-functest-healthcheck-jerma-tempest_smoke-run-37/tempest_smoke/tempest-report.html

Change-Id: I9598a45b09151fa267294716f70e65e3050f0239
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
(cherry picked from commit 21b512e55eb36e38160b697baae44c464fce9034)

4 years agoRename CNTT specific testcases 61/69861/1
Cédric Ollivier [Wed, 1 Apr 2020 06:11:04 +0000 (08:11 +0200)]
Rename CNTT specific testcases

Test DB and API don't support suites which raise side effects in Cachet
if both IaaS verification and CNTT conformance are executed.

Vmtp and Shaker haven't been modified for CNTT. They will be renamed
once CNTT asks for new post processing.

http://testresults.opnfv.org:8080/

Change-Id: I64e06694620027faa06b6d9d339684f5e8d733d7
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoIncrease Shaker timeout before init message in console 48/69848/1
Cédric Ollivier [Sat, 28 Mar 2020 08:52:24 +0000 (09:52 +0100)]
Increase Shaker timeout before init message in console

It failed in parallel of rally_full [1].

[1] https://build.opnfv.org/ci/job/functest-opnfv-functest-benchmarking-hunter-shaker-run/397/console
[2] https://build.opnfv.org/ci/job/functest-opnfv-functest-benchmarking-hunter-shaker-run/395/console

Change-Id: I0eab7374c5962d45405c5f4147798067526f6e70
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoCheck the login prompt in console in SingleVm1 42/69842/2
Cédric Ollivier [Thu, 26 Mar 2020 12:56:17 +0000 (13:56 +0100)]
Check the login prompt in console in SingleVm1

It also checks the second vm2 console log in case of vping_ssh.

Change-Id: I13a5edfb3e19449a38d2f0478d549bd8fcc5cfa7
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoMerge "Remove duplicated packages in VNF Dockerfile"
Cedric Ollivier [Tue, 24 Mar 2020 07:48:53 +0000 (07:48 +0000)]
Merge "Remove duplicated packages in VNF Dockerfile"

4 years agoUpdate xtesting to 0.87.0 07/69807/2
Cédric Ollivier [Tue, 17 Mar 2020 20:07:49 +0000 (21:07 +0100)]
Update xtesting to 0.87.0

Change-Id: I0ee3499cf9c78687825714c00c1cf18ed2a70456
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoRemove duplicated packages in VNF Dockerfile 06/69806/3
Cédric Ollivier [Tue, 17 Mar 2020 20:04:11 +0000 (21:04 +0100)]
Remove duplicated packages in VNF Dockerfile

Change-Id: I7f9c5b5e2c59f23ada721e7209bec56bfa23ae9e
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoDoesn't redirect stderr when getting verifier id 22/69822/4
Cédric Ollivier [Sun, 22 Mar 2020 12:13:53 +0000 (13:13 +0100)]
Doesn't redirect stderr when getting verifier id

The logic fails when rally produces warnings [1].
It also updates Rally OpenStack and checks if the previous error
has been solved[2].

TypeError: _discover_or_create_flavor() missing 1 required positional
argument: 'flv_disk' [3]

[1] https://build.opnfv.org/ci/job/functest-opnfv-functest-healthcheck-latest-tempest_smoke-run/757/console
[2] https://github.com/openstack/rally-openstack/commit/e62315115af20e53f6c7205494ba0008634047ed
[3] https://build.opnfv.org/ci/job/functest-opnfv-functest-healthcheck-latest-tempest_smoke-run/629/console

Change-Id: Ia1daaa76d7cef7f30904c1f3bd42e2f6a6ba10af
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoAdd oauth1 as optional Keystone features 56/69756/1
Cédric Ollivier [Thu, 5 Mar 2020 07:55:35 +0000 (08:55 +0100)]
Add oauth1 as optional Keystone features

It was not listed in Keystone which defacto sets it as optional.
It may be considered as mandatory in a second step.

It should be noted that it's not working in CNTT RI and there is no
true plan to update CNTT RI from the time writing.

Close cntt-n/CNTT#1253

Change-Id: If7ee4efeafc05638173a51ce997ecbdcaabfc79c
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoBlacklist tests which are not mandatory in CNTT 47/69747/1
Cédric Ollivier [Tue, 3 Mar 2020 16:03:42 +0000 (17:03 +0100)]
Blacklist tests which are not mandatory in CNTT

CNTT rally_jobs must conform with CNTT RC whatever the OpenStack
version under tests. All tests added by neutron since Hunter must
be skipped in conformance.

Of course, the IaaS verification part is unchanged as this tests
are relevant.

Change-Id: I4cfb4ae725e5ce9125f4ed25489dd003e16695f4
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoAdd OVN Controller Gateway agent in neutron_bind_l2_agent_types 44/69744/1
Cédric Ollivier [Tue, 3 Mar 2020 10:02:28 +0000 (11:02 +0100)]
Add OVN Controller Gateway agent in neutron_bind_l2_agent_types

It avoids blacklisting NeutronNetworks.create_and_bind_ports in case of
OVN. It conforms with the upstream testing [1] and then reverts the
previous change [2].

[1] https://github.com/openstack/networking-ovn/blob/master/zuul.d/networking-ovn-jobs.yaml#L299
[2] https://git.opnfv.org/functest/commit/?id=8e297c49c481961959b29c2080cc059fcc84e9ee

This reverts commit 8e297c49c481961959b29c2080cc059fcc84e9ee.

Change-Id: I95f1b7146e636ae3ebe9f995733e53ad1b276d26
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoIncreate Neutron test count to 501 43/69743/1
Cédric Ollivier [Fri, 28 Feb 2020 21:15:36 +0000 (22:15 +0100)]
Increate Neutron test count to 501

http://artifacts.opnfv.org/functest/P5QXI9R2ULZQ/functest-opnfv-functest-smoke-cntt-latest-neutron-tempest-plugin-api-run-29/neutron-tempest-plugin-api/tempest-report.html

Change-Id: I0dee2ecea051e1caafd6437bc1766c920b3e1ff4
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoRemove /src/glance after generating policy.conf 40/69740/1
Cédric Ollivier [Fri, 28 Feb 2020 11:50:55 +0000 (12:50 +0100)]
Remove /src/glance after generating policy.conf

It also cleans former dirs.

Change-Id: I924436652e3fe0f19d0755024839ecb5290aa2f3
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoBlacklist NeutronNetworks.create_and_bind_ports if ovn 28/69728/1
Cédric Ollivier [Mon, 24 Feb 2020 15:59:27 +0000 (16:59 +0100)]
Blacklist NeutronNetworks.create_and_bind_ports if ovn

It only works for Linux Bridge and Open vSwitch.

Change-Id: I1a437145eb8140642d3c8297c3f154113e74505f
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoBlacklist tests asking for vxlan 26/69726/1
Cédric Ollivier [Sat, 22 Feb 2020 06:21:38 +0000 (07:21 +0100)]
Blacklist tests asking for vxlan

http://artifacts.opnfv.org/functest/B4HOI3WWLNVK/functest-ovn-opnfv-functest-smoke-jerma-neutron-tempest-plugin-api-run-4/neutron-tempest-plugin-api/tempest-report.html

Change-Id: I6ff82b92cb4c392ac1f453faf7e16ef587dc2060
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoPublish tempest_conf.yaml for Functest OVN SUT 24/69724/1
Cédric Ollivier [Sat, 22 Feb 2020 05:28:28 +0000 (06:28 +0100)]
Publish tempest_conf.yaml for Functest OVN SUT

Change-Id: I96237e8bfe469f100dc72d022747ce0013b41284
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoUpdate patrole regex (OVN) 21/69721/1
Cédric Ollivier [Fri, 21 Feb 2020 20:24:45 +0000 (21:24 +0100)]
Update patrole regex (OVN)

It takes into account last changes in Patrole.
It was not covered since Apex stopped deploying OVN.

Change-Id: I7ab8362f9998024ae65f49973b169b95bbfd4fb5
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoSkip a few tests in tempest_full and tempest_slow 11/69711/1
Cédric Ollivier [Fri, 21 Feb 2020 10:47:11 +0000 (11:47 +0100)]
Skip a few tests in tempest_full and tempest_slow

It completes the first patch updating neutron-tempest-plugin-api [1].
The same dvr regex is used in tempest_slow, a new one is defined for
tempest_full which will be added in CNTT doc
(test_network_basic_ops.TestNetworkBasicOps.test_router_rescheduling).

Close cntt-n/CNTT#1106

Change-Id: I9fd79c9a82bb1f84a622ccb9ea316b8e43273e2a
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoMerge "Update test case list in neutron-tempest-plugin-api"
Cedric Ollivier [Tue, 18 Feb 2020 15:41:01 +0000 (15:41 +0000)]
Merge "Update test case list in neutron-tempest-plugin-api"

4 years agoBlacklick test_add_subport if OVN 97/69697/2
Cédric Ollivier [Tue, 18 Feb 2020 10:40:11 +0000 (11:40 +0100)]
Blacklick test_add_subport if OVN

https://bugs.launchpad.net/neutron/+bug/1863707

Change-Id: Ieebe10ee2a9040887d84aca3e8fb5ee66294634b
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoUpdate test case list in neutron-tempest-plugin-api 96/69696/2
Cédric Ollivier [Tue, 18 Feb 2020 10:34:21 +0000 (11:34 +0100)]
Update test case list in neutron-tempest-plugin-api

It takes into account latest changes in CNTT [1]

[1] https://github.com/cntt-n/CNTT/pull/1107

Close cntt-n/CNTT#1106

Change-Id: I3212d1b765f7fd657ed603ed520d79fccae80bfa
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoSelect OpenStack requirements master 92/69692/1
Cédric Ollivier [Mon, 17 Feb 2020 12:06:40 +0000 (13:06 +0100)]
Select OpenStack requirements master

https://github.com/openstack/requirements/commit/7a04f4e96205f16e74a9a08fe60b168c187516d6

Change-Id: I9ed510c45f63714b64dcb9fa90e4d7239f93ee3f
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoFix incorrect test numbers 91/69691/1
Cédric Ollivier [Mon, 17 Feb 2020 00:58:18 +0000 (01:58 +0100)]
Fix incorrect test numbers

[1] http://artifacts.opnfv.org/functest/16S4PBMRW5HP/functest-opnfv-functest-smoke-cntt-latest-neutron-tempest-plugin-api-run-23/neutron-tempest-plugin-api/tempest-report.html

Change-Id: I9cb04c3abdbb899d2f1d4188a9fb9743a8f4c6d0
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoBypass upstream requirement issues 90/69690/1
Cédric Ollivier [Sun, 16 Feb 2020 23:10:07 +0000 (00:10 +0100)]
Bypass upstream requirement issues

https://review.opendev.org/#/c/708041/

Change-Id: Iebbf0a720fe9d1c62083028d0bc0078bf7680753
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoRemove refstack version tag 89/69689/1
Cédric Ollivier [Sun, 16 Feb 2020 19:32:52 +0000 (20:32 +0100)]
Remove refstack version tag

It has been unread since the files are cached.

Change-Id: Iba74163ac486dddaee4e81a340fcbe2b9297071f
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoExclude vxlan testing in CNTT 76/69676/1
Cédric Ollivier [Sun, 16 Feb 2020 14:27:30 +0000 (15:27 +0100)]
Exclude vxlan testing in CNTT

Close cntt-n/CNTT#1077

Change-Id: If9c0f52138e9f669f17933c42906936e2e196b2a
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoRun test_agent_management vs OVN 75/69675/1
Cédric Ollivier [Sat, 15 Feb 2020 17:18:11 +0000 (18:18 +0100)]
Run test_agent_management vs OVN

They must not longer be blacklisted as opposed to
test_dhcp_agent_scheduler [1].

https://bugs.launchpad.net/networking-ovn/+bug/1863432

Change-Id: Ib08bb87580a10e2124faa1b3853f3e27dcb3a0a0
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoSet dhcp_agent_scheduler as optional 74/69674/1
Cédric Ollivier [Sat, 15 Feb 2020 11:11:37 +0000 (12:11 +0100)]
Set dhcp_agent_scheduler as optional

dhcp_agent_scheduler [1] indirectly forces the Neutron backends
as highlighted by OVN testing.

[1] https://specs.openstack.org/openstack/neutron-specs/specs/api/agent_schedulers.html

Close cntt-n/CNTT#1073

Change-Id: Iafa3ad7f15dc157c0362ffa59eed31b89bf368e7
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoOrder regex in neutron-tempest-plugin-api (CNTT) 73/69673/1
Cédric Ollivier [Sat, 15 Feb 2020 10:36:33 +0000 (11:36 +0100)]
Order regex in neutron-tempest-plugin-api (CNTT)

It mostly adds admin as prefix.

Change-Id: Ic2e723b858ff1f3e26478f6037a19db1fd52e4aa
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoDecrease test_count to 1290 in tempest_full 72/69672/1
Cédric Ollivier [Sat, 15 Feb 2020 13:58:59 +0000 (14:58 +0100)]
Decrease test_count to 1290 in tempest_full

http://artifacts.opnfv.org/functest/2Y4502QRM7YM/functest-opnfv-functest-smoke-cntt-latest-tempest_full-run-16/tempest_full/tempest.log

Change-Id: Ifa1ae117db7dff6471ab557d6f7f3bf03940de76
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoIncrease test_count to 547 in neutron-tempest-plugin-api 71/69671/1
Cédric Ollivier [Sat, 15 Feb 2020 11:13:02 +0000 (12:13 +0100)]
Increase test_count to 547 in neutron-tempest-plugin-api

It takes into account the new tests added in Neutron Tempest Plugin.

Change-Id: I7994638c69ef6bd39bae3c6ded8409baabc27e9d
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoAdd Functest CNTT-specific containers in release notes 26/69626/1
Cédric Ollivier [Tue, 4 Feb 2020 05:18:15 +0000 (06:18 +0100)]
Add Functest CNTT-specific containers in release notes

Change-Id: I979a5e26caee893d772de484e7a61f2e82762ace
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoUpdate Alpine to 3.11 03/69503/5
Cédric Ollivier [Sat, 4 Jan 2020 21:31:40 +0000 (22:31 +0100)]
Update Alpine to 3.11

It also updates Python to 3.8 (default version).
It selects arm32v6 et arm64v8 repos and switches multiarch binfmt.

https://alpinelinux.org/posts/Alpine-3.11.0-released.html

Change-Id: Ib41cf0ab805ce2137658f3ff656b0a88c7b4ebf5
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoGenerate /etc/glance/policy.json 76/69576/1
Cédric Ollivier [Fri, 24 Jan 2020 19:59:03 +0000 (20:59 +0100)]
Generate /etc/glance/policy.json

It takes into account the following change in glance [1]

[1] https://github.com/openstack/glance/commit/5c17e4c7ef533b57ba15ead931b0452e23f46b4b#diff-335462891f7178710c6ca7185f9f877c

Change-Id: I61e37cd2383620fa6db665f1858830b9c5d13938
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoSlightly change Functest2020 51/69551/1
Cédric Ollivier [Tue, 14 Jan 2020 16:19:55 +0000 (17:19 +0100)]
Slightly change Functest2020

Change-Id: I7f82f5905536da593193d586a1b0655fcd44d6ad
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoUpdate ODL git commit id (python3 migration) 48/69548/1
Cédric Ollivier [Tue, 14 Jan 2020 13:37:29 +0000 (14:37 +0100)]
Update ODL git commit id (python3 migration)

https://jira.opendaylight.org/browse/INTTEST-65

Co-Authored-By: Alexandru Avadanii <alexandru.avadanii@enea.com>
Change-Id: I40c9df7c7d80fc8d9709f0b75dda333d9ed9da12
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoPublish Functest 2020 41/69541/1
Cédric Ollivier [Mon, 13 Jan 2020 15:31:27 +0000 (16:31 +0100)]
Publish Functest 2020

http://testresults.opnfv.org/functest/functest2020/

Change-Id: I4116b08bd2210231d78e2761a1089fbfc0d56a46
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoRevert "Ease overriding tempest_conf.yaml" 29/69529/1
Cédric Ollivier [Thu, 9 Jan 2020 18:45:59 +0000 (19:45 +0100)]
Revert "Ease overriding tempest_conf.yaml"

It raises side effects if the file is missing (trying to mount a
directory onto a file) which is the default case.

This reverts commit fe4c595edbaa31a43b94c5065fb14cab932ddffd.

Change-Id: Ic24bbbbadfe0cd8901ed66357e95f466cee8da80
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoRemove test_server_connectivity_cold_migration_revert from Compliance 28/69528/1
Cédric Ollivier [Thu, 9 Jan 2020 10:46:42 +0000 (11:46 +0100)]
Remove test_server_connectivity_cold_migration_revert from Compliance

It's skipped due to an upstream bug [1] highlighted by Jerma runs [2].

[1] https://launchpad.net/bugs/1836595
[2] http://artifacts.opnfv.org/functest/UXR96KDNMPTP/functest-opnfv-functest-smoke-cntt-jerma-tempest_slow-run-4/tempest_slow/tempest-report.html

Change-Id: Ib4cbf0e6e8e010febd39dec8dd8ecd773ad28c3e
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoEase overriding tempest_conf.yaml 80/69480/1
Cédric Ollivier [Thu, 2 Jan 2020 11:58:06 +0000 (12:58 +0100)]
Ease overriding tempest_conf.yaml

It works asis in Functest gates but its values mays be modified by
users at their convenience.

Change-Id: Id83c01693818802d11eb3822b59a508ac09990c3
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoRemove test_server_connectivity_cold_migration_revert from exclusion list 68/69468/1
Cédric Ollivier [Mon, 30 Dec 2019 02:45:06 +0000 (03:45 +0100)]
Remove test_server_connectivity_cold_migration_revert from exclusion list

It has to be part of the Compliance testing

Co-Authored-By: Deepanshu Bhatia <deepanshu@voereir.com>
Change-Id: I16d35e3c3a14b6b18901b6b27e50fc709ce0559f
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoSet port_security: true in tempest_conf.yaml 61/69461/1
Cédric Ollivier [Fri, 27 Dec 2019 17:54:35 +0000 (18:54 +0100)]
Set port_security: true in tempest_conf.yaml

It allows running
test_boot_into_disabled_port_security_network_without_secgroup.

It also sets a few default values.

Change-Id: I851c5d13705e0419a7e664e05d32eec0efb417c6
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoFully remove Quotas.nova_update_and_delete 57/69457/1
Cédric Ollivier [Fri, 27 Dec 2019 11:15:18 +0000 (12:15 +0100)]
Fully remove Quotas.nova_update_and_delete

It was blacklisted for a while and it's still failing [1][2].
It has to be removed from scenarios (blacklisting is useless and could
mislead endusers).

[1] http://artifacts.opnfv.org/functest/BYERCT6UZDWT/functest-opnfv-functest-benchmarking-iruya-rally_full-run-227/rally_full/rally_full.html
[2] http://artifacts.opnfv.org/functest/LYQLHFQB7CTI/functest-opnfv-functest-benchmarking-hunter-rally_full-run-329/rally_full/rally_full.html

Change-Id: I9ccea90a70024b6e54d873024cf550db5beea990
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoSet create_shared_resources to true 55/69455/1
Cédric Ollivier [Fri, 27 Dec 2019 00:56:21 +0000 (01:56 +0100)]
Set create_shared_resources to true

It takes last Neutron Tempest plugin change into account [1].
It also increases test count.

[1] https://review.opendev.org/#/c/692822/

Change-Id: I5e7218dd808069a0be6d481447576099aa9c63e9
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoPin rally-openstack in master 54/69454/1
Cédric Ollivier [Thu, 26 Dec 2019 14:06:48 +0000 (15:06 +0100)]
Pin rally-openstack in master

The last patch seems buggy [1]
TypeError: _discover_or_create_flavor() missing 1 required positional argument: 'flv_disk' [2]

[1] https://github.com/openstack/rally-openstack/commit/e62315115af20e53f6c7205494ba0008634047ed
[2] https://build.opnfv.org/ci/job/functest-opnfv-functest-healthcheck-latest-tempest_smoke-run/629/console

Change-Id: Id0402afdf79d7a1081e817ea513d90c93b077ce4
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoRemove former Rally blacklist 43/69443/1
Cédric Ollivier [Tue, 24 Dec 2019 15:35:54 +0000 (16:35 +0100)]
Remove former Rally blacklist

Change-Id: Ibc9aa210846ad2163f7ef943d224374dfff6f1ec
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoUpdate Xtesting to 0.86 23/69423/1
Cédric Ollivier [Sun, 22 Dec 2019 15:18:50 +0000 (16:18 +0100)]
Update Xtesting to 0.86

It eases dumping all logs for third-parties.

Change-Id: I6055e85902eb41cce01f1502cd31d7ec489708d8
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoMerge "Run tests sequentially in tempest_slow"
Cedric Ollivier [Sat, 7 Dec 2019 15:28:08 +0000 (15:28 +0000)]
Merge "Run tests sequentially in tempest_slow"

4 years agoMerge "Introduce CNTT Compliance by Functest"
Cedric Ollivier [Sat, 7 Dec 2019 13:34:12 +0000 (13:34 +0000)]
Merge "Introduce CNTT Compliance by Functest"

4 years agoMerge "Disable false ansiblelint warnings"
Cedric Ollivier [Sat, 7 Dec 2019 13:34:00 +0000 (13:34 +0000)]
Merge "Disable false ansiblelint warnings"

4 years agoRun tests sequentially in tempest_slow 78/69278/1
Cédric Ollivier [Sat, 7 Dec 2019 12:56:40 +0000 (13:56 +0100)]
Run tests sequentially in tempest_slow

concurrency is set to 2 in the upstream job [1] but it conflicts with
serial also passed.

As it fails once without any other test in parallel, the number of
executors should be decreased [2].

[0] https://799189c1bf6a1aa9c8de-48970bda2a30ee836a70a12e61555969.ssl.cf1.rackcdn.com/694893/1/check/tempest-slow/1bf5851/job-output.txt
[1] http://artifacts.opnfv.org/functest/functest-opnfv-functest-smoke-cntt-hunter-tempest_slow-run-7/tempest_slow/tempest-report.html

Change-Id: I51bc9a584cf4b32a88b7a84d9387e7b8e90281c2
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoIntroduce CNTT Compliance by Functest 54/69254/2
Cédric Ollivier [Wed, 4 Dec 2019 20:02:59 +0000 (21:02 +0100)]
Introduce CNTT Compliance by Functest

Change-Id: I77dd7d3e0d21573e76ec8d43a0b6ca5b64be2ad2
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoDisable false ansiblelint warnings 74/69274/1
Cédric Ollivier [Sat, 7 Dec 2019 12:38:47 +0000 (13:38 +0100)]
Disable false ansiblelint warnings

git commit has to be executed via shell module [1].
It also update ansible to conform with the latest changes in
XtestingCI.

[1] https://github.com/ansible/ansible/issues/50334

Change-Id: I3cc7a675eddabb0cbd9834a9e64fe7389a11865f
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoIncrease tests_count (538) in CNTT neutron-tempest-plugin-api-run 69/69269/1
Cédric Ollivier [Sat, 7 Dec 2019 08:32:05 +0000 (09:32 +0100)]
Increase tests_count (538) in CNTT neutron-tempest-plugin-api-run

New tests have been published in the upstream project [1].

[1] https://build.opnfv.org/ci/job/functest-opnfv-functest-smoke-cntt-latest-neutron-tempest-plugin-api-run/4/console

Change-Id: I46603ed78f865f89fe2a7ebcf6a72da38a02bb14
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoDisable tempest serial_console testing 46/69246/1
Cédric Ollivier [Tue, 3 Dec 2019 14:32:09 +0000 (15:32 +0100)]
Disable tempest serial_console testing

DevStack seems incorrect when configuring serial console in case of
multinode deployment (missing proxyclient_address in master, missing
socket in Rocky, etc). Then the testing is disabled.

Change-Id: I9d1d43017b0935b23ea2a939748b5f709212c70d
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoVerify Shaker results via json report 60/68560/4
Cédric Ollivier [Mon, 2 Dec 2019 22:43:55 +0000 (23:43 +0100)]
Verify Shaker results via json report

As shaker always returns 0, it verifies the records and returns false
after the first failure.

Change-Id: I9393be0c65d315c1ca055de9f7f994f9db22eadb
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoReturn result = 0 if failure in juju_epc 19/69219/1
Cédric Ollivier [Mon, 2 Dec 2019 06:31:52 +0000 (07:31 +0100)]
Return result = 0 if failure in juju_epc

Else it's falsy successfull [1]

[1] https://build.opnfv.org/ci/job/airship-opnfv-functest-vnf-latest-juju_epc-run/42/console

Change-Id: Ic9f7c37db998904833c90ae3ee912e9908617abd
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoUpdate Xtesting to 0.85.0 09/69209/1
Cédric Ollivier [Sat, 30 Nov 2019 13:25:34 +0000 (14:25 +0100)]
Update Xtesting to 0.85.0

It fixes falsy hrefs returned by OPNFV Test API.

Change-Id: Ib6e7e7e35cf6ad581fb67692dcba561769686007
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoSwitch xrally_kubernetes back to master 82/69182/1
Juha Kosonen [Fri, 29 Nov 2019 08:09:12 +0000 (10:09 +0200)]
Switch xrally_kubernetes back to master

The pull request [1] is now merged.

[1] https://github.com/xrally/xrally-kubernetes/pull/46

Change-Id: Ida258c279314cdbbacf255c50b3a4d1224ea803b
Signed-off-by: Juha Kosonen <juha.kosonen@nokia.com>
4 years agoPropose CNTT Compliance playbook 14/69114/1
Cédric Ollivier [Wed, 27 Nov 2019 09:51:21 +0000 (10:51 +0100)]
Propose CNTT Compliance playbook

It eases building CI/CD toolchains everywhere veryfing the compliance
between CNTT Chapter 5 API and local platforms.

Change-Id: Ia5375031d5e8cafca808d52c71dde70f80e841e9
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoUpdate package list before installing in CircleCI 13/69113/1
Cédric Ollivier [Wed, 27 Nov 2019 09:42:41 +0000 (10:42 +0100)]
Update package list before installing in CircleCI

It currently fails:
https://app.circleci.com/jobs/github/collivier/functest/189

Change-Id: I8d3e2f468c6c44fa2b680f0370100d2bcf786601
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoFix CNTT tempest_slow regex 02/69102/1
Cédric Ollivier [Tue, 26 Nov 2019 21:24:18 +0000 (22:24 +0100)]
Fix CNTT tempest_slow regex

It also deactivates ipv6 tests as for tempest_scenario.

Change-Id: Ie383e9c5b96fa4b7c989979a8c0bc8d9875d95ef
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoAdd tempest_scenario and tempest_slow in smoke-cntt 36/69036/1
Cédric Ollivier [Tue, 26 Nov 2019 17:02:37 +0000 (18:02 +0100)]
Add tempest_scenario and tempest_slow in smoke-cntt

The testcases related to ipv6 are currenty not executed because they
cannot be covered by our SUTs.

Close cntt-n/CNTT#696

Change-Id: Ic0ca3818011bede965702e778f37752059c86173
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoAdd functest-benchmarking-cntt 35/69035/1
Cédric Ollivier [Tue, 26 Nov 2019 17:24:43 +0000 (18:24 +0100)]
Add functest-benchmarking-cntt

It configures Rally to verify the mandatory services asked by CNTT.
It also prepares the next benchmarking (API and dataplane) KPIs.

Change-Id: Ie8701ddfa1a497f8b1a6f839e6ff7a77849b618c
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoComplete tempest_full for CNTT Compliance 15/69015/2
Cédric Ollivier [Tue, 26 Nov 2019 12:17:35 +0000 (13:17 +0100)]
Complete tempest_full for CNTT Compliance

It forbids skipping any test and counts the testcases executed.

It mosly avoids running tests accoring to the upstream skip tests
(known bugs), related to nova-network, glance v1, keystone v2 and
all features defined as optional by CNTT.

It fixes an issue highlighted by yallint.

Change-Id: Ib4678cb9e9fc37b16fcf21d8418931eae0f667d0
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoAdd tempest_full in Compliance 10/69010/1
Cédric Ollivier [Tue, 26 Nov 2019 00:02:36 +0000 (01:02 +0100)]
Add tempest_full in Compliance

Change-Id: Ib2898d48d21704a06cf1f4574df81f4f0dae3f52
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoUpdate scheduler_available_filters 09/69009/1
Cédric Ollivier [Tue, 26 Nov 2019 01:24:20 +0000 (02:24 +0100)]
Update scheduler_available_filters

Else few tests are skipped if DifferentHostFilter is not available.

Change-Id: Idfc524216dc8503e590d4fed569a43e99ea22123
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoMerge "Add rally_sanity"
Cedric Ollivier [Mon, 25 Nov 2019 20:02:56 +0000 (20:02 +0000)]
Merge "Add rally_sanity"

4 years agoMerge "Verify additional Nova features"
Cedric Ollivier [Mon, 25 Nov 2019 19:55:06 +0000 (19:55 +0000)]
Merge "Verify additional Nova features"

4 years agoSwitch to OPNFV Clearwater repository 60/68960/4
Cédric Ollivier [Sun, 24 Nov 2019 11:39:41 +0000 (12:39 +0100)]
Switch to OPNFV Clearwater repository

Project Clearwater is backed by Metaswitch Networks [1].
They will therefore not be reinstating the 14.04 Project Clearwater
repo server.

Then all binaries have been compiled and published on
http://artifacts.opnfv.org/functest/clearwater/debian

Then it updates sources.list.d/clearwater.list

[1] https://www.projectclearwater.org/

Change-Id: I529e59f8aeeafb96bafb7da8a1cce5c4c5a9e031
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoVerify additional Nova features 44/68944/3
Cédric Ollivier [Thu, 21 Nov 2019 12:52:51 +0000 (13:52 +0100)]
Verify additional Nova features

Our SUT allows verifying the next Nova features
  - shelve
  - vnc_console
  - cold_migration

attach_encrypted_volume is now False because of ceph.

It writes the tempest default values to ease highlighting the overall
configuration.

Change-Id: Ib9ebc8e5b390ea99edf2c3aacbd873c5eb6e7abc
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoSet manage_volume_ref and manage_snapshot_ref 51/68951/1
Cédric Ollivier [Fri, 22 Nov 2019 19:43:53 +0000 (20:43 +0100)]
Set manage_volume_ref and manage_snapshot_ref

Ceph doesn't conform with the LVM driver and asks for modifying the
manage volume and snapshop refs [1].

It allows passing test_unmanage_manage_snapshot [2].

[1] https://opendev.org/openstack/tempest/commit/ebc752b59dd3e2164807930e31b313a92bce70d5
[2] http://artifacts.opnfv.org/functest/functest-opnfv-functest-smoke-latest-tempest_full-run-480/tempest_full/tempest-report.html

Change-Id: I8d3b2484ba5cbd203c32fa446fa27e17a80888d5
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoConform with latest SUT updates 43/68943/2
Cédric Ollivier [Wed, 20 Nov 2019 23:33:01 +0000 (00:33 +0100)]
Conform with latest SUT updates

Ceph is now used as backend which requires few adaptations for live
migration. It differs from the main OpenStack gates but suits CNTT and
most of the feedbacks received from enduser deployments.

Change-Id: If6b76a7d4ec09f90467f3e63618c15a9b413bfbd
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoUpdate Xtesting 0.84 29/68929/1
Cédric Ollivier [Mon, 18 Nov 2019 20:05:27 +0000 (21:05 +0100)]
Update Xtesting 0.84

It bypasses the current S3 compat limitation as proposed by google
(multipart upload).

Change-Id: Id702bf32e41e0d2ff904f1e22df1998857454106
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoFix details in Rally 19/68919/1
Cédric Ollivier [Sun, 17 Nov 2019 11:46:28 +0000 (12:46 +0100)]
Fix details in Rally

self.details is now a dict and summary is located under root [1].

[1] https://build.opnfv.org/ci/job/functest-opnfv-functest-smoke-hunter-rally_sanity-run/422/console

Change-Id: Ic89e674b2f6660704b9dafe6070a224753e2af46
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoUpdate to Xtesting 0.83 09/68909/1
Cédric Ollivier [Sat, 16 Nov 2019 15:44:27 +0000 (16:44 +0100)]
Update to Xtesting 0.83

It supports mimetypes and then eases reading the reports from browser.

Change-Id: Ic38fca9fb05ca1ad76b589800b22bc78882c7806
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoMerge "Correctly override dir_results and res_dir"
Cedric Ollivier [Sat, 16 Nov 2019 13:36:34 +0000 (13:36 +0000)]
Merge "Correctly override dir_results and res_dir"

4 years agoMerge "Add tempest_keystone in CNTT API Compliance"
Cedric Ollivier [Sat, 16 Nov 2019 13:36:08 +0000 (13:36 +0000)]
Merge "Add tempest_keystone in CNTT API Compliance"

4 years agoCorrectly override dir_results and res_dir 97/68897/1
Cédric Ollivier [Sat, 16 Nov 2019 13:01:05 +0000 (14:01 +0100)]
Correctly override dir_results and res_dir

Both have to be modified else publishing artifacts fails [1].

[1] https://build.opnfv.org/ci/job/functest-opnfv-functest-healthcheck-latest-tempest_smoke-run/555/console

Change-Id: Ibd110e4b57cb443b12adea73f73c8cdf7f828652
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoOptimize lxml build if arm 93/68893/1
Cédric Ollivier [Sat, 16 Nov 2019 10:38:08 +0000 (11:38 +0100)]
Optimize lxml build if arm

Else it raises timeouts on travis-ci.org:
https://www.travis-ci.org/collivier/functest/builds/612068457
https://www.travis-ci.org/collivier/functest/builds/612116863
https://www.travis-ci.org/collivier/functest/jobs/612116916

Change-Id: Id34144ebcdf3f418d5a07068434eb7aa96b023d2
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoAdd rally_sanity 92/68892/1
Cédric Ollivier [Fri, 15 Nov 2019 21:18:02 +0000 (22:18 +0100)]
Add rally_sanity

Gnocchi and Barbican are not currently selected by CNTT.
Then they are removed from the optional list.

Change-Id: I46d16b2cabd832b2655606b0708a6f43721cb3c5
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoAdd tempest_keystone in CNTT API Compliance 88/68888/1
Cédric Ollivier [Fri, 15 Nov 2019 20:32:08 +0000 (21:32 +0100)]
Add tempest_keystone in CNTT API Compliance

It excludes test_federated_authentication as federation is currently
optional [1].

Close cntt-n/CNTT#624

[1] https://github.com/collivier/CNTT/commit/2e4ae5d0f4ebf4ef4bbc2504ed6cd46388361c09

Change-Id: Ie322e7912c429543c5da92f8afb33de3e8e75c8a
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoTest identity project_tags and application_credentials 87/68887/1
Cédric Ollivier [Fri, 15 Nov 2019 19:27:32 +0000 (20:27 +0100)]
Test identity project_tags and application_credentials

Both are supported by OpenStack and Functest gates.
It also sets the default values to highlight the coverage.

Change-Id: Iae080a8bde0c411acc7811e7a0e70e3471db8c98
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoAdd tempest_cinder in compliance 54/68854/1
Cédric Ollivier [Sun, 10 Nov 2019 16:58:40 +0000 (17:58 +0100)]
Add tempest_cinder in compliance

It conforms with Cinder Microversions and Feature [1].
It cleans the testcases which require CNTT updates (Keystone, Glance,
Nova, etc.)

[1] https://github.com/cntt-n/CNTT/pull/577

Change-Id: I8e719e9f48d70a860c0f879117144bb3ce6f4875
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoAdd features volume testing 53/68853/1
Cédric Ollivier [Sun, 10 Nov 2019 15:12:29 +0000 (16:12 +0100)]
Add features volume testing

The next features are supported by Functest SUT:
 - backup
 - snapshot
 - clone
 - manage_snapshot
 - manage_volume
 - volume_revert

Change-Id: I0e83bb616a56b9e8651115bebf2373f85c642260
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoUpdate neutron-tempest-plugin-api regex (CNTT) 52/68852/2
Cédric Ollivier [Sun, 10 Nov 2019 14:09:45 +0000 (15:09 +0100)]
Update neutron-tempest-plugin-api regex (CNTT)

It conforms with the last updates in API [1] adding Neutron QoS and
Trunk as mandatory.

QosMinimumBandwidthRuleTestJSON is skipped as it's not covered by
OpenStack (and Functest) gates.

[1] https://github.com/cntt-n/CNTT/pull/463

Change-Id: I54ff5e1fdb9b1e7265c63e3f66dfcf2f10db07d5
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoSet provider_vlans in tempest Neutron_plugin_options 51/68851/1
Cédric Ollivier [Sun, 10 Nov 2019 13:43:31 +0000 (14:43 +0100)]
Set provider_vlans in tempest Neutron_plugin_options

Few tests are skipped if this value is unset.
Then it's needed to fully cover Neutron Trunk (Compliance).

Change-Id: Ife4becb7ff8b47c2d90fc6c5eb4f585685205ed6
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoBuld cntt containers in a specific stage 43/68843/1
Cédric Ollivier [Sun, 10 Nov 2019 08:04:38 +0000 (09:04 +0100)]
Buld cntt containers in a specific stage

They must be built after smoke.

Change-Id: I939ef6c4663ad940c9f1b95440980628c4880385
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoUpdate to Xtesting 0.82.0 35/68835/1
Cédric Ollivier [Sat, 9 Nov 2019 18:48:10 +0000 (19:48 +0100)]
Update to Xtesting 0.82.0

Change-Id: Ie94b35c9107c851bf0a412c1361629e0cf4154a2
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoUpdate Xtesting to 0.81 01/68801/5
Cédric Ollivier [Thu, 7 Nov 2019 07:03:33 +0000 (08:03 +0100)]
Update Xtesting to 0.81

It contains a key fix about bucket creation.
It also changes the Rebaca link which sometimes breaks sphinx
spellcheck.

Change-Id: Iaa7c791ad9a70c9fb65288557c5c8e8cddb5f2d0
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoUpdate xtesting to 0.80.0 66/68766/1
Cédric Ollivier [Sat, 2 Nov 2019 20:45:58 +0000 (21:45 +0100)]
Update xtesting to 0.80.0

It allows publishing the artifacts via Xtesting.
It's required by the new Xtesting Ansible role [1].

[1] https://github.com/collivier/ansible-role-xtesting/commit/8c62525bb0d0b5f8dcc2c4436711d5d075de8811

Change-Id: I832e5e19467c7fd86a46574448faad4d6f2d4c0d
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoPin sphinxcontrib-spelling (4.3.0) 65/68765/1
Cédric Ollivier [Sat, 2 Nov 2019 21:23:56 +0000 (22:23 +0100)]
Pin sphinxcontrib-spelling (4.3.0)

Change-Id: I926d8e4cfd344f7177f2d2ad130b226a6726f214
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoTemporarily switch to xrally_kubernetes pull request 46/68746/1
Cédric Ollivier [Fri, 1 Nov 2019 14:44:43 +0000 (15:44 +0100)]
Temporarily switch to xrally_kubernetes pull request

The pull request "Remove deprecated extensions/v1beta1 API" [1] is
needed by Functest master and Jerma.

It will be safely reverted once the pull request is merged.

[1] https://github.com/xrally/xrally-kubernetes/pull/46

Change-Id: Ifaab89654a5b75a5948a0a5ccdb6e39349ce5cb4
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
4 years agoMerge "Publish functest-cntt-smoke"
Juha Kosonen [Tue, 29 Oct 2019 09:13:44 +0000 (09:13 +0000)]
Merge "Publish functest-cntt-smoke"

4 years agoMerge "Add keystone-tempest-plugin"
Cedric Ollivier [Tue, 29 Oct 2019 09:06:35 +0000 (09:06 +0000)]
Merge "Add keystone-tempest-plugin"

4 years agoMerge "Add cinder-tempest-plugin"
Cedric Ollivier [Tue, 29 Oct 2019 09:06:26 +0000 (09:06 +0000)]
Merge "Add cinder-tempest-plugin"

4 years agoMerge "Add healthcheck Horizon tests"
Cedric Ollivier [Tue, 29 Oct 2019 09:06:13 +0000 (09:06 +0000)]
Merge "Add healthcheck Horizon tests"