bugfix: Remove typo from requirements.txt

Wrong characters were inserted into requirements.txt during
modification of file license header. This bug caused issues
during installation of vsperf by installation scripts.
Problematic line was removed to avoid installation failures.

JIRA: VSPERF-489

Change-Id: I399eb8ecc7c42a9c42fb1e697dd6322fc9867951
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Marco Varlese <marco.varlese@suse.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>

Xena_pylint_fix: Fix param call to changes made by pylint patch

Missed this small issue when calling continuous streams caused
by the param name change from the pylint patch in XenaDriver.py
ca9c9275ed6d5d852987c69a378e88a3502cb2ab.

Change-Id: Ic8ad86358f72e91edea34cb37207d7dc583128b4
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

pkt_gen: STC parameter reordering bug.

This patch fixes a bug caused due to wrong parameter ordering.
stc_common_settings should come after rfc2544_common_settings.
It also gets rid of 'Import' error for module 'conf'

JIRA: VSPERF-491

Change-Id: I356294b4efdf9ebd0cea4492d3ed1cb8e04ec9b1
Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>

license: Add license info to all project files

All files were updated with license header. In case
of binary files is license stored in LICENSE file stored
in the same directory. Packages.txt was removed, because
file has not been used.List of packages differs according
OS distribution, all of neccesary packages are include in
instalation scripts

JIRA: VSPERF-489

Change-Id: I6ecae21b8db2a0f22fa5a66f9525352080f1fcc0
Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>

Merge "ci: Add SRIOV TC to CI daily job"

ci: Execute pylint checks by VERIFY and MERGE jobs

Pylint should be executed automatically for every patch
to assure, that new code meets vsperf coding standards.

JIRA: VSPERF-114

Change-Id: Icb1000e207b2d728497ff3d349fb3cb8334baac7
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>

ci: Add SRIOV TC to CI daily job

SRIOV functionality should be regularly tested to detect
any issues brought by new features. Testcase pvp_tput
will be executed by daily job for several packet sizes.
Testcase results will be reported and stored into artifactory,
but they won't be stored into result database.

JIRA: VSPERF-390

Change-Id: I9f6290b3be297a84c185681ce354bc7365b4036c
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Martin Goldammer <martinx.goldammer@intel.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>

pylint: Fixing pylint errors and warnings

All python files must reach pylint score 10/10. This will be
regularly verified by Jenkins jobs to keep constant code quality.
VSPERF specific pylintrc file was updated according to the vsperf
coding standards. Distro version included in reports will be
slightly different, due to migration to new python package distro.
Previously used platform.distro() will be deprecated since python 3.7.

JIRA: VSPERF-487

Change-Id: I934120208b9624787a3567ccaa49e14d77d7a5bf
Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>

docs: Remove hyperlinks to docs in artifacts

It is possible to use sphinx cross referencing
feature in case, that only one level of toctree
is used. Thus documentation was reorganized
to utilize just one top level index with toctree.
After that it was possible to use rst native syntax
to create a cross links among vsperf documentation
chapters. As a result only 2 hyperlinks to the
yardstick documentation are version specific.

JIRA: VSPERF-442

Change-Id: I15c2f53922e88765506448de61af4a299f5d53c5
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Martin Goldammer <martinx.goldammer@intel.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>

Merge "pkt_gen: STC - RFC 2889 Address Learning and Caching Support"

pkt_gen: STC - RFC 2889 Address Learning and Caching Support

This patch adds RFC-2889 address-learning-rate test and
address-caching-capacity tests. The patch includes following changes

1. 01_testcases.conf: testcase definitions are added for new tests
2. results_constants.py: 3 new results constants are added, removed
   unsupported constants
3. testcenter-rfc2889-rest.py: Added support to these two new
   tests. Removed un-necessary synchronization of db-file. 5 new
   configuration parameters are added - which are explained in (4).
4. trafficgen.rst: Configuration description for rfc2889 tests are
   added. Stale information is removed.
5. testcenter.py: Support for two new tests are added. Separate
   functions for results analysis and parameter settings are added.
6. traffic_controller_rfc2889.py: Calls to functions in testcenter.py,
   based on the traffic_type, are added.

Removed trailing whitespaces from trafficgen.rst

JIRA: VSPERF-395

Change-Id: Ie6ca87519b7736e7410d7f0e60904579934af24a
Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>

fedora_remove_old: Remove installation scripts for Fedora 20-22

VSPERF with DPDK 16.04 and 16.07 did not work on Fedora 20-22.
Installtion scripts for F20-F22 were deleted. VSPERF supports
F24 and F25.

JIRA: VSPERF-475

Change-Id: I3ce62b8883844cbcaab5b75fb9374068f9fced16
Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>

Merge "fedora25_install: Provide installer script for Fedora 25"

fedora25_install: Provide installer script for Fedora 25

Adds installer script for Fedora 25. Kernel version on Fedora 25
requires DPDK 16.11 and newer. VSPERF user must use DPDK and OVS
versions, which are compatible with installed kernel.

Adds new folder for current distribution with installation scripts.

JIRA: VSPERF-453

Change-Id: Icb86ea7655e95df57a8052e4a8523348a0c75dc0
Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>

info: Updated key project facts

List of commiters was updated and name of IRC channel added.

Change-Id: Ib12cc5fd9991f5918be06e0bccf5ef09dcff5628
Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>

Merge "fedora24_install: Provide installer script for Fedora 24"

fedora24_install: Provide installer script for Fedora 24

Adds installer script for Fedora 24. Kernel version on Fedora 24
requires DPDK 16.11 and newer. VSPERF user must ensure, that used DPDK
and OVS version which are compatible with installed kernel.

Adds new folder for current distribution with installation scripts.

JIRA: VSPERF-453

Change-Id: I08846d6e51faa578ea9305173174bfc49b77018a
Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>

Merge "rte_target_fix: Resolves blank rte_target issue in conf file"

rte_target_fix: Resolves blank rte_target issue in conf file

Modifies RTE_TARGET in conf/10_custom.conf which overwrites
default value in 02_vswitch.conf file.

JIRA: VSPERF-359

Change-Id: I83561d94543a6543764cd76eb4376ccdc091a4cd
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

docs: Installation doc updated

Documentation was updated as follows:
* description of vsperf downloading was added
* VNF section was updated
* additions to installation and virtualnev related parts
* file permissions of all documentaton files
was unified on 644
* README.md was updated with links to doc files
and online docs
* 3rd_party/readme was renamed and updated to follow
markdown syntax

JIRA: VSPERF-441

Change-Id: I648c6a8f0bb283bbc0875fd6fecd2539ca0c9056
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Martin Goldammer <martinx.goldammer@intel.com>

Merge "centos73_install: Provide installer script for CentOS 7.3"

Merge "dpdk_vhostuser_mq_fix: Fixes erroneous error message with MQ and dpdk"

Merge "xena_cont_accuracy_fix: Xena continuous traffic accuracy fixes"

Merge "xena_cont_learning: Adds learning preemption to continuous traffic"

docs: Upgrade instructions

New section specific to upgrade was added into documentation.
Description of configuration changes beetween Colorado and
Danube releases is discussed in detail.

JIRA: VSPERF-269

Change-Id: Ibbd1bb447e5d85c6b269ad26e10ff5d646a2bfbe
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Martin Goldammer <martinx.goldammer@intel.com>

xena_cont_learning: Adds learning preemption to continuous traffic

Adds a configurable learning preemptive option when running
xena continuous traffic tests. This resolves a missing packet
or two when running OVS tests at flow rates that should not
drop packets.

JIRA: VSPERF-473

Change-Id: I056578ed9c9181287d97aea55a002f09aac14e81
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

xena_cont_accuracy_fix: Xena continuous traffic accuracy fixes

Second patch to help improve Xena continuous traffic accuracy.
Increases delay before gathering statistics to allow packets in
flight to be received. Changes bps and fps to be calculated
based on total bytes and packets received versus capturing the
data while port is transmitting from active statistics.

Sets time limit on ports based on duration.

JIRA: VSPerf-423

Change-Id: I574819694d3141edb539de64bc16dcd6c6fcf489
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

dpdk_vhostuser_mq_fix: Fixes erroneous error message with MQ and dpdk

Removes un-needed code to set multi-queue option on vhostuser ports.

JIRA: VSPerf-471

Change-Id: I9f58e53d9a9bb62ef5ed441a7b4b1dea37a2f557
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

centos73_install: Provide installer script for CentOS 7.3

Adds installer script for CentOS 7.3. Modifications are
based on installation script for RHEL7.3.

Modified dpdk makefile to allow upstream dpdk to build.
Prevents upstream vanilla OVS from building due to kernel
incompatibilities.

JIRA: VSPERF-452

Change-Id: Iaf05de0cf2ad7f5636d9474f351d3c7d193123cf
Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>

Merge "testpmd_pvp_fix: Fix SR-IOV QemuPciPassthrough mode to not use vdev"

Merge "mrg_buff_doc: Add documentation on mergable buffer option"

mrg_buff_doc: Add documentation on mergable buffer option

Adds section about mergable buffers option to testusage doc.

Also adds drive boot type info into gotchas section of
testusage doc.

JIRA: VSPERF-459

Change-Id: I159273502663dd29f4847b0737535009a42e430d
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

docs: Ixia docs update

Ixia generator related documenation was reviewed
and updated. Links to the chapters specific to
supported traffic generators were created.

JIRA: VSPERF-454

Change-Id: I3a19b054002ac8be3ed3115bc21986b3ca4ea187
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>

docs: Dummy pre-configured results

In case of Dummy traffic generator, the test results
can be pre-configured. Configuration and examples
were described in trafficgen related chapter.

JIRA: VSPERF-458

Change-Id: I6179e98f3999e5b2df2ad4080582302bf4177cda
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>

testpmd_pvp_fix: Fix SR-IOV QemuPciPassthrough mode to not use vdev

A recent patch introduced a bug where SR-IOV would use code designed
for use with testpmd_pvp scenarios. This is because this scenario
also calls for the vswitch=none flag. This patch resolves this issue
to stop the vdev devices from being added when the vnf is specified
as QemuPciPassthrough.

JIRA: VSPERF-460

Change-Id: Ie4522b046982ec5554c3deb6a507d86ca9798124
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

Merge "traffic: Configurable traffic details"

traffic: Configurable traffic details

Traffic generated by traffic generator is based on default
values and their modifications specific to particular testing
scenario. Traffic default values were defined inside VSPERF
code and it was not possible to change them. This patch introduces
new TRAFFIC dictionary inside 03_traffic.conf. Thus user can
modify any of TRAFFIC values either in configuration file
or by CLI or by 'Parameters' section of testcase definition.
Following CLI options were obsoleted by this patch:
    'bidirectional', 'traffic_type', 'iload', 'multistream',
    'stream_type' and 'pre-installed_flows'
Following CLI option was renamed to be consistent with other options:
    'tunnel_type' => 'TUNNEL_TYPE'
Following sections of testcase definition were obsoleted:
    "Traffic Type", "biDirectional", "MultiStream", "Stream Type",
    "Pre-installed Flows", "Flow Type" and "iLoad"
New TRAFFIC dictionary should be used instead of old CLI options
and old testcase definition sections. Testcase definitons,
yardstick sample testcases and documentation were updated to reflect
configuration changes.

JIRA: VSPERF-433

Change-Id: I03a388c766491d5688e715f6d7b51e8e0377ec27
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: <sridhar.rao@spirent.com>

docs: Update NEWS section

Update NEWS with details about vsperf changes implemented
during Danube release.

JIRA: VSPERF-440

Change-Id: I3ebb010ef2a86806084c856257a6195b425b98a6
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>

Merge "testpmd_pvp: Adds pkt_fwd to allow pvp topology testing"

Merge "docs: Fix links to default test parameters"

testpmd_pvp: Adds pkt_fwd to allow pvp topology testing

Requires DPDK 16.11 or greater to support vdev flags.

Initial support for TestPMD to support guests.

Allows vsperf to execute TestPMD as a switch for pvp
test scenarios.

Can be increased in functionality later to support
multiple guest configs.

JIRA: VSPERF-406

Change-Id: I67a5a355c990ca6cfcbb5845a2beaf1c1f21f5f0
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

docs: Fix links to default test parameters

Links to the default test parameters were fixed.

JIRA: VSPERF-442

Change-Id: I775d5598799050fe44a5f0fc23a28716e24c2c76
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>

ovs-dpdk port setup: specify PCI slot.

Update to use options:dpdk-devargs coming from the Arbitray Port Naming feature
lately upstreamed in Ovs-DPDK project.
See Commit ID: 55e075e65ef9ecbd70e5e0fada2704c3d73724d8.
By this new param you can explicitly select a PCI slot for a dpdk port.

JIRA: VSPERF-449

Change-Id: Id6028cc4efbaf228a99c6f0a346a8e96a82e43a6
Signed-off-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Martin Klozik martinx.klozik@intel.com
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: <bmichalo@redhat.com>
Reviewed-by: <sridhar.rao@spirent.com>

Merge "rhel73_install: Provide installer script for RHEL 7.3"

rhel73_install: Provide installer script for RHEL 7.3

Adds installer scripts for RHEL 7.3 OS.

Modified dpdk makefile to allow upstream dpdk to build.

Prevents upstream OVS from building due to kernel incompatibilities.

Provides instructions on setting up RHEL 7.3 for usage with binary
OVS packages when testing with OVS Vanilla.

Tested under RHEL 7.3

JIRA: VSPerf-322

Change-Id: If294d465f28f60a1c514a7b661ce4696ac3b5b73
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

Merge "pkt_gen: STC - Handle Results DB file synchronization failures."

pkt_gen: STC - Handle Results DB file synchronization failures.

If the downloading of results-database file fails, the CSV file and
corresponding results are not generated - eventhough the test was
successful.
This small patch handles such cases.

Updated the logging to be more explicit.

JIRA: VSPERF-435

Change-Id: I14bf519fbca2ea362777e29920bc1759494965e0
Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>

bugfix: Ethernet type and vnf stop fixes

Usage of ethernet type for IPv4 was harmonized, to use
0x0800 at all places. Together with this fix a bug during
VNF cleanup was removed - VNF started by TestSteps are
tested for validity before the call of their stop() method.
It avoid vsperf crash in case, that VNF was not properly
started.

JIRA: VSPERF-436

Change-Id: Ic1a36919f5c9d707aa0aad64b5d96a1214c56cb3
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>

Merge "install: Ubuntu 16.xx support"

conf: traffic type naming step2

Update of the rest of old traffic type names.

JIRA: VSPERF-420

Change-Id: Icf4bab7afad09f9b48ee25b9ff020c83cf2e02bd
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: <sridhar.rao@spirent.com>

install: Ubuntu 16.xx support

Installation scripts were updated to support Ubuntu 16.04 LTS
and Ubuntu 16.10. Ubuntu 16.10 uses kernel 4.8, which is supported
since DPDK 16.11. It is up to the vsperf user to use DPDK and OVS
versions compatible with active Linux kernel.

JIRA: VSPERF-408

Change-Id: Ifb71de72cf6d4f9d6e2319cb5c1d7d5dcbe5314f
Signed-off-by: Goldammer, MartinX <martinx.goldammer@intel.com>
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: <sridhar.rao@spirent.com>

Merge "conf:Traffic-type naming convention and consistency"

conf:Traffic-type naming convention and consistency

Following changes are added following first review
1. Descriptions in integration/01_testcases.conf
2. Comment in conf/01_testcases.conf
3. Checking all cases of traffic types in traffic_controller_rfc2544.py
4. Removing whitespaces
5. Missing changes (throughput->rfc2544_throughput)
6. Syntax error in core/traffic_controller_rfc2544.py

Currently the traffic-type values that are provided as part of the
test case definition needs some fix to support additional traffic
- apart from rfc2544. The Current and the proposed changed is summarized
in the below table:

|--------------------------------------------------------------------|
|  Parameter  | Existing traffic_type value |    Changed to          |
----------------------------------------------------------------------
| Throughput  | rfc2544  OR throughput      |   rfc2544_throughput   |
----------------------------------------------------------------------
| Back2Back   | back2back                   |   rfc2544_back2back    |
----------------------------------------------------------------------
| Continuous  | continuous                  |   rfc2544_continuous   |
----------------------------------------------------------------------

JIRA: VSPERF-420

Change-Id: I22bd897f6389d2b568a6a3735c67f0003e813445
Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>

Merge "scl_fix: Fix broken link to install python33"

Merge "pkt_gen:  MoonGen updated to keep parity with master"

Merge "yardstick: CLI params support for yardstick TCs"

scl_fix: Fix broken link to install python33

Fixes broken link to download python33 rpm scl installer.

Replaces Centos with software collections recommended method
to install Python33.

Adds temporary repo for Rhel7.2 to install python33.

Verified on Centos7.2 and Rhel7.2.

JIRA: VSPerf-429

Change-Id: Id86748e898f1d81011d19024d9ff2c0e9a47479f
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

pkt_gen:  MoonGen updated to keep parity with master

Need to make VSPERF's MoonGen codebase in parity with master emmerich
MoonGen branch.

JIRA:  VSPERF-400

Change-Id: I8c50ed89c9e7b0080497107c1af826f49c1e82f0
Signed-off-by: bmichalo <bmichalo@redhat.com>

yardstick: CLI params support for yardstick TCs

Vswitchperf specific class in yardstick was updated to reflect
new functionality of --test-params. These changes have impact
on vsperf documentation and yardstick samples.
As part of this fix following changes were made:
* trafficgen mode can be executed with default configuration
* yardstick specific TC samples were updated
* dummy traffic generator was enhanced to support back2back
* dummy traffic generator was enhanced to accept traffic
results from configuration

JIRA: VSPERF-422
JIRA: VSPERF-205

Change-Id: Ibeaa6ef46bde453e3ca5dee6e4568fc8c3853521
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: <sridhar.rao@spirent.com>

ci: Configure hugepages directly from CI script

In case of CI it is better to enforce hugepages
allocation. Just for case, that hugepages were
left enabled by last vsperf execution or by
another job.

JIRA: VSPERF-391

Change-Id: I0531b2a8a1e5024d73c227377dd9c487d6931c35
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>

Merge "Xena_cont_accuracy: Modify continuous from duration to packet limit"

Merge "ci: Use HTML report instead of PDF"

Merge "Rebase to fuel 10.0 for fuel@opnfv D release"

Merge "Rhel_scl_python: Modify python build in place to scl usage"

ci: Use HTML report instead of PDF

After the switch to opnfvdocs script for documentation
build, the pdf version of documentation is not generated.
HTML report should be stored inside artifactory instead.

JIRA: VSPERF-324

Change-Id: I42f918721264959ba7c94223204d83ce1fe8ad60
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Otto Sabart <osabart@redhat.com>

Merge "report: [fix] remove upper border of a process table"

Xena_cont_accuracy: Modify continuous from duration to packet limit

First of a few patches planned to help increase Xena continuous
traffic accuracy. Modifies port limits to packet calculated limits
versus time based limits which can be wildly inaccurate. Also
modifies some port settings to be more inline with how rfc2544
settings are applied on Xena. Increased time delay by one
second to allow packets to finish transmitting before stat
collection occurs.

JIRA: VSPerf-423

Change-Id: I214b13d743a84a0733e885ccfc5bdd57812d7104
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

ci: Decrease hugepages size for VERIFY&MERGE jobs

VSPERF by default requires allocation of hugepages with total
size of 10GB. However for MERGE and VERIFY jobs less memory is
required and default size of 10GB can cause issues. Thus amount
of memory was limited and other minor enhancements were introduced:
* sysstat system package is installed at nodes running VERIFY
  and MERGE jobs
* WHITELIST_NICS was set to empty list by default to avoid
  automatic bind of NICs to DPDK. Old default value could
  cut off network connection to DUT.
* imports were fixed at both integration.py and testcase.py

JIRA: VSPERF-391

Change-Id: Ic07d68f4591ae697c1b8edeae6c0cffe47c065ce
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>

Rhel_scl_python: Modify python build in place to scl usage

Previously Rhel install script would build python 3 in place using
downloaded bits. It was suggested to change this to use scl method
instead. This patch modifies the build in place to use scl method
as per Centos scripts.

JIRA: VSPERF-258

Change-Id: I5b6d7b8fd7f96a315d04e1ccdfd381908e0d1ad0
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

INFO: modified committer list

Change-Id: I709dd316b1c53fa632c1a6ff192b13d1756669d0
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>

Merge "cli: Modify configuration via CLI"

cli: Modify configuration via CLI

In the past, only a few configuration parameters could be
modified via --test-params CLI argument and it was not easy
to find out their complete list.
This patch adds support for generic modification of any
configuration parameter via CLI argument --test-params
or by "Parameters" section of testcase definition.
Thus it is possible to customize a vsperf configuration
environment per testcase or for each vsperf execution.
Old CLI parameters duration, pkt_sizes, rfc2544_tests
and rfc2889_trials were renamed to TRAFFICGEN_DURATION,
TRAFFICGEN_PKT_SIZES, TRAFFICGEN_RFC2544_TESTS and
TRAFFICGEN_RFC2889_TRIALS to be consistent with
other configuration parameters.

JIRA: VSPERF-375

Change-Id: I50a1f4ff7250d754aa8af0295a9c7c1be8151175
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: <sridhar.rao@spirent.com>

bugfix: Trafficgen Ixia does not work

IXIA traffic generator can be controlled by two different
VSPERF's wrappers IxNet (preferred) and Ixia (legacy and
outdated). It has been found, that Ixia wrapper can't be used
because of missing "packetsize" traffic item. Also only
IXIA OS 6.60 was supported and never IXIA OS versions
were not working. Both limitations were fixed.
Also reported results were fixed to show correct values
for MBPS items.

JIRA: VSPERF-417

Change-Id: I191aa9fee2683877ce373b6aa7cd1c72e9847568
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Christo Kleu <christo.kleu@netronome.com>

teststeps: Generic support of step driven tests

In the past, step driven testcases were supported
only by integration testcases. This patch adds generic
support of TestSteps for both integration and performance
testcases. Step driven test were improved to support
modification of existing deployment. As part of
the patch a refactoring of traffic controllers
were performed. Traffic controllers were modified
to support trafficgen-off and trafficgen-pause
modes in all possible ways of trafficgen invocation.

JIRA: VSPERF-362

Change-Id: Ic8b7a9b0e7165f0a15a52279ed0f0952da9fedb8
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>

guest_binding: Add dpdk driver binding options for guests

Adds uio_pci_generic and vfio_no_iommu options for guest
driver binding. In case of SR-IOV tests with guests attached
and uio_pci_generic is selected the option will be modified
to use igb_uio instead as uio_pci_generic is not supported.

JIRA: VSPERF-397

Change-Id: I56003addacc8bf0d024cce35d41b00dd0baa8cbc
signed-off-by: Christian Trautman <ctrautma@redhat.com>

Merge "ci: Enhance verify and merge jobs"

ci: Enhance verify and merge jobs

Verify and merge jobs will execute real vsperf TCs,
which won't require neither physical NICs nor traffic
generator. Script ./build-vsperf.sh will take care about
creation, update and activation of python virtual environment.
It will also install required system packages at nodes
running merge and verify jobs.
Additional improvements:
* set of simple sanity checks was added
* two new integration TCs were added; However test with
  VNF is not used now, because it requires a VM image.
* detailed logs are shown in case of failure

JIRA: VSPERF-391

Change-Id: I33e75e762fdc62656de92dc34f0ad7a484623603
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Fatih Degirmenci <fatih.degirmenci@ericsson.com>

doc: fix copy-paste error in Moongen configuration section

JIRA: VSPERF-414

Change-Id: I1924c8a0c949695b4ec0699a206b9e39ee2ef724
Signed-off-by: Otto Sabart <osabart@redhat.com>

Merge "testpmd: Simplify GUEST's testpmd configuration"

testpmd: Simplify GUEST's testpmd configuration

Testpmd has a lot of parameters and vsperf was able
to modify only a few of them through dedicated GUEST's
specific configuration options. Old configuration
options were replaced by one generic GUEST_TESTPMD_PARAMS,
which allows to modify any of existing testpmd parameters.
Detection of testpmd execution was changed to be independent
on TXQ flags setting.
Documentation was modified to reflect GUEST_TESTPMD change.
Also doc formatting was fixed at several places.

JIRA: VSPERF-380

Change-Id: Ie0bf290320f3b22ef6be6b55ed553235bbcb4aff
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>

licenses: Dedicated directory for non Apache files

All files, which do not comply to Apache 2.0 license,
are moved into dedicated 3rd_party directory. This will
simplify license checks performed on vsperf code.
It is not required to move l2fwd module from its
current location.

JIRA: VSPERF-413

Change-Id: I6b4bd6bb5542e6db9a7ef91ee3f5f2907f93e9b8
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>

Merge "IETF Draft: Comments from IETF-96"

report: [fix] remove upper border of a process table

According to Markdown Tables extension specification, there should be no upper
border in the table.

See for example python implementation of Markdown Tables extension [0][1].

[0] https://pythonhosted.org/Markdown/extensions/tables.html
[1] https://michelf.ca/projects/php-markdown/extra/#table

JIRA: VSPERF-411

Change-Id: I2843dbeb4544a1d1fe0a5f1a6b1028ae788a28ee
Signed-off-by: Otto Sabart <osabart@redhat.com>

vsperf: launch should not depend on current $PWD

JIRA: VSPERF-392

Change-Id: I44866b7d3298617003b87b015eb08bf32c4014f7
Signed-off-by: Otto Sabart <osabart@redhat.com>

Merge "integration: Test vHost User numa awareness"

IETF Draft: Comments from IETF-96

JIRA: VSPERF-410

x Ramki on OVS features - the scope of benchmarking does not include
the ever-growing list of OVS features, only the general and
switch-agnostic features will be assessed.

x Justify the length of SOAK tests (with variability allowed),
mention that the goal is stability characterization, not
the typical short term benchmarks of performance.

x Fix the LTD Reference to point to Brahmaputra version
(which is frozen in the release docs)

Change-Id: I2f795cd42e7ec2e06e5cd35bbf0c1f336a5e43ca
Signed-off-by: Al Morton <acmorton@att.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Billy O'Mahony<billy.o.mahony@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>

CLI: add Multiqueue params.

This patch implements the following new CLI parameters that
can be used in the --test-params list.

 1. guest_nic_queues, which overrides all GUEST_NIC_QUEUES values
 2. guest_testpmd_txq, which overrides all GUEST_TESTPMD_TXQ
 3. guest_testpmd_rxq, which overrides all GUEST_TESTPMD_RXQ
 4. guest_testpmd_nb_cores, which overrides all GUEST_TESTPMD_NB_CORES
    values
 5. guest_testpmd_cpu_mask, which overrides all GUEST_TESTPMD_CPU_MASK
    values
 6. vswitch_dpdk_multi_queues, which overrides VSWITCH_DPDK_MULTI_QUEUES
 7. guest_smp, which overrides all GUEST_SMP values
 8. guest_core_binding, which overrides all GUEST_CORE_BINDING values

When they are present in the CLI the corresponding settings from the
configuration files will be overridden.

As an example a usage can be:
./vsperf --test-params "guest_nic_queues=2;guest_testpmd_txq=1;\
guest_testpmd_rxq=1;guest_testpmd_nb_cores=1"...

v2: rebase + rework to add other CLI params as suggested and update doc.
v3: changes in 'testusage.rst' doc.

JIRA: VSPERF-371

Change-Id: I140d6e068c1653d21aaa0df27532a48c4a12c151
Signed-off-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>

Merge "Integration Test: 4 serial VMs testcases."

Rebase to fuel 10.0 for fuel@opnfv D release

Change-Id: I3ebe6876bd0f04218489d2c7d21dcd401a2ee48a
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>

integration: Test vHost User numa awareness

Open vSwitch with DPDK can optimize memory usage
in case of NUMA architecture to avoid unnecessary
memory access across NUMA slots. In a nutshell,
PMD threads serving virtual NICs are co-located at
the same NUMA slot as QEMU instance, which is using
these NICs.
This patch adds new (functional) integration testcase,
which verifies OVS vHost User numa awareness feature.
Step driven test objects were updated to allow a call
of OS utilies and evaluation of conditions. Also the
documentation was updated with the list of supported
test objects and their methods.

JIRA: VSPERF-377

Change-Id: I184e71e066d27b5b9fc9e6a9f7e240e2d1b5a0fa
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Ciara Loftus <ciara.loftus@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>

Merge "pkt_gen: Spirent Testcenter RFC 2889 Support"

Merge "cmd_timeout: Add ovs command timeout configuration option"

cmd_timeout: Add ovs command timeout configuration option

Adds option for configurable timeout for ovs commands.

JIRA: VSPERF-396

Change-Id: Ie73dfea1a088a5c92bef705f1fe874ddeeaec5a7
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

bugfix: Correct VM handling by integration tests

Patch with multi VM support has changed the way
how data are copied into the shared folder. Also
new support of GUEST_ options expansion requires
proper initialization with exact number of VMs
involved in the test.
Code of class specific to integration tests
was updated to initialize both GUEST_ options
and VM shared dir correctly.
Original values of all GUEST_ options are restored
after the testcase execution. So other TCs can
use original values for configuration expansion
to required number of VMs.

JIRA: VSPERF-361

Change-Id: Ic1149fbc73f73a66982bb64173b2217e55597200
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>

ci: Update default DPDK and OVS versions

VSPERF was updated to use DPDK16.07 and OVS 2.6.90
by default. This change should improve a performance.
It will also solve failures of VSPERF verify and merge
jobs at OPNFV Jenkins, because newer OVS version is
compatible with Linux Kernel 4.4.

JIRA: VSPERF-378

Change-Id: I636dd96facd3f6357f215290eb2382c9cc16150e
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>

bugfix: Qemu shared dir failure

In case of testpmd or l2fwd loopback app, VSPERF copies
sources if these tools into qemu shared folder. Maximum
size of folder content is limited to approx. 500MB. This
limit is exceeded in case that DPDK is built for multiple
RTE_TARGETs. Unnecessary files are excluded from the
copy to spare size inside shared folder.

JIRA: VSPERF-398

Change-Id: Iab31a6ff2397f7031eae6a95d424317c3343d4d9
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>

pkt_gen: Spirent Testcenter RFC 2889 Support

The changes/additions, apart from spirent testcenter-specific, also
includes
to some files in conf (01_testcase and 03_traffic) and core (result-
constants, traffic_controller and component_factory) folders.

Currently, only RFC2889 Forwarding testcase is supported.

Incorporated following review suggestions:
1. Log level fixes
2. Removing unused function in results_constants.py
3. Added documentation to docs/configguide/trafficgen.rst. Userguide
   will be updated once other RFC2889 tests are implemented.
4. string matching in component_factory.
5. Remove Trailing Whitespaces

JIRA: VSPERF-286

Change-Id: I0195720ab2f8cf2c3a5aa490d66166bdca0afcb0
Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>

Merge "paths: Support binary packages"

paths: Support binary packages

Currently VSPERF supports OVS, DPDK and QEMU built
from the source code only. In some cases it is required
to support installation of these tools from binary packages
available for given linux distribution. Thus VSPERF
configuration and code was modified to suport both source
and binary versions of tools. This can be configured perf
tool, so various combinations of source and binary version
are supported.
Together with new configuration also a handling of kernel
modules was modified to automatically detect and load module
dependencies.

JIRA: VSPERF-340
JIRA: VSPERF-339

Change-Id: I855cb438cbd8998bdc499613ea5e7de2526299d7
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Otto Sabart <osabart@redhat.com>

merge_buffers: Add option to disable merge buffer on qemu startup

In cases with VHost user and non-jumbo frame scenarios we can
disable merge buffers on the guest NICS to improve performance.
This patch adds this option to the 04_vnf conf file.

JIRA: VSPERF-388

Change-Id: Ic1f776e90fdccaa5d5a0c952c96811a8747fe936
Signed-off-by: Christian Trautman <ctrautma@redhat.com>