gerrit.opnfv Code Review - vswitchperf.git/log

xena_bug: Resolve baseconfig reporting option to work with new versions

Fix baseconfig to work with new Xena2544.exe versions. Reporting
option for latency/jitter collection has changed.

Added note to trafficgen document reflecting recommended version
to use for Xena2544.exe.

JIRA: VSPERF-311

Change-Id: I1974ea3c9f9e4c0935fc8adead6ddd5a92a16a04
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

Xena: Modify xena_json for back2back options

Add method set_test_options_back2back in code to modify duration,
iterations, and flowrate for back2back options in the json file.

JIRA: VSPERF-305

Change-Id: I1337318e7519fbd7b5a71bb26a1c62fcd8c2b66c
Signed-off-by: tli <tli@redhat.com>

xena_burst: Add Xena Burst traffic

Add Xena burst traffic functionality.

JIRA: VSPERF-263

Change-Id: I6336e5fcb33c0f66ee87f0f14f1b795937e3d00d
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

results: Write trafficgen results into CSV

Write test results provided by traffic generator into CSV file
also in case, that trafficgen mode is selected.

JIRA: VSPERF-288

Change-Id: Ib55f9f81aadef7dd20a5dce4b000dc2c9607cb95
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>

Merge "xena_bug: Fix throughput stats with bi-directional traffic"

Merge "linux_bridge_guest: Modify packet structure for linux bridge tests"

Merge "INFO: update committer list"

Merge "xena_cont: Add Xena continuous traffic functionality"

Merge "Throughput and Latency Profile Test: Clarify"

src: update dpdk, ovs and qemu versions

Update dpdk, ovs and qemu versions to overcome build errors on the vsperf commit gate.

Change-Id: I579d731756bb27c37b0f4e38ff91bf36a7bd06de
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>

linux_bridge_guest: Modify packet structure for linux bridge tests

Change packet structure for pvp/pvvp tests that use the linux
bridge as the loopback to include the tgen mac address instead
of the guest nic mac addresses in layer 2.

This change is due to the old way not working with Xena traffic
generators. Ixia works with both the old and new way.

* Verified to work with Xena
* Verified to work with Ixia

JIRA: VSPERF-307

Change-Id: Ieca0c58610797d9d5c726ba9f21227e255958092
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

Throughput and Latency Profile Test: Clarify

Make clear that 'max' refers to RFC2544 Throughput not line rate.

Change-Id: I968c1f99920b6ab0a3009622cb16c67daf5e3373
Signed-off-by: Billy O'Mahony<billy.o.mahony@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Gurpreet Singh <gurpreet.singh@spirent.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>

INFO: update committer list

Change-Id: Ia55c4c98fc70ce5eafe22b3a99f71646b0309932
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Aric Gardner <agardner@linuxfoundation.org>
Reviewed-by: Al Morton <acmorton@att.com>

xena_cont: Add Xena continuous traffic functionality

* Adds XenaDriver.py module to allow direct communication to
Xena chassis through socket API and collect stats.
* Adds implementation into xena.py for continuous traffic
flow.

JIRA: VSPERF-262

Change-Id: I6f975bc205e3c954215eb16466f11298e3fcdfaf
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

Merge "integration_doc: Update integration document"

xena_bug: Fix throughput stats with bi-directional traffic

Fix xena throughput stats for bi directional traffic by
taking the receive numbers from both ports instead of
a single port.

JIRA: VSPERF-303

Change-Id: I3898afe00f8c80f54e5b4c210831e1fc6cef3c20
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

integration_doc: Update integration document

Update integration document to reflect tests are not
just overlay tests.

* Include instructions for using macros
* Include information on test step validation

JIRA: VSPERF-298

Change-Id: Ic0d5f277b2a8b646f331e967f83421708b374f21
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

Merge "Rebase to fuel 9.0 and add vagrant based build and enhance some scripts"

bugfix: Remove dependency on ifconfig

VSPERF uses ifconfig at several places to bring up
a networking interface. However ifconfig has been
deprecated by iproute2 package and it is not available
in standard installation of many Linux distributions.
Thus all calls of ifconfig have been replaced by
call of 'ip' tool.

Change-Id: I935eaf85b6082e4641d12cffea3e0882c634e5ea
JIRA: VSPERF-299
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

Merge "xena_multistream_fix: Fix multistream json config"

Rebase to fuel 9.0 and add vagrant based build and enhance some scripts

Change-Id: Id3a38d662c330cd388c6509c9d6e90409c1da6e7
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>

Merge "run_task_fix: Fix run_task to provide all output from command"

Updating Committer list (Committer removals)

Change-Id: I508954206a92a96446b28f40680acb87cd916c0b
Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>

run_task_fix: Fix run_task to provide all output from command

Fix run_task to correctly provide all output from command
sent. Commands that produced longer output would not
return all text.

JIRA: VSPERF-296

Change-Id: I7e501690ffdb7c01f90d524ffbabe65500f62304
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

xena_multistream_fix: Fix multistream json config

Fix xena_json module to correctly assign hwmodifier for
multistream. Append was incorrect application and
list needs to be assigned directly.

JIRA: VSPERF-293

Change-Id: I88d1930b88711af7c920b507a4db6c29cca83d8d
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

dpdk: Support of DPDK v16.04

Configuration options modified by VSPERF were split
between config_base and config_linuxapp files. Makefile
was modified to reflect this change.
Additional changes:
* content of qemu shared dir is copied without preservation
of attributes to avoid compilation issues due misaligned
clocks => could produce broken igb_uio module
* added support of new testpmd "Bye.." message
* DPDK sources are copied from RTE_SDK_USER directory for all
VNF variants - this has been wrongly reverted by inttest patch

Change-Id: Id502a072c1f843258496decbf031e7ba7264d459
JIRA: VSPERF-297
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>
Reviewed-by: Michal Weglicki <michalx.weglicki@intel.com>

Merge "docs: updated the added features list"

docs: add gotcha for activating the python 3 env

Add instructions for gotcha when activating the python 3 env.

Change-Id: Ia531ca796ad15354974dee13033a8d97a42c7747
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>

Merge "testcase: execution time"

ovsdb: Add delay after ovsdb start

Ovsdb must be up and running before any configuration
option is modified or vswitchd is executed.
Otherwise options won't be modified in DB and/or vswitchd
won't be able to use correct options during start up.

Change-Id: I04948d383272f2e694ec685b3a21d639068125ca
JIRA: VSPERF-291
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

Merge "ovs: update to OVS 2.5"

testcase: execution time

Measure the execution time for a testcase and add it to the log. We need
to report the test execution times for the testcases for OPNFV release
C. Modified the timing result in the csv + results file to display a
H:M:S format.

Change-Id: Ife9e361da5f8b3fc3721050ae3e6dce049f7402d
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>

docs: updated the added features list

Updated the added features list in NEWS.rst. If there's anything I
missed please let me know.

Change-Id: I12dd63cbea293642f14e1ab3eb0d5b715e3a015e
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>

ovs: update to OVS 2.5

Upgrade OVS version tested to 2.5. Tested with OVS with DPDK and stock
OVS.
JIRA: VSPERF-254
Change-Id: I78f6cdca0b96c5b13524cec3a662e55f49320f69

Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>

qemu: add python path to configure

Add python path to ./configure arguments for QEMU to overcome build issue.

Change-Id: I6a29f471a27bc0088609bf78176120637709df21
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>

build_base_machine: added sysstat

Added sysstat package to build base machine for Ubuntu.

Change-Id: I648f5a8db21a7713fb5c24ef010db877c9ec4d15
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>

dpdk: Support new way of DPDK configuration in ovs-vswitchd

Configuration of DPDK options in ovs-vswitchd has changed.
Previously used option --dpdk was deprecated and all DPDK
related options have to be configured through ovsdb via ovs-vsctl
calls. VSPERF was modified to detect and use correct version
of DPDK configuration. New configuration options should
be put into VSWITCHD_DPDK_CONFIG dictionary.
VSPERF classes specific to OVS were refactored.

Change-Id: Ia3fad5906221439f477638f1f9734289dbf737bb
JIRA: VSPERF-291
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

pkt_gen: Reporting FPS and MBPS from Spirent Testcenter

Support for reporting FPS and MBPS (TX and RX) is added.

JIRA: VSPERF-285

Change-Id: Ic4b6ca02368b1808f0f985e90099cdb0b41c2afa
Signed-off-by: sridharkn <sridhar.rao@spirent.com>

Merge "bugfix: Fix creation of vsperfenv in Ubuntu"

Merge "bidirectional value: Fix inconsistency for bidir param"

Merge "hugepage_doc: Add hugepage configuration info to installation doc"

Merge "makefile: Remove obsolete copy operations"

bidirectional value: Fix inconsistency for bidir param

Fixes bi-directional param and enforces string type in
testcase configuration. Modifies all instance where bi
directional value is used to string.

* Changes documentation to specify value type as needed
* Changes traffic defaults to use string for bidir value
* Fixes testcases configuration files to use bidir as str
* Change testcase conf documentation to note enforcement
   of string type
* Sets bidir to title format to keep consitency in traffic
   profile when passed to traffic generators
* Fix pvp/pvvp check for bidir value
* Raise exception if testcase configuration is not set
   as str for bidir value
* Change Xena bi-dir check to string compare instead of
   typecasting to boolean to compare.

JIRA: VSPERF-282

Change-Id: I7c91fcd7333a1d1e1371bfd31700c01d7da268b5
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

bugfix: Fix creation of vsperfenv in Ubuntu

Wrong version of virtualenv was executed in Ubuntu
specific script. So python modules could not be installed
and vsperf was not working.
Hugepages mount point is newly created inside
sudo environment to avoid issues with permissions.

Change-Id: I4f5afc22bceb2eebbf018c42f42b7074a93e2293
JIRA: VSPERF-292
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>

bugfix: Graceful shutdown of VM - improvement

Cleanup phase of PVVP scenario sometimes causes server reboot.
Following updates were made to prevent reboots:
* better generic process termination procedure
* ovsdb is terminated after vswitchd termination
* vswitchd is terminated directly instead of parent sudo process
* already running VNFs are terminated in case of failure during
VNF start()

Change-Id: Ic09d60d7bfdea01c84a2685ede3d0316f0d09be7
JIRA: VSPERF-271
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>

hugepage_doc: Add hugepage configuration info to installation doc

Adds some documentation to the installation guide on proper
hugepage configuration to run vsperf with dpdk and/or guests.

JIRA: VSPERF-256

Change-Id: I3b85fe7d69b00841844aa82ba8faf936d7e37825
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

Merge "integration: Support of PVP and PVVP integration TCs"

makefile: Remove obsolete copy operations

In the past DPDK, OVS and QEMU were copied and compiled for all
three OVS configurations, i.e. Vanilla OVS, OVS+DPDK with vHost Cuse
and OVS+DPK with vHost User. Later compilation of QEMU was triggered
just once and DPDK compilation was removed from OVS Vanilla dir.
However source code was still copied to all directories. Unnecessary
copy operations were removed.

Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

integration: Support of PVP and PVVP integration TCs

Integration TC support has been enhanced to support PVP
and PVVP scenarios. Definition of integration testcases
have been modified to use a sort of macros for repetitive
parts.
Additional improvements were introduced:
* instances of testcases are created only for testcases
selected for execution
* new TC definition options allow to define test specific
vswitch, VNF, traffic generator and test options
* tests filter applied on pattern specified by --tests
allows to define negative filter only; In that case
list of all tests is used as base for negative filter.
* traffic values defined within teststep passed to send_traffic
is merged with default values; This is essential for execution
of TCs with linux_bridge or SRIOV support. It also simplifies
integration TC definition
* typos removed

Change-Id: Icb734a7afd7e5154f27a8ff25615a39e01f58c27
JIRA: VSPERF-213
JIRA: VSPERF-216
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

xena_port_ip: Add port ip assignment for Xena traffic generator

Adds port ip set options as part of conf files. Allows for IPv4
address assignment. Adds ipv6 options for later implementation
when available in framework.

* Adds Xena to documentation area where available traffic gens
are listed.

JIRA: VSPERF-273

Change-Id: Ia4129222ea95f1d399d5cc0c589c9a99d7b1b81a
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

xena_version: Add versioning info for report file from Xena

Adds Xena version info to report files. Works by pulling the
version info from the result file and adding it to the
settings dictionary.

JIRA: VSPERF-274

Change-Id: I2b7db30e5a621f32a7eaacfe48ab1bca498e4287
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

vm: use the same testpmd sources inside VM

Always copy testpmd sources from the directory with vHost User
version of DPDK. This will avoid possible issues with missing
dependencies in some VM images. It will also ensure, that testpmd
inside VM is agnostic to chosen vHost method.

Change-Id: I0496cc846eff3f7d4c1aef0a9c825545a4c3c818
JIRA: VSPERF-283
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

xena: Back 2 Back implementation

Allows for execution of back 2 back tests by enabling back to back
test scenario in json file when executing Xena2544.exe. Return
results are the number of frames. Results for test execution can
be found in the coresponding JIRA ticket.

- Disabled throughput by default in json file.
- Modified test params in baseconfig file for b2b test
- Modified create_result method to use data in resulting xml file
over using inspect strategy to detect test type
- Added line to Xena installation guide for issue that was found
locally after installation

JIRA: VSPERF-264

Change-Id: I0ecd6e1ce750613c53fe308aea3f5a55cca69c20
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

systems: Fix build scripts from arch specific packages

Fixes the build scripts to stop using arch specific packages.
The issue was found on an x86_64 arch when performing the
installation script. The glibc.i686 would fail to install
because a dependency was installed with a x86_64 arch.

While testing I found other versions of Fedora should also
include the glib2-devel package which was added to Fedora 22
build_base_machine script in another patch. This does not
seem to be included in the base installation of the OS.

Tested on Centos7, Fedora22, 21, 20, and Rhel7.2.

JIRA: VSPERF-281

Change-Id: I884d14fdacf0ceb96c9dc341e82c96d864653766
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

bugfix: Graceful shutdown of VM

Cleanup phase of PVVP scenario sometimes causes server reboot.
Following updates were made to prevent reboots:
* sleep after VM OS shutdown allows QEMU to finish its own shutdown
procedure
* shared dir was mounted as read only to prevent its modification,
which sometimes causes delays during shutdown; Also warning messages
are causing CI jobs failures.

Change-Id: I1607e79beeee343893496efe01ca0be5ea684a9d
JIRA: VSPERF-271
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

sriov: Support of SRIOV and Qemu PCI passthrough

Generic support of SRIOV has been added. Virtual interfaces can be
used in multiplei scenarios instead of physical NICs. Virtual
functions can be directly accessed from VM by PCI passthrough method.
Another option is to use VFs with vSwtich to evaluate impact
on performance.
Additonal modifications:
* Automatic detection of NIC details has been added to simplify
configuration.
* Obsoleted configuration options have been removed.
* Logging usage within vsperf script was fixed.
* Vsperf main was refactored and final cleanup function added.
* Configurable forwarding mode of TestPMD executed inside VM.

JIRA: VSPERF-198
Change-Id: I4a0d5d262b245d433b12419de79399fb5825a623
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

docs: rename scalability test

Rename LTD.Scalability.RFC2544.0PacketLoss to
LTD.Scalability.Flows.RFC2544.0PacketLoss to indicate what is being
scaled.

Change-Id: I398cbccf319fc09b621e7a68d7f81e4ff8d0b050
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>

pkt_gen: Testcenter traffic generation using STC-REST API -Import Issue.

The import of stcrestclient in moved down to avoid execution errors.

Change-Id: Ib9b64f62400c20a031f0ffcd3410582741cf1644
JIRA: VSPERF-237

docs: Fix param name test-param to test-params

Repair of documentation and configuration files where test-params
is incorrectly listed as test-param.

JIRA: VSPERF-266

Change-Id: I6be6c387fd57338f5dc5fba2ca8e1438dada0852
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

xena: Throughput method implementation for Xena Networks

Add files for Xena Networks 2544 throughput
implementation. This allows for Xena to execute
tput tests from VSPerf. For information on how
this works please see the JIRA ticket.

Modify traffic gen guide on install instructions
for Xena. Add in scapy to requirements file. Modify
conf file for Xena chassis connection information.

* Added license info to __init__.py / baseconfig.x2544
* Set initial rate to 10% line rate for tput testing
* Modified default mac address xena_json->set_header_layer2
from aa:aa:aa:aa:aa:aa to cc:cc:cc:cc:cc:cc

* Removed obsolete multistream params
* Added traffic params to 03_traffic.conf
* Comments to explain try/catch for latency values
* Removed unused import

* Rebased to fix merge conflict
* Added Xena to available traffic gen list in conf files

JIRA: VSPERF-261

Change-Id: I3c4b4a332fd532e10b6096e9ed97a4a39d410839
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

doc: Fix typos in documentation

A few fixes in documentation to assure clean pdf build.

Change-Id: Ib42818820f18ee96efb98d2016f4d6d9ee3e2b62
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

pkt_gen: Adding Support of testcenter traffic generation using STC REST API.

Stcrestclient package based script is added. Support for RFC22544
backtoback, latency, frameloss are also added, along with the throughput.

Comments Addressed:
1.  Parameter name consistency. Ex: use duration (refer dummy.py).
2.  Moved 'only the necessary contents of README to
    configguide/trafficgen.rst.
3.  Removed README file
4.  Commit message format (pkt_gen: and linewrap)
5.  Merged 4 scripts (throughput/backtoback/latency/frameloss)
    that were rest-based into one single script.
    Name: testcenter-rfc2544-test.py
6.  Changed year to 2016
7.  Moved imports to the top (testcenter-rfc2544-rest.py)
8.  Changed prints to Log (testcenter-rfc2544-rest.py)
9.  Reporting the frame loss percentage.
10. Calls to frameloss and latency are not added as the 'caller'
    class TrafficControllerRFC2544 is only calling backtoback and
    throughput.
11. Changed Exception, e to Exception as e for python 3
    compatibility
12. Remaining prints to debug and logger.error for errors.
13. Moved Session creation under try block.
14. Removed deadcode
15. Fixed missing docstring
16. Generic to specific Exception.
17. if-if to if-elif
18. Debug level logging only under verbose flag.
19. Fixed Arguments mismatch.
20. Ordering of the imports
Note: The testcenter-rfc2544-rest.py is spawned as a separate process,
and need not be wrapped in a class.

JIRA: VSPERF-237

Change-Id: I05d2b24fca1da4ba67bc4d79206c5d755ebf8f20
Signed-off-by: sridharkn <sridhar.rao@spirent.com>

Configuration: Fix of default param in custom conf file

Fixing default param for packet sizes to be of correct parameter
name.

JIRA: VSPERF-260

Change-Id: Ie09cae6fa47d85f1a15e7da40325a48d3acd1518
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

bugfix: Graceful shutdown of VMs

Cleanup phase of PVVP scenario sometimes causes server reboot.
It seems, that forced kill of VMs is the root cause. So graceful
shutdown of VMs was introduced.

Change-Id: I427404406fd7174d2a034f3cf0b51fe0833f9ecf
JIRA: VSPERF-271
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

LTD: Add Overlay Network Test

Following development on the Etherpad, this is one of the
new test cases for Release C.
modified: docs/requirements/vswitchperf_ltd.rst
not sure if conf/01_testcases.conf also needs update,
or other conf files?

JIRA: VSPERF-241

Change-Id: Ib747c4ed729b5af96ae141493beb8f033e940ba5
Signed-off-by: Al Morton <acmorton@att.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>

docs: update test summary list.

Update test summary list to include:
* LTD.Scalability.VNF.RFC2544.PacketLossProfile
* LTD.Scalability.VNF.RFC2544.PacketLossRatio
* LTD.Stress.RFC2544.0PacketLoss

JIRA: VSPERF-238

Change-Id: I62ff23c00243cadc8c818d09079dcd38a587a922
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>

IETF Draft: Address last BMWG meeting Comments

Final version submitted as -02
On branch IETF-95draft_1b
Changes to be committed:
new file: docs/requirements/ietf_draft/draft-vsperf-bmwg-vswitch-opnfv-02.xml
new file: docs/requirements/ietf_draft/draft-vsperf-bmwg-vswitch-opnf-02.txt

JIRA: VSPERF-246

Change-Id: I69262f3392cc9865be46ddff0f12ba85091d947d
Signed-off-by: Al Morton <acmorton@att.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>

systems: Fix top level build_base_machine script to use ID

Modified top level build_base_machine.sh script to use ID
instead of Name from os-release file. Renamed folders to
adapt to this change.

* Modified ID variable assignment from echo to straight assignment.

JIRA: VSPERF-257

Change-Id: I22a7d5a1f191418cbc8fc9fd7d85b013e51b49bc
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

LTD: Add Rationale for 10^-7 % Loss Ratio

This expanded item in the Throughput RFC description
explains a choice we made in Release A.
modified: docs/requirements/vswitchperf_ltd.rst

JIRA: VSPERF-2?? (having trouble with JIRA on 3/26)

Change-Id: Icf5132f55c8b00f99c41439ca644655dfcdf017d
Signed-off-by: Al Morton <acmorton@att.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>

IETF Draft: Address IETF-94 BMWG meeting Comments

Several Comments from the IETF-94 meeting, many are captured in the meeting notes.
Section 6 of the meeting notes gives the comments:
https://www.ietf.org/proceedings/94/minutes/minutes-94-bmwg

JIRA: VSPERF-246

Change-Id: Ibe77b67789024ac48cce00147ce94cf2270d8106
Signed-off-by: Al Morton <acmorton@att.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>

bugfix: Fix errors related to removal of kernel modules

Internal module manager is responsible for removal of all vsperf
specific kernel modules. Order of modules has been changed
to respect possible dependencies among modules. Manager has been
improved to detect modules automatically loaded by modprobe
to solve dependecies. These modules are automatically removed.
Code of module manager has been refactored.

Change-Id: I4484f3bea7d9900db688f96edd5c3c6d4a304742
JIRA: VSPERF-259
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

integration: Support of integration testcases

Generic support for integration testcases with first
set of tests for vswitch testing.
New test option "TestSteps" has been introduced
to define test step by step directly in configuration
file.
In case that this concept will be accepted, there
are plenty of possibilities for future improvements.
For example:
* use it also for performance tests without explicit
call of validation methods
* introduce step macros for repetitive scenarios,
so new tests can be easily written
* further generalization, which would go beyond
usage of controllers and will operate directly
with vswitch, vnf and trafficgen objects

Change-Id: Ifad166c8ef9cfbda6694682fe6b3421e0e97bbf2
JIRA: VSPERF-212
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

tunneling: Vanilla OVS decapsulation tests

Add Vanilla OVS VXLAN/GRE/GENEVE decapsulation tests
Recent changes:
* Line wrap
* Fix GENEVE IP settings
* Add GRE and GENEVE steps to integration.rst
* Add DUT_NIC1_MAC and DUT_NIC2_MAC
* Remove unnecessary call to vswitch.set_tunnel_arp
* Move optional VXLAN/GRE/GENEVE decap settings to a different section
* Add tunnel type to report files md and rst
* Fix typo error: l4 to L4 in conf/integration/03_traffic.conf

Change-Id: I8a43521668d5870ec893aed1df49467f0a84a07d
JIRA: VSPERF-180
Signed-off-by: Dino Simeon Madarang <dino.simeonx.madarang@intel.com>
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

Install: Adding RedHat 7.2 Installation bash scripts

Adding in prepare_python_env.sh and build_base_machine.sh
scripts to appropriate systems folder for installation on
Red Hat 7.2. Modified installation.rst to reflect these
changes.

* Fixed Header to add Red Hat
* Added myself as contributor

JIRA: VSPERF-214

Change-Id: I23a10316e77c3cec67b7f25176e8707de683af09
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>

bugfix: Eliminate error and warning messages

Several issues have been fixed to decrease a number of warning
and error messages written to the standard output. Error and
warning messages causes false build failure report by Jenkins,
in case that internal parsing of job output is enabled.
Fixed issues:
* qemu makefile updated
* shared directories between host and guests are forcibly deleted
before vsperf execution
* nonstop_tsc cpu flag is exported from host to the guest
* vloop-vnf help has been updated and changelog added
* TCL scripts updated to print info instead of warning
* vloop-vnf image updated to avoid snmpd related warnings

Change-Id: Id9ca014bae8fa34772b67d1ebab3431682682931
JIRA: VSPERF-206
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>

bugfix: Cleanup of traffic gen api and default traffic values

Both documentation and traffic generator API are updated
to match current code logic. Additional default values
are added into TRAFFIC_DEFAULTS dictionary. Constructor
of TestCase class uses default values from TRAFFIC_DEFAULTS
instead of magic numbers.

Change-Id: Id2f4983945e4b123adddbc9a2a832f4a735b27f6
JIRA: VSPERF-253
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>

dpdk: enable vfio_pci support

Enable vfio_pci support for DPDK in the case where the end user
doesn't want to use igb_uio.
Changes:
* Use generic functions to strip the path and .ko extension from the
module to be inserted/removed.
* Removed debug line in Modules_Manager.
* Removed commented code.
* Fixed all pylint issues.
JIRA: VSPERF-249

Change-Id: I69c9077735879bcbf7ce5c970c1ec53c219e9f90
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>

bugfix: Fix link to the artifactory

Test report PDF publishes the link to the logs collected
during CI build. Link has been fixed to point to the right
file.

Change-Id: I3d482d3934874af69f9630b95c7813736ae94afe
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

docs: add Scalability Tests for VMs in Series

Add LTD.Scalability.VNF.RFC2544.PacketLossProfile and
LTD.Scalability.VNF.RFC2544.PacketLossRatio to LTD.

JIRA: VSPERF-238

Change-Id: I26e2b9e06d7bdaf4cc5ab8de7d6ecf261e0a03d4
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Signed-off-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>

docs: update LTD.CPU.RFC2544.0PacketLoss

Rename and update LTD.CPU.RFC2544.0PacketLoss to
LTD.Stress.RFC2544.0PacketLoss and adding the memory
stressing app also.

JIRA: VSPERF-252

Change-Id: Ib79249f5cfeb304e03ce7f21b5c97a8030edade3
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>

Altering the heading levels to fit into the composite docs user guide.

Is required or it leaves the context of the document segment in the userguide.

Change-Id: Idb476b7926ba0fce11ed3be54eaa6837e34bff66
Signed-off-by: ChristopherPrice <christopher.price@ericsson.com>

Results: Report percentage frameloss from Dummy

This patch adds the frameloss % result reporting to the dummy traffic
gen and fixes incorrect calculations in the past for mbps that don't
convert packet sizes to bits.
JIRA: VSPERF-201

Change-Id: Ic4fc64a981ecbed0ab956f1cb94c7d76e7868def
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Billy O Mahony <billy.o.mahony@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>

bugfix: Parameter duration does not work

Vswitchperf help describes two different options, which will
set lenght of the test or duration of its iteration. It can be set
either by parameter --duration or by --test-params CLI option
duration. However only the second option is implemented. It is
enough to support only one option and thus --duration parameter
has been removed.

Change-Id: Icfa40ec25f50bd090229b0761fa968567d8d3553
JIRA: VSPERF-196
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>

systems: Dependency package additions for Fedora 22

Added in sysstat and glib2-devel to Fedora build_base_machine.sh for
proper build and execution of VSPerf. QEMU make would fail because of
missing dependencies and VSPerf would error on pidstat execution. Installing
these two packages resolves those issues when building VSPerf on a fresh
install of Fedora 22.

JIRA: VSPerf-221

Change-Id: Icf2f96ce9e2305928cbb1f3811171ed0821d6f2d
Signed-off-by: Christian Trautman <ctrautma@redhat.com>

CI: Generate test report and push logs and report to the artifactory

Script for CI job execution automatically generates final test
report, collects log files and pushes these results into artifactory.
Support for branch specific configuration file has been added.

Change-Id: Ifdf13b1c4c389f8d20dbc8e0ed99f43273e0820b
JIRA: VSPERF-181
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>

trafficgen: pause trafficgenerator

Add a mode to pause the traffic generator before transmission to bypass
manual setup if required.

Change-Id: Iad62a5e7cb83a311e2814d8a9ee2bc9b2d2ed4de
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>

docs: Fixing typo in testusage.rst for port name example.

JIRA: VSPERF-222

Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>

pktgen: docstring fix

Fixed docstring to correctly reflect python output from using
merge_spec function.

JIRA: VSPERF-210

Change-Id: Ie3bf2a3d148aa9823bafafe8c61c4c94f00ccc87
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>

docs: results explain the dashboard results

Add some more details on the test names used by the dashboard as well as
the test metrics plotted in the graphs.

Change-Id: I6c780a292937622e03fd8af4b9396add82e89bf8
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Billy O Mahony <billy.o.mahony@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>

VSPERF: Report percentage frameloss from IXIA/IXNET

The patch introduces frame_loss_percent result value.
The implementation is done for Ixia and IxNet
traffic generators. The value is visible in list
of result values at the end of the test, in csv,
rst and md files.

JIRA: VSPERF-201

Change-Id: I9b6795d427b199cb62ed66b7a137e412e36dc757
Signed-off-by: Radek Zetik <radekx.zetik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Tv Rao <tv.rao@freescale.com>
Reviewed-by: Billy O Mahony <billy.o.mahony@intel.com>

docs: add release information

Add the release information to NEWS.rst.

Change-Id: I12baf8098c7ea1c45075a99fdaf031f1bd63f905
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Billy O Mahony <billy.o.mahony@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christopher Price <christopher.price@ericsson.com>

src: update make install for DPDK

Update make install for DPDK to install to the appropriate DESTDIR.

Change-Id: I6e4f0707038c05eeb2e2849ce34300149d8c5410
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Ian Stokes <ian.stokes@intel.com>
Reviewed-by: Antonio Fischetti<antonio.fischetti@intel.com>
Reviewed-by: Radek Zetik <radekx.zetik@intel.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>
Reviewed-by: Al Morton <acmorton@att.com

docs: results documentation

Add a results directory and relevant rst files for vsperf brahmaputra
results.

Change-Id: I99ea7b4246b801054d2582933f7d25b7f36abe5d
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Billy O Mahony <billy.o.mahony@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christopher Price <christopher.price@ericsson.com>

Altering the filename for autogeneration

Updated the heading and moved to a new filename for composite docs.
Added a link to the vsp userguide at the end of the doc.

Change-Id: I416228be9347275bcd4c90e394678e4eb93198d4
Signed-off-by: ChristopherPrice <christopher.price@ericsson.com>

bugfix: Blank lines are required to join RST templates

Blank lines are required to correctly join multiple RST templates.
Otherwise their text will be merged into one paragraph and formatting
tags will be ignored.

Change-Id: I6885019f7af2fd2201b9f30496d78200a0432e8e
JIRA: VSPERF-181
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Billy O Mahony <billy.o.mahony@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>

docs: adding license to rest of rst files

Add Creative Commons Creative Commons license to missed documentation
in vsperf. One of these files is not on the stable Brahmaputra branch.
JIRA: VSPERF-239

Change-Id: If1420c3b84ba5ba9e1b4c1f9d75347f1b6e6117f
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Billy O Mahony <billy.o.mahony@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Brian Castelli <brian.castelli@spirent.com>