Martin Klozik [Mon, 20 Nov 2017 09:40:38 +0000 (09:40 +0000)]
ci: Skip VPP tests if needed
If VPP can't be executed properly, then VPP tests will be skipped
for VERIFY and MERGE jobs. It sometimes happens, that VPP can't
be executed at builders used for VERIFY & MERGE jobs execution.
These failures are not caused by patches themselves, but they
are blocking standard review & merge process. Thus VPP tests
will be suppressed in case that VPP can't be started at all.
This change is not related to DAILY job, which is executed
at POD dedicated to VSPERF project. It means that VPP tests
are always executed by DAILY job.
Change-Id: I4752601561b94a82482c403305bc3f24779f538b
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Mon, 20 Nov 2017 09:30:10 +0000 (09:30 +0000)]
Merge "paths: Modify algorithm for PATHS verification"
Martin Klozik [Wed, 15 Nov 2017 08:24:29 +0000 (08:24 +0000)]
Merge "teststeps: Improvements and bugfixing of teststeps"
Martin Klozik [Tue, 14 Nov 2017 12:55:09 +0000 (12:55 +0000)]
vpp: Define vppctl socket name
Newer versions of VPP require an explicit definition of CLI socket
file for proper functionality. Otherwise vppctl is not able to connect
to running vpp process and thus vsperf is not able to configure
and control vpp.
Change-Id: Id0df75fd0894e22b1b4d7fa05e16f49efe20d3ab
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Thu, 9 Nov 2017 13:09:25 +0000 (13:09 +0000)]
paths: Modify algorithm for PATHS verification
VSPERF verifies if PATHS to the tools (vSwitch, VNF, etc.)
are valid. This check was modified to take into the account
tools required by selected testcase. It will help to avoid
runtime errors triggered by missing tools, which
are not essential for testcase execution.
Change-Id: Ifcfea983cad1bdbc8c1f08c7a0281001005410df
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Tue, 7 Nov 2017 09:10:43 +0000 (09:10 +0000)]
Merge "load_gen: Supporting loading of load_gen via loader."
Martin Klozik [Fri, 3 Nov 2017 13:50:00 +0000 (13:50 +0000)]
vpp: Multiqueue support for VPP
VPP class was updated to configure RX queues of VPP interfaces
based on VSWITCH_DPDK_MULTI_QUEUES value.
Change-Id: I855dbaef86cf935b2639976e8b1757eb1af4e9ac
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Sridhar K. N. Rao [Thu, 5 Oct 2017 03:59:35 +0000 (09:29 +0530)]
load_gen: Supporting loading of load_gen via loader.
Currently all tools are loaded via loader utility, except load_gen.
Load_gens were loaded directly through component_factory.
This patch adds support to load load_gens through loader utility.
The changes are as follows:
1. Configuration changes:The common.conf include configuration of
directory. testcases.conf includes changes to load configuration,
where tool is no more part of the load-configuration. The
custom.conf has configuration of LOADGEN to be used - this configuration
replaces the earlier 'tool' configuration parameter.
2. loader_utility_changes: In loader.py, loadgen_loader is
defined, which is used in new get_loadgen function.
3. component_factory changes: in create_loadgen, similar
to other tools, the function just retuns the object of loadgen_class.
4. Renaming of Dummy load_gen: Loader fails to load properly a dummy
loadgen due to name-clash with dummy in pkt_gen. To avoid this name clash
dummy is renamed to dummyloadgen.
5. testcase changes: create_loadgen is now called with output of
loader's get_loadgen_class.
6. Fixed Pylint Errors and extra-space at the end.
7. Included CLI options support for --loadgen and --list-loadgens.
Thanks to Martin K.
8. Added the missing loadgen parameter in testcases.conf.
9. Fixed the missing comma error.
10. Added CI change in build-vsperf.sh
11. Fixed configuration reading in stress/stress.py
JIRA: VSPERF-533
Change-Id: I3fbb259618825a12fef55320a748a4f02509190b
Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Martin Klozik [Thu, 31 Aug 2017 13:01:18 +0000 (15:01 +0200)]
teststeps: Improvements and bugfixing of teststeps
This patch introduces several improvements and small bugfixes
of teststeps. These changes were identified during implementation
of OVS/DPDK regression tests.
Patch content:
* teststeps: step aliases were implemented
* teststeps: improved filtering by regex for any step, which returns string
or list of stings; filter will process all lines
* teststeps: support for log object
* teststeps: support for trafficgen get_results call
* teststeps: configurable suppression of step validation
* trafficgen: remove old results before traffic is executed
* trafficgen: support for flow control on/off (IxNet)
* trafficgen: support for configurable learning frames (IxNet)
* trafficgen: support for runtime changes of TRAFFICGEN_PKT_SIZES, _DURATION
and _LOSSRATE
* vnf: flush pexpect output of previous commands
* vnf: use execute_and_wait() to ensure correct cmds order
* vnf: dpdk vHost User interface name set according to its type,
e.g. dpdkvhostuserclient
* vswitch: support for OVS restart
* decap: simplify configuration of tunneling decapsulation tests
* settings: values of all configuration options are restored after TC execution
* modified formatting of test description used by --list
* testcase name and description is logged before its execution
* small bugfixes
JIRA: VSPERF-539
Change-Id: I550ba0d897ece89abd3f33d6d66f545c4d863e7b
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Sridhar K. N. Rao [Sun, 29 Oct 2017 11:08:03 +0000 (16:38 +0530)]
INFO: Update PTL
https://lists.opnfv.org/pipermail/opnfv-tech-discuss/2017-October/018501.html
Change-Id: I9305ec2e13e19b32e142640dab63487bab9a2b6a
Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>
Martin Klozik [Fri, 20 Oct 2017 10:22:08 +0000 (10:22 +0000)]
Merge "trex_multistream: Add multistream support to T-Rex"
Christian Trautman [Wed, 4 Oct 2017 14:34:46 +0000 (10:34 -0400)]
trex_multistream: Add multistream support to T-Rex
Adds incremental source multi-stream functionality to
T-Rex traffic generator code in VSPerf.
JIRA: VSPERF-532
Change-Id: Ib5ba326699d89350ac1715c9a4276e5fa46a133e
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Martin Klozik [Thu, 19 Oct 2017 12:40:40 +0000 (13:40 +0100)]
conf: Fix default VPP configuration
Number of VPP workers (aka PMD threads) was not specified
explicitly in default configuration file. Configuration
has been fixed to use the same cores as OVS with DPDK.
Change-Id: Icd3e5d6f429435fbc1ff580891f4b182d1c48729
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Thu, 5 Oct 2017 06:44:17 +0000 (06:44 +0000)]
Merge "doc_review: Review docs for accuracy and grammar"
Christian Trautman [Mon, 2 Oct 2017 21:55:06 +0000 (17:55 -0400)]
doc_review: Review docs for accuracy and grammar
Fix issues with grammar and accuracy.
JIRA: VSPERF-536
Change-Id: Ia703d306bb7a14b11e09ab4077b8adfa5fb5e6af
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Martin Klozik [Tue, 3 Oct 2017 15:04:32 +0000 (15:04 +0000)]
Merge "Removed drafts of test specificaiton now published as RFC8204. Also removed IETF license notice and added a file with link to RFC8204"
Trevor Cooper [Mon, 2 Oct 2017 04:51:47 +0000 (21:51 -0700)]
Removed drafts of test specificaiton now published as RFC8204. Also removed IETF license notice and added
a file with link to RFC8204
Change-Id: I44b4cb75afeff74a58f402a7cb8816ddfbe52b87
Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
Trevor Cooper [Wed, 27 Sep 2017 19:21:10 +0000 (12:21 -0700)]
Updated project description to clarify VSPERF independence from Open Stack
Change-Id: Iab653c7ad1cf6cbdb9c15056337a2768a489a87a
Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
Christian Trautman [Mon, 25 Sep 2017 21:22:38 +0000 (17:22 -0400)]
trex_prom: Add promiscuous option for trex for SRIOV tests
Adds option to enable promiscuous mode for Trex traffic
generator to allow for SR-IOV tests to work correctly.
Trex by default only accepts packets based on destination
MAC address matching what is configured on server in
/etc/trex-cfg.yaml. This removes that limitation since
SR-IOV tests require mac addresses to be modified in the
generated packets to correctly route packets to the relevant
VFs.
JIRA: VSPERF-531
Change-Id: I19b64f364c8a1b656994c82c96f47a68b92486d8
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Martin Klozik [Thu, 21 Sep 2017 09:22:06 +0000 (09:22 +0000)]
Merge "trex: RFC2544 Throughput bugfixing"
Martin Goldammer [Mon, 18 Sep 2017 10:48:01 +0000 (03:48 -0700)]
trex: RFC2544 Throughput bugfixing
Changes introduced by patch:
* Ensure that correct results with given lossreate are returned
* Add threshold value to specify the accurancy of RFC2544 Throughput
measurement. Default value is 0.05.
JIRA: VSPERF-530
Change-Id: I8148deba9039c3a0feb6394d6671aa10c5afaf0a
Signed-off-by: Martin Goldammer <martin.goldammer6@gmail.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Mon, 18 Sep 2017 09:58:37 +0000 (10:58 +0100)]
CI: Update hugepages configuration
Changes introduced by this patch:
* Configure more hugepages to be used during CI run.
* Fix detection of correct ovs-vswitchd execution.
* Skip VPP shutdown overhead in case that VPP execution
has failed.
Change-Id: Id1badd61334141dcc331691af4a1401a09d06807
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Martin Klozik [Fri, 15 Sep 2017 17:48:57 +0000 (17:48 +0000)]
Merge "trex: Enforce 10 iterations for RFC2544 tput"
Christian Trautman [Thu, 14 Sep 2017 13:53:32 +0000 (09:53 -0400)]
Tuning_doc: Add tuning doc for installation of cpu-partitioning profile
Add documentation for installing and configuring tuned-adm using
the cpu-partitioning profile. Tested and verified by Martin and
Christian.
JIRA: VSPERF-514
Change-Id: I7ae25898abe0854c22ae16ee8d3d0a6001cda2f6
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Martin Klozik [Fri, 15 Sep 2017 13:57:35 +0000 (14:57 +0100)]
trex: Enforce 10 iterations for RFC2544 tput
This patch enforces 10 iterations during search
for besti RFC2544 Throughput with 0% packet loss. Unless
0% packet loss is detected during first iteration
with initial frame rate.
JIRA: VSPERF-530
Change-Id: I99e49e9dbf4e1424253d0cfec804819516c00df8
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Reviewed-by: Martin Goldammer <martin.goldammer6@gmail.com>
Martin Klozik [Fri, 15 Sep 2017 12:16:25 +0000 (12:16 +0000)]
Merge "CI: Update hugepages configuration"
Martin Klozik [Fri, 15 Sep 2017 11:16:04 +0000 (12:16 +0100)]
CI: Update hugepages configuration
Use the number of free hugepages to correctly set hugepages
configuration. Limit the number of allocated hugepages to
avoid memory exhaustion.
Change-Id: Id5239200579f8c43706ffcc769e4963280b9eb2b
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Trevor Cooper [Wed, 13 Sep 2017 22:48:19 +0000 (15:48 -0700)]
Updated project description in user and developer guides.
Updated info on RFC8204 in developer guide.
Removed whitespaces causing rst validation failure.
Change-Id: Ibdefee2d0fea03873bac8aba514b68de1f1e0dbe
Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Tue, 12 Sep 2017 15:01:42 +0000 (15:01 +0000)]
Merge "Added two extra packages"
Marco Varlese [Fri, 8 Sep 2017 10:45:04 +0000 (12:45 +0200)]
Added two extra packages
Change-Id: Ibd7f5506d5600d8921dec42f10960df06f0f5250
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Martin Klozik [Fri, 8 Sep 2017 06:37:38 +0000 (06:37 +0000)]
Merge "trex: fix Trex makefile"
Martin Klozik [Fri, 8 Sep 2017 06:06:41 +0000 (06:06 +0000)]
Merge "doc: Include list of TCs in doc"
Martin Klozik [Wed, 6 Sep 2017 16:53:28 +0000 (16:53 +0000)]
Merge "openSUSE support"
Marco Varlese [Wed, 6 Sep 2017 07:16:11 +0000 (09:16 +0200)]
openSUSE support
Modified support for Leap 42.2 so not to be prompted for y/n on update
and installation of required packages.
Added Leap 42.3 as supported OS.
Upgraded documentation accordingly.
Change-Id: I33f3046a5b33bc842534a16911423a2febaa9417
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Martin Goldammer [Tue, 5 Sep 2017 10:12:24 +0000 (03:12 -0700)]
trex: fix Trex makefile
Trex makefile was fix to checkout correct commit ID.
Add trex repo folder to .gitignore file.
JIRA: VSPERF-528
Change-Id: Icd0406eaf088b88c28d90cf8a7dd9e1fa53a6f3b
Signed-off-by: Martin Goldammer <martin.goldammer6@gmail.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Fri, 1 Sep 2017 14:36:35 +0000 (15:36 +0100)]
opnfvresultdb: Report failed TCs into result DB
In following cases, TC will be reported as FAIL in result DB:
* CSV file with VSPERF results is missing (e.g. execution
of vSwitch, VNF or trafficgen has failed)
* 0 RX FPS is detected for at least one packet size during
RFC2544 Throughput test (e.g. vSwitch is not properly
configured due insufficient hugepages size)
JIRA: VSPERF-488
Change-Id: I453bbe32db87497644e1464e74ef597f0f0f323c
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Mars Toktonaliev <mars.toktonaliev@nokia.com>
Reviewed-by: Morgan Richomme <morgan.richomme@orange.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Fri, 1 Sep 2017 12:13:30 +0000 (12:13 +0000)]
Merge "trex: Add support Trex traffic generator"
Martin Goldammer [Thu, 24 Aug 2017 16:28:50 +0000 (09:28 -0700)]
trex: Add support Trex traffic generator
Topology are two physical servers, on first is trex and second is VSPERF.
Trex is running in stateless mode this means that on server where is located
trex repo is running trex binary file and VSPERF working with server via
python API.
JIRA: VSPERF-528
Change-Id: Id8819495325ebc13fdce365f4af0e040ce68cd0e
Signed-off-by: Martin Goldammer <martin.goldammer6@gmail.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Thu, 31 Aug 2017 06:48:31 +0000 (06:48 +0000)]
Merge "docs: Update E release notes"
Martin Klozik [Wed, 30 Aug 2017 12:32:07 +0000 (13:32 +0100)]
docs: Update E release notes
Release notes were updated with VSPERF additions during Euphrates
release timeframe.
Change-Id: I87154036676450065906c6fd8bc6db4604c84260
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Tue, 29 Aug 2017 13:19:05 +0000 (14:19 +0100)]
doc: Include list of TCs in doc
List of vsperf "inbox" testcases was added into documentation.
This patch also fixes:
* a few SPHINX warnings and errors
* empty userguide index
JIRA: VSPERF-519
Change-Id: I417ed40130f0c7de4f76551f3f1cac0cb1e6da89
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Wed, 30 Aug 2017 06:17:48 +0000 (06:17 +0000)]
Merge "opnfvresultdb: Add mapping for VPP TCs"
Martin Klozik [Fri, 25 Aug 2017 14:13:13 +0000 (15:13 +0100)]
report: Update paths after doc reorganization
Directory with report files was moved to different
location. Thus CI build script must be updated too.
Change-Id: Id5b4c8b2740c01c821c25f8bfdaeb25352410e76
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Fri, 25 Aug 2017 13:46:32 +0000 (13:46 +0000)]
Merge "build: Rename cloned repositories and remove cuse"
Martin Klozik [Thu, 24 Aug 2017 12:52:34 +0000 (13:52 +0100)]
opnfvresultdb: Add mapping for VPP TCs
Patch adds testcase mapping among native VSPERF VPP TCs and appropriate
TC names defined in results DB.
JIRA: VSPERF-488
Change-Id: I5c4a50587a354a741c738d255105726943a701f5
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Mars Toktonaliev <mars.toktonaliev@nokia.com>
Reviewed-by: Morgan Richomme <morgan.richomme@orange.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Cian Ferriter [Fri, 25 Aug 2017 07:24:38 +0000 (08:24 +0100)]
build: Rename cloned repositories and remove cuse
VSPERF expects folders to be named a certain way, but this may not be
the case if another repository is specified via the package-list.mk
file. One example of this is the DPDK stable repo which gets cloned to
the "dpdk-stable" directory unless otherwise specified. Thus Makefiles
were updated to enforce expected folder names.
Unused configuration related to vHostCuse support was removed.
Change-Id: Ifa48898d51e96c72e7d740f43cb635d729b2a796
Signed-off-by: Cian Ferriter <cian.ferriter@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Cian Ferriter [Fri, 25 Aug 2017 07:11:34 +0000 (08:11 +0100)]
gitignore: Ignore non vsperf files
.gitignore was updated to ignore following files:
* VPP project directory
* l2fwd binary files
* tags
JIRA: VSPERF-529
Change-Id: Idc10eae7b14c72a863f3473e02cbdc7c47d31b41
Signed-off-by: Cian Ferriter <cian.ferriter@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Thu, 24 Aug 2017 09:01:41 +0000 (09:01 +0000)]
Merge "opnfvresultdb: Update data reported to result DB"
Martin Klozik [Wed, 23 Aug 2017 13:31:31 +0000 (14:31 +0100)]
opnfvresultdb: Update data reported to result DB
Data reported to result DB were updated to comply
with recent API version and requirements.
JIRA: VSPERF-488
Change-Id: I6ab02ea54d99099e88b0d5ab6e9745ee8297f544
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Signed-off-by: Mars Toktonaliev <mars.toktonaliev@nokia.com>
Signed-off-by: Morgan Richomme <morgan.richomme@orange.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Trevor Cooper [Tue, 22 Aug 2017 22:29:08 +0000 (15:29 -0700)]
Moved devguide for consitency with docs dir structure for all testing projects
Updated RFC description based on IETF approval of Internet Draft
Change-Id: Ifd37da946866f350b8968bbbe8c5a3f5ce762cfa
Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Fri, 18 Aug 2017 08:11:13 +0000 (08:11 +0000)]
Merge "driverctl: Add driverctl binding tool"
Christian Trautman [Wed, 9 Aug 2017 19:11:15 +0000 (15:11 -0400)]
driverctl: Add driverctl binding tool
Adds driverctl as a binding tool option for dpdk devices. JIRA
ticket contains test results to verify it works when using
dpdk-devbind or driverctl.
JIRA: VSPERF-525
Change-Id: Ia7a6e43a4b6fb3ba21f5d87d601f4ea4b95b7dab
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Martin Klozik [Mon, 14 Aug 2017 14:36:42 +0000 (14:36 +0000)]
Merge "xena2544_verify_fix: Fix Xena verify options"
Martin Klozik [Mon, 14 Aug 2017 14:27:06 +0000 (14:27 +0000)]
Merge "tests: L3, L4 and VxLAN tests for OVS & VPP"
Christian Trautman [Tue, 8 Aug 2017 18:09:53 +0000 (14:09 -0400)]
xena2544_verify_fix: Fix Xena verify options
Fixes issue when running multiple packets sizes and using the Xena
verify option. Original values are restored to settings for each
new packet size or test case.
Also fixes a minor issue where if the test failed, the verify would
run regardless.
JIRA: VSPERF-515
Change-Id: I6b6ce5160b66e7ed4a3847711c4f05529ae8ca54
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Martin Klozik [Fri, 2 Jun 2017 12:56:57 +0000 (13:56 +0100)]
tests: L3, L4 and VxLAN tests for OVS & VPP
A set of tests was introduced with focus on L3, L4 and VxLAN performance
of OVS and VPP. New testcases were created for phy2phy network scenario.
In case of PVP and PVVP, only OVS testcases are available.
Notes:
* two sets of OVS P2P testcases were created, one creates unique flow
for each IP address involved in the test (performance sensitive);
Second set inserts just one flow with large network mask (tests with
_mask suffix).
* three different types of VPP P2P L3 testcases were created to
demonstrate performance impact of multi ARP entries or IP routes.
* VPP multi ARP record based testcases use a set of "workarounds"
to load a large number of ARP entries. It is not possible to use
"set ip arp count" syntax, as it doesn't work well for large count
values (e.g. 60K)
* OVS VxLAN testcases utilize existing OP2P deployment scenario and thus
it can be used also with GRE and GENEVE tunnel types. Tunnel type
to be used is defined by test configuration option "Tunnel Type".
JIRA: VSPERF-518
Change-Id: I65adad976f12d8625d918a1996eb42693c511ee1
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Reviewed-by: Cian Ferriter <cian.ferriter@intel.com>
Martin Klozik [Thu, 27 Jul 2017 06:30:50 +0000 (06:30 +0000)]
Merge "ci: Fix path to CI report"
Martin Klozik [Thu, 20 Jul 2017 14:49:16 +0000 (15:49 +0100)]
dpdk: Support dpdk vhost-user client mode
Support of vhost-user client mode has been added for both
OVS and VPP. VSPERF configures vhost-user server mode
in vswitches by default for backward compatibility.
Support of vhost-user server mode is deprecated
in OVS and it can be removed in future releases. Once it will
happen, we have to change vsperf default behavior to
usage of vhost-user client ports at vswitch side.
This patch also fixes processing of boolean configuration
parameters passed via --test-params option. In the past
it was not possible to set boolean value to False through
--test-params option.
JIRA: VSPERF-517
Change-Id: I65e341f820edd6c720043a4acc74c5140b05db18
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Wed, 19 Jul 2017 07:04:00 +0000 (08:04 +0100)]
ci: Fix path to CI report
Index file of CI report was restored and paths to it updated
to reflect new documentation structure.
JIRA: VSPERF-514
Change-Id: Id92eb2003a9e6737652313f7ecd03d48a0bfd2ce
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Tue, 4 Jul 2017 07:18:46 +0000 (08:18 +0100)]
ci: Use log scale for B2B graphs
Graph configuration for B2B was modified to show correct y axis
tittle and to use log scale.
Change-Id: I7ac75ca803f93be28d89a4504e046b1119d341e1
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Mon, 3 Jul 2017 06:18:31 +0000 (06:18 +0000)]
Merge "ovs: Update OVS to use DPDK 17.02"
Martin Klozik [Wed, 21 Jun 2017 08:54:15 +0000 (09:54 +0100)]
ovs: Update OVS to use DPDK 17.02
Versions of VSPERF tools were updated to use OVS
with DPDK 17.02 support by default. Currently used
VPP version uses DPDK 17.02 already.
VSPERF was updated to support new path to the dpdk
devbind tool.
JIRA: VSPERF-516
Change-Id: I004d0531553c974d604635d50f601cd4326f2f7d
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Guo Ruijing [Thu, 22 Jun 2017 15:42:54 +0000 (08:42 -0700)]
cleanup: remove fuel plugin since fuel@opnfv uses mcp
Change-Id: Ibe2028b01c38fa545e72a00a7ef47103d1112b82
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
Martin Klozik [Wed, 14 Jun 2017 05:57:07 +0000 (06:57 +0100)]
ci: Fix of SRIOV graphs generation
Wrong test name was used for SRIOV.
Change-Id: Ie07a3bcd162b228d9d6843205a9abf237026f428
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Martin Klozik [Tue, 13 Jun 2017 06:27:07 +0000 (07:27 +0100)]
ci: Fix of CI graphs generation
Parameters must be quoted, otherwise list of testcases is split
among many parameters.
Change-Id: I16ca4feb7e8d30bbbed60fd259e3bd3155f382b3
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Martin Klozik [Mon, 12 Jun 2017 09:35:43 +0000 (10:35 +0100)]
ci: Configure graphical output
Modify configuration of graphs generated from CI results.
Change-Id: Id1a30e0c61419ff131fb4f41138af2e62f822b9c
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Martin Klozik [Fri, 9 Jun 2017 07:30:44 +0000 (07:30 +0000)]
Merge "tests: Improvement of step driven testcases"
Martin Klozik [Wed, 7 Jun 2017 16:41:18 +0000 (16:41 +0000)]
Merge "ci: Fix VPP back2back TCs"
Martin Klozik [Tue, 6 Jun 2017 14:02:07 +0000 (15:02 +0100)]
ci: Plot graphs from CI results
CI scripts were enhanced to plot graphs from last
results and push them into artifactory. Graphs
will be updated by every CI run and can be included
e.g. in VSPERF results WIKI page.
Change-Id: Iada4acd7cc2c3dc73b9f30a429fe2b53020c4d3b
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Martin Klozik [Mon, 5 Jun 2017 14:49:54 +0000 (15:49 +0100)]
ci: Fix VPP back2back TCs
There was a generic issue with restoration of original environment
after execution of testcase. Thus in case that multiple tests were
executed, their settings could be corrupted. This issue was detected
after VPP testcases were added into VSPERF DAILY CI job.
There were two issues:
* setttings.load_from_dict() method was used to restore original
configuration values; However this method updates dict content
with supplied values. If TC has introduced new dict item,
then it was not removed from settings after TC execution
and modified settings was applied also for next test(s).
* test configuration passed to testcase constructor is used
for initialization of TC members, which are later updated;
As python does shallow copy on dict members by default,
modification of such testcase members led to corruption
of configuration of other testcases. Thus deepcopy of testcase
configuration was introduced into vsperf constructor to
avoid TC configuration corruption.
JIRA: VSPERF-511
Change-Id: I45fb49d48743015353652de12db4692333043733
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Fri, 2 Jun 2017 13:56:43 +0000 (14:56 +0100)]
ixia: Fix IXIA in trafficgen mode
There are two IXIA wrappers in VSPERF - IxNET and Ixia. It has
been found that legacy Ixia implementation is no longer working
in trafficgen mode. This issues has been fixed.
JIRA: VSPERF-513
Change-Id: Ief1db71f688a19c5b41508617ccbc73024a02c48
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Thu, 18 May 2017 09:18:38 +0000 (10:18 +0100)]
tests: Improvement of step driven testcases
A set of improvements was introduced to enhance step driven
testcases capabilities.
Details:
* delay among test steps is configurable by TEST_STEP_DELAY
parameter
* step driven tool function exec was renamed to exec_shell
* new step driven tool function exec_python was introduced to execute
a python code
* new step driven object sleep was introduced to pause test execution
for defined number of seconds.
* fixed bug in settings.validate_getValue() to correctly validate
access of parameters modified by TEST_PARAMS
* new #PARAM() macro was introduced to allow references among
configuration parameters
* multistream support has been added into ixnetrfc2544v2.tcl,
which is used for tunneling protocols test (op2p deployment)
* fixed bug in op2p deployment to list interfaces and flows
from both bridges involved in the test
* test report updated to state exact rfcxxxx type of traffic
type, e.g. rfc2544_continuous
* test report of step driven testcases was updated to contain
measured values from traffic generator in CSV report
* method for ovs flow comparison was modified to normalize
IPv4 CIDR network addr (e.g. 10.0.0.5/8 => 10.0.0.0/8)
JIRA: VSPERF-512
Change-Id: Ib4f38dcdfbf3820dd766b25520da0ad0c81f3293
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Reviewed-by: Ciara Loftus <ciara.loftus@intel.com>
Martin Klozik [Wed, 31 May 2017 13:04:31 +0000 (13:04 +0000)]
Merge "Qemu: Mechanism to pass extra qemu cpu features and pin vCPU threads"
kalyanreddy [Thu, 25 May 2017 09:31:40 +0000 (15:01 +0530)]
Qemu: Mechanism to pass extra qemu cpu features and pin vCPU threads
JIRA: VSPERF-510
This patch is used to implement the mechanism to pass extra qemu
cpu options required to achieve better results/performance. Also
used to implement a mechanism to pin the vCPU threads to another
pCPU core which helps in reducing the noise from housekeeping
thread and packet loss.
Change-Id: Ic40fd47d7c4f5556f7e240c6ca671a0535d06ece
Signed-off-by: Gundarapu Kalyan Reddy <reddyx.gundarapu@intel.com>
Christian Trautman [Thu, 25 May 2017 14:43:34 +0000 (10:43 -0400)]
xena_cont_bug_fix: Fix duration issue
Port duration is in microseconds. I broke this with a previous
commit.
Change-Id: Id2770149355f40107ab8ee0523482b5867e0e72a
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Christian Trautman [Thu, 18 May 2017 17:40:08 +0000 (13:40 -0400)]
vpp_doc_fix: Modify VPP documentation to be current
Update VPP installation documentation and add note for issue
seen with some installs.
Change-Id: Ib1a2bb5f7b6bb07ddff2ea5c7d2ca9f9100250dd
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Martin Klozik [Tue, 16 May 2017 07:23:02 +0000 (07:23 +0000)]
Merge "xena_pairs: Add pairs topology for 2544 testing"
Christian Trautman [Thu, 27 Apr 2017 20:08:49 +0000 (16:08 -0400)]
xena_pairs: Add pairs topology for 2544 testing
Add xena pairs topology and port removal options for JSON
files with RFC2544 testing. Refactored JSON code for
better expansion later.
Resolved pathing issues related to previous patch allowing
for execution of VSPerf from any directory.
JIRA: VSPERF-502
Change-Id: Ida60c1223ae0f45f8879351770ab7fdce859b59b
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Martin Klozik [Fri, 12 May 2017 14:24:21 +0000 (15:24 +0100)]
ci: Update list of VPP TCs in daily job
JIRA: VSPERF-509
Change-Id: I03bfc5a2c8ff69e226464d307563e117b7f3318e
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Martin Klozik [Fri, 12 May 2017 13:56:54 +0000 (14:56 +0100)]
ci: Add VPP test execution into CI daily job
Basic set of VPP performance tests was added into
OPNFV CI daily job.
JIRA: VSPERF-509
Change-Id: I9cd6086a958d67dd0e395f962111e6d2b44bf86c
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Fri, 21 Apr 2017 08:57:56 +0000 (09:57 +0100)]
build: Automated VPP build
VSPERF makefiles were updated to automatically download and compile
VPP. VPP will not be installed into the OS, but it will be executed
from VSPERF's src subdirectory. Thus underlying OS is not affected
by VPP build required by VSPERF. It also allows quick switch among
different versions of various tools used by VSPERF.
As part of this patch, VERIFY and MERGE CI jobs were updated to
build VPP and test it with basic set of integration tests.
JIRA: VSPERF-493
Change-Id: I958b9031c4fefc87c4c63a471d2ba1a0db1eaaa4
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Christian Trautman [Mon, 1 May 2017 15:13:59 +0000 (11:13 -0400)]
pylint_error_report: Report errors generated from pylint failures
Change the output of the pylint check script to report the errors
generated from a non 10 pylint score.
JIRA: VSPerf-508
Change-Id: I6d764f4040a662385c83125322bec7e887942bc5
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Christian Trautman [Thu, 20 Apr 2017 19:28:01 +0000 (15:28 -0400)]
xena_duration_fix: Revert xena continuous to port time limits
Revert xena continuous traffic to port based time limits as
packet limits have an uppers bounds which could be reached
with small packet sizes and longer durations.
JIRA: VSPERF-507
Change-Id: I56986159643344f7872e311590f7d05ac02b038b
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Martin Klozik [Thu, 20 Apr 2017 08:35:17 +0000 (08:35 +0000)]
Merge "ixia: Support of 1 NIC connection to trafficgen"
Martin Klozik [Wed, 19 Apr 2017 11:47:08 +0000 (12:47 +0100)]
docs: Remove whitespaces from indexes
Whitespaces were removed from RST indexes to correctly
pass rst validation.
Change-Id: I5f277d5f8846653c6e7ea3fbb29881e2dd3f610b
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Wed, 19 Apr 2017 11:09:45 +0000 (11:09 +0000)]
Merge "xena_verify: Add final verification option to Xena"
Martin Klozik [Wed, 29 Mar 2017 07:08:44 +0000 (08:08 +0100)]
ixia: Support of 1 NIC connection to trafficgen
For some testcases it is useful to have only one connection between
traffic generator and DUT. Thus IxNet class was extended to support
such connection. Feature is enabled if both IXIA ports are set to
the same value.
New integration testcase ixnet_pvp_tput_1nic was created to demonstrate
this feature.
Unused code was removed from 3rd_party/ixia/ixnetrfc2544.tcl to simplify
introduction of new features and to speed up IXIA configuration.
JIRA: VSPERF-503
Change-Id: I92ab24fa58eeb1ccb7f00ac7f3530ffca7b99241
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Christian Trautman [Thu, 13 Apr 2017 23:31:57 +0000 (19:31 -0400)]
xena_verify: Add final verification option to Xena
Adds final verification option to Xena traffic generator
inside VSPerf. Works by running the Xena2544.exe again
after the initial run is complete with modified values
inside the json file. If the final verify fails it will
revert the settings and continue the in a pattern based
on if the smart search is enabled.
JIRA: VSPERF-506
Change-Id: Ic272628c489b88989f67549bd020af7354dc9b91
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Marco Varlese [Thu, 13 Apr 2017 14:00:23 +0000 (16:00 +0200)]
Fix for multi-stream configuration
The multistream configuration is not passed to the remote host where the traffic generator (MoonGen) runs.
Change-Id: I3e9862553b5b064272f3bfffb788c06ebd3740ca
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Martin Klozik [Wed, 12 Apr 2017 05:47:34 +0000 (05:47 +0000)]
Merge "ixia: VLAN support without l3/l4 headers"
Martin Klozik [Wed, 12 Apr 2017 05:47:00 +0000 (05:47 +0000)]
Merge "jumbo_frame: Add jumbo frame support"
Trevor Cooper [Fri, 31 Mar 2017 14:42:15 +0000 (07:42 -0700)]
Changes index depth
Change-Id: I9f83b22eebb61de7ab98040bd67f7dd7f3caf129
Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Thu, 30 Mar 2017 13:50:28 +0000 (14:50 +0100)]
ixia: VLAN support without l3/l4 headers
Remove dependency of VLAN headers on L3 and L4 protocols.
JIRA: VSPERF-499
Change-Id: Ic16dbbf2b503be7dd48a7bf55e45795bbb9f7e67
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
Christian Trautman [Wed, 29 Mar 2017 17:28:38 +0000 (13:28 -0400)]
jumbo_frame: Add jumbo frame support
Add jumbo frame support for all packet forwarding applications
inside guest for pxp testing. Enable jumbo frame support for
OvsVanilla, OvsDpdkVhostUser, and Packet forwarding.
Add minor fix for missing method issue when running packet
forwarding tests. The get_version method was missing in
the packet_forwaring core module.
JIRA: VSPERF-501
Change-Id: Ia99975f47c64259ed2566bde3c85b2779c309e80
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Trevor Cooper [Wed, 29 Mar 2017 07:22:57 +0000 (00:22 -0700)]
Removed white space
Change-Id: I4455ce38ca81ad1d5a028c626e3ac53d6d87db43
Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
Trevor Cooper [Wed, 29 Mar 2017 06:40:07 +0000 (23:40 -0700)]
Fixed indexes in user and developer documentation
Change-Id: Iad5c130936a815c41265b29053d2978808ff14bb
Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
Martin Klozik [Mon, 27 Mar 2017 10:43:47 +0000 (10:43 +0000)]
Merge "ixia: Make L3 and L4 headers optional"
Martin Klozik [Mon, 27 Mar 2017 10:43:25 +0000 (10:43 +0000)]
Merge "ixia: Fix VLAN support by IxNet class"
Martin Klozik [Mon, 27 Mar 2017 10:42:34 +0000 (10:42 +0000)]
Merge "vpp: Reporting update related to VPP"
Martin Klozik [Fri, 24 Mar 2017 10:49:10 +0000 (10:49 +0000)]
ixia: Make L3 and L4 headers optional
During testing it is sometimes useful to generate pure L2 traffic
without L3 or L4 related headers. IxNetwork TCL script was updated
to support this option.
Generic TRAFFIC array was enhanced by on/off switch for L3 and L4
headers. Thus it can be implemented by other traffic generators
in the future, if this feature will prove itself useful.
JIRA: VSPERF-500
Change-Id: I723c703e5d6ef609fd5b7db366871278a4730203
Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>