Move tests: unit/common

* Fix pylint errors
* Add TODOs

Some errors are ignored locally, as they were a symptom of other problems.
These issues have been flagged with a TODO, and should be fixed later.

JIRA: YARDSTICK-837
Change-Id: I2847c380556985fae2c92bb8a7da9c47e91e1338
Signed-off-by: Emma Foley <emma.l.foley@intel.com>

pylint: try to change formatting for Jenkins again

looks like we have to add var to tox passenv

Change-Id: Iba2da2123ae531e026897308769aa832c7eb6d04
Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>

Merge "Move tests: functional/"

Merge "Move tests: unit/apiserver/"

Move tests: unit/apiserver/

* Fix pylint errors
* Add TODOs

Some errors are ignored locally, as they were a symptom of other problems.
These issues have been flagged with a TODO, and should be fixed later.

JIRA: YARDSTICK-837
Signed-off-by: Emma Foley <emma.l.foley@intel.com>
Change-Id: I30d3f61e5ea479758f9a2f39cf415da18e49b9d6

Move tests: unit/test_ssh.py

Change-Id: I0eabdd5d7e918dcf0df747119a104dedf125606f
Jira: YARDSTICK-837
Signed-off-by: Emma Foley <emma.l.foley@intel.com>

Move tests: functional/

All tests in tests/functional have been moved to yardstick/tests/functional

JIRA: YARDSTICK-837
Change-Id: I89276b36635de74dd7b8f70e961c71aa0d2c494e
Signed-off-by: Emma Foley <emma.l.foley@intel.com>

pylint: make Jenkins output parseable

Jenkins doesn't handle the color and the output is hard to read in
Jenkins logs

Change-Id: Ie8fc5a78e89f72c829e4bbbcbd1291a723dfde72
Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>

Merge "Run tests in yardstick/tests/"

Run tests in yardstick/tests/

* Edit .testr.conf and tools/run_tests.sh
  * Run functional and unit tests in tests/ and yardstick/tests/
* Add yardstick/tests/unit/__init__.py and yardstick/tests/__init__.py
* Update pylintrc rules to disable:
  * missing-docstring
  * fixme
  * protected-access

Test will run in both tests/ and yardstick/tests/ initially

Change-Id: Iccd0df0d1b85b5d08f7faa56669bc32687925f7e
JIRA: YARDSTICK-837
Signed-off-by: Emma Foley <emma.l.foley@intel.com>

Merge "pyOpenSSL missing: cause 'git review' failed"

pyOpenSSL missing: cause 'git review' failed

JIRA: YARDSTICK-905

In the latest Yardstick container, when use git review to upload patches, an Attribute Error will cause failure.

root@a80081a4dccd:/home/opnfv/repos/yardstick# git review
Traceback (most recent call last):
  File "/usr/bin/git-review", line 6, in <module>
    from git_review.cmd import main
  File "/usr/lib/python2.7/dist-packages/git_review/cmd.py", line 32, in <module>
    import requests
  File "/usr/local/lib/python2.7/dist-packages/requests/_init_.py", line 52, in <module>
    from .packages.urllib3.contrib import pyopenssl
  File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 46, in <module>
    import OpenSSL.SSL
  File "/usr/lib/python2.7/dist-packages/OpenSSL/_init_.py", line 8, in <module>
    from OpenSSL import rand, crypto, SSL
  File "/usr/lib/python2.7/dist-packages/OpenSSL/SSL.py", line 118, in <module>
    SSL_ST_INIT = _lib.SSL_ST_INIT
AttributeError: 'module' object has no attribute 'SSL_ST_INIT'

pyOpenSSL is required.

Change-Id: I88a4916c9c2dfcdee45320f6b1a37eaae0803671
Signed-off-by: JingLu5 <lvjing5@huawei.com>

Merge "Bump requirements to match OpenStack Pike release"

Merge "Remove unnecessary function definition in IxLoadTrafficGen"

Merge "Rename test/unit/cmd directory"

Remove unnecessary function definition in IxLoadTrafficGen

Removed call to 'instantiate' base class in IxLoadTrafficGen.

JIRA: YARDSTICK-894

Change-Id: I0ebee1f5e0f22cfd3a67eaac8accc67ecd35ad0c
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

Merge "ansible image build improvement"

Merge "delete obsoleted zte pod info"

Merge "SPEC cpu2006 test case for VM"

delete obsoleted zte pod info

Delete zte pod info in yardstick/etc/yardstick/nodes.

Change-Id: Ie22fd9fa4b84529f0b2a7d113776d3559106e67a
Signed-off-by: zhihui wu <wu.zhihui1@zte.com.cn>

Remove tool provisioning in PROX helper

Tool provisioning in PROX setup environment helper is not needed [1]. The
tool (PROX traffic injector) is already provided during the VNF building:
  ./ansible/nsb_setup.yml -->
  ./ansible/build_yardstick_image.yml -->
  ./ansible/ubuntu_server_cloudimg_modify_samplevnfs.yml -->
  ./ansible/roles/install_samplevnf

[1]https://github.com/opnfv/yardstick/blob/master/yardstick/network_services/vnf_generic/vnf/prox_helpers.py#L641

JIRA: YARDSTICK-872

Change-Id: I0f925a7967a35a97901fbe5053793a791a7b1b01
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

Make GenericVNF an abstract class

GenericVNF class is now an abstract class. Only optional methods are
implemented. Mandatory methods:
  - instantiate
  - wait_for_instantiate
  - terminate
  - scale
  - collect_kpi.

JIRA: YARDSTICK-866

Change-Id: Ia8766f9f98816e11894d1e72b0f3bd573d091d99
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

Remove 'inconsistent-return-statements' check from Pylint

There are several bugs in Pylint [1] [2] affecting
'inconsistent-return-statements' check. It will be temporarily
removed.

[1] https://github.com/PyCQA/pylint/issues/1782
[2] https://github.com/PyCQA/pylint/issues/1794

JIRA: YARDSTICK-911

Change-Id: Ib655ef1befdc734c646cdfb9b48f1db0ccdf676d
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

Merge "Fix inventory.ini for build_yardstick_image"

Merge "Adding vFW RFC2544 and ixload test cases with various packet sizes"

ansible image build improvement

JIRA: YARDSTICK-879

Add some image build vars
Add automatic image build of nsb
yardstick_image: ansible-playbook -e img_property="normal" -vvv -i inventory.ini build_yardstick_image.yml

nsb_image_build: ansible-playbook -e img_property="nsb" -vvv -i inventory.ini build_yardstick_image.yml

prepare for yardstick image uploading

Change-Id: I9fdf30084511ca9a008df3b53887b06273bbd549
Signed-off-by: Ace Lee <liyin11@huawei.com>

SPEC cpu2006 test case for VM

JIRA: YARDSTICK-906

This test case is for benchmarking VM(VNF) compute performance using SPEC CPU2006.

Change-Id: Ida87aa4d394e38b398acb0af3176dd1b4c858c35
Signed-off-by: JingLu5 <lvjing5@huawei.com>

Fix inventory.ini for build_yardstick_image

In [1], 'no hosts matched' occured because 'jumphost' was not defined
in inventory.ini.

[1]: https://build.opnfv.org/ci/job/yardstick-daisy-baremetal-daily-master/72/console

Change-Id: I8cb36bf083ce589e94f5f8b115e99556f0bcb053
Signed-off-by: Alex Yang <yangyang1@zte.com.cn>

Add get function in ssh.py

JIRA: YARDSTICK-904

This task is about to implement a get function in ssh.py to
fetch desired files/folder in a remote VM to a local path.

In some test cases, test tools will produce results in files.
We want retain the original result files and archive them in
Yardstick docker for future usage.

Change-Id: Ifd333eb044ce31cffa6f5b2a8f6a46648a8858d1
Signed-off-by: JingLu5 <lvjing5@huawei.com>

Merge "Replace subprocess "check_output" with "Popen""

Merge changes from topics 'YARDSTICK-875', 'YARDSTICK-874'

* changes:
  Check if multiverse repository is available in Ubuntu
  Specify supported architectures for Ubuntu backports repository

Merge "Bugfix in role enable_hugepages_on_boot"

Replace subprocess "check_output" with "Popen"

"check_output" is a blocking wrapper for "Popen" which returns the output
of the command execution or raises an exception in case of error.

"Popen" is a non-blocking function that allows to create asynchronous
tasks. It returns any possible execution error but doesn't raise an
exception; this is delegated to the developer.

This code is used in the Yardstick CLI base test class.

Change-Id: Ie3e1228b2d40cb306354447653678bf581bc9697
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

Merge "Bugfix:proxy env, ansible multinode support"

Merge "Remove "flake8" and "pep8" from test-requirements"

Merge "Variable local_iface_name is read before it is set"

Check if multiverse repository is available in Ubuntu

In Ubuntu, multiverse repository is needed to install the image
dependencies [1]. If this repository is not enabled, it should be
added as part of the role "add_custom_repos".

[1] https://github.com/opnfv/yardstick/tree/master/ansible/roles/install_image_dependencies

JIRA: YARDSTICK-875

Change-Id: Ie37ebf87bf245185447f2b675568af9bd38219c0
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

Specify supported architectures for Ubuntu backports repository

Currently Trusty (Ubuntu 14.04 LTS) and Xenial (Ubuntu 16.04 LTS) doesn't
have support for arch=ARM64 in backports repository:
- http://archive.ubuntu.com/ubuntu/dists/xenial-backports/
- http://archive.ubuntu.com/ubuntu/dists/trusty-backports/

During the Yardstick image building process, the repository is added to the
APT repository list. In order to avoid errors during the repository retrival,
the available architectures must be specified [1].

[1]https://github.com/opnfv/yardstick/blob/stable/euphrates/ansible/roles/add_custom_repos/templates/sources.list.j2#L4

JIRA: YARDSTICK-874

Change-Id: I7774189fbdd7d74ff5df29526ba0da2693b3b53a
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

Bugfix in role enable_hugepages_on_boot

Make role idempotent.
Current regex doesn't match for:
linux   /boot/vmlinuz-4.10.0-30-generic root=/dev/nvme0n1p1 ro vga=788 text

Change-Id: If5eb20fce4ddc35bb109c00eb7565853b3763950
Signed-off-by: Jan Malanik <janx.malanik@intel.com>
Signed-off-by: Malanik Jan <janx.malanik@intel.com>

Merge "Fix the pylint version for pep8 tox target"

Add doc about installing YardStick on OpenSUSE

Add guide to install YardStick on OpenSUSE and modify the README
to state that OpenSUSE is supported.

Change-Id: Id107b24e0ec1ab441426bb150d9e863986d20fc1
Signed-off-by: Rossella Sblendido <rsblendido@suse.com>

Bump requirements to match OpenStack Pike release

Bumped requirements to match OpenStack Pike release
requirements [1].

[1] https://github.com/openstack/requirements/tree/stable/pike

JIRA: YARDSTICK-889

Change-Id: I18ccdc01c14693cb63bd74d29c14554f610629e3
Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>

Rename test/unit/cmd directory

Renamed test/unit/cmd directory to test/unit/test_cmd, in order to
avoid importing errors during the execution of unit tests. This directory
name collides with Python "cmd" library.

Change-Id: Ie06d58d4faace33df684c8e511a398aa0667b098
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

Fix the pylint version for pep8 tox target

Change-Id: I5e1c169a6ca13b3f46129b2c4a15ccbab2677a63
Signed-off-by: Martin Banszel <martinx.banszel@intel.com>

Variable local_iface_name is read before it is set

Moving variable setting before reading
Verified via TC:
yardstick/samples/vnf_samples/nsut/ping/tc_ping_heat_context.yaml

JIRA: YARDSTICK-899

Change-Id: Ia2feac1ed4e67dccd02446ba27afc9d40e87be35
Signed-off-by: Jiri Prokes <jirix.x.prokes@intel.com>

Merge "pretty cli format: runner/scenario/testcase list"

update release notes for Euphrates 5.1.0

Change-Id: I11b248882dd314baebd3ab4e7e676a1f3e0b50cd
Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>

Merge "Addition of NSB Prox test documentation of vPE and LW-AFTR test cases"

bugfix: tc078 have no data stored or dashboard to show results

JIRA: YARDSTICK-867

1.print result in the log, showing the txt format result

Change-Id: I6deeb4cf44895ef7a6c6d231c77b3843eec285d7
Signed-off-by: rexlee8776 <limingjiang@huawei.com>

Merge "bugfix: tc078 fails in some situations"

Merge "bugfix: kill process do not accurately kill "nova-api""

samples: Add generic L3 forwarder tests

A generic throughput test case that can be used as a
stub code for a Linux-based VNF configured as an L3 forwarder.

Supported context:
* Standalone OVSDPDK and SRIOV
* Baremetal

Code changes:
* Allow pmd-cpu-mask and lcore mask for OVS DPDK
* router_vnf.py - configures interface IP addresses and static arp entries
  using ip command
* NFVi KPIs
* Allow cputune tag for standalone context to be able to PIN on NUMA 1 cpus

SRIOV Test cases:
* RFC2544 Ethernet framesizes, 128K Flows
* 2,4 and 6 ports
* 2 and 3 vcpus per port
*
OVSDPDK Test cases:
* RFC2544 Ethernet framesizes, 128K Flows
* 2 and 4 ports
* 2 vcpus per port
* 2 PMD threads per port

TODO:
* Documentation
* Add 6 ports tests

References:
* router_vnf.py is based on sample_vnf.py
* tc_*.yaml files are based on acl/vfw test case files

Added unitests
Added get_stats to parse ip -s link

Change-Id: Id1b969d5420dfcab7c1e695acbd2cd1655747efe
Signed-off-by: Dino Simeon Madarang <dinox.madarang@intel.com>
Signed-off-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Reviewed-by: Alain Jebara <alain.jebara@intel.com>
Reviewed-by: Deepak S <deepak.s@linux.intel.com>
Reviewed-by: Emma Foley <emma.l.foley@intel.com>
Reviewed-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
Reviewed-by: Ross Brattain <ross.b.brattain@intel.com>
Reviewed-by: Edward MacGillivray <edward.s.macgillivray@intel.com>
Signed-off-by: Dhaval Patel <dhaval.r.patel@intel.com>
Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>

pretty cli format: runner/scenario/testcase list

JIRA: YARDSTICK-855

1. using prettytable to reformat cli below:
yardstick runner list
yardstick scenario list
yardstick testcase list
2. remove redundant function print_hbar
3. fix pep8 problems, the framework using do_list dynamicly,
so disable unused-argument check for now.

Change-Id: I79e1226e21fca4624bf4436414917bd07ecabca0
Signed-off-by: rexlee8776 <limingjiang@huawei.com>

NSB: Fix standalone.model.Libvirt SR-IOV modeling

Fixed standalone.model.Libvirt SR-IOV XML interface modeling, acording
to [1]:
- All PCI attributes now are printed in hexadecimal format.
- The PCI address is now added in the correct section, 'interface'.

network_services.utils.PciAddress was refactored to accept both 'domain:
bus:slot:function' and 'bus:slot:function' format inputs. This class is
used as input in the previous class, Libvirt, to print in XML the PCI
address of a SR-IOV interface.

network_services.utils.PciAddress.parse_address is now deprecated. Instead
the class standard instantiation must be used:

    libvirt_obj = utils.PciAddress(text_with_address)

A deprecation decorator is implemented along with this patch. This
decorator is used for the first time in the previously mentioned function.
This decorator stores every decorated function name and deprecation message
and raises a logging warning message the first time this function is used.

[1] https://goo.gl/so2Mrp

Change-Id: I22e95c488e27d6e2a8fdf6c1a07faab275fa6bba
Signed-off-by: Dino Simeon Madarang <dinox.madarang@intel.com>
Reviewed-by: Alain Jebara <alain.jebara@intel.com>
Reviewed-by: Deepak S <deepak.s@linux.intel.com>
Reviewed-by: Ross Brattain <ross.b.brattain@intel.com>
Reviewed-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

bugfix: kill process do not accurately kill "nova-api"

JIRA: YARDSTICK-849

1. update the kill process RegEx pattern to be more accurate
2. make attack_process to be parameter so it can be customized if
the SUT is using a different name of attack_process

Change-Id: I569730ced6c24aafbffcf2fc5752d3560d0adac5
Signed-off-by: rexlee8776 <limingjiang@huawei.com>

Bugfix:proxy env, ansible multinode support

JIRA: YARDSTICK-893

- hosts and plays in ansible/nsb_setup.yml refactored
Fixed proxy configuration from env or /etc/environment in nsb_setup.sh
Fixed ansible parameter 'environment: "{{ proxy_env }}"' in:
 - roles for components download.
 - roles for components dependencies install.

Now, you can use ansible to modify all yardstick-standalone hosts at once.
1) Configure http[s]_proxy in
- /etc/environment
or
- env variables
2) Modify ansible/yardstick-install-inventory.ini:
  [jumphost]
  localhost  ansible_connection=local

  [yardstick-standalone]
  yardstick-standalone-node ansible_host=192.168.1.2
  yardstick-standalone-node-2 ansible_host=192.168.1.3

  [all:vars]
  ansible_user=root
  ansible_pass=root

3) start:
./nsb_setup.sh # for baremetal/sriov
./nsb_setup.sh <path to admin-openrc.sh> #for openstack heat

Change-Id: I167db8bae8303210f21e8ae6f3870ef054bbedce
Signed-off-by: Malanik Jan <janx.malanik@intel.com>

Merge "bugfix: tc006, tc079, tc082 miss grafana dashboard in local deployment"

Merge "Refactor userguide "Yardstick Installation""

Change testcases 'cirros' image to 'yardstick-image'

The default OpenStack 'cirros-0.3.5' image doesn't exist anymore. The
image included by default in any testing OpenStack deployment is now
called 'cirros-0.3.5-x86_64-disk', but this name can change.

Because Yardstick, during the installation, deploys a customized image,
'yardstick-image', it makes sense to use it as the default image.

JIRA: YARDSTICK-873

Change-Id: I8fd7cbc01d4fa52e9107f2fac7d2d9ff5d1091c7
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

Merge "Ansible: fix lowercasing issue with ConfigParser"

Remove "flake8" and "pep8" from test-requirements

Removed "flake8" and "pep8" from test-requirements. Since
44070670c798d2cde2824f3150b2b11bf35c6319, "pylint" is the
code style checker, instead of "flake8" or "pep8".

JIRA: YARDSTICK-832

Change-Id: Iee598b0b1793d71dc74be36fa1875387b17d1e25
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

bugfix: tc078 fails in some situations

1. make  "SPECint_benchmark, runspec_iterations, runspec_tune, runspec_size,
runspec_rate" parameterized and change the default value "int^429" to "int"
2. remove "become: true" in some roles since it does not need root privilege

JIRA: YARDSTICK-852

Change-Id: Icb384bddc12911e2681a981d0504e0e142d1a8ec
Signed-off-by: rexlee8776 <limingjiang@huawei.com>

Merge "NSB: Fix IndexError in pin_vcpu_for_perf"

Avoid pylint warning for "protected-access"

This warning should be disabled in order to access protected
methods during testing. Any access to protected methods done
outside the testing classes, must be catched during the reviewing
process.

Change-Id: I2127b41edf704d0cb4f68b33d98705039e058d1a
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

Avoid pylint warning for "missing-docstring"

Disabled pylint message for missing doctring in methods, classes and
modules. Modules must be auto-explanatory, and some methods are trivial
an doesn't need an explanation.

Change-Id: I01d80737d92a7345bc6a2a6f607eb35cbf28da67
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

Merge "Adding vFirewall HTTP Traffic Profiles for tests including Concurrency, CPS, TPUT, TPS for 2Ports and 4Ports"

Adding vFirewall HTTP Traffic Profiles.

Modified http_locator location for 64K, 256K, 512K and 1024K
concurrency files.

The traffic profiles include various http locator image sizes i.e
4K,64K,256K,512K and 1024K

The traffic schema is changed to "nsb" from "isb" for all the
traffic profiles

Change-Id: I012da8daaa880ca80db2d3b08cebd9a73c19cd47
Signed-off-by: Phani Kiran Thaticharla <phani.kiran.thaticharla@intel.com>
Reviewed-by: Oscar Medina-Duran <oscar.medina-duran@intel.com>
Reviewed-by: Deepak S <deepak.s@linux.intel.com>
Reviewed-by: Ross Brattain <ross.b.brattain@intel.com> 

heat: allow overriding Heat/Neutron private IP for DPDK tests

For some L2/L3 DPDK testcases we need to use a custom
IP address space different from what Heat provides.

These testcases require port_security_enabled = False so
Neutron should allow for unrestricted L2 traffic.

This will work because we bind the ports to DPDK and thus
don't need DHCP.

  vnf_0:
    floating_ip: true
    placement: "pgrp1"
    network_ports:
      mgmt:
        - mgmt
      uplink_0:
        - xe0:
            local_ip: 10.44.0.20
            netmask: 255.255.255.0
      downlink_0:
        - xe1:
            local_ip: 10.44.0.30
            netmask: 255.255.255.0

Also fixup flake8 errors in unittests

Change-Id: Id29dfffa692f16fb1f526d208db43e476e2f7830
Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>

Adding vFW RFC2544 and ixload test cases with various packet sizes

Changed private to uplink and public to downlink

Change-Id: Id9273d9489f58bd45b60a00fc9e5bcbe9e136c84
Signed-off-by: Phani Kiran Thaticharla <phani.kiran.thaticharla@intel.com>
Reviewed-by: Oscar Medina-Duran <oscar.medina-duran@intel.com>
Reviewed-by: Deepak S <deepak.s@linux.intel.com>
Reviewed-by: Ross Brattain <ross.b.brattain@intel.com> 

Adding vFirewall HTTP Traffic Profiles for tests including Concurrency, CPS, TPUT, TPS for 2Ports and 4Ports

Change-Id: I3c7f047dc6d1545093aed6f64ccaed9f90d85af3
Signed-off-by: Phani Kiran Thaticharla <phani.kiran.thaticharla@intel.com>
Reviewed-by: Oscar Medina-Duran <oscar.medina-duran@intel.com>
Reviewed-by: Deepak S <deepak.s@linux.intel.com>
Reviewed-by: Ross Brattain <ross.b.brattain@intel.com> 

Merge "bugfix: tc023 miss description and tc050-58 wrong description"

Merge "KVMFORNFV: Reverting LiveMigration changes"

KVMFORNFV: Reverting LiveMigration changes

This patch consists of reverting the changes of patch 45227 and
incudes redirecting the console output of the LiveMigration
execution to /dev/null as the stdout contains only the statistics,
i.e., totaltime, downtime and setuptime.

This reverts commit 5a1f65d3e7d67488ee6f558dccfa5ca5581ddb65.

Change-Id: I252b5a4045657cfa8362e9aae755249480cd3b77
Signed-off-by: Navya <navyax.bathula@intel.com>

Merge "Remove img_modify_playbook assignation in build_yardstick_image.yml"

Merge "Move test requirements into test-requirements.txt"

Merge "Move test scripts to tools/"

Merge "tox: Split tests into separate tox environments"

Merge "Tox: add a pep8 target"

Remove img_modify_playbook assignation in build_yardstick_image.yml

Variable "img_modify_playbook" is being assigned in first context of
./ansible/build_yardstick_image.yml [1]. However this variable is never used.
In second context [2], the variable used is a CLI input variable.

[1]https://github.com/opnfv/yardstick/blob/stable/euphrates/ansible/build_yardstick_image.yml#L187
[2]https://github.com/opnfv/yardstick/blob/stable/euphrates/ansible/build_yardstick_image.yml#L205

JIRA: YARDSTICK-871

Change-Id: I7bd5063c5e86520abcafdc782222ee53faf58f45
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

Addition of NSB Prox test documentation of vPE and LW-AFTR test cases

YARDSTICK-840

NSB Prox test documentation of vPE and LW-AFTR test cases documenation.

Change-Id: Ic6da6546faf0494fdee71962a515083e6e10a410
Signed-off-by: Daniel Martin Buckley <daniel.m.buckley@intel.com>

fix docker client don't have trex_client

JIRA: YARDSTICK-854

Add trex_client in docker,
so we could run NSB testcase in docker container.

Change-Id: Iac1393d6e3a175137973190936ab69a1f2ce8272
Signed-off-by: Ace Lee <liyin11@huawei.com>

Merge "update docker version to 16.04"

NSB: Fix IndexError in pin_vcpu_for_perf

This addresses the IndexError in Standalone SRIOV/OVSDPDK context.
The correct sys_cpu number should be sys_cpu-1

Error:
    threads = "%s-%s" % (soc_cpu[socket][sys_cpu], soc_cpu[socket][-1])
IndexError: list index out of range

Tested platform: (Hyper-Threading disabled)
NUMA node0 CPU(s):     0-21
NUMA node1 CPU(s):     22-43

With socket equal to 0, sys_cpu value was 22 which resulted to IndexError.

Change-Id: I36b045cacce4caff4b5ddafaa9b6737f1c6df0a1
Signed-off-by: Dino Simeon Madarang <dinox.madarang@intel.com>
Reviewed-by: Alain Jebara <alain.jebara@intel.com>
Reviewed-by: Deepak S <deepak.s@linux.intel.com>
Reviewed-by: Ross Brattain <ross.b.brattain@intel.com>
Reviewed-by: Edward MacGillivray <edward.s.macgillivray@intel.com>

bugfix: tc023 miss description and tc050-58 wrong description

also modify tc019,025,045-49 descrition to be unified

JIRA: YARDSTICK-850

Change-Id: I3f775f1ebff4063edc53b9bc26d7ba10b8af8a9d
Signed-off-by: rexlee8776 <limingjiang@huawei.com>

Move test requirements into test-requirements.txt

Move the packages required for testing into test-requirements.txt
This follows conventions used in OpenStack projects.

JIRA: YARDSTICK-837
Change-Id: If08fc416aa21b11250066bc19a54daa35e863407
Signed-off-by: Emma Foley <emma.l.foley@intel.com>

Move test scripts to tools/

Move the scripts that tox uses for running tests
to the tools/ directory:
* run_tests.sh -> tools/run_tests.sh
* tests/ci/cover.{sh,awk} -> tools/

JIRA: YARDSTICK-837
Change-Id: I817c9e5f58c06b45f1de3f369318f4bb24168677
Signed-off-by: Emma Foley <emma.l.foley@intel.com>

tox: Split tests into separate tox environments

* Add argument parsing to run_tests.sh so tests can be selected
* Define tox environments for:
  * Coverage
  * Unit tests
  * Functional tests
    * for py27 and py3
* Add environments to default env
  * Behaviour is the same when the tests are run
* Updates the py27 environment config, and adds a py3 config.
  * Commands from testenv are moved to py27
  * py3 env uses the same commands, but runs with python3

Change-Id: I22f17c0103101f01ec268b1de9d146780ae67a6d
JIRA: YARDSTICK-837
Signed-off-by: Emma Foley <emma.l.foley@intel.com>

Tox: add a pep8 target

Adds a pep8, pep8-full targets to tox:
* pep8 target: runs pylint on the changed files
* pep8-full target: runs pylint on whole repo

Adds scripts to run pylint:
* stored in tools/

Documentation: changeed the command for running tests
(run_tests.sh -> tox). This runs the same set of tests as before.

JIRA: YARDSTICK-832

Change-Id: I652da87723682d958f3fcbc2eb4cd88422636a3b
Signed-off-by: Emma Foley <emma.l.foley@intel.com>

Merge "Dockerfile: apt-get clean to save layer space"

Make GenericTrafficGen class abstract

GenericTrafficGen class is now an abstract class. Only optional methods
are implemented.
  - 'run_traffic' and 'terminate' are mandatory.
  - 'listen_traffic', 'verify_traffic' and 'wait_for_instance' are
    optional. By default these methods doesn't execute any action.

JIRA: YARDSTICK-853

Change-Id: I2befdaa337af79cc2364bdd7c66183c31c5ab69a
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

Merge "Add vfw ixload testcase for heat"

Merge "NSB: update vfw tc_heat_external tests"

Merge "Check requirements against OpenStack requirements"

Merge "NSB Prox BM test case fixes for scale up"

Merge "Fix controller IP parsing in "nsb_setup.sh" script"

Merge "Clean functional tests in "test_cli_scenario""

Merge "Create get_description and get_scenario_type for Scenario"

Fix controller IP parsing in "nsb_setup.sh" script

Fixed the controller IP parsing in "nsb_setup.sh" script. The new
regex expression now accepts "OS_AUTH_URL" as:
  * http://10.237.223.168/identity
  * http://10.237.223.168:5000/identity
  * http://hostname/identity
  * http://hostname:5000/identity

JIRA: YARDSTICK-829

Change-Id: Ifaeab991bcbb6aa7b22c3533ab7554527184878b
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>

bugfix: tc006, tc079, tc082 miss grafana dashboard in local deployment

JIRA: YARDSTICK-847

Change-Id: I0750f2d17bac9e0214caf640e4ea1141ea3b4a03
Signed-off-by: rexlee8776 <limingjiang@huawei.com>

update docker version to 16.04

JIRA: YARDSTICK-690

This patch is for Yardstick Docker base image upgrade to 16.04

This patch will enable ansible build image in yardstick env prepare.

Add qemu-img convert to ansible build image.

Change-Id: I43127b6020bd20bd9f4aac4fca0df75353b24346
Signed-off-by: Ace Lee <liyin11@huawei.com>