From: Markos Chandras <mchandras@suse.de>
Date: Tue, 9 May 2017 14:41:22 +0000 (+0100)
Subject: prototypes: xci: provision-vm-nodes: Do not provision VMs as root.
X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F97%2F34597%2F2;hp=5ef62747c290944deabf801ccf9c8a2d0f7ec38a;p=releng.git

prototypes: xci: provision-vm-nodes: Do not provision VMs as root.

There is no need to provision VM nodes as root. The only thing that we
need to run as root is the destroy-env.sh script and for that we move
it to its own play so we can use Ansible's become directive. Moreover,
since this playbook operates on localhost we can use 'connection: local'
so we don't have to execute everything via ssh and possibly speed up
the whole process.

Change-Id: Ia9efd5f30e95385b5cf193dde352f93551846c0e
Signed-off-by: Markos Chandras <mchandras@suse.de>
---

diff --git a/prototypes/xci/playbooks/provision-vm-nodes.yml b/prototypes/xci/playbooks/provision-vm-nodes.yml
index 9a32d0bfc..dad0184f1 100644
--- a/prototypes/xci/playbooks/provision-vm-nodes.yml
+++ b/prototypes/xci/playbooks/provision-vm-nodes.yml
@@ -8,7 +8,7 @@
 # http://www.apache.org/licenses/LICENSE-2.0
 ##############################################################################
 - hosts: localhost
-  remote_user: root
+  connection: local
   vars_files:
     - ../var/{{ ansible_os_family }}.yml
     - ../var/opnfv.yml
@@ -22,10 +22,25 @@
       copy:
         src: "{{ OPNFV_RELENG_PATH }}/prototypes/bifrost/"
         dest: "{{ OPENSTACK_BIFROST_PATH }}"
+
+- hosts: localhost
+  connection: local
+  become: yes
+  vars_files:
+    - ../var/{{ ansible_os_family }}.yml
+    - ../var/opnfv.yml
+  tasks:
     - name: destroy VM nodes created by previous deployment
       command: "/bin/bash ./scripts/destroy-env.sh"
       args:
         chdir: "{{ OPENSTACK_BIFROST_PATH }}"
+
+- hosts: localhost
+  connection: local
+  vars_files:
+    - ../var/{{ ansible_os_family }}.yml
+    - ../var/opnfv.yml
+  tasks:
     - name: create and provision VM nodes for the flavor {{ XCI_FLAVOR }}
       command: "/bin/bash ./scripts/bifrost-provision.sh"
       args: