From: randyl Date: Tue, 7 Mar 2017 00:38:46 +0000 (-0700) Subject: Add check that SSH validate returns true X-Git-Tag: opnfv-5.0.0~152 X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F97%2F29897%2F1;p=snaps.git Add check that SSH validate returns true The SSH Validate call needs to be checked before passing tests. test_ssh_client_fip_before_active and test_ssh_client_fip_after_active run the SSH Verify function, but do not check the return value. You will see an error in the test log file, but the test will appear to have passed. JIRA: SNAPS-45 Added an Assert True test to the SSH Validate return. Change-Id: Ib86ec38c7b5a64061a1ace4293336e3021c59013 Signed-off-by: randyl --- diff --git a/snaps/openstack/tests/create_instance_tests.py b/snaps/openstack/tests/create_instance_tests.py index 9a02765..827f305 100644 --- a/snaps/openstack/tests/create_instance_tests.py +++ b/snaps/openstack/tests/create_instance_tests.py @@ -624,7 +624,7 @@ class CreateInstanceSingleNetworkTests(OSIntegrationTestCase): self.assertTrue(inst_creator.vm_active(block=True)) self.assertEquals(vm_inst, inst_creator.get_vm_inst()) - validate_ssh_client(inst_creator) + self.assertTrue(validate_ssh_client(inst_creator)) def test_ssh_client_fip_after_active(self): """ @@ -651,7 +651,7 @@ class CreateInstanceSingleNetworkTests(OSIntegrationTestCase): self.assertTrue(inst_creator.vm_active(block=True)) self.assertEquals(vm_inst, inst_creator.get_vm_inst()) - validate_ssh_client(inst_creator) + self.assertTrue(validate_ssh_client(inst_creator)) # TODO - Determine how allowed_address_pairs is supposed to operate before continuing this test # see http://docs.openstack.org/developer/dragonflow/specs/allowed_address_pairs.html for a functional description