From: Cédric Ollivier <cedric.ollivier@orange.com>
Date: Sun, 26 Mar 2017 09:55:10 +0000 (+0200)
Subject: Fix pylint warnings in testcase_base
X-Git-Tag: opnfv-5.0.RC1~536^2
X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F85%2F31785%2F3;p=functest.git

Fix pylint warnings in testcase_base

It takes into account the following warnings:
  - bare-except
  - unused-argument
  - broad-except

Change-Id: I3a50bf6d07823edc80a7f0f78f46681ace7f4a39
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
---

diff --git a/functest/core/testcase_base.py b/functest/core/testcase_base.py
index 838b63983..2848073f7 100644
--- a/functest/core/testcase_base.py
+++ b/functest/core/testcase_base.py
@@ -35,11 +35,12 @@ class TestcaseBase(object):
             assert self.criteria
             if self.criteria == 'PASS':
                 return TestcaseBase.EX_OK
-        except:
+        except AssertionError:
             self.logger.error("Please run test before checking the results")
         return TestcaseBase.EX_TESTCASE_FAILED
 
     def run(self, **kwargs):
+        # pylint: disable=unused-argument
         self.logger.error("Run must be implemented")
         return TestcaseBase.EX_RUN_ERROR
 
@@ -58,6 +59,6 @@ class TestcaseBase(object):
             else:
                 self.logger.error("The results cannot be pushed to DB")
                 return TestcaseBase.EX_PUSH_TO_DB_ERROR
-        except Exception:
+        except Exception:  # pylint: disable=broad-except
             self.logger.exception("The results cannot be pushed to DB")
             return TestcaseBase.EX_PUSH_TO_DB_ERROR