From: Tim Rozet <trozet@redhat.com>
Date: Sat, 23 Sep 2017 14:09:18 +0000 (-0400)
Subject: Fixes clone fork change URL
X-Git-Tag: opnfv-5.0.0~39^2
X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F55%2F42855%2F1;p=apex.git

Fixes clone fork change URL

Downloading the change information was failing for branches other than
master.  This fixes the URL format to work for branches.

Change-Id: I5ec0494aca93437266237ee63b292a6aa5a43f0e
Signed-off-by: Tim Rozet <trozet@redhat.com>
---

diff --git a/apex/build/build_utils.py b/apex/build/build_utils.py
index 14327a90..66a63d37 100644
--- a/apex/build/build_utils.py
+++ b/apex/build/build_utils.py
@@ -16,6 +16,8 @@ import re
 import shutil
 import sys
 
+from urllib.parse import quote_plus
+
 
 def clone_fork(args):
     ref = None
@@ -35,7 +37,9 @@ def clone_fork(args):
         change_id = m.group(1)
         logging.info("Using change ID {} from {}".format(change_id, args.repo))
         rest = GerritRestAPI(url=args.url)
-        change_str = "changes/{}?o=CURRENT_REVISION".format(change_id)
+        change_path = "{}~{}~{}".format(args.repo, quote_plus(args.branch),
+                                        change_id)
+        change_str = "changes/{}?o=CURRENT_REVISION".format(change_path)
         change = rest.get(change_str)
         try:
             assert change['status'] not in 'ABANDONED' 'CLOSED',\
@@ -104,5 +108,6 @@ def main():
         parser.print_help()
         exit(1)
 
+
 if __name__ == "__main__":
     main()