From: Cédric Ollivier <cedric.ollivier@orange.com>
Date: Sun, 30 Apr 2017 07:35:05 +0000 (+0200)
Subject: Fix pylint warnings in snaps
X-Git-Tag: opnfv-5.0.RC1~449^2
X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F13%2F34013%2F1;p=functest.git

Fix pylint warnings in snaps

Pylint only warns about missing module docstrings now.

Change-Id: I989ff800cd2628fed80a2d3510ef37ce2876cbd4
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
---

diff --git a/functest/opnfv_tests/openstack/snaps/health_check.py b/functest/opnfv_tests/openstack/snaps/health_check.py
index 44e3b876b..c057eb2b0 100644
--- a/functest/opnfv_tests/openstack/snaps/health_check.py
+++ b/functest/opnfv_tests/openstack/snaps/health_check.py
@@ -30,8 +30,7 @@ class HealthCheck(SnapsTestRunner):
 
         image_custom_config = None
         if hasattr(CONST, 'snaps_health_check'):
-            image_custom_config = CONST.snaps_health_check
-
+            image_custom_config = CONST.__getattribute__('snaps_health_check')
         self.suite.addTest(
             OSIntegrationTestCase.parameterize(
                 SimpleHealthCheck, os_creds=self.os_creds,
diff --git a/functest/opnfv_tests/openstack/snaps/smoke.py b/functest/opnfv_tests/openstack/snaps/smoke.py
index 5a637f288..2c6fc2553 100644
--- a/functest/opnfv_tests/openstack/snaps/smoke.py
+++ b/functest/opnfv_tests/openstack/snaps/smoke.py
@@ -32,12 +32,13 @@ class SnapsSmoke(SnapsTestRunner):
         # snaps_health_check suite, so reuse it here
         image_custom_config = None
         if hasattr(CONST, 'snaps_health_check'):
-            image_custom_config = CONST.snaps_health_check
+            image_custom_config = CONST.__getattribute__('snaps_health_check')
 
         # Tests requiring floating IPs leverage files contained within the
         # SNAPS repository and are found relative to that path
         if self.use_fip:
-            snaps_dir = CONST.dir_repo_snaps + '/snaps'
+            snaps_dir = os.path.join(CONST.__getattribute__('dir_repo_snaps'),
+                                     'snaps')
             os.chdir(snaps_dir)
 
         test_suite_builder.add_openstack_integration_tests(
diff --git a/functest/opnfv_tests/openstack/snaps/snaps_test_runner.py b/functest/opnfv_tests/openstack/snaps/snaps_test_runner.py
index b17aab0c0..8a68cad9e 100644
--- a/functest/opnfv_tests/openstack/snaps/snaps_test_runner.py
+++ b/functest/opnfv_tests/openstack/snaps/snaps_test_runner.py
@@ -24,16 +24,16 @@ class SnapsTestRunner(PyTestSuiteRunner):
         super(SnapsTestRunner, self).__init__(**kwargs)
 
         self.os_creds = openstack_tests.get_credentials(
-            os_env_file=CONST.openstack_creds, proxy_settings_str=None,
-            ssh_proxy_cmd=None)
+            os_env_file=CONST.__getattribute__('openstack_creds'),
+            proxy_settings_str=None, ssh_proxy_cmd=None)
 
         self.ext_net_name = snaps_utils.get_ext_net_name(self.os_creds)
-        self.use_fip = CONST.snaps_use_floating_ips
-        self.use_keystone = CONST.snaps_use_keystone
+        self.use_fip = CONST.__getattribute__('snaps_use_floating_ips')
+        self.use_keystone = CONST.__getattribute__('snaps_use_keystone')
         scenario = functest_utils.get_scenario()
 
         self.flavor_metadata = create_flavor.MEM_PAGE_SIZE_ANY
         if 'ovs' in scenario or 'fdio' in scenario:
             self.flavor_metadata = create_flavor.MEM_PAGE_SIZE_LARGE
 
-        self.logger.info("Using flavor metatdata '%s'" % self.flavor_metadata)
+        self.logger.info("Using flavor metadata '%s'", self.flavor_metadata)