From: spisarski Date: Mon, 10 Apr 2017 16:59:55 +0000 (-0600) Subject: Problem found while working on FUNCTEST-577 where instances with X-Git-Tag: opnfv-5.0.0~144 X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=commitdiff_plain;h=e64bf898644b45f28f9df31dd054b8864e4828b8;p=snaps.git Problem found while working on FUNCTEST-577 where instances with security groups need to be active before application. JIRA: FUNCTEST-577 Change-Id: I0d31b6afe4a378b3be85b335ba5f1568a0b26708 Signed-off-by: spisarski --- diff --git a/snaps/openstack/create_instance.py b/snaps/openstack/create_instance.py index 620483b..793f4c7 100644 --- a/snaps/openstack/create_instance.py +++ b/snaps/openstack/create_instance.py @@ -146,7 +146,11 @@ class OpenStackVmInstance: # TODO - the call above should add security groups. The return object shows they exist but the association # had never been made by OpenStack. This call is here to ensure they have been added for sec_grp_name in self.instance_settings.security_group_names: - nova_utils.add_security_group(self.__nova, self.__vm, sec_grp_name) + if self.vm_active(block=True): + nova_utils.add_security_group(self.__nova, self.__vm, sec_grp_name) + else: + raise Exception('Cannot applying security group with name ' + sec_grp_name + + ' to VM that did not activate with name - ' + self.instance_settings.name) self.__apply_floating_ips()