From: Juan Antonio Osorio Robles <jaosorior@redhat.com>
Date: Tue, 22 Aug 2017 18:06:14 +0000 (+0300)
Subject: Add -s (silent) to curl command for CRL refresh
X-Git-Tag: opnfv-6.0.0~56
X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=commitdiff_plain;h=ab48d3a438845f1fe7a862cb1396963e7ca754e2;p=apex-puppet-tripleo.git

Add -s (silent) to curl command for CRL refresh

Without it, it doesn't reload the services it should.

Change-Id: I43e6188700deb585f905ca700e69b6875f0ded45
Closes-Bug: #1712404
---

diff --git a/manifests/certmonger/ca/crl.pp b/manifests/certmonger/ca/crl.pp
index 2454460..a69065d 100644
--- a/manifests/certmonger/ca/crl.pp
+++ b/manifests/certmonger/ca/crl.pp
@@ -129,7 +129,7 @@ class tripleo::certmonger::ca::crl (
 
   if $ensure == 'present' {
     # Fetch CRL in cron job and notify needed services
-    $cmd_list = concat(["${sleep}curl -L -o ${fetched_crl} ${crl_source}"], $process_cmd, $reload_cmds)
+    $cmd_list = concat(["${sleep}curl -s -L -o ${fetched_crl} ${crl_source}"], $process_cmd, $reload_cmds)
     $cron_cmd = join($cmd_list, ' && ')
   } else {
     $cron_cmd = absent
diff --git a/spec/classes/tripleo_certmonger_ca_crl_spec.rb b/spec/classes/tripleo_certmonger_ca_crl_spec.rb
index 1e605ce..29726f1 100644
--- a/spec/classes/tripleo_certmonger_ca_crl_spec.rb
+++ b/spec/classes/tripleo_certmonger_ca_crl_spec.rb
@@ -47,7 +47,7 @@ describe 'tripleo::certmonger::ca::crl' do
       end
 
       let :cron_cmd do
-        "curl -L -o #{params[:crl_preprocessed]} #{params[:crl_source]} && #{process_cmd}"
+        "curl -s -L -o #{params[:crl_preprocessed]} #{params[:crl_source]} && #{process_cmd}"
       end
 
       it 'should create and process CRL file' do
@@ -75,7 +75,7 @@ describe 'tripleo::certmonger::ca::crl' do
       end
 
       let :cron_cmd do
-        "curl -L -o #{params[:crl_dest]} #{params[:crl_source]}"
+        "curl -s -L -o #{params[:crl_dest]} #{params[:crl_source]}"
       end
 
       it 'should create and process CRL file' do