From: Sofer Athlan-Guyot <chem@sathlan.org>
Date: Thu, 18 Aug 2016 08:55:34 +0000 (+0200)
Subject: Fix check of rpm-python.
X-Git-Tag: opnfv-6.0.0~1685^2
X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=commitdiff_plain;h=a6962e751f23598dd8a637965a8b55793a3dc3c0;p=apex-tripleo-heat-templates.git

Fix check of rpm-python.

There is a typo in the code, making this test always successful.

Closes-Bug: 1614437
Change-Id: Ia6b0b156294de9fcb8f66fc46aa8801555775a56
---

diff --git a/extraconfig/tasks/major_upgrade_controller_pacemaker_1.sh b/extraconfig/tasks/major_upgrade_controller_pacemaker_1.sh
index d67d5a1a..26a3c8f1 100755
--- a/extraconfig/tasks/major_upgrade_controller_pacemaker_1.sh
+++ b/extraconfig/tasks/major_upgrade_controller_pacemaker_1.sh
@@ -18,7 +18,7 @@ STONITH_STATE=$(pcs property show stonith-enabled | grep "stonith-enabled" | awk
 pcs property set stonith-enabled=false
 
 # If for some reason rpm-python are missing we want to error out early enough
-if [ ! rpm -q rpm-python &> /dev/null ]; then
+if ! rpm -q rpm-python &> /dev/null; then
     echo_error "ERROR: upgrade cannot start without rpm-python installed"
     exit 1
 fi