From: Steven Hardy <shardy@redhat.com>
Date: Tue, 15 Nov 2016 22:49:18 +0000 (+0000)
Subject: Correct AllNodesDeploySteps depends_on
X-Git-Tag: opnfv-6.0.0~1393^2
X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=commitdiff_plain;h=8fe71c088889426f5a1547e96b47c569a0a0643c;p=apex-tripleo-heat-templates.git

Correct AllNodesDeploySteps depends_on

This is wrong atm, it should loop to create a list for the depends_on
not multiple depends_on statements.

Note this was first corrected in https://review.openstack.org/#/c/330659/
but we need it as a standalone patch that can be backported.

Change-Id: I4d1d6346f2147e573fc0900038f1ad1d782e75ee
Closes-Bug: #1642069
---

diff --git a/overcloud.j2.yaml b/overcloud.j2.yaml
index 64bed276..42339ead 100644
--- a/overcloud.j2.yaml
+++ b/overcloud.j2.yaml
@@ -542,8 +542,8 @@ resources:
   # Post deployment steps for all roles
   AllNodesDeploySteps:
     type: OS::TripleO::PostDeploySteps
-{% for role in roles %}
     depends_on:
+{% for role in roles %}
       - {{role.name}}AllNodesDeployment
 {% endfor %}
     properties: