From: Carlos Camacho <ccamacho@redhat.com>
Date: Tue, 17 Jan 2017 15:44:40 +0000 (+0100)
Subject: Check that all templates are using the release alias
X-Git-Tag: opnfv-6.0.0~1220
X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=commitdiff_plain;h=7efa88bbec6294e59d7334e60dffab02825f8418;p=apex-tripleo-heat-templates.git

Check that all templates are using the release alias

Quick verification to check that the release name
is used instead the date.

Im also adding here all the updated templates required
to pass the check and merge this check as soon as possible.

Change-Id: Ifdc9ac4a9d0a4872d3e21672c93fc87da2e68a4e
---

diff --git a/puppet/services/cinder-hpelefthand-iscsi.yaml b/puppet/services/cinder-hpelefthand-iscsi.yaml
index f22a3aeb..ca7d2838 100644
--- a/puppet/services/cinder-hpelefthand-iscsi.yaml
+++ b/puppet/services/cinder-hpelefthand-iscsi.yaml
@@ -1,4 +1,4 @@
-heat_template_version: 2017-02-24
+heat_template_version: ocata
 
 description: >
   Configure Cinder HPELeftHandISCSIDriver
diff --git a/tools/yaml-validate.py b/tools/yaml-validate.py
index f2359af6..63e3ce51 100755
--- a/tools/yaml-validate.py
+++ b/tools/yaml-validate.py
@@ -94,6 +94,10 @@ def validate_mysql_connection(settings):
 
 
 def validate_service(filename, tpl):
+    if 'heat_template_version' in tpl and not str(tpl['heat_template_version']).isalpha():
+        print('ERROR: heat_template_version needs to be the release alias not a date: %s'
+              % filename)
+        return 1
     if 'outputs' in tpl and 'role_data' in tpl['outputs']:
         if 'value' not in tpl['outputs']['role_data']:
             print('ERROR: invalid role_data for filename: %s'