From: spisarski <s.pisarski@cablelabs.com>
Date: Fri, 21 Jul 2017 14:08:30 +0000 (-0600)
Subject: Created new class ProjectSettingsError.
X-Git-Tag: opnfv-5.0.0~52^2
X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=commitdiff_plain;h=7c3bbf62df8553475b787ffd234cd3df3fa0c90b;p=snaps.git

Created new class ProjectSettingsError.

Raising ProjectSettingsError in ProjectSettings instead of Exception.

JIRA: SNAPS-135

Change-Id: I5169dd196775453466ea8d7fe9fa0c8d82b2382a
Signed-off-by: spisarski <s.pisarski@cablelabs.com>
---

diff --git a/snaps/openstack/create_project.py b/snaps/openstack/create_project.py
index 0384ccc..a20033e 100644
--- a/snaps/openstack/create_project.py
+++ b/snaps/openstack/create_project.py
@@ -131,5 +131,11 @@ class ProjectSettings:
             self.enabled = True
 
         if not self.name:
-            raise Exception(
+            raise ProjectSettingsError(
                 "The attribute name is required for ProjectSettings")
+
+
+class ProjectSettingsError(Exception):
+    """
+    Exception to be thrown when project settings attributes are incorrect
+    """
diff --git a/snaps/openstack/tests/create_project_tests.py b/snaps/openstack/tests/create_project_tests.py
index 3c6b2d1..f2af0d9 100644
--- a/snaps/openstack/tests/create_project_tests.py
+++ b/snaps/openstack/tests/create_project_tests.py
@@ -15,7 +15,8 @@
 import unittest
 import uuid
 
-from snaps.openstack.create_project import OpenStackProject, ProjectSettings
+from snaps.openstack.create_project import (
+    OpenStackProject, ProjectSettings, ProjectSettingsError)
 from snaps.openstack.create_security_group import OpenStackSecurityGroup
 from snaps.openstack.create_security_group import SecurityGroupSettings
 from snaps.openstack.create_user import OpenStackUser
@@ -32,11 +33,11 @@ class ProjectSettingsUnitTests(unittest.TestCase):
     """
 
     def test_no_params(self):
-        with self.assertRaises(Exception):
+        with self.assertRaises(ProjectSettingsError):
             ProjectSettings()
 
     def test_empty_config(self):
-        with self.assertRaises(Exception):
+        with self.assertRaises(ProjectSettingsError):
             ProjectSettings(**dict())
 
     def test_name_only(self):