From: Alex Schultz <aschultz@redhat.com>
Date: Fri, 3 Mar 2017 16:21:59 +0000 (-0700)
Subject: Throw warnings for norpm actions
X-Git-Tag: opnfv-6.0.0~315^2
X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=commitdiff_plain;h=2be36167fd223d95a71d557afa9d26bf950e21c8;p=apex-puppet-tripleo.git

Throw warnings for norpm actions

If the norpm provider attempts to do any install/update/remove actions,
we should throw a warning in the logs so people are aware that the
action did not actually take place.

Change-Id: Ieee5cac3412c709ba6b39316e455d7708cc9d22e
Closes-Bug: #1669666
---

diff --git a/lib/puppet/provider/package/norpm.rb b/lib/puppet/provider/package/norpm.rb
index 080b138..abe1780 100644
--- a/lib/puppet/provider/package/norpm.rb
+++ b/lib/puppet/provider/package/norpm.rb
@@ -12,6 +12,7 @@
 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations
 # under the License.
+require 'puppet'
 require 'puppet/provider/package'
 
 Puppet::Type.type(:package).provide :norpm, :source => :rpm, :parent => :rpm do
@@ -24,18 +25,22 @@ Puppet::Type.type(:package).provide :norpm, :source => :rpm, :parent => :rpm do
   end
 
   def install
+    Puppet.warning("[norpm] Attempting to install #{name} but it will not be installed")
     true
   end
 
   def uninstall
+    Puppet.warning("[norpm] Attempting to uninstall #{name} but it will not be removed")
     true
   end
 
   def update
+    Puppet.warning("[norpm] Attempting to update #{name} but it will not be updated")
     true
   end
 
   def purge
+    Puppet.warning("[norpm] Attempting to purge #{name} but it will not be removed")
     true
   end