Protect vs Bucket containing html chars 60/73260/3 stable/jerma
authorCédric Ollivier <cedric.ollivier@orange.com>
Fri, 4 Mar 2022 09:01:29 +0000 (10:01 +0100)
committerCédric Ollivier <cedric.ollivier@orange.com>
Fri, 4 Mar 2022 14:04:49 +0000 (15:04 +0100)
It allows dumping MTS output files.

Change-Id: I2b35ee81a764573a9d17cb3a225cb5febed5fa46
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
xtesting/core/campaign.py

index 4dca304..aadba78 100644 (file)
@@ -128,18 +128,21 @@ class Campaign():
             # pylint: disable=no-member
             for s3_object in b3resource.Bucket(bucket_name).objects.filter(
                     Prefix="{}/".format(prefix)):
-                path, _ = os.path.split(s3_object.key)
+                path, _ = os.path.split(
+                    urllib.parse.unquote_plus(s3_object.key))
                 lpath = re.sub('^{}/*'.format(s3path), '', path)
                 if lpath and not os.path.exists(lpath):
                     os.makedirs(lpath)
+                Campaign.__logger.info(
+                    "Downloading %s",
+                    re.sub('^{}/*'.format(s3path), '',
+                           urllib.parse.unquote_plus(s3_object.key)))
                 # pylint: disable=no-member
                 b3resource.Bucket(bucket_name).download_file(
-                    s3_object.key,
-                    re.sub('^{}/*'.format(s3path), '', s3_object.key),
+                    urllib.parse.unquote_plus(s3_object.key),
+                    re.sub('^{}/*'.format(s3path), '',
+                           urllib.parse.unquote_plus(s3_object.key)),
                     Config=tconfig)
-                Campaign.__logger.info(
-                    "Downloading %s",
-                    re.sub('^{}/*'.format(s3path), '', s3_object.key))
             return Campaign.EX_OK
         except Exception:  # pylint: disable=broad-except
             Campaign.__logger.exception("Cannot publish the artifacts")