Fixed the Glance connection test routines. 89/33789/2
authorspisarski <s.pisarski@cablelabs.com>
Tue, 25 Apr 2017 12:37:24 +0000 (14:37 +0200)
committerSteven Pisarski <s.pisarski@cablelabs.com>
Wed, 26 Apr 2017 13:48:49 +0000 (13:48 +0000)
test_glance_connect_success gave a false positive and
test_glance_connect_fail gave a false negative.
Both were calling incorrect APIs due to copying from the equivalent
nova_utils.py test.

JIRA: SNAPS-57

Change-Id: I1246d535f8bd376c163315dc889ff5bacebb12ec
Signed-off-by: spisarski <s.pisarski@cablelabs.com>
snaps/openstack/utils/tests/glance_utils_tests.py

index ba7f6cf..37b14a5 100644 (file)
@@ -36,9 +36,9 @@ class GlanceSmokeTests(OSComponentTestCase):
         Tests to ensure that the proper credentials can connect.
         """
         glance = glance_utils.glance_client(self.os_creds)
-
-        users = glance.images.list()
-        self.assertIsNotNone(users)
+        nova = nova_utils.nova_client(self.os_creds)
+        image = glance_utils.get_image(nova, glance, 'foo')
+        self.assertIsNone(image)
 
     def test_glance_connect_fail(self):
         """
@@ -47,8 +47,9 @@ class GlanceSmokeTests(OSComponentTestCase):
         from snaps.openstack.os_credentials import OSCreds
 
         with self.assertRaises(Exception):
-            neutron = glance_utils.glance_client(OSCreds('user', 'pass', 'url', 'project'))
-            neutron.list_networks()
+            glance = glance_utils.glance_client(OSCreds('user', 'pass', 'url', 'project'))
+            nova = nova_utils.nova_client(self.os_creds)
+            glance_utils.get_image(nova, glance, 'foo')
 
 
 class GlanceUtilsTests(OSComponentTestCase):