Bug fix: Remove use_prebuilt_images condition

The creation or not of the IPA image does not depend on the value of the
use_prebuilt_images. This variable is intended to control the following
call to bifrost-create-dib-image role.

I added a few comments to clarify what we are doing in each call to the
bifrost-create-dib-image role

Change-Id: Id66e1a969ca279a055640481719f118744eedf38
Signed-off-by: Manuel Buil <mbuil@suse.com>

diff --git a/xci/infra/bifrost/playbooks/opnfv-virtual.yml b/xci/infra/bifrost/playbooks/opnfv-virtual.yml
index abac7ba..8dfd9db 100644 (file)
--- a/xci/infra/bifrost/playbooks/opnfv-virtual.yml
+++ b/xci/infra/bifrost/playbooks/opnfv-virtual.yml
@@ -76,9 +76,7 @@
       testing: false
       enabled_hardware_types: ipmi
       network_interface: "{{ ansible_default_ipv4.interface }}"
-    # NOTE(TheJulia): While the next step creates a ramdisk, some elements
-    # do not support ramdisk-image-create as they invoke steps to cleanup
-    # the ramdisk which causes ramdisk-image-create to believe it failed.
+      # Create the IPA image for ironic to boot the nodes and write the final distro in the hard drive
     - role: bifrost-create-dib-image
       dib_imagename: "{{ http_boot_folder }}/ipa"
       build_ramdisk: false
@@ -88,7 +86,7 @@
       dib_notmpfs: true
       when:
         - create_ipa_image | bool == true
-        - not use_prebuilt_images | bool == false
+      # Create the final distro image
     - role: bifrost-create-dib-image
       dib_imagetype: "qcow2"
       dib_imagename: "{{deploy_image}}"