Mitigating for missing values in storage QPI.

- Update unit tests

Change-Id: I7bfe89dc6bbe1cafe13b2f3e4f9356a06a59c68b
Signed-off-by: Taseer Ahmed <taseer94@gmail.com>

diff --git a/qtip/cli/commands/cmd_qpi.py b/qtip/cli/commands/cmd_qpi.py
index 4865b7a..a280203 100644 (file)
--- a/qtip/cli/commands/cmd_qpi.py
+++ b/qtip/cli/commands/cmd_qpi.py
@@ -44,6 +44,10 @@ def show(name):
     with open('{}/{}.yaml'.format(QPI_PATH, name)) as conf:
         qpi = yaml.safe_load(conf)
     for section in qpi['sections']:
-        table.add_row([section['name'], section['description'],
-                       section['formula']])
+        try:
+            table.add_row([section['name'], section['description'],
+                           section['formula']])
+        except Exception:
+            table.add_row([section['name'], section['description'],
+                           'Not Available'])
     click.echo(table)

diff --git a/tests/unit/cli/cmd_qpi_test.py b/tests/unit/cli/cmd_qpi_test.py
index ba5f814..fa0c859 100644 (file)
--- a/tests/unit/cli/cmd_qpi_test.py
+++ b/tests/unit/cli/cmd_qpi_test.py
@@ -26,8 +26,11 @@ def test_list(runner):
     assert 'QTIP Performance Index of compute' in result.output
 
 
-def test_show(runner):
-    result = runner.invoke(cli, ['qpi', 'show', 'compute'])
+@pytest.mark.parametrize("test_input", [
+    'storage',
+    'compute'])
+def test_show(runner, test_input):
+    result = runner.invoke(cli, ['qpi', 'show', test_input])
     assert 'QPI' in result.output
     assert 'Description' in result.output
     assert 'Formula' in result.output