Fix error status when executing CLI run command 27/58027/2
authorMiikka Koistinen <miikka.koistinen@nokia.com>
Tue, 29 May 2018 11:28:33 +0000 (14:28 +0300)
committerGeorg Kunz <georg.kunz@ericsson.com>
Wed, 6 Jun 2018 10:06:17 +0000 (10:06 +0000)
This commit fixes CLI run command to exit with non-zero exit status
when bad arguments are given for '--testsuite' or '--testarea'.

JIRA: DOVETAIL-660

Change-Id: I4539b19978d9e93d8a90be9000f36d0aa1895f71
Signed-off-by: Miikka Koistinen <miikka.koistinen@nokia.com>
dovetail/cli/commands/cli_testcase.py
dovetail/run.py

index 7529765..d4d8033 100644 (file)
@@ -84,5 +84,5 @@ class CliTestcase(object):
 
         cmd = ("python %s/run.py"
                " %s" % (repo_dir, options))
-        dt_utils.exec_cmd(cmd, exit_on_error=False,
+        dt_utils.exec_cmd(cmd, exit_on_error=True,
                           exec_msg_on=False, info=True)
index 19d0acb..348c391 100755 (executable)
@@ -33,6 +33,9 @@ import utils.dovetail_logger as dt_logger
 import utils.dovetail_utils as dt_utils
 
 
+EXIT_RUN_FAILED = 2
+
+
 def load_testsuite(testsuite):
     Testsuite.load()
     return Testsuite.get(testsuite)
@@ -285,6 +288,9 @@ def main(*args, **kwargs):
     dt_utils.get_hardware_info(logger)
 
     testcase_list = get_testcase_list(logger, **kwargs)
+    if not testcase_list:
+        raise SystemExit(EXIT_RUN_FAILED)
+
     duration = run_test(testcase_list, logger)
     if (duration != "stop_on_fail"):
         Report.generate(testcase_list, duration)