Add more moon-db tests

Change-Id: I9c0f08580528a6411420fe3d5e41ebbc18280cd2
Signed-off-by: ReemMahmoud <rfawzy.ext@orange.com>

diff --git a/python_moondb/tests/unit_python/policies/mock_data.py b/python_moondb/tests/unit_python/policies/mock_data.py
index b264297..23eeef6 100644 (file)
--- a/python_moondb/tests/unit_python/policies/mock_data.py
+++ b/python_moondb/tests/unit_python/policies/mock_data.py
@@ -30,6 +30,16 @@ def create_policy(model_id):
     return value
 
 
+def create_pdp(pdp_ids):
+    value = {
+        "name": "test_pdp",
+        "security_pipeline": pdp_ids,
+        "keystone_project_id": "keystone_project_id1",
+        "description": "...",
+    }
+    return value
+
+
 def get_policy_id():
     import policies.test_policies as test_policies
     import models.test_models as test_models
@@ -39,7 +49,7 @@ def get_policy_id():
     model = test_models.add_model(value=create_model(meta_rule_id))
     model_id = list(model.keys())[0]
     value = create_policy(model_id)
-    policy = test_policies.add_policies(value)
+    policy = test_policies.add_policies(value=value)
     assert policy
     policy_id = list(policy.keys())[0]
     return policy_id

diff --git a/python_moondb/tests/unit_python/policies/test_data.py b/python_moondb/tests/unit_python/policies/test_data.py
index 68b1d2a..875121e 100755 (executable)
--- a/python_moondb/tests/unit_python/policies/test_data.py
+++ b/python_moondb/tests/unit_python/policies/test_data.py
@@ -495,7 +495,7 @@ def test_delete_subject_with_invalid_perimeter_id(db):
 
 def test_get_available_metadata(db):
     policy_id = mock_data.get_policy_id()
-    metadata = get_available_metadata(policy_id)
+    metadata = get_available_metadata(policy_id=policy_id)
     assert metadata
     assert metadata['object'][0] == "object_category_id1"
     assert metadata['subject'][0] == "subject_category_id1"
@@ -504,10 +504,15 @@ def test_get_available_metadata(db):
 
 def test_get_available_metadata_empty_model(db):
     import policies.test_policies as test_policies
-    policy_id = mock_data.get_policy_id()
     value = mock_data.create_policy("invalid")
-    policy = test_policies.add_policies(value)
+    policy = test_policies.add_policies(value=value)
     assert policy
     policy_id = list(policy.keys())[0]
-    metadata = get_available_metadata(policy_id)
-    assert metadata
\ No newline at end of file
+    metadata = get_available_metadata(policy_id=policy_id)
+    assert metadata
+
+
+def test_get_available_metadata_with_invalid_policy_id(db):
+    with pytest.raises(Exception) as exception_info:
+        get_available_metadata(policy_id='invalid')
+    assert '400: Policy Unknown' == str(exception_info.value)

diff --git a/python_moondb/tests/unit_python/policies/test_policies.py b/python_moondb/tests/unit_python/policies/test_policies.py
index acd5d7a..487cb6a 100755 (executable)
--- a/python_moondb/tests/unit_python/policies/test_policies.py
+++ b/python_moondb/tests/unit_python/policies/test_policies.py
@@ -3,13 +3,16 @@
 # license which can be found in the file 'LICENSE' in this package distribution
 # or at 'http://www.apache.org/licenses/LICENSE-2.0'.
 
+import pytest
+import policies.mock_data as mock_data
+
 
 def get_policies():
     from python_moondb.core import PolicyManager
     return PolicyManager.get_policies("admin")
 
 
-def add_policies(value=None):
+def add_policies(policy_id=None, value=None):
     from python_moondb.core import PolicyManager
     if not value:
         value = {
@@ -18,7 +21,7 @@ def add_policies(value=None):
             "genre": "authz",
             "description": "test",
         }
-    return PolicyManager.add_policy("admin", value=value)
+    return PolicyManager.add_policy("admin", policy_id=policy_id, value=value)
 
 
 def delete_policies(uuid=None, name=None):
@@ -31,6 +34,16 @@ def delete_policies(uuid=None, name=None):
     PolicyManager.delete_policy("admin", uuid)
 
 
+def update_policy(policy_id, value):
+    from python_moondb.core import PolicyManager
+    return PolicyManager.update_policy("admin", policy_id, value)
+
+
+def get_policy_from_meta_rules(meta_rule_id):
+    from python_moondb.core import PolicyManager
+    return PolicyManager.get_policy_from_meta_rules("admin", meta_rule_id)
+
+
 def get_rules(policy_id=None, meta_rule_id=None, rule_id=None):
     from python_moondb.core import PolicyManager
     return PolicyManager.get_rules("", policy_id, meta_rule_id, rule_id)
@@ -65,7 +78,7 @@ def test_add_policies(db):
         "genre": "authz",
         "description": "test",
     }
-    policies = add_policies(value)
+    policies = add_policies(value=value)
     assert isinstance(policies, dict)
     assert policies
     assert len(policies.keys()) == 1
@@ -75,6 +88,20 @@ def test_add_policies(db):
         assert policies[policy_id][key] == value[key]
 
 
+def test_add_policies_twice_with_same_id(db):
+    policy_id = 'policy_id_1'
+    value = {
+        "name": "test_policy",
+        "model_id": "",
+        "genre": "authz",
+        "description": "test",
+    }
+    add_policies(policy_id, value)
+    with pytest.raises(Exception) as exception_info:
+        add_policies(policy_id, value)
+    assert str(exception_info.value) == '409: Policy Error'
+
+
 def test_delete_policies(db):
     value = {
         "name": "test_policy1",
@@ -82,7 +109,7 @@ def test_delete_policies(db):
         "genre": "authz",
         "description": "test",
     }
-    policies = add_policies(value)
+    policies = add_policies(value=value)
     policy_id1 = list(policies.keys())[0]
     value = {
         "name": "test_policy2",
@@ -90,7 +117,7 @@ def test_delete_policies(db):
         "genre": "authz",
         "description": "test",
     }
-    policies = add_policies(value)
+    policies = add_policies(value=value)
     policy_id2 = list(policies.keys())[0]
     assert policy_id1 != policy_id2
     delete_policies(policy_id1)
@@ -98,6 +125,106 @@ def test_delete_policies(db):
     assert policy_id1 not in policies
 
 
+def test_delete_policies_with_invalid_id(db):
+    policy_id = 'policy_id_1'
+    with pytest.raises(Exception) as exception_info:
+        delete_policies(policy_id)
+    assert str(exception_info.value) == '400: Policy Unknown'
+
+
+def test_update_policy(db):
+    policies = add_policies()
+    policy_id = list(policies.keys())[0]
+    value = {
+        "name": "test_policy4",
+        "model_id": "",
+        "genre": "authz",
+        "description": "test-3",
+    }
+    updated_policy = update_policy(policy_id, value)
+    assert updated_policy
+    for key in ("genre", "name", "model_id", "description"):
+        assert key in updated_policy[policy_id]
+        assert updated_policy[policy_id][key] == value[key]
+
+
+def test_update_policy_with_invalid_id(db):
+    policy_id = 'invalid-id'
+    value = {
+        "name": "test_policy4",
+        "model_id": "",
+        "genre": "authz",
+        "description": "test-3",
+    }
+    with pytest.raises(Exception) as exception_info:
+        update_policy(policy_id, value)
+    assert str(exception_info.value) == '400: Policy Unknown'
+
+
+def test_get_policy_from_meta_rules(db):
+    import models.test_models as test_models
+    import models.test_meta_rules as test_meta_rules
+    import test_pdp as test_pdp
+    meta_rule = test_meta_rules.add_meta_rule(value=mock_data.create_meta_rule())
+    meta_rule_id = list(meta_rule.keys())[0]
+    model = test_models.add_model(value=mock_data.create_model(meta_rule_id))
+    model_id = list(model.keys())[0]
+    value = mock_data.create_policy(model_id)
+    policy = add_policies(value=value)
+    assert policy
+    policy_id = list(policy.keys())[0]
+    pdp_ids = [policy_id,]
+    pdp_obj = mock_data.create_pdp(pdp_ids)
+    test_pdp.add_pdp(value=pdp_obj)
+    matched_policy_id = get_policy_from_meta_rules(meta_rule_id)
+    assert matched_policy_id
+    assert policy_id == matched_policy_id
+
+
+def test_get_policy_from_meta_rules_with_no_policy_ids(db):
+    import test_pdp as test_pdp
+    meta_rule_id = 'meta_rule_id'
+    value = {
+        "name": "test_pdp",
+        "security_pipeline": [],
+        "keystone_project_id": "keystone_project_id1",
+        "description": "...",
+    }
+    test_pdp.add_pdp(value=value)
+    matched_policy_id = get_policy_from_meta_rules(meta_rule_id)
+    assert not matched_policy_id
+
+
+def test_get_policy_from_meta_rules_with_no_policies(db):
+    import test_pdp as test_pdp
+    meta_rule_id = 'meta_rule_id'
+    policy_id = 'invalid'
+    pdp_ids = [policy_id,]
+    pdp_obj = mock_data.create_pdp(pdp_ids)
+    test_pdp.add_pdp(value=pdp_obj)
+    with pytest.raises(Exception) as exception_info:
+        get_policy_from_meta_rules(meta_rule_id)
+    assert str(exception_info.value) == '400: Policy Unknown'
+
+
+def test_get_policy_from_meta_rules_with_no_models(db):
+    import models.test_meta_rules as test_meta_rules
+    import test_pdp as test_pdp
+    meta_rule = test_meta_rules.add_meta_rule(value=mock_data.create_meta_rule())
+    meta_rule_id = list(meta_rule.keys())[0]
+    model_id = 'invalid'
+    value = mock_data.create_policy(model_id)
+    policy = add_policies(value=value)
+    assert policy
+    policy_id = list(policy.keys())[0]
+    pdp_ids = [policy_id,]
+    pdp_obj = mock_data.create_pdp(pdp_ids)
+    test_pdp.add_pdp(value=pdp_obj)
+    with pytest.raises(Exception) as exception_info:
+        get_policy_from_meta_rules(meta_rule_id)
+    assert str(exception_info.value) == '400: Model Unknown'
+
+
 def test_get_rules(db):
     value = {
         "rule": ("low", "medium", "vm-action"),