Get a logger before printing
authorCédric Ollivier <cedric.ollivier@orange.com>
Mon, 15 May 2017 13:47:33 +0000 (15:47 +0200)
committerCédric Ollivier <cedric.ollivier@orange.com>
Mon, 15 May 2017 13:49:08 +0000 (15:49 +0200)
It also fixes pylint errors.

Change-Id: I0d973360574a517724d0be3986c788c3ce7f54d4
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
functest/core/pytest_suite_runner.py

index 21edc18..2b201ee 100644 (file)
@@ -5,12 +5,18 @@
 #
 # http://www.apache.org/licenses/LICENSE-2.0
 
-import testcase as base
+# pylint: disable=missing-docstring
+
+import logging
 import unittest
 import time
 
+from functest.core import testcase
+
+logging.basicConfig()
+
 
-class PyTestSuiteRunner(base.TestCase):
+class PyTestSuiteRunner(testcase.TestCase):
     """
     This superclass is designed to execute pre-configured unittest.TestSuite()
     objects
@@ -18,7 +24,7 @@ class PyTestSuiteRunner(base.TestCase):
     def __init__(self, **kwargs):
         super(PyTestSuiteRunner, self).__init__(**kwargs)
         self.suite = None
-        self.logger = None
+        self.logger = logging.getLogger(__name__)
 
     def run(self, **kwargs):
         """
@@ -45,13 +51,13 @@ class PyTestSuiteRunner(base.TestCase):
         # we shall distinguish Execution Error from FAIL results
         # TestCase.EX_RUN_ERROR means that the test case was not run
         # not that it was run but the result was FAIL
-        exit_code = base.TestCase.EX_OK
+        exit_code = testcase.TestCase.EX_OK
         if ((result.errors and len(result.errors) > 0)
                 or (result.failures and len(result.failures) > 0)):
-            self.logger.info("%s FAILED" % self.case_name)
+            self.logger.info("%s FAILED", self.case_name)
             self.result = 'FAIL'
         else:
-            self.logger.info("%s OK" % self.case_name)
+            self.logger.info("%s OK", self.case_name)
             self.result = 'PASS'
 
         self.details = {}