Add module skeletons 85/26585/5
authorYujun Zhang <zhang.yujunz@zte.com.cn>
Tue, 27 Dec 2016 08:57:28 +0000 (16:57 +0800)
committerYujun Zhang <zhang.yujunz@zte.com.cn>
Tue, 3 Jan 2017 09:34:11 +0000 (17:34 +0800)
- Remove `suite` and `case` which seems redundant at the moment
- Rename `qtip.spec` to `qtip.loader` since the class loads spec
- Add driver `sample` which will generate random performance data
- Add collector `logfile` which will collect result from log files
- Add reporter `console` which will print report to console
- Add exception classes

See updated class diagram in https://wiki.opnfv.org/display/qtip/Design

JIRA: QTIP-148
JIRA: QTIP-193
Change-Id: Idf751d33428176a26224e4443100a142feda6f32
Signed-off-by: Yujun Zhang <zhang.yujunz@zte.com.cn>
37 files changed:
qtip/base/constant.py [new file with mode: 0644]
qtip/base/error.py [new file with mode: 0644]
qtip/collector/__init__.py [moved from qtip/drivers/__init__.py with 100% similarity]
qtip/collector/base.py [moved from qtip/drivers/base.py with 86% similarity]
qtip/collector/logfile.py [moved from qtip/agent/reporter.py with 78% similarity]
qtip/driver/__init__.py [moved from qtip/spec/__init__.py with 100% similarity]
qtip/driver/ansible.py [moved from qtip/drivers/ansible.py with 100% similarity]
qtip/driver/base.py [new file with mode: 0644]
qtip/driver/sample.py [new file with mode: 0644]
qtip/driver/yardstick.py [moved from qtip/drivers/yardstick.py with 100% similarity]
qtip/loader/__init__.py [new file with mode: 0644]
qtip/loader/base.py [moved from qtip/base/benchmark.py with 54% similarity]
qtip/loader/metric.py [moved from qtip/spec/metric.py with 84% similarity]
qtip/loader/qpi.py [moved from qtip/spec/qpi.py with 89% similarity]
qtip/reporter/__init__.py [new file with mode: 0644]
qtip/reporter/base.py [new file with mode: 0644]
qtip/reporter/console.py [moved from qtip/agent/collector.py with 81% similarity]
qtip/runner/base.py [new file with mode: 0644]
qtip/runner/case.py [deleted file]
qtip/runner/plan.py
qtip/runner/suite.py [deleted file]
tests/conftest.py
tests/data/benchmarks/QPI/fake-qpi.yaml [new file with mode: 0644]
tests/data/benchmarks/metric/dhrystone.yaml [moved from tests/data/benchmarks/metrics/dhrystone.yaml with 100% similarity]
tests/data/benchmarks/metric/dpi.yaml [moved from tests/data/benchmarks/metrics/dpi.yaml with 100% similarity]
tests/data/benchmarks/metric/fake-metric.yaml [new file with mode: 0644]
tests/data/benchmarks/metric/ramspeed.yaml [moved from tests/data/benchmarks/metrics/ramspeed.yaml with 100% similarity]
tests/data/benchmarks/metric/ssl.yaml [moved from tests/data/benchmarks/metrics/ssl.yaml with 100% similarity]
tests/data/benchmarks/metric/whetstone.yaml [moved from tests/data/benchmarks/metrics/whetstone.yaml with 100% similarity]
tests/data/benchmarks/plan/fake-plan.yaml [new file with mode: 0644]
tests/data/benchmarks/plans/verification.yaml [deleted file]
tests/unit/loader/metric_test.py
tests/unit/loader/qpi_test.py
tests/unit/runner/case_test.py [deleted file]
tests/unit/runner/conftest.py [deleted file]
tests/unit/runner/plan_test.py
tests/unit/runner/suite_test.py [deleted file]

diff --git a/qtip/base/constant.py b/qtip/base/constant.py
new file mode 100644 (file)
index 0000000..187f070
--- /dev/null
@@ -0,0 +1,50 @@
+##############################################################################
+# Copyright (c) 2016 ZTE Corp and others.
+#
+# All rights reserved. This program and the accompanying materials
+# are made available under the terms of the Apache License, Version 2.0
+# which accompanies this distribution, and is available at
+# http://www.apache.org/licenses/LICENSE-2.0
+##############################################################################
+
+
+class AlgoName(object):
+    """algorithm names"""
+    ARITHMETIC_MEAN = 'arithmetic mean'
+    WEIGHTED_ARITHMETIC_MEAN = 'weighted arithmetic mean'
+    GEOMETRIC_MEAN = 'geometric mean'
+    WEIGHTED_GEOMETRIC_MEAN = 'weighted geometric mean'
+
+
+class PkgName(object):
+    """QTIP package names"""
+    COLLECTOR = 'collector'
+    DRIVER = 'driver'
+    REPORTER = 'reporter'
+    RUNNER = 'runner'
+    SPEC = 'spec'
+
+
+class PropName(object):
+    """property names"""
+    # list
+    NAME = 'name'
+    CONTENT = 'content'
+    ABSPATH = 'abspath'
+    # content
+    name = 'name'
+    DESCRIPTION = 'description'
+    # spec
+    SECTIONS = 'sections'
+    WEIGHT = 'weight'
+    ALGORITHM = 'algorithm'
+    METRICS = 'metrics'
+    WORKLOADS = 'workloads'
+    # plan
+    CONFIG = 'config'
+    FACILITY = 'facility'
+    ENGINEER = 'engineer'
+    DRIVER = 'driver'
+    COLLECTOR = 'collector'
+    REPORTER = 'reporter'
+    QPIS = 'QPIs'
diff --git a/qtip/base/error.py b/qtip/base/error.py
new file mode 100644 (file)
index 0000000..d364c53
--- /dev/null
@@ -0,0 +1,23 @@
+##############################################################################
+# Copyright (c) 2016 ZTE Corp and others.
+#
+# All rights reserved. This program and the accompanying materials
+# are made available under the terms of the Apache License, Version 2.0
+# which accompanies this distribution, and is available at
+# http://www.apache.org/licenses/LICENSE-2.0
+##############################################################################
+
+
+class QtipError(Exception):
+    pass
+
+
+class InvalidFormat(QtipError):
+    def __init__(self, filename):
+        self.filename = filename
+
+
+class NotFound(QtipError):
+    def __init__(self, module, package='qtip'):
+        self.package = package
+        self.module = module
similarity index 86%
rename from qtip/drivers/base.py
rename to qtip/collector/base.py
index 1aa8d8a..cd8fc79 100644 (file)
@@ -8,5 +8,5 @@
 ##############################################################################
 
 
-class BaseDriver(object):
-    """performance testing tool driver"""
+class BaseCollector(object):
+    """performance metrics collector"""
similarity index 78%
rename from qtip/agent/reporter.py
rename to qtip/collector/logfile.py
index b5c4acf..6528ea9 100644 (file)
@@ -7,7 +7,8 @@
 # http://www.apache.org/licenses/LICENSE-2.0
 ##############################################################################
 
+from base import BaseCollector
 
-class Reporter(object):
-    """generate test report and push test data to database"""
-    pass
+
+class LogfileCollector(BaseCollector):
+    """collect performance metrics from log files"""
diff --git a/qtip/driver/base.py b/qtip/driver/base.py
new file mode 100644 (file)
index 0000000..6f5cab3
--- /dev/null
@@ -0,0 +1,20 @@
+##############################################################################
+# Copyright (c) 2016 ZTE Corp and others.
+#
+# All rights reserved. This program and the accompanying materials
+# are made available under the terms of the Apache License, Version 2.0
+# which accompanies this distribution, and is available at
+# http://www.apache.org/licenses/LICENSE-2.0
+##############################################################################
+
+
+class BaseDriver(object):
+    """performance testing tool driver"""
+    def pre_run(self):
+        pass
+
+    def run(self):
+        pass
+
+    def post_run(self):
+        pass
diff --git a/qtip/driver/sample.py b/qtip/driver/sample.py
new file mode 100644 (file)
index 0000000..9b34794
--- /dev/null
@@ -0,0 +1,15 @@
+##############################################################################
+# Copyright (c) 2016 ZTE Corp and others.
+#
+# All rights reserved. This program and the accompanying materials
+# are made available under the terms of the Apache License, Version 2.0
+# which accompanies this distribution, and is available at
+# http://www.apache.org/licenses/LICENSE-2.0
+##############################################################################
+
+
+from base import BaseDriver
+
+
+class SampleDriver(BaseDriver):
+    """sample driver that generates random data for testing"""
diff --git a/qtip/loader/__init__.py b/qtip/loader/__init__.py
new file mode 100644 (file)
index 0000000..e69de29
similarity index 54%
rename from qtip/base/benchmark.py
rename to qtip/loader/base.py
index b38e601..f7fcb66 100644 (file)
@@ -12,52 +12,14 @@ from os import listdir
 from os import path
 import yaml
 
-
-class Property(object):
-    # list
-    NAME = 'name'
-    CONTENT = 'content'
-    ABSPATH = 'abspath'
-    # content
-    TITLE = 'title'
-    DESCRIPTION = 'description'
-    # spec
-    ALGORITHM = 'algorithm'
-    SECTIONS = 'sections'
-    WEIGHT = 'weight'
-    METRICS = 'metrics'
-    SPEC = 'spec'
-    WORKLOADS = 'workloads'
-    # plan
-    INFO = 'info'
-    FACILITY = 'facility'
-    ENGINEER = 'engineer'
-    SUITES = 'suites'
-    # suite
-    QPI_SPEC = 'QPI_spec'
-    CONDITION = 'condition'
-    CASES = 'cases'
-    # case
-    METRIC_SPEC = 'metric_spec'
-    CONFIG = 'config'
-
-
-class QtipError(Exception):
-    pass
-
-
-class Algorithm(object):
-    ARITHMETIC_MEAN = 'arithmetic mean'
-    WEIGHTED_ARITHMETIC_MEAN = 'weighted arithmetic mean'
-    GEOMETRIC_MEAN = 'geometric mean'
-    WEIGHTED_GEOMETRIC_MEAN = 'weighted geometric mean'
-
+from qtip.base.error import InvalidFormat, NotFound
+from qtip.base.constant import PropName
 
 ROOT_DIR = 'benchmarks'
 
 
-class Benchmark(object):
-    """Abstract class of QTIP benchmarks"""
+class BaseLoader(object):
+    """Abstract class of QTIP benchmark loader"""
     DEFAULT_DIR = '.'
     _paths = [path.join(path.dirname(__file__), path.pardir, path.pardir,
                         ROOT_DIR)]
@@ -65,7 +27,16 @@ class Benchmark(object):
     def __init__(self, name, paths=None):
         self._file = name
         self._abspath = self._find(name, paths)
-        self.name = path.splitext(name)[0]
+
+        try:
+            content = yaml.safe_load(file(self._abspath))
+        except yaml.YAMLError:
+            # TODO(yujunz) log yaml error
+            raise InvalidFormat(self._abspath)
+
+        self.name = content[PropName.NAME] if PropName.NAME in content \
+            else path.splitext(name)[0]
+        self.content = content
 
     def _find(self, name, paths):
         """find a benchmark in searching paths"""
@@ -75,7 +46,7 @@ class Benchmark(object):
             abspath = path.join(p, name)
             if path.exists(abspath):
                 return abspath
-        raise QtipError("'{}' not found in paths: {}".format(name, paths))
+        raise NotFound(name, paths)
 
     @classmethod
     def list_all(cls, paths=None):
@@ -86,10 +57,6 @@ class Benchmark(object):
         for name in names:
             item = cls(name, paths=paths)
             yield {
-                Property.NAME: name,
-                Property.ABSPATH: item._abspath,
-                Property.CONTENT: item.content()}
-
-    def content(self):
-        """description of benchmark"""
-        return yaml.safe_load(file(self._abspath))
+                PropName.NAME: name,
+                PropName.ABSPATH: item._abspath,
+                PropName.CONTENT: item.content}
similarity index 84%
rename from qtip/spec/metric.py
rename to qtip/loader/metric.py
index e9c7054..d6174e8 100644 (file)
@@ -7,10 +7,10 @@
 # http://www.apache.org/licenses/LICENSE-2.0
 ##############################################################################
 
-from qtip.base.benchmark import Benchmark
+from base import BaseLoader
 
 
-class MetricSpec(Benchmark):
+class MetricSpec(BaseLoader):
     """metrics in QTIP are categorized by performance test tools, such as
     dhrystone, whetstone and etc"""
-    DEFAULT_DIR = 'metrics'
+    DEFAULT_DIR = 'metric'
similarity index 89%
rename from qtip/spec/qpi.py
rename to qtip/loader/qpi.py
index b7d7aa0..2972cbd 100644 (file)
@@ -7,10 +7,10 @@
 # http://www.apache.org/licenses/LICENSE-2.0
 ##############################################################################
 
-from qtip.base.benchmark import Benchmark
+from base import BaseLoader
 
 
-class QPISpec(Benchmark):
+class QPISpec(BaseLoader):
     """
     a QPI specification defines how to calculate a performance index from
      collected metrics.
diff --git a/qtip/reporter/__init__.py b/qtip/reporter/__init__.py
new file mode 100644 (file)
index 0000000..e69de29
diff --git a/qtip/reporter/base.py b/qtip/reporter/base.py
new file mode 100644 (file)
index 0000000..b931d14
--- /dev/null
@@ -0,0 +1,14 @@
+##############################################################################
+# Copyright (c) 2016 ZTE Corp and others.
+#
+# All rights reserved. This program and the accompanying materials
+# are made available under the terms of the Apache License, Version 2.0
+# which accompanies this distribution, and is available at
+# http://www.apache.org/licenses/LICENSE-2.0
+##############################################################################
+
+
+class BaseReporter(object):
+    """benchmark result reporter"""
+    def __init__(self, collector=None):
+        self.collector = collector
similarity index 81%
rename from qtip/agent/collector.py
rename to qtip/reporter/console.py
index 3df2137..136ce35 100644 (file)
@@ -7,7 +7,8 @@
 # http://www.apache.org/licenses/LICENSE-2.0
 ##############################################################################
 
+from base import BaseReporter
 
-class Collector(object):
-    """collect test result and test condition"""
-    pass
+
+class ConsoleReporter(BaseReporter):
+    """report result to console"""
diff --git a/qtip/runner/base.py b/qtip/runner/base.py
new file mode 100644 (file)
index 0000000..07fba10
--- /dev/null
@@ -0,0 +1,45 @@
+##############################################################################
+# Copyright (c) 2016 ZTE Corp and others.
+#
+# All rights reserved. This program and the accompanying materials
+# are made available under the terms of the Apache License, Version 2.0
+# which accompanies this distribution, and is available at
+# http://www.apache.org/licenses/LICENSE-2.0
+##############################################################################
+
+from qtip.base.constant import PkgName, PropName
+from qtip.base.error import NotFound
+from qtip.collector.logfile import LogfileCollector
+from qtip.driver.sample import SampleDriver
+from qtip.loader.base import BaseLoader
+from qtip.reporter.console import ConsoleReporter
+
+
+class BaseRunner(BaseLoader):
+    def __init__(self, name, paths=None, config=None):
+        super(BaseRunner, self).__init__(name, paths=paths)
+        if config is None:
+            config = self.content[PropName.CONFIG]
+
+        driver_name = config[PropName.DRIVER]
+        collector_name = config[PropName.COLLECTOR]
+        reporter_name = config[PropName.REPORTER]
+
+        # TODO(yujunz) dynamically load modules by name
+
+        if driver_name == 'sample':
+            self.driver = SampleDriver()
+        else:
+            raise NotFound(driver_name, package=PkgName.DRIVER)
+
+        if collector_name == 'logfile':
+            self.collector = LogfileCollector()
+        else:
+            raise NotFound(collector_name,
+                           package=PkgName.COLLECTOR)
+
+        if reporter_name == 'console':
+            self.reporter = ConsoleReporter()
+        else:
+            raise NotFound(reporter_name,
+                           package=PkgName.REPORTER)
diff --git a/qtip/runner/case.py b/qtip/runner/case.py
deleted file mode 100644 (file)
index eb3febc..0000000
+++ /dev/null
@@ -1,17 +0,0 @@
-##############################################################################
-# Copyright (c) 2016 ZTE Corp and others.
-#
-# All rights reserved. This program and the accompanying materials
-# are made available under the terms of the Apache License, Version 2.0
-# which accompanies this distribution, and is available at
-# http://www.apache.org/licenses/LICENSE-2.0
-##############################################################################
-
-from qtip.base.benchmark import Property
-from qtip.spec.metric import MetricSpec
-
-
-class Case(object):
-    def __init__(self, spec, paths=None):
-        self.metric_spec = MetricSpec(spec[Property.METRIC_SPEC], paths=paths)
-        self.config = spec[Property.CONFIG]
index 265ad8d..f6c1c3b 100644 (file)
@@ -7,20 +7,19 @@
 # http://www.apache.org/licenses/LICENSE-2.0
 ##############################################################################
 
-from qtip.base.benchmark import Benchmark, Property
-from qtip.runner.suite import Suite
+from qtip.base.constant import PropName
+from qtip.runner.base import BaseRunner
+from qtip.loader.qpi import QPISpec
 
 
-class Plan(Benchmark):
+class Plan(BaseRunner):
+    """
+    a benchmark plan is consist of configuration and a QPI list
     """
-    a benchmark plan is consist of basic information and  several suites"""
 
-    DEFAULT_DIR = 'plans'
+    DEFAULT_DIR = 'plan'
 
     def __init__(self, name, paths=None):
-        super(Plan, self).__init__(name, paths=paths)
-        content = self.content()
-
-        self.info = content[Property.INFO]
-        self.suites = [Suite(suite, paths=paths)
-                       for suite in content[Property.SUITES]]
+        super(Plan, self).__init__(name, paths)
+        self.qpis = [QPISpec(qpi, paths=paths)
+                     for qpi in self.content[PropName.QPIS]]
diff --git a/qtip/runner/suite.py b/qtip/runner/suite.py
deleted file mode 100644 (file)
index 55033d2..0000000
+++ /dev/null
@@ -1,22 +0,0 @@
-##############################################################################
-# Copyright (c) 2016 ZTE Corp and others.
-#
-# All rights reserved. This program and the accompanying materials
-# are made available under the terms of the Apache License, Version 2.0
-# which accompanies this distribution, and is available at
-# http://www.apache.org/licenses/LICENSE-2.0
-##############################################################################
-
-from qtip.base.benchmark import Property
-from qtip.spec.qpi import QPISpec
-from qtip.runner.case import Case
-
-
-class Suite(object):
-    """a suite of benchmark cases under specified condition"""
-    def __init__(self, spec, paths=None):
-        self._paths = paths
-        self.qpi_spec = QPISpec(spec[Property.QPI_SPEC], paths=paths)
-        self.condition = spec.get(Property.CONDITION, {})
-        self.cases = [Case(case_spec, paths)
-                      for case_spec in spec.get(Property.CASES, [])]
index 8e2ecf7..f1ec91f 100644 (file)
@@ -10,6 +10,8 @@
 from os import path
 import pytest
 
+from qtip.runner.plan import Plan
+
 
 @pytest.fixture(scope='session')
 def data_root():
@@ -19,3 +21,8 @@ def data_root():
 @pytest.fixture(scope='session')
 def benchmarks_root(data_root):
     return path.join(data_root, 'benchmarks')
+
+
+@pytest.fixture(scope='session')
+def plan(benchmarks_root):
+    return Plan('fake-plan.yaml', [benchmarks_root])
diff --git a/tests/data/benchmarks/QPI/fake-qpi.yaml b/tests/data/benchmarks/QPI/fake-qpi.yaml
new file mode 100644 (file)
index 0000000..d75c656
--- /dev/null
@@ -0,0 +1,9 @@
+name: Fake QPI
+description: a fake QPI producing random result
+algorithm: weighted arithmetic mean
+sections:
+- name: Fake Section
+  weight: 0.5
+  algorithm: geometric mean
+  metrics:
+    - fake_metric.yaml
diff --git a/tests/data/benchmarks/metric/fake-metric.yaml b/tests/data/benchmarks/metric/fake-metric.yaml
new file mode 100644 (file)
index 0000000..c5fcc5c
--- /dev/null
@@ -0,0 +1,7 @@
+name: fake compute
+description: >
+  a fake compute performance index which generate random result
+workloads:  # all supported workloads
+  - fake_workload_1
+  - fake_workload_2
+  - fake_workload_3
diff --git a/tests/data/benchmarks/plan/fake-plan.yaml b/tests/data/benchmarks/plan/fake-plan.yaml
new file mode 100644 (file)
index 0000000..8887f66
--- /dev/null
@@ -0,0 +1,10 @@
+name: fake plan
+description: fake benchmark plan for demonstration and testing
+config:
+  facility: local
+  engineer: local
+  driver: sample
+  collector: logfile
+  reporter: console
+QPIs:
+  - fake-qpi.yaml
diff --git a/tests/data/benchmarks/plans/verification.yaml b/tests/data/benchmarks/plans/verification.yaml
deleted file mode 100644 (file)
index b146ee3..0000000
+++ /dev/null
@@ -1,21 +0,0 @@
-title: verification
-description: benchmark plan for QTIP verification
-info:
-  facility: opnfv-ci
-  engineer: opnfv-bot
-suites:
-  - QPI_spec: compute.yaml
-# Uncomment next line to setup suite running condition
-#    condition: {}
-# Uncomment the following lines setup case running configuration
-#    cases:
-#      - metric_spec: dhrystone.yaml
-#        config: {}
-#      - metric_spec: whetstone.yaml
-#        config: {}
-#      - metric_spec: ramspeed.yaml
-#        config: {}
-#      - metric_spec: dpi.yaml
-#        config: {}
-#      - metric_spec: ssl.yaml
-#        config: {}
index 5eced70..d2be038 100644 (file)
@@ -9,8 +9,8 @@
 
 import pytest
 
-from qtip.base.benchmark import Property
-from qtip.spec.metric import MetricSpec
+from qtip.base.constant import PropName
+from qtip.loader.metric import MetricSpec
 
 
 @pytest.fixture(scope='module')
@@ -29,17 +29,17 @@ def init_test(metric_spec):
 
 def list_all_test():
     metric_list = MetricSpec.list_all()
-    assert len(list(metric_list)) is 1
+    assert len(list(metric_list)) is 6
     for desc in metric_list:
-        assert Property.NAME in desc
-        assert Property.DESCRIPTION in desc
-        assert Property.ABSPATH in desc
-        assert Property.ABSPATH is not None
+        assert PropName.NAME in desc
+        assert PropName.DESCRIPTION in desc
+        assert PropName.ABSPATH in desc
+        assert PropName.ABSPATH is not None
 
 
 def content_test(metric):
-    content = metric.content()
-    assert Property.NAME in content
-    assert Property.DESCRIPTION in content
-    assert Property.WORKLOADS in content
-    assert isinstance(content[Property.WORKLOADS], list)
+    content = metric.content
+    assert PropName.NAME in content
+    assert PropName.DESCRIPTION in content
+    assert PropName.WORKLOADS in content
+    assert isinstance(content[PropName.WORKLOADS], list)
index bfa1f58..c0d4b37 100644 (file)
@@ -9,8 +9,8 @@
 
 import pytest
 
-from qtip.base.benchmark import Algorithm, Property
-from qtip.spec.qpi import QPISpec
+from qtip.base.constant import AlgoName, PropName
+from qtip.loader.qpi import QPISpec
 
 QPI_SPEC = 'compute.yaml'
 
@@ -31,22 +31,22 @@ def test_init(qpi_spec):
 
 def test_list_all(benchmarks_root):
     qpi_spec_list = QPISpec.list_all(paths=[benchmarks_root])
-    assert len(list(qpi_spec_list)) is 1
+    assert len(list(qpi_spec_list)) is 2
     for item in qpi_spec_list:
-        assert Property.NAME in item
-        assert Property.CONTENT in item
-        assert Property.ABSPATH in item
-        assert Property.ABSPATH is not None
+        assert PropName.NAME in item
+        assert PropName.CONTENT in item
+        assert PropName.ABSPATH in item
+        assert PropName.ABSPATH is not None
 
 
 def test_content(qpi_spec):
-    content = qpi_spec.content()
-    assert Property.DESCRIPTION in content
-    assert Property.ALGORITHM in content
-    assert Property.SECTIONS in content
+    content = qpi_spec.content
+    assert PropName.DESCRIPTION in content
+    assert PropName.ALGORITHM in content
+    assert PropName.SECTIONS in content
 
-    assert content[Property.ALGORITHM] in Algorithm.__dict__.values()
-    sections = content[Property.SECTIONS]
+    assert content[PropName.ALGORITHM] in AlgoName.__dict__.values()
+    sections = content[PropName.SECTIONS]
     assert isinstance(sections, list)
     for section in sections:
-        assert Property.NAME in section
+        assert PropName.NAME in section
diff --git a/tests/unit/runner/case_test.py b/tests/unit/runner/case_test.py
deleted file mode 100644 (file)
index 59a54a8..0000000
+++ /dev/null
@@ -1,15 +0,0 @@
-###############################################################
-# Copyright (c) 2016 ZTE Corp and others.
-#
-# All rights reserved. This program and the accompanying materials
-# are made available under the terms of the Apache License, Version 2.0
-# which accompanies this distribution, and is available at
-# http://www.apache.org/licenses/LICENSE-2.0
-##############################################################################
-
-from qtip.spec.metric import MetricSpec
-
-
-def init_test(case):
-    assert isinstance(case.metric_spec, MetricSpec)
-    assert isinstance(case.config, dict)
diff --git a/tests/unit/runner/conftest.py b/tests/unit/runner/conftest.py
deleted file mode 100644 (file)
index 6d14f7a..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-##############################################################################
-# Copyright (c) 2016 ZTE Corp and others.
-#
-# All rights reserved. This program and the accompanying materials
-# are made available under the terms of the Apache License, Version 2.0
-# which accompanies this distribution, and is available at
-# http://www.apache.org/licenses/LICENSE-2.0
-##############################################################################
-
-import pytest
-
-from qtip.base.benchmark import Property
-from qtip.runner.case import Case
-from qtip.runner.plan import Plan
-from qtip.runner.suite import Suite
-
-
-@pytest.fixture(scope='module')
-def plan(benchmarks_root):
-    return Plan('verification.yaml', paths=[benchmarks_root])
-
-
-@pytest.fixture(scope='module')
-def suite(plan):
-    return Suite(plan[Property.SUITES][0])
-
-
-@pytest.fixture(scope='module')
-def case(suite):
-    return Case(suite[Property.CASES][0])
index d783e5e..7b3611d 100644 (file)
@@ -9,12 +9,12 @@
 
 import pytest
 
-from qtip.base.benchmark import Property
+from qtip.base.constant import PropName
 from qtip.runner.plan import Plan
 
 
 def test_init(plan):
-    assert plan.name == 'verification'
+    assert plan.name == 'fake plan'
 
     with pytest.raises(TypeError) as excinfo:
         Plan()
@@ -26,13 +26,13 @@ def test_list_all(benchmarks_root):
     plan_list = Plan.list_all(paths=[benchmarks_root])
     assert len(list(plan_list)) is 1
     for desc in plan_list:
-        assert Property.NAME in desc
-        assert Property.CONTENT in desc
-        assert Property.ABSPATH in desc
-        assert Property.ABSPATH is not None
+        assert PropName.NAME in desc
+        assert PropName.CONTENT in desc
+        assert PropName.ABSPATH in desc
+        assert PropName.ABSPATH is not None
 
 
 def test_content(plan):
-    content = plan.content()
-    assert Property.TITLE in content
-    assert Property.DESCRIPTION in content
+    content = plan.content
+    assert PropName.NAME in content
+    assert PropName.DESCRIPTION in content
diff --git a/tests/unit/runner/suite_test.py b/tests/unit/runner/suite_test.py
deleted file mode 100644 (file)
index 7dad8f6..0000000
+++ /dev/null
@@ -1,27 +0,0 @@
-##############################################################################
-# Copyright (c) 2016 ZTE Corp and others.
-#
-# All rights reserved. This program and the accompanying materials
-# are made available under the terms of the Apache License, Version 2.0
-# which accompanies this distribution, and is available at
-# http://www.apache.org/licenses/LICENSE-2.0
-##############################################################################
-
-import pytest
-
-from qtip.runner.suite import Suite
-from qtip.runner.case import Case
-from qtip.spec.qpi import QPISpec
-
-
-def init_test(suite):
-    assert isinstance(suite.qpi, QPISpec)
-    assert isinstance(suite.condition, dict)
-    assert isinstance(suite.cases, list)
-    for case in suite.cases:
-        assert isinstance(case, Case)
-
-    with pytest.raises(TypeError) as excinfo:
-        Suite()
-    assert '__init__() takes exactly 2 arguments (1 given)' \
-           in str(excinfo.value)