Kubernetes API "delete_service" missing parameter 73/57073/6
authorRodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
Fri, 4 May 2018 16:46:03 +0000 (17:46 +0100)
committerRodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
Wed, 9 May 2018 16:55:29 +0000 (16:55 +0000)
Kubernetes method "delete_service" calls core API function
"delete_namespaced_service". The parameter "body" [1] is missing:

    :param V1DeleteOptions body: (required)

[1] https://github.com/kubernetes-client/python/blob/6.0.0/kubernetes/client/apis/core_v1_api.py

JIRA: YARDSTICK-1154

Change-Id: I40bca2af0f5359eaa788d3b81d82897a770329f0
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
yardstick/common/kubernetes_utils.py

index 0cf7b9e..d60c9b2 100644 (file)
@@ -41,6 +41,7 @@ def create_service(template,
                    namespace='default',
                    wait=False,
                    **kwargs):       # pragma: no cover
+    # pylint: disable=unused-argument
     core_v1_api = get_core_api()
     metadata = client.V1ObjectMeta(**template.get('metadata', {}))
 
@@ -63,7 +64,8 @@ def delete_service(name,
                    **kwargs):       # pragma: no cover
     core_v1_api = get_core_api()
     try:
-        core_v1_api.delete_namespaced_service(name, namespace, **kwargs)
+        body = client.V1DeleteOptions()
+        core_v1_api.delete_namespaced_service(name, namespace, body, **kwargs)
     except ApiException:
         LOG.exception('Delete Service failed')
 
@@ -86,7 +88,7 @@ def create_replication_controller(template,
                                   namespace='default',
                                   wait=False,
                                   **kwargs):    # pragma: no cover
-
+    # pylint: disable=unused-argument
     core_v1_api = get_core_api()
     try:
         core_v1_api.create_namespaced_replication_controller(namespace,
@@ -101,7 +103,7 @@ def delete_replication_controller(name,
                                   namespace='default',
                                   wait=False,
                                   **kwargs):    # pragma: no cover
-
+    # pylint: disable=unused-argument
     core_v1_api = get_core_api()
     body = kwargs.get('body', client.V1DeleteOptions())
     kwargs.pop('body', None)
@@ -119,7 +121,7 @@ def delete_pod(name,
                namespace='default',
                wait=False,
                **kwargs):    # pragma: no cover
-
+    # pylint: disable=unused-argument
     core_v1_api = get_core_api()
     body = kwargs.get('body', client.V1DeleteOptions())
     kwargs.pop('body', None)
@@ -147,6 +149,7 @@ def read_pod(name,
 
 
 def read_pod_status(name, namespace='default', **kwargs):   # pragma: no cover
+    # pylint: disable=unused-argument
     return read_pod(name).status.phase
 
 
@@ -155,6 +158,7 @@ def create_config_map(name,
                       namespace='default',
                       wait=False,
                       **kwargs):   # pragma: no cover
+    # pylint: disable=unused-argument
     core_v1_api = get_core_api()
     metadata = client.V1ObjectMeta(name=name)
     body = client.V1ConfigMap(data=data, metadata=metadata)
@@ -169,6 +173,7 @@ def delete_config_map(name,
                       namespace='default',
                       wait=False,
                       **kwargs):     # pragma: no cover
+    # pylint: disable=unused-argument
     core_v1_api = get_core_api()
     body = kwargs.get('body', client.V1DeleteOptions())
     kwargs.pop('body', None)