kubespray: Do not grep log text to determine failure 51/53751/2
authorFatih Degirmenci <fdegir@gmail.com>
Wed, 14 Mar 2018 07:36:56 +0000 (08:36 +0100)
committerFatih Degirmenci <fdegir@gmail.com>
Wed, 14 Mar 2018 07:39:03 +0000 (07:39 +0000)
Pipefail should be sufficient to determine the failure so this
change gets rid of grepping the logs for failure and unreachable
to leave the evaluation to bash itself.

Change-Id: I0fcd6016ddc19eb11b3eb2402347032a11c5a32a
Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
xci/installer/kubespray/deploy.sh

index 548ed77..b68fec9 100755 (executable)
@@ -7,11 +7,13 @@
 # which accompanies this distribution, and is available at
 # http://www.apache.org/licenses/LICENSE-2.0
 ##############################################################################
+set -o errexit
+set -o nounset
+set -o pipefail
 
 K8_XCI_PLAYBOOKS="$(dirname $(realpath ${BASH_SOURCE[0]}))/playbooks"
 export ANSIBLE_ROLES_PATH=$HOME/.ansible/roles:/etc/ansible/roles:${XCI_PATH}/xci/playbooks/roles
 
-
 #-------------------------------------------------------------------------------
 # Configure localhost
 #-------------------------------------------------------------------------------
@@ -72,14 +74,9 @@ fi
 
 echo "Info: Using kubespray to deploy the kubernetes cluster"
 echo "-----------------------------------------------------------------------"
-ssh root@$OPNFV_HOST_IP "cd releng-xci/.cache/repos/kubespray;\
+ssh root@$OPNFV_HOST_IP "set -o pipefail; cd releng-xci/.cache/repos/kubespray;\
          ansible-playbook ${XCI_ANSIBLE_PARAMS} \
          -i opnfv_inventory/inventory.cfg cluster.yml -b | tee setup-kubernetes.log"
 scp root@$OPNFV_HOST_IP:~/releng-xci/.cache/repos/kubespray/setup-kubernetes.log \
          $LOG_PATH/setup-kubernetes.log
-# check the log to see if we have any error
-if grep -q 'failed=1\|unreachable=1' $LOG_PATH/setup-kubernetes.log; then
-    echo "Error: Kubernetes cluster setup failed!"
-    exit 1
-fi
 echo "Info: Kubernetes installation is successfully completed!"