Fix strncpy issue introduced by fb0c44a8

Change-Id: I833d753bd5c426d50c0c9fdee5668f3b9fff13b9
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>

diff --git a/VNFs/DPPD-PROX/cmd_parser.c b/VNFs/DPPD-PROX/cmd_parser.c
index d4bfed0..dea955f 100644 (file)
--- a/VNFs/DPPD-PROX/cmd_parser.c
+++ b/VNFs/DPPD-PROX/cmd_parser.c
@@ -2272,7 +2272,10 @@ static int parse_cmd_help(const char *str, struct input *input)
                                                len3 = max_len;
                                }
 
-                               prox_strncpy(tmp, h, len3);
+                               // Use strncpy here and not prox_strncpy. The dest (tmp) has been initialized with 0.
+                               // The fact that we are copying 80 characters potentially not null terminated is hence not an issue.
+                               // Using prox_strncpy here might cause a PROX_PANIC
+                               strncpy(tmp, h, len3);
                                h += len3;
                                while (h[0] == ' ' && strlen(h))
                                        h++;