Unify security group operations
authorCédric Ollivier <cedric.ollivier@orange.com>
Mon, 19 Feb 2018 22:07:44 +0000 (23:07 +0100)
committerCédric Ollivier <cedric.ollivier@orange.com>
Wed, 21 Feb 2018 15:05:12 +0000 (16:05 +0100)
It updates juju_epc to conform with cloudify_ims and
cloudify_vrouter regarding security group operations.

Change-Id: I2bc4a16ec17f2836564df82d3ceddd3bc73ece7a
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
functest/opnfv_tests/vnf/epc/juju_epc.py

index 7d7194c..6897918 100644 (file)
@@ -186,17 +186,17 @@ class JujuEpc(vnf.VnfOnBoarding):
     def _add_custom_rule(self, sec_grp_name):
         """ To add custom rule for SCTP Traffic """
         sec_grp_rules = list()
-        security_group_init = OpenStackSecurityGroup(
+        sec_grp_rules.append(
+            SecurityGroupRuleConfig(
+                sec_grp_name=sec_grp_name, direction=Direction.ingress,
+                protocol=Protocol.sctp))
+        security_group = OpenStackSecurityGroup(
             self.snaps_creds,
             SecurityGroupConfig(
                 name=sec_grp_name,
                 rule_settings=sec_grp_rules))
-        security_group_init.initialize()
-        sctp_rule = SecurityGroupRuleConfig(
-            sec_grp_name=sec_grp_name, direction=Direction.ingress,
-            protocol=Protocol.sctp)
-        security_group_init.add_rule(sctp_rule)
-        self.created_object.append(security_group_init)
+        security_group.create()
+        self.created_object.append(security_group)
 
     def prepare(self):
         """Prepare testcase (Additional pre-configuration steps)."""