Print stderr in logs when calling cmd over ssh 29/60429/2
authorCédric Ollivier <cedric.ollivier@orange.com>
Tue, 31 Jul 2018 10:25:40 +0000 (12:25 +0200)
committerCédric Ollivier <cedric.ollivier@orange.com>
Tue, 31 Jul 2018 11:10:56 +0000 (13:10 +0200)
Change-Id: I152ac898661a0e99a6232df86689c70c468ceaa5
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
functest/core/singlevm.py
functest/opnfv_tests/openstack/vping/vping_ssh.py
functest/tests/unit/openstack/vping/test_vping_ssh.py

index 2a8ae87..46aa419 100644 (file)
@@ -381,8 +381,9 @@ class SingleVm1(VmReady1):
 
         Returns: echo exit codes
         """
-        (_, stdout, _) = self.ssh.exec_command('echo Hello World')
+        (_, stdout, stderr) = self.ssh.exec_command('echo Hello World')
         self.__logger.debug("output:\n%s", stdout.read())
+        self.__logger.debug("error:\n%s", stderr.read())
         return stdout.channel.recv_exit_status()
 
     def run(self, **kwargs):
index 643f4f6..a8a6fd9 100644 (file)
@@ -44,9 +44,10 @@ class VPingSSH(singlevm.SingleVm2):
         Returns: ping exit codes
         """
         assert self.ssh
-        (_, stdout, _) = self.ssh.exec_command(
+        (_, stdout, stderr) = self.ssh.exec_command(
             'ping -c 1 ' + self.vm2.private_v4)
-        self.__logger.debug("output:\n%s", stdout.read())
+        self.__logger.info("output:\n%s", stdout.read())
+        self.__logger.info("error:\n%s", stderr.read())
         return stdout.channel.recv_exit_status()
 
     def clean(self):
index 3595638..05482ed 100644 (file)
@@ -75,7 +75,7 @@ class VpingSSHTesting(unittest.TestCase):
         self.vping.ssh = mock.Mock()
         stdout = mock.Mock()
         stdout.channel.recv_exit_status.return_value = ret
-        self.vping.ssh.exec_command.return_value = (None, stdout, None)
+        self.vping.ssh.exec_command.return_value = (None, stdout, mock.Mock())
         self.assertEqual(self.vping.execute(), ret)
         self.vping.ssh.exec_command.assert_called_once_with(
             'ping -c 1 {}'.format(self.vping.vm2.private_v4))