Code Review / apex-tripleo-heat-templates.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | patch | inline | side by side (parent: 3fe6c1a)
Fix check of rpm-python.
authorSofer Athlan-Guyot <chem@sathlan.org>
Thu, 18 Aug 2016 08:55:34 +0000 (10:55 +0200)
committerAthlan-Guyot sofer <sathlang@redhat.com>
Fri, 26 Aug 2016 17:56:20 +0000 (17:56 +0000)
There is a typo in the code, making this test always successful.

Closes-Bug: 1614437
Change-Id: Ia6b0b156294de9fcb8f66fc46aa8801555775a56

extraconfig/tasks/major_upgrade_controller_pacemaker_1.sh patch | blob | history

diff --git a/extraconfig/tasks/major_upgrade_controller_pacemaker_1.sh b/extraconfig/tasks/major_upgrade_controller_pacemaker_1.sh
index d67d5a1..26a3c8f 100755 (executable)
--- a/extraconfig/tasks/major_upgrade_controller_pacemaker_1.sh
+++ b/extraconfig/tasks/major_upgrade_controller_pacemaker_1.sh
@@ -18,7 +18,7 @@ STONITH_STATE=$(pcs property show stonith-enabled | grep "stonith-enabled" | awk
 pcs property set stonith-enabled=false
 
 # If for some reason rpm-python are missing we want to error out early enough
-if [ ! rpm -q rpm-python &> /dev/null ]; then
+if ! rpm -q rpm-python &> /dev/null; then
     echo_error "ERROR: upgrade cannot start without rpm-python installed"
     exit 1
 fi