Fix dump packets command 57/69957/2
authorXavier Simonart <xavier.simonart@intel.com>
Thu, 16 Apr 2020 14:09:14 +0000 (16:09 +0200)
committerXavier Simonart <xavier.simonart@intel.com>
Fri, 24 Apr 2020 14:40:32 +0000 (14:40 +0000)
dump packets (e.g. dump 1 0 1) was in some cases dumping more
packets than expected.
Proper count of packets is now dumped.

Change-Id: I0974465d617eda00e77ee87148bf96991ecd3ed7
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
VNFs/DPPD-PROX/lconf.c
VNFs/DPPD-PROX/tx_pkt.c

index 23ae58e..63e4763 100644 (file)
@@ -264,9 +264,8 @@ int lconf_do_flags(struct lcore_cfg *lconf)
                t = lconf->tasks_all[lconf->msg.task_id];
 
                if (lconf->msg.val) {
-                       t->aux->task_rt_dump.n_trace = lconf->msg.val;
-
                        if (task_base_get_original_rx_pkt_function(t) != rx_pkt_dummy) {
+                               t->aux->task_rt_dump.n_trace = lconf->msg.val;
                                task_base_add_rx_pkt_function(t, rx_pkt_trace);
                                if (t->tx_pkt == tx_pkt_l3) {
                                        if (t->aux->tx_pkt_orig)
index d494236..e789d30 100644 (file)
@@ -778,7 +778,7 @@ static inline void dump_pkts(struct task_base *tbase, struct rte_mbuf **mbufs, u
                for (uint32_t i = 0; i < n_trace; ++i) {
                        plogdx_info(mbufs[i], "TX: ");
                }
-               tbase->aux->task_rt_dump.n_trace - n_trace;
+               tbase->aux->task_rt_dump.n_trace -= n_trace;
        }
 }