[Bug Fix] Use correct image for the Quagga instance 51/58151/7
authorDimitrios Markou <mardim@intracom-telecom.com>
Fri, 1 Jun 2018 13:09:47 +0000 (16:09 +0300)
committerDimitrios Markou <mardim@intracom-telecom.com>
Tue, 5 Jun 2018 06:50:15 +0000 (09:50 +0300)
In testcase_3 the Quagga image is downloaded from the
opnfv.artifacts repository to the /home/opnfv/functest/data
directory.

But the testcase_3 after that tries to find the image in the
/home/opnfv/functest/images directory.

This results in using a wrong image

Jira: SDNVPN-213

Change-Id: I99539fc9a7a2d016a97ed51fca0cde81f82b3911
Signed-off-by: Dimitrios Markou <mardim@intracom-telecom.com>
sdnvpn/lib/config.py
sdnvpn/test/functest/testcase_13.py
sdnvpn/test/functest/testcase_3.py

index 81d895b..847b41c 100644 (file)
@@ -53,7 +53,7 @@ class CommonConfig(object):
             # TODO does functest have an ubuntu image somewhere?
             self.ubuntu_image_name = "sdnvpn-ubuntu"
             self.ubuntu_image_path = '{0}/{1}'.format(
-                getattr(config.CONF, 'dir_functest_images'),
+                getattr(config.CONF, 'dir_functest_data'),
                 "ubuntu-16.04-server-cloudimg-amd64-disk1.img")
             self.custom_flavor_name = 'm1.custom'
             self.custom_flavor_ram = 1024
index 35a1a31..8beb1db 100644 (file)
@@ -9,6 +9,7 @@
 #
 
 import logging
+import os
 import sys
 
 from random import randint
@@ -31,6 +32,17 @@ def main():
     results.add_to_summary(2, "STATUS", "SUBTEST")
     results.add_to_summary(0, "=")
 
+    if not os.path.isfile(COMMON_CONFIG.ubuntu_image_path):
+        logger.info("Downloading image")
+        image_dest_path = '/'.join(
+                COMMON_CONFIG.ubuntu_image_path.split('/')[:-1])
+        os_utils.download_url(
+            "http://artifacts.opnfv.org/sdnvpn/"
+            "ubuntu-16.04-server-cloudimg-amd64-disk1.img",
+            image_dest_path)
+    else:
+        logger.info("Using old image")
+
     nova_client = os_utils.get_nova_client()
     neutron_client = os_utils.get_neutron_client()
     glance_client = os_utils.get_glance_client()
index 373e5a8..95023c6 100644 (file)
@@ -140,10 +140,12 @@ def main():
     # Taken from the sfc tests
     if not os.path.isfile(COMMON_CONFIG.ubuntu_image_path):
         logger.info("Downloading image")
+        image_dest_path = '/'.join(
+                COMMON_CONFIG.ubuntu_image_path.split('/')[:-1])
         os_utils.download_url(
             "http://artifacts.opnfv.org/sdnvpn/"
             "ubuntu-16.04-server-cloudimg-amd64-disk1.img",
-            "/home/opnfv/functest/data/")
+            image_dest_path)
     else:
         logger.info("Using old image")